René's URL Explorer Experiment


Title: [3.8] bpo-36502: Correct documentation of str.isspace() (GH-15019) by gnprice · Pull Request #15296 · python/cpython · GitHub

Open Graph Title: [3.8] bpo-36502: Correct documentation of str.isspace() (GH-15019) by gnprice · Pull Request #15296 · python/cpython

X Title: [3.8] bpo-36502: Correct documentation of str.isspace() (GH-15019) by gnprice · Pull Request #15296 · python/cpython

Description: The documented definition was much broader than the real one: there are tons of characters with general category "Other", and we don't (and shouldn't) treat most of them as whitespace. Rewrite the definition to agree with the comment on _PyUnicode_IsWhitespace, and with the logic in makeunicodedata.py, which is what generates that function and so ultimately governs. Add suitable breadcrumbs so that a reader who wants to pin down exactly what this definition means (what's a "bidirectional class" of "B"?) can do so. The unicodedata module documentation is an appropriate central place for our references to Unicode's own copious documentation, so point there. Also add to the isspace() test a thorough check that the implementation agrees with the intended definition. https://bugs.python.org/issue36502

Open Graph Description: The documented definition was much broader than the real one: there are tons of characters with general category "Other", and we don't (and shouldn't) treat most of them as whites...

X Description: The documented definition was much broader than the real one: there are tons of characters with general category "Other", and we don't (and shouldn't) treat most o...

Opengraph URL: https://github.com/python/cpython/pull/15296

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2aa937e3-b00a-05ef-4f96-188e8006158a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC3A4:362FC4:AF08819:B26AE8F:6A50BABE
html-safe-noncedebda1ecd084ca917b645c8b9bbd311f20b67c35a6a7925d18a6bcb27fa069a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0E0OjM2MkZDNDpBRjA4ODE5OkIyNkFFOEY6NkE1MEJBQkUiLCJ2aXNpdG9yX2lkIjoiNTg2MjA3MDI3NTYxMzQ0MDcwMiIsInJlZ2lvbl9lZGdlIjoic2VhIiwicmVnaW9uX3JlbmRlciI6InNlYSJ9
visitor-hmac1ebafbcecc4df6483bd05da01626e4f12778e8c19a3196df1b9a8ffe8e1e5cc0
hovercard-subject-tagpull_request:307567312
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/15296/files
twitter:imagehttps://avatars.githubusercontent.com/u/28173?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/28173?s=400&v=4
og:image:altThe documented definition was much broader than the real one: there are tons of characters with general category "Other", and we don't (and shouldn't) treat most of them as whites...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release08e79d53fc070870d5b168356afebb1e286a2ffe
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/15296/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15296%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15296%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/15296/files
Reloadhttps://github.com/python/cpython/pull/15296/files
Reloadhttps://github.com/python/cpython/pull/15296/files
Please reload this pagehttps://github.com/python/cpython/pull/15296/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/15296/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:3.8https://github.com/python/cpython/tree/3.8
gnprice:pr38-isspace-dochttps://github.com/gnprice/cpython/tree/pr38-isspace-doc
Conversation 2 https://github.com/python/cpython/pull/15296
Commits 1 https://github.com/python/cpython/pull/15296/commits
Checks 0 https://github.com/python/cpython/pull/15296/checks
Files changed https://github.com/python/cpython/pull/15296/files
Please reload this pagehttps://github.com/python/cpython/pull/15296/files
[3.8] bpo-36502: Correct documentation of str.isspace() (GH-15019) https://github.com/python/cpython/pull/15296/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/15296/files
2f9dd16 bpo-36502: Correct documentation of str.isspace() (GH-15019) gnprice Aug 14, 2019 https://github.com/python/cpython/pull/15296/commits/2f9dd16bfbf24517751e8949626468b481bfb68b
Clear filters https://github.com/python/cpython/pull/15296/files
Please reload this pagehttps://github.com/python/cpython/pull/15296/files
Please reload this pagehttps://github.com/python/cpython/pull/15296/files
stdtypes.rst https://github.com/python/cpython/pull/15296/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3
test_unicode.py https://github.com/python/cpython/pull/15296/files#diff-5a2c8275f700073cdc5d4e1b818ec472bb0230210b9c99eac0bdc9e0a2949f41
Doc/library/stdtypes.rsthttps://github.com/python/cpython/pull/15296/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3
View file https://github.com/gnprice/cpython/blob/2f9dd16bfbf24517751e8949626468b481bfb68b/Doc/library/stdtypes.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15296/{{ revealButtonHref }}
https://github.com/python/cpython/pull/15296/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3
https://github.com/python/cpython/pull/15296/files#diff-08a31a70dd1f6d97aa8dacdce77db4de04c700d9949be1af611a595186aad5b3
Lib/test/test_unicode.pyhttps://github.com/python/cpython/pull/15296/files#diff-5a2c8275f700073cdc5d4e1b818ec472bb0230210b9c99eac0bdc9e0a2949f41
View file https://github.com/gnprice/cpython/blob/2f9dd16bfbf24517751e8949626468b481bfb68b/Lib/test/test_unicode.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15296/{{ revealButtonHref }}
https://github.com/python/cpython/pull/15296/files#diff-5a2c8275f700073cdc5d4e1b818ec472bb0230210b9c99eac0bdc9e0a2949f41
https://github.com/python/cpython/pull/15296/files#diff-5a2c8275f700073cdc5d4e1b818ec472bb0230210b9c99eac0bdc9e0a2949f41
https://github.com/python/cpython/pull/15296/files#diff-5a2c8275f700073cdc5d4e1b818ec472bb0230210b9c99eac0bdc9e0a2949f41
https://github.com/python/cpython/pull/15296/files#diff-5a2c8275f700073cdc5d4e1b818ec472bb0230210b9c99eac0bdc9e0a2949f41
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.