René's URL Explorer Experiment


Title: gh-150490: Raise PyType_Modified for insertion into split dictionary (take 2) by DinoV · Pull Request #152914 · python/cpython · GitHub

Open Graph Title: gh-150490: Raise PyType_Modified for insertion into split dictionary (take 2) by DinoV · Pull Request #152914 · python/cpython

X Title: gh-150490: Raise PyType_Modified for insertion into split dictionary (take 2) by DinoV · Pull Request #152914 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Take 2 of #150489 - what's changed is that we now acquire the type lock in insert_split_key before we acquire the keys lock. We never do any work below the dictionary keys lock so we maintain a...

X Description: Take 2 of #150489 - what's changed is that we now acquire the type lock in insert_split_key before we acquire the keys lock. We never do any work below the dictionary keys lock so we mainta...

Opengraph URL: https://github.com/python/cpython/pull/152914

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2247e174-2d2e-97aa-e35e-a41b0a37afb0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD956:A370B:EFFAE3:1547E42:6A50E696
html-safe-nonce2bcbe1c5df8ef1a5abe569b97d98be61cb81a539d4d0aac78c0be54f4afb2689
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTU2OkEzNzBCOkVGRkFFMzoxNTQ3RTQyOjZBNTBFNjk2IiwidmlzaXRvcl9pZCI6IjQ0ODc0MjA4ODI0ODcxNDIwMzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4c6fc431933f27a1c1860c4746cb6e521d7e03cdc69486d15910151758319314
hovercard-subject-tagpull_request:3980618353
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/152914/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3f9d98d9b7419efa57155769812605db272f070dcc3188c149df0e09c23117f9/python/cpython/pull/152914
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3f9d98d9b7419efa57155769812605db272f070dcc3188c149df0e09c23117f9/python/cpython/pull/152914
og:image:altTake 2 of #150489 - what's changed is that we now acquire the type lock in insert_split_key before we acquire the keys lock. We never do any work below the dictionary keys lock so we maintain a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDinoV
hostnamegithub.com
expected-hostnamegithub.com
None72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefb19d617b534959801b4b7453938ecf1dfa22131
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/152914#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152914
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152914
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/152914
Reloadhttps://github.com/python/cpython/pull/152914
Reloadhttps://github.com/python/cpython/pull/152914
Please reload this pagehttps://github.com/python/cpython/pull/152914
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/152914
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
DinoVhttps://github.com/DinoV
python:mainhttps://github.com/python/cpython/tree/main
DinoV:sharedkeys_type2https://github.com/DinoV/cpython/tree/sharedkeys_type2
Conversationhttps://github.com/python/cpython/pull/152914
Commits2 (2)https://github.com/python/cpython/pull/152914/commits
Checkshttps://github.com/python/cpython/pull/152914/checks
Files changedhttps://github.com/python/cpython/pull/152914/files
gh-150490: Raise PyType_Modified for insertion into split dictionary (take 2)https://github.com/python/cpython/pull/152914#top
DinoVhttps://github.com/DinoV
python:mainhttps://github.com/python/cpython/tree/main
DinoV:sharedkeys_type2https://github.com/DinoV/cpython/tree/sharedkeys_type2
https://github.com/DinoV
DinoVhttps://github.com/DinoV
Jul 2, 2026https://github.com/python/cpython/pull/152914#issue-4797182288
Please reload this pagehttps://github.com/python/cpython/pull/152914
#150489https://github.com/python/cpython/pull/150489
Raise PyType_Modified on split key insertion to avoid cached keys version check #150490https://github.com/python/cpython/issues/150490
Please reload this pagehttps://github.com/python/cpython/pull/152914
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 2, 2026 https://github.com/python/cpython/pull/152914#ref-issue-4526368821
Raise PyType_Modified on split key insertion to avoid cached keys version check #150490 https://github.com/python/cpython/issues/150490
https://github.com/DinoV
DinoVhttps://github.com/DinoV
naschemehttps://github.com/nascheme
vstinnerhttps://github.com/vstinner
July 2, 2026 18:24https://github.com/python/cpython/pull/152914#event-27494280493
https://github.com/DinoV
DinoVhttps://github.com/DinoV
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jul 2, 2026https://github.com/python/cpython/pull/152914#event-27494325449
https://github.com/DinoV
DinoVhttps://github.com/DinoV
force-pushedhttps://github.com/python/cpython/compare/43d2f71725e728ce36c6f9eb17b37b20d732126d..e256c6b2ea2eb63b19c2bc883d42a32c1e276ff7
43d2f71https://github.com/python/cpython/commit/43d2f71725e728ce36c6f9eb17b37b20d732126d
e256c6bhttps://github.com/python/cpython/commit/e256c6b2ea2eb63b19c2bc883d42a32c1e276ff7
Compare https://github.com/python/cpython/compare/43d2f71725e728ce36c6f9eb17b37b20d732126d..e256c6b2ea2eb63b19c2bc883d42a32c1e276ff7
July 2, 2026 19:47https://github.com/python/cpython/pull/152914#event-27497343297
https://github.com/nascheme
naschemehttps://github.com/nascheme
Jul 2, 2026https://github.com/python/cpython/pull/152914#issuecomment-4870221901
Please reload this pagehttps://github.com/python/cpython/pull/152914
https://github.com/nascheme
naschemehttps://github.com/nascheme
Jul 2, 2026https://github.com/python/cpython/pull/152914#issuecomment-4870486108
Please reload this pagehttps://github.com/python/cpython/pull/152914
https://github.com/DinoV
DinoVhttps://github.com/DinoV
Jul 2, 2026https://github.com/python/cpython/pull/152914#issuecomment-4870657524
Please reload this pagehttps://github.com/python/cpython/pull/152914
https://github.com/DinoV
DinoVhttps://github.com/DinoV
July 2, 2026 22:34https://github.com/python/cpython/pull/152914#event-27502478725
https://github.com/DinoV
DinoVhttps://github.com/DinoV
markshannonhttps://github.com/markshannon
methanehttps://github.com/methane
code ownershttps://github.com/python/cpython/blob/31864bd9a683c93bd9b294fb5bcf6857493c15ff/.github/CODEOWNERS#L215
July 2, 2026 22:34https://github.com/python/cpython/pull/152914#event-27502478924
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 2, 2026https://github.com/python/cpython/pull/152914#event-27502479966
https://github.com/nascheme
naschemehttps://github.com/nascheme
Jul 3, 2026 https://github.com/python/cpython/pull/152914#pullrequestreview-4622083954
View reviewed changes https://github.com/python/cpython/pull/152914/files
naschemehttps://github.com/nascheme
https://github.com/python/cpython/pull/152914#pullrequestreview-4622083954
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/152914
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 3, 2026https://github.com/python/cpython/pull/152914#event-27506404053
https://github.com/DinoV
DinoVhttps://github.com/DinoV
force-pushedhttps://github.com/python/cpython/compare/cb6549d4615893910baf53bf90eb13379358870c..8513068a2d133429a6afb45af2075340ab6c5771
cb6549dhttps://github.com/python/cpython/commit/cb6549d4615893910baf53bf90eb13379358870c
8513068https://github.com/python/cpython/commit/8513068a2d133429a6afb45af2075340ab6c5771
Compare https://github.com/python/cpython/compare/cb6549d4615893910baf53bf90eb13379358870c..8513068a2d133429a6afb45af2075340ab6c5771
July 6, 2026 16:35https://github.com/python/cpython/pull/152914#event-27619958605
https://github.com/DinoV
DinoVhttps://github.com/DinoV
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
code ownerhttps://github.com/python/cpython/blob/4221ce7e3002ea5459ec7cb5543cc1e43f422506/.github/CODEOWNERS#L267
July 6, 2026 16:35https://github.com/python/cpython/pull/152914#event-27619958652
DinoVhttps://github.com/DinoV
July 6, 2026 09:46https://github.com/python/cpython/pull/152914#commits-pushed-0ed84a1
https://github.com/DinoV
Raise PyType_Modified for insertion into split dictionaryhttps://github.com/python/cpython/pull/152914/commits/0ed84a113165b4aa16e8776ef97657f29768a261
0ed84a1https://github.com/python/cpython/pull/152914/commits/0ed84a113165b4aa16e8776ef97657f29768a261
https://github.com/DinoV
Add comment, inline _PyDict_SplitKeysInvalidated, remove print, fix r…https://github.com/python/cpython/pull/152914/commits/a777c3e2fee253d778db54283232e3c9566a26d7
a777c3ehttps://github.com/python/cpython/pull/152914/commits/a777c3e2fee253d778db54283232e3c9566a26d7
https://github.com/DinoV
DinoVhttps://github.com/DinoV
force-pushedhttps://github.com/python/cpython/compare/8513068a2d133429a6afb45af2075340ab6c5771..a777c3e2fee253d778db54283232e3c9566a26d7
8513068https://github.com/python/cpython/commit/8513068a2d133429a6afb45af2075340ab6c5771
a777c3ehttps://github.com/python/cpython/commit/a777c3e2fee253d778db54283232e3c9566a26d7
Compare https://github.com/python/cpython/compare/8513068a2d133429a6afb45af2075340ab6c5771..a777c3e2fee253d778db54283232e3c9566a26d7
July 6, 2026 16:46https://github.com/python/cpython/pull/152914#event-27620461601
https://github.com/DinoV
DinoVhttps://github.com/DinoV
2092192https://github.com/python/cpython/commit/20921922fa4d34bea54bfbfc561503e67409b7ab
Jul 6, 2026https://github.com/python/cpython/pull/152914#event-27628872339
Please reload this pagehttps://github.com/python/cpython/pull/152914
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jul 6, 2026https://github.com/python/cpython/pull/152914#event-27628874199
gh-153182: Explicitly return NULL when new_keys_object call fails in _PyDict_NewKeysForClass #153183 https://github.com/python/cpython/pull/153183
Segfault from _PyDict_NewKeysForClass under memory pressure #153182 https://github.com/python/cpython/issues/153182
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152914
https://github.com/nascheme
nascheme https://github.com/nascheme
https://github.com/python/cpython/pull/152914/files/cb6549d4615893910baf53bf90eb13379358870c
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/methane
methane https://github.com/methane
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/152914
https://github.com/DinoV
https://github.com/nascheme
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.