René's URL Explorer Experiment


Title: gh-151518: Avoid STW starvation of attaching threads by tpn · Pull Request #152826 · python/cpython · GitHub

Open Graph Title: gh-151518: Avoid STW starvation of attaching threads by tpn · Pull Request #152826 · python/cpython

X Title: gh-151518: Avoid STW starvation of attaching threads by tpn · Pull Request #152826 · python/cpython

Description: Fixes #151518. Repeated stop-the-world requests can starve a thread returning from a detached operation. After start_the_world() restores its state to DETACHED, the next requester can suspend it again before its OS thread completes _PyThreadState_Attach(). This change distinguishes thread states suspended while detached from those suspended while attached. An active attach waiter records that it encountered the detached-origin suspension; subsequent stop-the-world scans let that waiter attach before suspending it again. The waiter remains in the stop-the-world countdown until it actually stops. Threads detached for sleep or I/O without an active attach attempt remain immediately parkable, and the uncontended attach path remains a single CAS. The waiting flag reuses trailing _PyThreadStateImpl padding. Existing state numbers are preserved, and both suspended states resume directly to DETACHED. The subprocess regression explicitly uses -X gil=0, waits for the collector to start, and repeatedly returns from sleep while another thread calls gc.collect() in a tight loop. It performs 50 reattachments with one second of total intentional sleep and relies on the test framework's outer timeout for stalled progress or shutdown. Validation on Linux x86-64 after rebasing onto 89c67a98aee: Debug free-threaded build (--with-pydebug --enable-safety --enable-slower-safety --disable-gil): test_free_threading test_gc test_threading test_capi test_embed passed, 2,211 tests run. test_interpreters is unsupported in this build and skipped. Release free-threaded build: test_free_threading test_gc test_threading test_embed passed, 647 tests run. Debug free-threaded binary with -X gil=1: GC, threading, embedding, and free-threaded GC tests passed, 403 tests run. The final regression also passed separately with this parent setting. Normal GIL build, using a separate bytecode cache: test_gc test_threading test_capi test_embed test_interpreters passed, 2,132 tests run. test_free_threading skipped as expected. Final regression passed -R 3:3 reference-leak checking. Seven additional stress trials passed with mixed global/local pauses, repeated detach/reattach, and workers blocked waiting for collector completion. Compiled layout comparison matched all 64 common measurements: _PyThreadStateImpl remains 18,200 bytes, and the new flag overlays padding at offset 18,136. make patchcheck and git diff --check passed. Issue: gh-151518

Open Graph Description: Fixes #151518. Repeated stop-the-world requests can starve a thread returning from a detached operation. After start_the_world() restores its state to DETACHED, the next requester can suspend it ag...

X Description: Fixes #151518. Repeated stop-the-world requests can starve a thread returning from a detached operation. After start_the_world() restores its state to DETACHED, the next requester can suspend it ag...

Opengraph URL: https://github.com/python/cpython/pull/152826

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b2321e76-c996-e686-9dc6-9e3ff9455946
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB714:3DCD28:19BAF27:220EE04:6B02171F
html-safe-nonceebdb92a926eb285db371d131eebf78068fec973dd505eedf34f0a40b5e7d37b5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzE0OjNEQ0QyODoxOUJBRjI3OjIyMEVFMDQ6NkIwMjE3MUYiLCJ2aXNpdG9yX2lkIjoiMzk1MjE5MjE4MTMwOTE1MTAwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf0bd71f661bccbd829ef01ed4f7df14c333b617c87c062636f44845b7f0343e7
hovercard-subject-tagpull_request:3974065238
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/152826/files
twitter:imagehttps://avatars.githubusercontent.com/u/629986?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/629986?s=400&v=4
og:image:altFixes #151518. Repeated stop-the-world requests can starve a thread returning from a detached operation. After start_the_world() restores its state to DETACHED, the next requester can suspend it ag...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/152826/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152826%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152826%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/152826/files
Reloadhttps://github.com/python/cpython/pull/152826/files
Reloadhttps://github.com/python/cpython/pull/152826/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
tpnhttps://github.com/tpn
python:mainhttps://github.com/python/cpython/tree/main
tpn:gh-151518-stw-attach-fairnesshttps://github.com/tpn/cpython-fork/tree/gh-151518-stw-attach-fairness
Conversation 37 https://github.com/python/cpython/pull/152826
Commits 8 https://github.com/python/cpython/pull/152826/commits
Checks 72 https://github.com/python/cpython/pull/152826/checks
Files changed https://github.com/python/cpython/pull/152826/files
Please reload this pagehttps://github.com/python/cpython/pull/152826/files
gh-151518: Avoid STW starvation of attaching threads https://github.com/python/cpython/pull/152826/files#top
Show all changes 8 commits https://github.com/python/cpython/pull/152826/files
14a870c gh-151518: Avoid STW starvation of attaching threads tpn Jun 17, 2026 https://github.com/python/cpython/pull/152826/commits/14a870c1c2c9a2de64f2755efef690b7751bad0d
d2adaf4 gh-151518: Track attach waiters in the thread state tpn Sep 22, 2026 https://github.com/python/cpython/pull/152826/commits/d2adaf428f62530831ca4e6a2fbcbb62b86b0264
09c0d2a gh-151518: Simplify the GC fairness regression tpn Sep 22, 2026 https://github.com/python/cpython/pull/152826/commits/09c0d2a64fca33e515fd60a4ae87ac4b891c1196
cec1cce gh-151518: Exercise STW fairness directly tpn Sep 23, 2026 https://github.com/python/cpython/pull/152826/commits/cec1cce55eab978f3f75d3e06628f492f0d467d9
c34abd4 gh-151518: Preserve attach waiters when resuming BRC suspensions tpn Sep 23, 2026 https://github.com/python/cpython/pull/152826/commits/c34abd44ea5c1fbd3f3f42da6f19e79a242dd2a8
15c4b6d gh-151518: Strengthen the STW attach fairness regression tpn Sep 24, 2026 https://github.com/python/cpython/pull/152826/commits/15c4b6dfdb9d2b0e8580120df609d6b4da6d9f74
4093ea6 gh-151518: Restrict STW test pauses to free-threaded builds tpn Sep 24, 2026 https://github.com/python/cpython/pull/152826/commits/4093ea6429d65a31ef6ecf059667be9a5613eed4
1a200bf gh-151518: Wake only registered attach waiters tpn Sep 25, 2026 https://github.com/python/cpython/pull/152826/commits/1a200bfe9b1456c3fa86e8e4962f3e1970399d9b
Clear filters https://github.com/python/cpython/pull/152826/files
Please reload this pagehttps://github.com/python/cpython/pull/152826/files
Please reload this pagehttps://github.com/python/cpython/pull/152826/files
pystate.h https://github.com/python/cpython/pull/152826/files#diff-fefbbf791abe2a1b6d9cab39778d388ebb9135eeefbd734e463aac75d1979e7f
pycore_pystate.h https://github.com/python/cpython/pull/152826/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
test_threading.py https://github.com/python/cpython/pull/152826/files#diff-be27d84769aae3c2f92edaf4dff2fc541f08e8d06450ab7e18cf01ad520a9f4e
2026-06-16-19-20-00.gh-issue-151518.e6v0Js.rst https://github.com/python/cpython/pull/152826/files#diff-7603b9d4f3fa21c7ffcd7693754fb0b50ddc0ff78b4fde3a38486259c52d7a4b
_testinternalcapi.c https://github.com/python/cpython/pull/152826/files#diff-687f4a736f1f6ad4b6cd4ff65c8e0113408304e8d65530dbd41b3f59a081a126
pystate.c https://github.com/python/cpython/pull/152826/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L319
Include/cpython/pystate.hhttps://github.com/python/cpython/pull/152826/files#diff-fefbbf791abe2a1b6d9cab39778d388ebb9135eeefbd734e463aac75d1979e7f
View file https://github.com/tpn/cpython-fork/blob/1a200bfe9b1456c3fa86e8e4962f3e1970399d9b/Include/cpython/pystate.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152826/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152826/files#diff-fefbbf791abe2a1b6d9cab39778d388ebb9135eeefbd734e463aac75d1979e7f
https://github.com/python/cpython/pull/152826/files#diff-fefbbf791abe2a1b6d9cab39778d388ebb9135eeefbd734e463aac75d1979e7f
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L319
Include/internal/pycore_pystate.hhttps://github.com/python/cpython/pull/152826/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
View file https://github.com/tpn/cpython-fork/blob/1a200bfe9b1456c3fa86e8e4962f3e1970399d9b/Include/internal/pycore_pystate.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152826/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152826/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
https://github.com/python/cpython/pull/152826/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
https://github.com/python/cpython/pull/152826/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
https://github.com/python/cpython/pull/152826/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
Lib/test/test_free_threading/test_threading.pyhttps://github.com/python/cpython/pull/152826/files#diff-be27d84769aae3c2f92edaf4dff2fc541f08e8d06450ab7e18cf01ad520a9f4e
View file https://github.com/tpn/cpython-fork/blob/1a200bfe9b1456c3fa86e8e4962f3e1970399d9b/Lib/test/test_free_threading/test_threading.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152826/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152826/files#diff-be27d84769aae3c2f92edaf4dff2fc541f08e8d06450ab7e18cf01ad520a9f4e
Misc/NEWS.d/next/Core_and_Builtins/2026-06-16-19-20-00.gh-issue-151518.e6v0Js.rsthttps://github.com/python/cpython/pull/152826/files#diff-7603b9d4f3fa21c7ffcd7693754fb0b50ddc0ff78b4fde3a38486259c52d7a4b
View file https://github.com/tpn/cpython-fork/blob/1a200bfe9b1456c3fa86e8e4962f3e1970399d9b/Misc/NEWS.d/next/Core_and_Builtins/2026-06-16-19-20-00.gh-issue-151518.e6v0Js.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152826/{{ revealButtonHref }}
Modules/_testinternalcapi.chttps://github.com/python/cpython/pull/152826/files#diff-687f4a736f1f6ad4b6cd4ff65c8e0113408304e8d65530dbd41b3f59a081a126
View file https://github.com/tpn/cpython-fork/blob/1a200bfe9b1456c3fa86e8e4962f3e1970399d9b/Modules/_testinternalcapi.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152826/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152826/files#diff-687f4a736f1f6ad4b6cd4ff65c8e0113408304e8d65530dbd41b3f59a081a126
https://github.com/python/cpython/pull/152826/files#diff-687f4a736f1f6ad4b6cd4ff65c8e0113408304e8d65530dbd41b3f59a081a126
https://github.com/python/cpython/pull/152826/files#diff-687f4a736f1f6ad4b6cd4ff65c8e0113408304e8d65530dbd41b3f59a081a126
https://github.com/python/cpython/pull/152826/files#diff-687f4a736f1f6ad4b6cd4ff65c8e0113408304e8d65530dbd41b3f59a081a126
https://github.com/python/cpython/pull/152826/files#diff-687f4a736f1f6ad4b6cd4ff65c8e0113408304e8d65530dbd41b3f59a081a126
https://github.com/python/cpython/pull/152826/files#diff-687f4a736f1f6ad4b6cd4ff65c8e0113408304e8d65530dbd41b3f59a081a126
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L319
Python/pystate.chttps://github.com/python/cpython/pull/152826/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
View file https://github.com/tpn/cpython-fork/blob/1a200bfe9b1456c3fa86e8e4962f3e1970399d9b/Python/pystate.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152826/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152826/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/152826/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/152826/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/152826/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
Please reload this pagehttps://github.com/python/cpython/pull/152826/files
https://github.com/python/cpython/pull/152826/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
Please reload this pagehttps://github.com/python/cpython/pull/152826/files
https://github.com/python/cpython/pull/152826/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/152826/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/152826/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/152826/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/152826/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/152826/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/152826/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
Please reload this pagehttps://github.com/python/cpython/pull/152826/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.