René's URL Explorer Experiment


Title: [3.14] gh-152060: Fix `_pydatetime.fromisoformat()` raising `AssertionError` on invalid lengths (GH-152061) by tonghuaroot · Pull Request #152786 · python/cpython · GitHub

Open Graph Title: [3.14] gh-152060: Fix `_pydatetime.fromisoformat()` raising `AssertionError` on invalid lengths (GH-152061) by tonghuaroot · Pull Request #152786 · python/cpython

X Title: [3.14] gh-152060: Fix `_pydatetime.fromisoformat()` raising `AssertionError` on invalid lengths (GH-152061) by tonghuaroot · Pull Request #152786 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: (cherry picked from commit ff781d5) Co-authored-by: tonghuaroot (童话) tonghuaroot@gmail.com Issue: datetime.fromisoformat() raises AssertionError instead of ValueError in the pure-Python implement...

X Description: (cherry picked from commit ff781d5) Co-authored-by: tonghuaroot (童话) tonghuaroot@gmail.com Issue: datetime.fromisoformat() raises AssertionError instead of ValueError in the pure-Python implement...

Mail addresses
tonghuaroot@gmail.com

Opengraph URL: https://github.com/python/cpython/pull/152786

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:504703f6-4502-84af-ec28-c04594df8af0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE60:27E5CD:3A84575:4ACFED3:6B01F6E1
html-safe-nonce06d19fbcd65b30b398a1e57c178fe681a17e2639fdcce5ea7c780ee05030898c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTYwOjI3RTVDRDozQTg0NTc1OjRBQ0ZFRDM6NkIwMUY2RTEiLCJ2aXNpdG9yX2lkIjoiNTIwNDA1MDMxMzg0NjQzMjk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac989e0d3333cb6b84ce86917514c5e54570897b10bcc06eb40be7e9f1259ed7e1
hovercard-subject-tagpull_request:3971106720
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/152786/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d6cd24067568ed63703000bca5e0dbc50b7d58247f84f3758dc000137286da96/python/cpython/pull/152786
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d6cd24067568ed63703000bca5e0dbc50b7d58247f84f3758dc000137286da96/python/cpython/pull/152786
og:image:alt(cherry picked from commit ff781d5) Co-authored-by: tonghuaroot (童话) tonghuaroot@gmail.com Issue: datetime.fromisoformat() raises AssertionError instead of ValueError in the pure-Python implement...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametonghuaroot
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/152786#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152786
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152786
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/152786
Reloadhttps://github.com/python/cpython/pull/152786
Reloadhttps://github.com/python/cpython/pull/152786
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
StanFromIrelandhttps://github.com/StanFromIreland
python:3.14https://github.com/python/cpython/tree/3.14
tonghuaroot:backport-ff781d5-3.14https://github.com/tonghuaroot/cpython/tree/backport-ff781d5-3.14
Conversationhttps://github.com/python/cpython/pull/152786
Commits3 (3)https://github.com/python/cpython/pull/152786/commits
Checkshttps://github.com/python/cpython/pull/152786/checks
Files changedhttps://github.com/python/cpython/pull/152786/files
[3.14] gh-152060: Fix _pydatetime.fromisoformat() raising AssertionError on invalid lengths (GH-152061)https://github.com/python/cpython/pull/152786#top
StanFromIrelandhttps://github.com/StanFromIreland
python:3.14https://github.com/python/cpython/tree/3.14
tonghuaroot:backport-ff781d5-3.14https://github.com/tonghuaroot/cpython/tree/backport-ff781d5-3.14
https://github.com/tonghuaroot
tonghuaroothttps://github.com/tonghuaroot
Jul 1, 2026https://github.com/python/cpython/pull/152786#issue-4786025725
ff781d5https://github.com/python/cpython/commit/ff781d52d451db56e154aac35ae7f2c41b1695a4
datetime.fromisoformat() raises AssertionError instead of ValueError in the pure-Python implementation #152060https://github.com/python/cpython/issues/152060
Please reload this pagehttps://github.com/python/cpython/pull/152786
https://github.com/tonghuaroot
pythongh-152060https://github.com/python/cpython/issues/152060
: Fixhttps://github.com/python/cpython/pull/152786/commits/d65624d88c413bb7b4cf6ed97e89a5a63ad6785b
_pydatetime.fromisoformat()https://github.com/python/cpython/pull/152786/commits/d65624d88c413bb7b4cf6ed97e89a5a63ad6785b
raising `Assertion…https://github.com/python/cpython/pull/152786/commits/d65624d88c413bb7b4cf6ed97e89a5a63ad6785b
d65624dhttps://github.com/python/cpython/pull/152786/commits/d65624d88c413bb7b4cf6ed97e89a5a63ad6785b
pythonGH-152061https://github.com/python/cpython/pull/152061
ff781d5https://github.com/tonghuaroot/cpython/commit/ff781d52d451db56e154aac35ae7f2c41b1695a4
https://github.com/tonghuaroot
tonghuaroothttps://github.com/tonghuaroot
abalkinhttps://github.com/abalkin
pgansslehttps://github.com/pganssle
code ownershttps://github.com/python/cpython/blob/f8fb02db9d1d83a2fe4d2a62dfda69a02023b75a/.github/CODEOWNERS#L165
July 1, 2026 13:32https://github.com/python/cpython/pull/152786#event-27431114223
datetime.fromisoformat() raises AssertionError instead of ValueError in the pure-Python implementation #152060 https://github.com/python/cpython/issues/152060
gh-152060: Fix datetime.fromisoformat() raising AssertionError in pure Python #152061 https://github.com/python/cpython/pull/152061
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jul 1, 2026https://github.com/python/cpython/pull/152786#event-27431120095
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
Jul 1, 2026 https://github.com/python/cpython/pull/152786#pullrequestreview-4611891447
View reviewed changes https://github.com/python/cpython/pull/152786/files/d65624d88c413bb7b4cf6ed97e89a5a63ad6785b
Lib/test/datetimetester.pyhttps://github.com/python/cpython/pull/152786/files/d65624d88c413bb7b4cf6ed97e89a5a63ad6785b#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
Please reload this pagehttps://github.com/python/cpython/pull/152786
https://github.com/StanFromIreland
Apply suggestion fromhttps://github.com/python/cpython/pull/152786/commits/68974da5a2db17079f95808819db62420a2f491c
@StanFromIrelandhttps://github.com/StanFromIreland
68974dahttps://github.com/python/cpython/pull/152786/commits/68974da5a2db17079f95808819db62420a2f491c
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
Jul 1, 2026 https://github.com/python/cpython/pull/152786#pullrequestreview-4611897378
View reviewed changes https://github.com/python/cpython/pull/152786/files/68974da5a2db17079f95808819db62420a2f491c
Lib/test/datetimetester.pyhttps://github.com/python/cpython/pull/152786/files/68974da5a2db17079f95808819db62420a2f491c#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
Please reload this pagehttps://github.com/python/cpython/pull/152786
https://github.com/StanFromIreland
oops one more spacehttps://github.com/python/cpython/pull/152786/commits/6a5e81709976d1c7f0c7e54fca26a59713fd24ed
6a5e817https://github.com/python/cpython/pull/152786/commits/6a5e81709976d1c7f0c7e54fca26a59713fd24ed
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
Jul 1, 2026 https://github.com/python/cpython/pull/152786#pullrequestreview-4611902063
View reviewed changes https://github.com/python/cpython/pull/152786/files/6a5e81709976d1c7f0c7e54fca26a59713fd24ed
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jul 1, 2026https://github.com/python/cpython/pull/152786#event-27443805469
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
July 1, 2026 18:48https://github.com/python/cpython/pull/152786#event-27444713220
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
205dfffhttps://github.com/python/cpython/commit/205dfff87cd09af308351763f2a53a77974a56be
Jul 1, 2026https://github.com/python/cpython/pull/152786#event-27444722395
Please reload this pagehttps://github.com/python/cpython/pull/152786
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jul 1, 2026https://github.com/python/cpython/pull/152786#event-27444724348
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152786
https://github.com/StanFromIreland
StanFromIreland https://github.com/StanFromIreland
https://github.com/python/cpython/pull/152786/files/6a5e81709976d1c7f0c7e54fca26a59713fd24ed
https://github.com/pganssle
pganssle https://github.com/pganssle
https://github.com/abalkin
abalkin https://github.com/abalkin
Please reload this pagehttps://github.com/python/cpython/pull/152786
Please reload this pagehttps://github.com/python/cpython/pull/152786
https://github.com/tonghuaroot
https://github.com/StanFromIreland
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.