René's URL Explorer Experiment


Title: gh-71808: Rebuild IDLE query dialogs on tkinter.simpledialog.Dialog by serhiy-storchaka · Pull Request #152773 · python/cpython · GitHub

Open Graph Title: gh-71808: Rebuild IDLE query dialogs on tkinter.simpledialog.Dialog by serhiy-storchaka · Pull Request #152773 · python/cpython

X Title: gh-71808: Rebuild IDLE query dialogs on tkinter.simpledialog.Dialog by serhiy-storchaka · Pull Request #152773 · python/cpython

Description: idlelib.query.Query hand-rolled the modal-dialog machinery (transient window, grab, wait_window, OK/Cancel buttons, geometry) that tkinter.simpledialog.Dialog now provides. This rebuilds Query as a Dialog subclass: create_widgets() becomes body(), and the buttons are dropped in favor of Dialog's standard buttonbox(). The query dialogs (Open Module, custom Run, new config-section / highlight-theme / key-set names, Help source) therefore gain Dialog's keyboard equivalents — , , and Alt+underlined-letter button accelerators — and its default-button handling (gh-71807). ok()'s validation moves to validate(); ok/cancel/transient/grab/wait_window are inherited. The entry_ok validation API and all five subclasses are preserved, as are IDLE's and macOS bindings and the non-resizable geometry. The widgets and paddings follow the style of tkinter.simpledialog (ttk widgets, 2m paddings, sticky fills). A private Dialog._show_modal() seam is added so Query can suppress the modal wait when unit testing; it is a behavior-preserving refactor of the tail of Dialog.__init__. Main-only: it depends on the themed (use_ttk) Dialog, which is not in the maintenance branches. Issue: gh-71808

Open Graph Description: idlelib.query.Query hand-rolled the modal-dialog machinery (transient window, grab, wait_window, OK/Cancel buttons, geometry) that tkinter.simpledialog.Dialog now provides. This rebuilds Query as a...

X Description: idlelib.query.Query hand-rolled the modal-dialog machinery (transient window, grab, wait_window, OK/Cancel buttons, geometry) that tkinter.simpledialog.Dialog now provides. This rebuilds Query as a...

Opengraph URL: https://github.com/python/cpython/pull/152773

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0012f05c-13f4-0b19-fb97-b8d49c593c91
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9AAA:1EEA:410EED7:5CAB199:6A4FEAA9
html-safe-nonce6a8d4df8cf9de25337f16eb40323d1191fffe4a976e11510eed7cd3ce1903114
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUFBOjFFRUE6NDEwRUVENzo1Q0FCMTk5OjZBNEZFQUE5IiwidmlzaXRvcl9pZCI6IjEzNDk2MTg4MzIzMTQ5ODUxMjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac68a31201dcd21f5d864c029980fde197ee5ed8eda10b2460b84e5b1b4c953d4a
hovercard-subject-tagpull_request:3970454580
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/152773/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:altidlelib.query.Query hand-rolled the modal-dialog machinery (transient window, grab, wait_window, OK/Cancel buttons, geometry) that tkinter.simpledialog.Dialog now provides. This rebuilds Query as a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef7e270be010aa4de2871991025fbb97f3afe2bcb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/152773/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152773%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152773%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/152773/files
Reloadhttps://github.com/python/cpython/pull/152773/files
Reloadhttps://github.com/python/cpython/pull/152773/files
Please reload this pagehttps://github.com/python/cpython/pull/152773/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/152773/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:gh-71808-query-simpledialoghttps://github.com/serhiy-storchaka/cpython/tree/gh-71808-query-simpledialog
Conversation 0 https://github.com/python/cpython/pull/152773
Commits 1 https://github.com/python/cpython/pull/152773/commits
Checks 49 https://github.com/python/cpython/pull/152773/checks
Files changed https://github.com/python/cpython/pull/152773/files
Please reload this pagehttps://github.com/python/cpython/pull/152773/files
gh-71808: Rebuild IDLE query dialogs on tkinter.simpledialog.Dialog https://github.com/python/cpython/pull/152773/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/152773/files
53ec4cf gh-71808: Rebuild IDLE query dialogs on tkinter.simpledialog.Dialog serhiy-storchaka Jul 1, 2026 https://github.com/python/cpython/pull/152773/commits/53ec4cf0864d671d659cadda12cbfec49dce1408
Clear filters https://github.com/python/cpython/pull/152773/files
Please reload this pagehttps://github.com/python/cpython/pull/152773/files
Please reload this pagehttps://github.com/python/cpython/pull/152773/files
test_query.py https://github.com/python/cpython/pull/152773/files#diff-3d21e300d8babfb0d202df112d0150bb30919e3268af062875342378cbd76d15
query.py https://github.com/python/cpython/pull/152773/files#diff-89433340d58d6b5ebd8b85268848d5200180adf3498ca5cf3f734071ced9081a
simpledialog.py https://github.com/python/cpython/pull/152773/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
2026-07-01-15-00-00.gh-issue-71808.Rk9pQ2.rst https://github.com/python/cpython/pull/152773/files#diff-30c6f97d32a58a76c446a8f07bc0e57e370d962f80489abb27153165fd6aaa09
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L505
Lib/idlelib/idle_test/test_query.pyhttps://github.com/python/cpython/pull/152773/files#diff-3d21e300d8babfb0d202df112d0150bb30919e3268af062875342378cbd76d15
View file https://github.com/python/cpython/blob/53ec4cf0864d671d659cadda12cbfec49dce1408/Lib/idlelib/idle_test/test_query.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152773/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152773/files#diff-3d21e300d8babfb0d202df112d0150bb30919e3268af062875342378cbd76d15
https://github.com/python/cpython/pull/152773/files#diff-3d21e300d8babfb0d202df112d0150bb30919e3268af062875342378cbd76d15
https://github.com/python/cpython/pull/152773/files#diff-3d21e300d8babfb0d202df112d0150bb30919e3268af062875342378cbd76d15
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L505
Lib/idlelib/query.pyhttps://github.com/python/cpython/pull/152773/files#diff-89433340d58d6b5ebd8b85268848d5200180adf3498ca5cf3f734071ced9081a
View file https://github.com/python/cpython/blob/53ec4cf0864d671d659cadda12cbfec49dce1408/Lib/idlelib/query.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152773/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152773/files#diff-89433340d58d6b5ebd8b85268848d5200180adf3498ca5cf3f734071ced9081a
https://github.com/python/cpython/pull/152773/files#diff-89433340d58d6b5ebd8b85268848d5200180adf3498ca5cf3f734071ced9081a
https://github.com/python/cpython/pull/152773/files#diff-89433340d58d6b5ebd8b85268848d5200180adf3498ca5cf3f734071ced9081a
https://github.com/python/cpython/pull/152773/files#diff-89433340d58d6b5ebd8b85268848d5200180adf3498ca5cf3f734071ced9081a
https://github.com/python/cpython/pull/152773/files#diff-89433340d58d6b5ebd8b85268848d5200180adf3498ca5cf3f734071ced9081a
https://github.com/python/cpython/pull/152773/files#diff-89433340d58d6b5ebd8b85268848d5200180adf3498ca5cf3f734071ced9081a
https://github.com/python/cpython/pull/152773/files#diff-89433340d58d6b5ebd8b85268848d5200180adf3498ca5cf3f734071ced9081a
https://github.com/python/cpython/pull/152773/files#diff-89433340d58d6b5ebd8b85268848d5200180adf3498ca5cf3f734071ced9081a
https://github.com/python/cpython/pull/152773/files#diff-89433340d58d6b5ebd8b85268848d5200180adf3498ca5cf3f734071ced9081a
Lib/tkinter/simpledialog.pyhttps://github.com/python/cpython/pull/152773/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
View file https://github.com/python/cpython/blob/53ec4cf0864d671d659cadda12cbfec49dce1408/Lib/tkinter/simpledialog.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152773/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152773/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
https://github.com/python/cpython/pull/152773/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
Misc/NEWS.d/next/IDLE/2026-07-01-15-00-00.gh-issue-71808.Rk9pQ2.rsthttps://github.com/python/cpython/pull/152773/files#diff-30c6f97d32a58a76c446a8f07bc0e57e370d962f80489abb27153165fd6aaa09
View file https://github.com/python/cpython/blob/53ec4cf0864d671d659cadda12cbfec49dce1408/Misc/NEWS.d/next/IDLE/2026-07-01-15-00-00.gh-issue-71808.Rk9pQ2.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152773/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/152773/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.