René's URL Explorer Experiment


Title: gh-69134: Wait until mapped in SimpleDialog keyboard tests by serhiy-storchaka · Pull Request #152690 · python/cpython · GitHub

Open Graph Title: gh-69134: Wait until mapped in SimpleDialog keyboard tests by serhiy-storchaka · Pull Request #152690 · python/cpython

X Title: gh-69134: Wait until mapped in SimpleDialog keyboard tests by serhiy-storchaka · Pull Request #152690 · python/cpython

Description: The SimpleDialog tests generate key events after focus_force(). On Windows these are only delivered once the toplevel is mapped, so they could be dropped and the test fail intermittently — seen on the AMD64 Windows10 buildbot, where test_return_no_default failed on the first run and passed on the re-run. Unlike the query dialogs (whose __init__ calls wait_visibility()), SimpleDialog only waits for its window in go(), which these tests bypass. Wait until the window is mapped in the create() helper, as GH-152599 did for the other keyboard tests. Issue: gh-69134

Open Graph Description: The SimpleDialog tests generate key events after focus_force(). On Windows these are only delivered once the toplevel is mapped, so they could be dropped and the test fail intermittently — seen on ...

X Description: The SimpleDialog tests generate key events after focus_force(). On Windows these are only delivered once the toplevel is mapped, so they could be dropped and the test fail intermittently — seen on ...

Opengraph URL: https://github.com/python/cpython/pull/152690

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:35e6e38c-e8fc-9ac1-57f0-a5e28f260a5f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE380:243FE3:69D87:8D5C1:6A52BCA4
html-safe-nonce5263d012886dd78f1efd15be7cea0d7fe83229acf85747ae1bd37b09a638b855
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzgwOjI0M0ZFMzo2OUQ4Nzo4RDVDMTo2QTUyQkNBNCIsInZpc2l0b3JfaWQiOiIyNDQyODM4NDcwNDQxNDgzNDI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4db77a6aafb1c8184c3dca9d43860302182accaf1c62c13dac77abe8d452b448
hovercard-subject-tagpull_request:3963839014
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/152690/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:altThe SimpleDialog tests generate key events after focus_force(). On Windows these are only delivered once the toplevel is mapped, so they could be dropped and the test fail intermittently — seen on ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/152690/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152690%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152690%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/152690/files
Reloadhttps://github.com/python/cpython/pull/152690/files
Reloadhttps://github.com/python/cpython/pull/152690/files
Please reload this pagehttps://github.com/python/cpython/pull/152690/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/152690/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:gh-69134-map-simpledialog-testshttps://github.com/serhiy-storchaka/cpython/tree/gh-69134-map-simpledialog-tests
Conversation 10 https://github.com/python/cpython/pull/152690
Commits 1 https://github.com/python/cpython/pull/152690/commits
Checks 62 https://github.com/python/cpython/pull/152690/checks
Files changed https://github.com/python/cpython/pull/152690/files
Please reload this pagehttps://github.com/python/cpython/pull/152690/files
gh-69134: Wait until mapped in SimpleDialog keyboard tests https://github.com/python/cpython/pull/152690/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/152690/files
1b5a7b2 gh-69134: Wait until mapped in SimpleDialog keyboard tests serhiy-storchaka Jun 30, 2026 https://github.com/python/cpython/pull/152690/commits/1b5a7b2223a54d57e73a0e440b013c95052d301d
Clear filters https://github.com/python/cpython/pull/152690/files
Please reload this pagehttps://github.com/python/cpython/pull/152690/files
Please reload this pagehttps://github.com/python/cpython/pull/152690/files
Lib/test/test_tkinter/test_simpledialog.pyhttps://github.com/python/cpython/pull/152690/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651
View file https://github.com/serhiy-storchaka/cpython/blob/1b5a7b2223a54d57e73a0e440b013c95052d301d/Lib/test/test_tkinter/test_simpledialog.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152690/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152690/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651
https://github.com/python/cpython/pull/152690/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651
https://github.com/python/cpython/pull/152690/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651
https://github.com/python/cpython/pull/152690/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651
https://github.com/python/cpython/pull/152690/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651
https://github.com/python/cpython/pull/152690/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651
https://github.com/python/cpython/pull/152690/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651
https://github.com/python/cpython/pull/152690/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651
https://github.com/python/cpython/pull/152690/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651
Please reload this pagehttps://github.com/python/cpython/pull/152690/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.