René's URL Explorer Experiment


Title: gh-152682: Fix NULL dereference on OOM in symtable_visit_type_param_bound_or_default by petrvaganoff · Pull Request #152684 · python/cpython · GitHub

Open Graph Title: gh-152682: Fix NULL dereference on OOM in symtable_visit_type_param_bound_or_default by petrvaganoff · Pull Request #152684 · python/cpython

X Title: gh-152682: Fix NULL dereference on OOM in symtable_visit_type_param_bound_or_default by petrvaganoff · Pull Request #152684 · python/cpython

Description: When a reserved name (e.g. __classdict__) is used as a type parameter, symtable_visit_type_param_bound_or_default() calls PyUnicode_FromFormat() to build the SyntaxError message. If the allocation fails and returns NULL, the subsequent PyErr_SetObject(PyExc_SyntaxError, NULL) and Py_DECREF(NULL) calls dereference the null pointer, causing a segfault. Fix by returning 0 immediately when PyUnicode_FromFormat() returns NULL, which propagates the MemoryError already set by PyUnicode_FromFormat(). The bug was introduced in gh-128632 (commit 891c61c). Found by static analyzer Svace (ISP RAS). Add a NEWS entry in Misc/NEWS.d/ Add regression test (test_disallowed_type_param_names_oom) Issue: gh-152682

Open Graph Description: When a reserved name (e.g. __classdict__) is used as a type parameter, symtable_visit_type_param_bound_or_default() calls PyUnicode_FromFormat() to build the SyntaxError message. If the allocation ...

X Description: When a reserved name (e.g. __classdict__) is used as a type parameter, symtable_visit_type_param_bound_or_default() calls PyUnicode_FromFormat() to build the SyntaxError message. If the allocation ...

Opengraph URL: https://github.com/python/cpython/pull/152684

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f6df791e-272e-905c-847c-ad0c38415323
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC8C:18CEBB:14D29B2:1B9BA3F:6A51BB86
html-safe-nonceade620da95c72034a3fb0f1e87202679960bb276197c7c45364c463128440803
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzhDOjE4Q0VCQjoxNEQyOUIyOjFCOUJBM0Y6NkE1MUJCODYiLCJ2aXNpdG9yX2lkIjoiNTg0MzY2NjM3NTEwOTg4NDgwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac19c4aed0a9f18ed5fd466581183fcc8fc497aa4f2fa6c7ad7c2251c4a38eb66b
hovercard-subject-tagpull_request:3963708168
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/152684/files
twitter:imagehttps://avatars.githubusercontent.com/u/202619501?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/202619501?s=400&v=4
og:image:altWhen a reserved name (e.g. __classdict__) is used as a type parameter, symtable_visit_type_param_bound_or_default() calls PyUnicode_FromFormat() to build the SyntaxError message. If the allocation ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/152684/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152684%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152684%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/152684/files
Reloadhttps://github.com/python/cpython/pull/152684/files
Reloadhttps://github.com/python/cpython/pull/152684/files
Please reload this pagehttps://github.com/python/cpython/pull/152684/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/152684/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
sobolevnhttps://github.com/sobolevn
python:mainhttps://github.com/python/cpython/tree/main
petrvaganoff:devhttps://github.com/petrvaganoff/cpython/tree/dev
Conversation 13 https://github.com/python/cpython/pull/152684
Commits 1 https://github.com/python/cpython/pull/152684/commits
Checks 64 https://github.com/python/cpython/pull/152684/checks
Files changed 3 https://github.com/python/cpython/pull/152684/files
gh-152682: Fix NULL dereference on OOM in symtable_visit_type_param_bound_or_default https://github.com/python/cpython/pull/152684/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/152684/files
ad57b62 gh-152682: Fix NULL dereference on OOM in symtable_visit_type_param_b… petrvaganoff Jun 30, 2026 https://github.com/python/cpython/pull/152684/commits/ad57b623b5c762bc286620ca1b45855bd223779d
Clear filters https://github.com/python/cpython/pull/152684/files
Please reload this pagehttps://github.com/python/cpython/pull/152684/files
Please reload this pagehttps://github.com/python/cpython/pull/152684/files
test_syntax.py https://github.com/python/cpython/pull/152684/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
2026-06-30-14-00-00.gh-issue-152682.yId7e5.rst https://github.com/python/cpython/pull/152684/files#diff-8df2cadd759b7eeded9b33c61a8d6b5996fe296dd4ae4e6778125cadaddd8a7a
symtable.c https://github.com/python/cpython/pull/152684/files#diff-1029343b7709f438c869082355577469b5aa784b454afa461ca2844ce9910ea6
Lib/test/test_syntax.pyhttps://github.com/python/cpython/pull/152684/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
View file https://github.com/petrvaganoff/cpython/blob/ad57b623b5c762bc286620ca1b45855bd223779d/Lib/test/test_syntax.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152684/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152684/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
https://github.com/python/cpython/pull/152684/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
https://github.com/python/cpython/pull/152684/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
StanFromIrelandhttps://github.com/StanFromIreland
Jun 30, 2026https://github.com/python/cpython/pull/152684/files#r3499793094
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/152684/files
petrvaganoffhttps://github.com/petrvaganoff
Jun 30, 2026https://github.com/python/cpython/pull/152684/files#r3501879708
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/152684/files
StanFromIrelandhttps://github.com/StanFromIreland
Jul 1, 2026https://github.com/python/cpython/pull/152684/files#r3504849150
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/152684/files
petrvaganoffhttps://github.com/petrvaganoff
Jul 1, 2026https://github.com/python/cpython/pull/152684/files#r3505631676
Please reload this pagehttps://github.com/python/cpython/pull/152684/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#152770https://github.com/python/cpython/pull/152770
Please reload this pagehttps://github.com/python/cpython/pull/152684/files
https://github.com/python/cpython/pull/152684/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
Misc/NEWS.d/next/Core_and_Builtins/2026-06-30-14-00-00.gh-issue-152682.yId7e5.rsthttps://github.com/python/cpython/pull/152684/files#diff-8df2cadd759b7eeded9b33c61a8d6b5996fe296dd4ae4e6778125cadaddd8a7a
View file https://github.com/petrvaganoff/cpython/blob/ad57b623b5c762bc286620ca1b45855bd223779d/Misc/NEWS.d/next/Core_and_Builtins/2026-06-30-14-00-00.gh-issue-152682.yId7e5.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152684/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L235
Python/symtable.chttps://github.com/python/cpython/pull/152684/files#diff-1029343b7709f438c869082355577469b5aa784b454afa461ca2844ce9910ea6
View file https://github.com/petrvaganoff/cpython/blob/ad57b623b5c762bc286620ca1b45855bd223779d/Python/symtable.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152684/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152684/files#diff-1029343b7709f438c869082355577469b5aa784b454afa461ca2844ce9910ea6
https://github.com/python/cpython/pull/152684/files#diff-1029343b7709f438c869082355577469b5aa784b454afa461ca2844ce9910ea6
Please reload this pagehttps://github.com/python/cpython/pull/152684/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.