René's URL Explorer Experiment

Title: gh-152635: Raise MemoryError rather than fail assert() when the lock allocation fails in _interpchannels.create() by stestagg · Pull Request #152642 · python/cpython · GitHub

Open Graph Title: gh-152635: Raise MemoryError rather than fail assert() when the lock allocation fails in _interpchannels.create() by stestagg · Pull Request #152642 · python/cpython

X Title: gh-152635: Raise MemoryError rather than fail assert() when the lock allocation fails in _interpchannels.create() by stestagg · Pull Request #152642 · python/cpython

Description: Previously, an allocation failure when creating the lock for a channel in _interpchannels would trigger an assert. Caused by handle_channel_error being passed an error code of -1 which is only allowed if an exception has been set. (in this case, no exception was set) channelsmod_create now forwards the error code from channel_create which handle_channel_error already handled. Because the only way to get a -7 error code (was ERR_CHANNEL_MUTEX_INIT) is via an allocation failure in PyThread_allocate_lock, I made handle_channel_error raise a MemoryError for this case rather than a ChannelError which seems more consistent with general practice. I also renamed the constant from ERR_CHANNEL_MUTEX_INIT to ERR_CHANNEL_ALLOC_LOCK to make this clearer for future changes. There's a test to cover this, which does rely on _interpchannels.create code paths not changing too wildly (first allocation has to be the lock), but even if that changes, the test isn't invalid. Full test suite passes, except test_struct which is known in gh-142414 on MacOS and Windows Test summary == Tests result: FAILURE == 32 tests skipped: test.test_asyncio.test_windows_events test.test_asyncio.test_windows_utils test.test_gdb.test_backtrace test.test_gdb.test_cfunction test.test_gdb.test_cfunction_full test.test_gdb.test_jit test.test_gdb.test_misc test.test_gdb.test_pretty_print test.test_multiprocessing_fork.test_manager test.test_multiprocessing_fork.test_misc test.test_multiprocessing_fork.test_processes test.test_multiprocessing_fork.test_threads test.test_os.test_windows test_android test_dbm_gnu test_devpoll test_dtrace test_epoll test_free_threading test_idle test_launcher test_msvcrt test_startfile test_tcl test_tkinter test_ttk test_ttk_textonly test_turtle test_winapi test_winconsoleio test_winreg test_wmi 9 tests skipped (resource denied): test_curses test_peg_generator test_smtpnet test_socketserver test_urllib2net test_urllibnet test_winsound test_xpickle test_zipfile64 1 test altered the execution environment (env changed): test_httpservers 1 test failed: test_struct 462 tests OK. Issue: gh-152635

Open Graph Description: Previously, an allocation failure when creating the lock for a channel in _interpchannels would trigger an assert. Caused by handle_channel_error being passed an error code of -1 which is only allo...

X Description: Previously, an allocation failure when creating the lock for a channel in _interpchannels would trigger an assert. Caused by handle_channel_error being passed an error code of -1 which is only allo...

Opengraph URL: https://github.com/python/cpython/pull/152642

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width