René's URL Explorer Experiment


Title: gh-152635: Raise MemoryError rather than fail assert() when the lock allocation fails in _interpchannels.create() by stestagg · Pull Request #152642 · python/cpython · GitHub

Open Graph Title: gh-152635: Raise MemoryError rather than fail assert() when the lock allocation fails in _interpchannels.create() by stestagg · Pull Request #152642 · python/cpython

X Title: gh-152635: Raise MemoryError rather than fail assert() when the lock allocation fails in _interpchannels.create() by stestagg · Pull Request #152642 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Previously, an allocation failure when creating the lock for a channel in _interpchannels would trigger an assert. Caused by handle_channel_error being passed an error code of -1 which is only allo...

X Description: Previously, an allocation failure when creating the lock for a channel in _interpchannels would trigger an assert. Caused by handle_channel_error being passed an error code of -1 which is only allo...

Opengraph URL: https://github.com/python/cpython/pull/152642

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:c9da1f0a-788a-54fe-6818-1f6d05bf69c0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id935E:1D428F:210EF5:2D376F:6A51B842
html-safe-nonce17fc4ccbaa67e866127decdcdb7770aea8e7cf76eea3af35f5dd5c367196b763
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzVFOjFENDI4RjoyMTBFRjU6MkQzNzZGOjZBNTFCODQyIiwidmlzaXRvcl9pZCI6Ijc0NTkxOTAyMzc1ODI5MzA1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfe34823375eb0a344447a155b849bc9bd7dffa89b39904c1264dec53bf7433a7
hovercard-subject-tagpull_request:3959418436
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/152642/commits
twitter:imagehttps://opengraph.githubassets.com/ad4cab06478d1df32729317e01632089fa4552b8cfeb605a4762aeeff75302ea/python/cpython/pull/152642
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ad4cab06478d1df32729317e01632089fa4552b8cfeb605a4762aeeff75302ea/python/cpython/pull/152642
og:image:altPreviously, an allocation failure when creating the lock for a channel in _interpchannels would trigger an assert. Caused by handle_channel_error being passed an error code of -1 which is only allo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamestestagg
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/152642/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152642%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152642%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/152642/commits
Reloadhttps://github.com/python/cpython/pull/152642/commits
Reloadhttps://github.com/python/cpython/pull/152642/commits
Please reload this pagehttps://github.com/python/cpython/pull/152642/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/152642/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
sobolevnhttps://github.com/sobolevn
python:mainhttps://github.com/python/cpython/tree/main
stestagg:mainhttps://github.com/stestagg/cpython/tree/main
Conversationhttps://github.com/python/cpython/pull/152642
Commits6 (6)https://github.com/python/cpython/pull/152642/commits
Checkshttps://github.com/python/cpython/pull/152642/checks
Files changedhttps://github.com/python/cpython/pull/152642/files
gh-152635: Raise MemoryError rather than fail assert() when the lock allocation fails in _interpchannels.create()https://github.com/python/cpython/pull/152642/commits#top
sobolevnhttps://github.com/sobolevn
python:mainhttps://github.com/python/cpython/tree/main
stestagg:mainhttps://github.com/stestagg/cpython/tree/main
Fix: gh-152635 _interpchannels channel lock alloc failurehttps://github.com/python/cpython/pull/152642/commits/c25ac11f0937a7979140de02b79c4dffa3b2960b
https://github.com/stestagg
stestagghttps://github.com/python/cpython/commits?author=stestagg
c25ac11https://github.com/python/cpython/pull/152642/commits/c25ac11f0937a7979140de02b79c4dffa3b2960b
https://github.com/python/cpython/tree/c25ac11f0937a7979140de02b79c4dffa3b2960b
Add @nomemtest decorator to the test, move the _testcapi call into the test method to avoid import issues, improve the syntax for handling the expected MemoryErrorhttps://github.com/python/cpython/pull/152642/commits/b61a06fc59baeab52a14b43077c3638d05cfd4c8
https://github.com/stestagg
stestagghttps://github.com/python/cpython/commits?author=stestagg
b61a06fhttps://github.com/python/cpython/pull/152642/commits/b61a06fc59baeab52a14b43077c3638d05cfd4c8
https://github.com/python/cpython/tree/b61a06fc59baeab52a14b43077c3638d05cfd4c8
self.assertRaises causes an allocation, so the _testcapi callhttps://github.com/python/cpython/pull/152642/commits/191f46a5aea2d3cb0392c241a6bb233d3a4be8ce
https://github.com/stestagg
stestagghttps://github.com/python/cpython/commits?author=stestagg
191f46ahttps://github.com/python/cpython/pull/152642/commits/191f46a5aea2d3cb0392c241a6bb233d3a4be8ce
https://github.com/python/cpython/tree/191f46a5aea2d3cb0392c241a6bb233d3a4be8ce
Remove the test as it's not reliable enough, and testing allocation failues seems to be rarely donehttps://github.com/python/cpython/pull/152642/commits/aeb50c0639b86e3c028c1be5e9310db7c73fdf85
https://github.com/stestagg
stestagghttps://github.com/python/cpython/commits?author=stestagg
aeb50c0https://github.com/python/cpython/pull/152642/commits/aeb50c0639b86e3c028c1be5e9310db7c73fdf85
https://github.com/python/cpython/tree/aeb50c0639b86e3c028c1be5e9310db7c73fdf85
Code review suggestionshttps://github.com/python/cpython/pull/152642/commits/b9182d3f008dff046745b6d7ea42d0a07f75c71e
stestagghttps://github.com/python/cpython/commits?author=stestagg
sobolevnhttps://github.com/python/cpython/commits?author=sobolevn
b9182d3https://github.com/python/cpython/pull/152642/commits/b9182d3f008dff046745b6d7ea42d0a07f75c71e
https://github.com/python/cpython/tree/b9182d3f008dff046745b6d7ea42d0a07f75c71e
Remove the now-redundant (and incorrect) branch fromhttps://github.com/python/cpython/pull/152642/commits/25b178a70153ac2753e9b0056ac515cbc17be1ad
https://github.com/stestagg
stestagghttps://github.com/python/cpython/commits?author=stestagg
25b178ahttps://github.com/python/cpython/pull/152642/commits/25b178a70153ac2753e9b0056ac515cbc17be1ad
https://github.com/python/cpython/tree/25b178a70153ac2753e9b0056ac515cbc17be1ad
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.