René's URL Explorer Experiment


Title: gh-152356: Fix Windows blocking sampling after target process exit by zainnadeem786 · Pull Request #152471 · python/cpython · GitHub

Open Graph Title: gh-152356: Fix Windows blocking sampling after target process exit by zainnadeem786 · Pull Request #152471 · python/cpython

X Title: gh-152356: Fix Windows blocking sampling after target process exit by zainnadeem786 · Pull Request #152471 · python/cpython

Description: Summary Fixes gh-152356. On Windows, profiling.sampling run --blocking could hang indefinitely after the target process had already exited, leaving an empty binary profile that could not be replayed. The non-blocking sampling path already terminates correctly when the target exits, but the Windows blocking implementation classified the same process-exit condition differently. Root Cause During blocking sampling, the profiler pauses the target through the Windows remote debugging layer. If the target process has already exited, NtSuspendProcess() fails. The Windows implementation currently reports this as a RuntimeError. The sampling loop treats RuntimeError as a recoverable sampling failure and continues retrying, so profiling never finishes and the binary profile writer is never finalized. Other platforms already report terminated processes as ProcessLookupError, which the sampling loop correctly treats as a terminal condition. Changes This patch updates the Windows implementation of _Py_RemoteDebug_StopAllThreads(). When NtSuspendProcess() fails because the target process has already terminated, the remote debugging layer now raises ProcessLookupError instead of RuntimeError. Existing RuntimeError behaviour is preserved for genuine NtSuspendProcess() failures while alive processes are unaffected. No other profiling behaviour changes. Tests Added a Windows-only regression test that: runs profiling.sampling run --binary --mode=cpu --blocking against a short-lived Python script, verifies the command exits successfully, verifies a non-empty binary profile is produced, verifies the generated profile can be replayed successfully. Validation Validated with: PCbuild\build.bat -p x64 -d PCbuild\amd64\python_d.exe -m unittest -v test.test_profiling.test_sampling_profiler.test_blocking.TestBlockingModeCLI PCbuild\amd64\python_d.exe -m test test_profiling PCbuild\amd64\python_d.exe -m test test_importlib test_subprocess manual verification of profiling.sampling run --blocking and profiling.sampling replay git diff --check After this change, Windows blocking sampling terminates correctly once the target process exits and produces a valid replayable binary profile.

Open Graph Description: Summary Fixes gh-152356. On Windows, profiling.sampling run --blocking could hang indefinitely after the target process had already exited, leaving an empty binary profile that could not be replaye...

X Description: Summary Fixes gh-152356. On Windows, profiling.sampling run --blocking could hang indefinitely after the target process had already exited, leaving an empty binary profile that could not be replaye...

Opengraph URL: https://github.com/python/cpython/pull/152471

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f1d1a4e2-84fb-4311-2eaf-72f3e3f47486
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC048:23E48:C8E346:FBC590:6B023B87
html-safe-noncefb1f49fcf6aec7c56b7cc2856666971a653d8cc69b41016afc6a17776c4eea20
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDQ4OjIzRTQ4OkM4RTM0NjpGQkM1OTA6NkIwMjNCODciLCJ2aXNpdG9yX2lkIjoiNTE3MDEyMDA1NjA1MDQzMjkwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8b4550b4cd377c1d910627f0a3c5858dcce13ad237763c94fde2cd29a300163a
hovercard-subject-tagpull_request:3950265626
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/152471/files
twitter:imagehttps://avatars.githubusercontent.com/u/165761530?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/165761530?s=400&v=4
og:image:altSummary Fixes gh-152356. On Windows, profiling.sampling run --blocking could hang indefinitely after the target process had already exited, leaving an empty binary profile that could not be replaye...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/152471/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152471%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152471%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/152471/files
Reloadhttps://github.com/python/cpython/pull/152471/files
Reloadhttps://github.com/python/cpython/pull/152471/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
zainnadeem786:fix/profiling-sampling-blocking-windows-exithttps://github.com/zainnadeem786/cpython/tree/fix/profiling-sampling-blocking-windows-exit
Conversation 9 https://github.com/python/cpython/pull/152471
Commits 1 https://github.com/python/cpython/pull/152471/commits
Checks 60 https://github.com/python/cpython/pull/152471/checks
Files changed https://github.com/python/cpython/pull/152471/files
Please reload this pagehttps://github.com/python/cpython/pull/152471/files
gh-152356: Fix Windows blocking sampling after target process exit https://github.com/python/cpython/pull/152471/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/152471/files
42f0941 gh-152356: Fix Windows blocking sampling after process exit zainnadeem786 Jun 28, 2026 https://github.com/python/cpython/pull/152471/commits/42f09415b54f2e700436d9b6bed8db70e11fe2a8
Clear filters https://github.com/python/cpython/pull/152471/files
Please reload this pagehttps://github.com/python/cpython/pull/152471/files
Please reload this pagehttps://github.com/python/cpython/pull/152471/files
test_blocking.py https://github.com/python/cpython/pull/152471/files#diff-3476c860d571d634be0a2ef95b5047698c4a2b25363f9909a25288353105c66d
2026-06-28-12-45-09.gh-issue-152356.Dr4w2Q.rst https://github.com/python/cpython/pull/152471/files#diff-6f29dfd2d0f98968dfcd71b933aaa61f02a9be1bba32e1b2c4904cad0c310d3f
threads.c https://github.com/python/cpython/pull/152471/files#diff-6cb0e37d99f0b76992ce6170feb1853dc26762bb1fd7e12ef30436b71198b8bb
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L568
Lib/test/test_profiling/test_sampling_profiler/test_blocking.pyhttps://github.com/python/cpython/pull/152471/files#diff-3476c860d571d634be0a2ef95b5047698c4a2b25363f9909a25288353105c66d
View file https://github.com/zainnadeem786/cpython/blob/42f09415b54f2e700436d9b6bed8db70e11fe2a8/Lib/test/test_profiling/test_sampling_profiler/test_blocking.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152471/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152471/files#diff-3476c860d571d634be0a2ef95b5047698c4a2b25363f9909a25288353105c66d
https://github.com/python/cpython/pull/152471/files#diff-3476c860d571d634be0a2ef95b5047698c4a2b25363f9909a25288353105c66d
https://github.com/python/cpython/pull/152471/files#diff-3476c860d571d634be0a2ef95b5047698c4a2b25363f9909a25288353105c66d
Misc/NEWS.d/next/Library/2026-06-28-12-45-09.gh-issue-152356.Dr4w2Q.rsthttps://github.com/python/cpython/pull/152471/files#diff-6f29dfd2d0f98968dfcd71b933aaa61f02a9be1bba32e1b2c4904cad0c310d3f
View file https://github.com/zainnadeem786/cpython/blob/42f09415b54f2e700436d9b6bed8db70e11fe2a8/Misc/NEWS.d/next/Library/2026-06-28-12-45-09.gh-issue-152356.Dr4w2Q.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152471/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L336
Modules/_remote_debugging/threads.chttps://github.com/python/cpython/pull/152471/files#diff-6cb0e37d99f0b76992ce6170feb1853dc26762bb1fd7e12ef30436b71198b8bb
View file https://github.com/zainnadeem786/cpython/blob/42f09415b54f2e700436d9b6bed8db70e11fe2a8/Modules/_remote_debugging/threads.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152471/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152471/files#diff-6cb0e37d99f0b76992ce6170feb1853dc26762bb1fd7e12ef30436b71198b8bb
https://github.com/python/cpython/pull/152471/files#diff-6cb0e37d99f0b76992ce6170feb1853dc26762bb1fd7e12ef30436b71198b8bb
Please reload this pagehttps://github.com/python/cpython/pull/152471/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.