Title: gh-152260: Fix flaky curses test_scr_dump on macOS by serhiy-storchaka · Pull Request #152390 · python/cpython · GitHub
Open Graph Title: gh-152260: Fix flaky curses test_scr_dump on macOS by serhiy-storchaka · Pull Request #152390 · python/cpython
X Title: gh-152260: Fix flaky curses test_scr_dump on macOS by serhiy-storchaka · Pull Request #152390 · python/cpython
Description: Issue: gh-152260 The screen dump embeds raw pointers that change after scr_restore() reallocates the virtual-screen structures, so comparing dump bytes is unreliable on platforms such as macOS. The previous attempt (gh-152260, PR #152340) tried to detect this by comparing two consecutive dumps of the unchanged screen and only byte-comparing when they matched. That probe is a false predictor: two back-to-back dumps share the same live-allocation pointers, but the asserted comparison is against a dump taken after scr_restore(), whose pointers differ. So test_scr_dump stayed flaky-red on macos-26-intel. Drop the byte comparison entirely and exercise the scr_dump/scr_restore/scr_init/scr_set round-trip functionally.
Open Graph Description: Issue: gh-152260 The screen dump embeds raw pointers that change after scr_restore() reallocates the virtual-screen structures, so comparing dump bytes is unreliable on platforms such as macOS. T...
X Description: Issue: gh-152260 The screen dump embeds raw pointers that change after scr_restore() reallocates the virtual-screen structures, so comparing dump bytes is unreliable on platforms such as macOS. T...
Opengraph URL: https://github.com/python/cpython/pull/152390
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:df746170-5a60-57b8-51bc-47c99abad160 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DC80:2D523B:557DAE:726060:6A52FA80 |
| html-safe-nonce | 93dc5756f05df10631739fb538c28075b7fdc0800b92adaa1bf1db36f3731949 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzgwOjJENTIzQjo1NTdEQUU6NzI2MDYwOjZBNTJGQTgwIiwidmlzaXRvcl9pZCI6IjExNDg2NDY0ODQ5MjI3OTI1NzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ca821ba5c9d1ccf10b78e64b0b1e8d1d1881561c72f02e25148d321a50f0e000 |
| hovercard-subject-tag | pull_request:3947452787 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/152390/files |
| twitter:image | https://avatars.githubusercontent.com/u/3659035?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3659035?s=400&v=4 |
| og:image:alt | Issue: gh-152260 The screen dump embeds raw pointers that change after scr_restore() reallocates the virtual-screen structures, so comparing dump bytes is unreliable on platforms such as macOS. T... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width