René's URL Explorer Experiment


Title: gh-116946: Implement the GC protocol for _tkinter tkapp and tktimertoken by serhiy-storchaka · Pull Request #152310 · python/cpython · GitHub

Open Graph Title: gh-116946: Implement the GC protocol for _tkinter tkapp and tktimertoken by serhiy-storchaka · Pull Request #152310 · python/cpython

X Title: gh-116946: Implement the GC protocol for _tkinter tkapp and tktimertoken by serhiy-storchaka · Pull Request #152310 · python/cpython

Description: The internal _tkinter.tkapp and _tkinter.tktimertoken types are heap types implemented in C but never implemented the garbage collector protocol, so reference cycles through a Tcl interpreter's trace function or a timer handler's callback could not be collected. They now implement tp_traverse and tp_clear, set Py_TPFLAGS_HAVE_GC, allocate through the type's tp_alloc, and untrack on deallocation. Two design points differ from the earlier, reverted attempt (gh-138331, reverted by gh-138807 over the gh-138789/gh-138791 regression): A pending timer is kept alive by the Tcl event loop, which fires it even after the Python token is dropped. It is therefore treated as a GC root -- only its callback is traversed, not the extra reference owned by the event loop -- so collecting it never cancels a live timer. test_timer_fires_after_gc guards this. The GC slots use a plain cast rather than the type-checking macro, because the collector may visit a surviving object during interpreter shutdown, after module clearing has reset the global type pointers (the source of the gh-138789 shutdown crash). test_pending_timer_at_shutdown guards this. This is independent of and complementary to gh-80937 / #152294: it does not traverse the command table, so it does not collect the createcommand cycle, and that fix does not collect interpreter/timer cycles. Issue: gh-116946

Open Graph Description: The internal _tkinter.tkapp and _tkinter.tktimertoken types are heap types implemented in C but never implemented the garbage collector protocol, so reference cycles through a Tcl interpreter's...

X Description: The internal _tkinter.tkapp and _tkinter.tktimertoken types are heap types implemented in C but never implemented the garbage collector protocol, so reference cycles through a Tcl interpreter&#...

Opengraph URL: https://github.com/python/cpython/pull/152310

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0bccfdf2-005f-b5ca-ec81-a7dfd40294a9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA572:62F48:18DBC0F:20A1C9D:6B0241F6
html-safe-nonced0049dac7280f33efc51d79d14f7370b2d728944653f852ae4f7f2a545521a64
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTcyOjYyRjQ4OjE4REJDMEY6MjBBMUM5RDo2QjAyNDFGNiIsInZpc2l0b3JfaWQiOiIzMTI2OTk1MTU0MDQxNDU1MDk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc0e5a8fada582c90a6d250f3b46e4d45259c2bbe462cb873ed8943c7cf57f642
hovercard-subject-tagpull_request:3943518479
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/152310/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:altThe internal _tkinter.tkapp and _tkinter.tktimertoken types are heap types implemented in C but never implemented the garbage collector protocol, so reference cycles through a Tcl interpreter's...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/152310/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152310%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152310%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/152310/files
Reloadhttps://github.com/python/cpython/pull/152310/files
Reloadhttps://github.com/python/cpython/pull/152310/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:tkinter-gc-protocolhttps://github.com/serhiy-storchaka/cpython/tree/tkinter-gc-protocol
Conversation 1 https://github.com/python/cpython/pull/152310
Commits 3 https://github.com/python/cpython/pull/152310/commits
Checks 52 https://github.com/python/cpython/pull/152310/checks
Files changed https://github.com/python/cpython/pull/152310/files
Please reload this pagehttps://github.com/python/cpython/pull/152310/files
gh-116946: Implement the GC protocol for _tkinter tkapp and tktimertoken https://github.com/python/cpython/pull/152310/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/152310/files
1721941 gh-116946: Implement the GC protocol for _tkinter tkapp and tktimertoken serhiy-storchaka Jun 26, 2026 https://github.com/python/cpython/pull/152310/commits/1721941f2d43431cfa7bcc980bfd6638a10a26c1
f0d5301 Merge remote-tracking branch 'upstream/main' into tkinter-gc-protocol serhiy-storchaka Jun 29, 2026 https://github.com/python/cpython/pull/152310/commits/f0d53012b55db0051bd1464ca41aa17521cd2179
82886ef Apply suggestion from @picnixz serhiy-storchaka Jun 29, 2026 https://github.com/python/cpython/pull/152310/commits/82886efef647dc1708369033fa7fa56e20890985
Clear filters https://github.com/python/cpython/pull/152310/files
Please reload this pagehttps://github.com/python/cpython/pull/152310/files
Please reload this pagehttps://github.com/python/cpython/pull/152310/files
test_misc.py https://github.com/python/cpython/pull/152310/files#diff-405a10eb3d5b952a9f938754dcd3c32bb019627f462b5c366d6f90b817a821ea
2026-06-26-14-05-00.gh-issue-116946.Kp7raZ.rst https://github.com/python/cpython/pull/152310/files#diff-03c1edcefce7c761306831ecc1d79a9eea3ef58d1e0c443e7d0b20ac4dd1cbd7
_tkinter.c https://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
Lib/test/test_tkinter/test_misc.pyhttps://github.com/python/cpython/pull/152310/files#diff-405a10eb3d5b952a9f938754dcd3c32bb019627f462b5c366d6f90b817a821ea
View file https://github.com/serhiy-storchaka/cpython/blob/82886efef647dc1708369033fa7fa56e20890985/Lib/test/test_tkinter/test_misc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152310/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152310/files#diff-405a10eb3d5b952a9f938754dcd3c32bb019627f462b5c366d6f90b817a821ea
https://github.com/python/cpython/pull/152310/files#diff-405a10eb3d5b952a9f938754dcd3c32bb019627f462b5c366d6f90b817a821ea
https://github.com/python/cpython/pull/152310/files#diff-405a10eb3d5b952a9f938754dcd3c32bb019627f462b5c366d6f90b817a821ea
Misc/NEWS.d/next/Library/2026-06-26-14-05-00.gh-issue-116946.Kp7raZ.rsthttps://github.com/python/cpython/pull/152310/files#diff-03c1edcefce7c761306831ecc1d79a9eea3ef58d1e0c443e7d0b20ac4dd1cbd7
View file https://github.com/serhiy-storchaka/cpython/blob/82886efef647dc1708369033fa7fa56e20890985/Misc/NEWS.d/next/Library/2026-06-26-14-05-00.gh-issue-116946.Kp7raZ.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152310/{{ revealButtonHref }}
Modules/_tkinter.chttps://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
View file https://github.com/serhiy-storchaka/cpython/blob/82886efef647dc1708369033fa7fa56e20890985/Modules/_tkinter.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152310/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152310/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
Please reload this pagehttps://github.com/python/cpython/pull/152310/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.