René's URL Explorer Experiment


Title: gh-152305: Fix pure-Python time.strftime AttributeError on %Y/%G/%C/%F by tonghuaroot · Pull Request #152306 · python/cpython · GitHub

Open Graph Title: gh-152305: Fix pure-Python time.strftime AttributeError on %Y/%G/%C/%F by tonghuaroot · Pull Request #152306 · python/cpython

X Title: gh-152305: Fix pure-Python time.strftime AttributeError on %Y/%G/%C/%F by tonghuaroot · Pull Request #152306 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: _wrap_strftime in the pure-Python datetime implementation reads object.year in its year-normalization branch. When strftime is called on a datetime.time (which has no .year), this raises AttributeE...

X Description: _wrap_strftime in the pure-Python datetime implementation reads object.year in its year-normalization branch. When strftime is called on a datetime.time (which has no .year), this raises AttributeE...

Opengraph URL: https://github.com/python/cpython/pull/152306

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:faf5e141-4c11-90ab-a8d7-b97d37e419e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2CC:2E3FEE:4732D8E:59F031B:6B023A6B
html-safe-nonce3a7126a94c32ff376cea78c6ac47def607fe84645b62474240b6e2f6350e7c14
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkNDOjJFM0ZFRTo0NzMyRDhFOjU5RjAzMUI6NkIwMjNBNkIiLCJ2aXNpdG9yX2lkIjoiODkwODM3OTY3NDAzMjM1NTk0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd54a8224bcf9986c63c7aed6e6d2b704006ecd859c11c59bf7b0b2394ee24ba2
hovercard-subject-tagpull_request:3943300254
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/152306/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bcdedd430710a49f250498f3c844b15893ac530a72ca7914c10e3c8a27aab84b/python/cpython/pull/152306
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bcdedd430710a49f250498f3c844b15893ac530a72ca7914c10e3c8a27aab84b/python/cpython/pull/152306
og:image:alt_wrap_strftime in the pure-Python datetime implementation reads object.year in its year-normalization branch. When strftime is called on a datetime.time (which has no .year), this raises AttributeE...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametonghuaroot
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/152306#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152306
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152306
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/152306
Reloadhttps://github.com/python/cpython/pull/152306
Reloadhttps://github.com/python/cpython/pull/152306
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
StanFromIrelandhttps://github.com/StanFromIreland
python:mainhttps://github.com/python/cpython/tree/main
tonghuaroot:fix-gh-152305-strftime-time-yearhttps://github.com/tonghuaroot/cpython/tree/fix-gh-152305-strftime-time-year
Conversationhttps://github.com/python/cpython/pull/152306
Commits3 (3)https://github.com/python/cpython/pull/152306/commits
Checkshttps://github.com/python/cpython/pull/152306/checks
Files changedhttps://github.com/python/cpython/pull/152306/files
gh-152305: Fix pure-Python time.strftime AttributeError on %Y/%G/%C/%Fhttps://github.com/python/cpython/pull/152306#top
StanFromIrelandhttps://github.com/StanFromIreland
python:mainhttps://github.com/python/cpython/tree/main
tonghuaroot:fix-gh-152305-strftime-time-yearhttps://github.com/tonghuaroot/cpython/tree/fix-gh-152305-strftime-time-year
https://github.com/tonghuaroot
tonghuaroothttps://github.com/tonghuaroot
Jun 26, 2026https://github.com/python/cpython/pull/152306#issue-4753237183
Please reload this pagehttps://github.com/python/cpython/pull/152306
datetime.time.strftime('%Y') raises AttributeError in the pure-Python implementation #152305https://github.com/python/cpython/issues/152305
Please reload this pagehttps://github.com/python/cpython/pull/152306
https://github.com/tonghuaroot
pythongh-152305https://github.com/python/cpython/issues/152305
: Fix pure-Python time.strftime AttributeError on %Y/%…https://github.com/python/cpython/pull/152306/commits/1c23f5ac909480ee9afd76d2dac0037935d45def
1c23f5ahttps://github.com/python/cpython/pull/152306/commits/1c23f5ac909480ee9afd76d2dac0037935d45def
https://github.com/tonghuaroot
tonghuaroothttps://github.com/tonghuaroot
StanFromIrelandhttps://github.com/StanFromIreland
pgansslehttps://github.com/pganssle
code ownershttps://github.com/python/cpython/blob/671357691f84820d4a4799012e937ab9dcbfdaca/.github/CODEOWNERS#L436
June 26, 2026 15:42https://github.com/python/cpython/pull/152306#event-27253078384
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 26, 2026 https://github.com/python/cpython/pull/152306#ref-issue-4753227438
datetime.time.strftime('%Y') raises AttributeError in the pure-Python implementation #152305 https://github.com/python/cpython/issues/152305
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jun 26, 2026https://github.com/python/cpython/pull/152306#event-27253082558
https://github.com/eendebakpt
eendebakpthttps://github.com/eendebakpt
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Jun 26, 2026https://github.com/python/cpython/pull/152306#event-27264829644
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
Jun 27, 2026https://github.com/python/cpython/pull/152306#event-27277717925
https://github.com/StanFromIreland
Use subTest, move to test_stftime_specialhttps://github.com/python/cpython/pull/152306/commits/677b8a5e3b800f852289ac0c8f139107ef109d8b
677b8a5https://github.com/python/cpython/pull/152306/commits/677b8a5e3b800f852289ac0c8f139107ef109d8b
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
Jun 27, 2026 https://github.com/python/cpython/pull/152306#pullrequestreview-4585048164
View reviewed changes https://github.com/python/cpython/pull/152306/files/677b8a5e3b800f852289ac0c8f139107ef109d8b
Lib/_pydatetime.pyhttps://github.com/python/cpython/pull/152306/files/677b8a5e3b800f852289ac0c8f139107ef109d8b#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
Please reload this pagehttps://github.com/python/cpython/pull/152306
Misc/NEWS.d/next/Library/2026-06-26-15-41-34.gh-issue-152305.WnbbBc.rsthttps://github.com/python/cpython/pull/152306/files/677b8a5e3b800f852289ac0c8f139107ef109d8b#diff-2271ec212fadda9d98c15e4031fb939bfb42a4d891041439cbd228fd216dd90a
Please reload this pagehttps://github.com/python/cpython/pull/152306
https://github.com/tonghuaroot
Address review: simplify the year-directive check and reword the NEWS…https://github.com/python/cpython/pull/152306/commits/955c6f79f826f674b263cab8fedae9aaf633b9b1
955c6f7https://github.com/python/cpython/pull/152306/commits/955c6f79f826f674b263cab8fedae9aaf633b9b1
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
Jun 27, 2026 https://github.com/python/cpython/pull/152306#pullrequestreview-4585099545
View reviewed changes https://github.com/python/cpython/pull/152306/files/955c6f79f826f674b263cab8fedae9aaf633b9b1
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jun 27, 2026https://github.com/python/cpython/pull/152306#event-27278814728
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
5733361https://github.com/python/cpython/commit/5733361fdd85519c931e67fd7cab0ff3a11b8ec0
Jun 27, 2026https://github.com/python/cpython/pull/152306#event-27282193484
Please reload this pagehttps://github.com/python/cpython/pull/152306
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jun 27, 2026https://github.com/python/cpython/pull/152306#event-27282194550
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jun 27, 2026https://github.com/python/cpython/pull/152306#issuecomment-4818615389
@tonghuaroothttps://github.com/tonghuaroot
@StanFromIrelandhttps://github.com/StanFromIreland
Please reload this pagehttps://github.com/python/cpython/pull/152306
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 27, 2026https://github.com/python/cpython/pull/152306#issuecomment-4818616944
GH-152425https://github.com/python/cpython/pull/152425
3.15 branchhttps://github.com/python/cpython/tree/3.15
Please reload this pagehttps://github.com/python/cpython/pull/152306
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Jun 27, 2026https://github.com/python/cpython/pull/152306#event-27282197856
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 27, 2026https://github.com/python/cpython/pull/152306#issuecomment-4818617468
GH-152426https://github.com/python/cpython/pull/152426
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/152306
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Jun 27, 2026https://github.com/python/cpython/pull/152306#event-27282198797
StanFromIrelandhttps://github.com/StanFromIreland
Jun 27, 2026 https://github.com/python/cpython/pull/152306#ref-commit-1a63e76
https://github.com/miss-islington
https://github.com/tonghuaroot
https://github.com/StanFromIreland
[3.14]https://github.com/python/cpython/commit/1a63e7640cd1dd1469502513ffdd72fa2157db67
gh-152305https://github.com/python/cpython/issues/152305
: Fixhttps://github.com/python/cpython/commit/1a63e7640cd1dd1469502513ffdd72fa2157db67
_pydatetime.time.strftime()https://github.com/python/cpython/commit/1a63e7640cd1dd1469502513ffdd72fa2157db67
raising on year d…https://github.com/python/cpython/commit/1a63e7640cd1dd1469502513ffdd72fa2157db67
1a63e76https://github.com/python/cpython/commit/1a63e7640cd1dd1469502513ffdd72fa2157db67
GH-152306https://github.com/python/cpython/pull/152306
#152426https://github.com/python/cpython/pull/152426
5733361https://github.com/python/cpython/commit/5733361fdd85519c931e67fd7cab0ff3a11b8ec0
StanFromIrelandhttps://github.com/StanFromIreland
Jun 27, 2026 https://github.com/python/cpython/pull/152306#ref-commit-bfb01d8
https://github.com/miss-islington
https://github.com/tonghuaroot
https://github.com/StanFromIreland
[3.15]https://github.com/python/cpython/commit/bfb01d8a0c4283553463d87da07e4ff816e69260
gh-152305https://github.com/python/cpython/issues/152305
: Fixhttps://github.com/python/cpython/commit/bfb01d8a0c4283553463d87da07e4ff816e69260
_pydatetime.time.strftime()https://github.com/python/cpython/commit/bfb01d8a0c4283553463d87da07e4ff816e69260
raising on year d…https://github.com/python/cpython/commit/bfb01d8a0c4283553463d87da07e4ff816e69260
bfb01d8https://github.com/python/cpython/commit/bfb01d8a0c4283553463d87da07e4ff816e69260
GH-152306https://github.com/python/cpython/pull/152306
#152425https://github.com/python/cpython/pull/152425
5733361https://github.com/python/cpython/commit/5733361fdd85519c931e67fd7cab0ff3a11b8ec0
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152306
https://github.com/StanFromIreland
StanFromIreland https://github.com/StanFromIreland
https://github.com/python/cpython/pull/152306/files/955c6f79f826f674b263cab8fedae9aaf633b9b1
https://github.com/pganssle
pganssle https://github.com/pganssle
Please reload this pagehttps://github.com/python/cpython/pull/152306
https://github.com/StanFromIreland
StanFromIreland https://github.com/StanFromIreland
Please reload this pagehttps://github.com/python/cpython/pull/152306
https://github.com/tonghuaroot
https://github.com/StanFromIreland
https://github.com/eendebakpt
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.