René's URL Explorer Experiment


Title: gh-139145: Fix tkinter event loop in interactive mode by serhiy-storchaka · Pull Request #152257 · python/cpython · GitHub

Open Graph Title: gh-139145: Fix tkinter event loop in interactive mode by serhiy-storchaka · Pull Request #152257 · python/cpython

X Title: gh-139145: Fix tkinter event loop in interactive mode by serhiy-storchaka · Pull Request #152257 · python/cpython

Description: This fixes two related bugs in the interactive-mode input hook (EventHook in Modules/_tkinter.c), with minimal changes and without requiring a thread-enabled Tcl, so it remains backportable. gh-139145: when a Tcl command running its own event loop (such as vwait or wait_variable) is active and input arrives on stdin, the loop kept spinning at 100% CPU. The stdin file handler is now removed as soon as input becomes available, in MyFileProc, so a nested loop no longer keeps waking on the same unread input. gh-139816: an exception raised in a callback made EventHook return to the prompt, where (on a build without readline) it blocks in fgets until the user presses Enter, starving later callbacks. The exception is now reported inline and the loop keeps pumping until stdin actually has input. The handler is deleted on every loop-exit path, and the descriptor is passed by value through clientData rather than as a pointer to a stack variable, so no stack address can outlive EventHook. This builds on @mdehoon's #139180 (gh-139145) and a suggestion there from @chrstphrchvz; both are credited as co-authors. It supersedes #139180 by also covering gh-139816 and closing the result < 0 exit path. No test is included: the spin and the without-readline hang both depend on the platform notifier and on timing/load, so a reliable, non-flaky regression test isn't practical across CI configurations. Issue: gh-139145 Also fixes gh-139816.

Open Graph Description: This fixes two related bugs in the interactive-mode input hook (EventHook in Modules/_tkinter.c), with minimal changes and without requiring a thread-enabled Tcl, so it remains backportable. gh-139...

X Description: This fixes two related bugs in the interactive-mode input hook (EventHook in Modules/_tkinter.c), with minimal changes and without requiring a thread-enabled Tcl, so it remains backportable. gh-139...

Opengraph URL: https://github.com/python/cpython/pull/152257

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8431a493-a1f8-7950-f3b0-838545e3348b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC194:F8C5C:1226C06:16CD741:6B023F4A
html-safe-nonce158d043e09ca9f64db6afed8c022886b89a77c06bbbbf43068479bd1e7414aec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTk0OkY4QzVDOjEyMjZDMDY6MTZDRDc0MTo2QjAyM0Y0QSIsInZpc2l0b3JfaWQiOiIxNTY1MTY0NDkzMzgwNjY1MTYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac58e67e89d53fc97be94dda922d88b45d6104bd8500007c8e59b1be52eaa8d97b
hovercard-subject-tagpull_request:3941254736
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/152257/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:altThis fixes two related bugs in the interactive-mode input hook (EventHook in Modules/_tkinter.c), with minimal changes and without requiring a thread-enabled Tcl, so it remains backportable. gh-139...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/152257/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152257%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152257%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/152257/files
Reloadhttps://github.com/python/cpython/pull/152257/files
Reloadhttps://github.com/python/cpython/pull/152257/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:tkinter-eventhook-minimalhttps://github.com/serhiy-storchaka/cpython/tree/tkinter-eventhook-minimal
Conversation 5 https://github.com/python/cpython/pull/152257
Commits 1 https://github.com/python/cpython/pull/152257/commits
Checks 66 https://github.com/python/cpython/pull/152257/checks
Files changed 3 https://github.com/python/cpython/pull/152257/files
gh-139145: Fix tkinter event loop in interactive mode https://github.com/python/cpython/pull/152257/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/152257/files
273b85b gh-139145: Fix tkinter event loop in interactive mode serhiy-storchaka Jun 25, 2026 https://github.com/python/cpython/pull/152257/commits/273b85bb307c86dda50728a13ecbb4a42bcae3d6
Clear filters https://github.com/python/cpython/pull/152257/files
Please reload this pagehttps://github.com/python/cpython/pull/152257/files
Please reload this pagehttps://github.com/python/cpython/pull/152257/files
2026-06-25-14-32-42.gh-issue-139145.kT9rmP.rst https://github.com/python/cpython/pull/152257/files#diff-ed50411969d51e560c0c96cf2c4ee8ac643206cb6d7115b6d11831588acc51bf
2026-06-25-14-32-43.gh-issue-139816.Lq2vXa.rst https://github.com/python/cpython/pull/152257/files#diff-8f1adf35102fa36bee9d2d52dcdec9df7b391a632d83257bea5f5aab27943ee5
_tkinter.c https://github.com/python/cpython/pull/152257/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
Misc/NEWS.d/next/Library/2026-06-25-14-32-42.gh-issue-139145.kT9rmP.rsthttps://github.com/python/cpython/pull/152257/files#diff-ed50411969d51e560c0c96cf2c4ee8ac643206cb6d7115b6d11831588acc51bf
View file https://github.com/serhiy-storchaka/cpython/blob/273b85bb307c86dda50728a13ecbb4a42bcae3d6/Misc/NEWS.d/next/Library/2026-06-25-14-32-42.gh-issue-139145.kT9rmP.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152257/{{ revealButtonHref }}
Misc/NEWS.d/next/Library/2026-06-25-14-32-43.gh-issue-139816.Lq2vXa.rsthttps://github.com/python/cpython/pull/152257/files#diff-8f1adf35102fa36bee9d2d52dcdec9df7b391a632d83257bea5f5aab27943ee5
View file https://github.com/serhiy-storchaka/cpython/blob/273b85bb307c86dda50728a13ecbb4a42bcae3d6/Misc/NEWS.d/next/Library/2026-06-25-14-32-43.gh-issue-139816.Lq2vXa.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152257/{{ revealButtonHref }}
Modules/_tkinter.chttps://github.com/python/cpython/pull/152257/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
View file https://github.com/serhiy-storchaka/cpython/blob/273b85bb307c86dda50728a13ecbb4a42bcae3d6/Modules/_tkinter.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152257/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152257/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152257/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152257/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/152257/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
Please reload this pagehttps://github.com/python/cpython/pull/152257/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.