René's URL Explorer Experiment


Title: gh-152204: Validate date and time fields in `_pydatetime.date{time}.fromisoformat` by tonghuaroot · Pull Request #152205 · python/cpython · GitHub

Open Graph Title: gh-152204: Validate date and time fields in `_pydatetime.date{time}.fromisoformat` by tonghuaroot · Pull Request #152205 · python/cpython

X Title: gh-152204: Validate date and time fields in `_pydatetime.date{time}.fromisoformat` by tonghuaroot · Pull Request #152205 · python/cpython

Description: _pydatetime._parse_isoformat_date reads each fixed-width field with int() on a slice, without checking that the slice is exactly N ASCII digits. int() accepts a leading +/-/whitespace and a short string, so several malformed ISO 8601 basic-format dates are silently parsed into a wrong-but-plausible date instead of raising ValueError: >>> import _pydatetime >>> _pydatetime.date.fromisoformat('2020+12') datetime.date(2020, 1, 2) >>> _pydatetime.date.fromisoformat('+020-06-15') datetime.date(20, 6, 15) >>> _pydatetime.date.fromisoformat('2020061') # 7 chars: day slice reads '1' datetime.date(2020, 6, 1) >>> _pydatetime.date.fromisoformat('2020-W2') # 1-digit week number datetime.date(2020, 1, 6) The C accelerator rejects all of these via parse_digits() (which requires the exact field width and digit-only content), so this is a C-vs-pure-Python divergence. The pure-Python path is used when the _datetime C extension is unavailable, and directly via _pydatetime. This validates each field slice (year / month / day / weekno / weekday) to be exactly N ASCII digits before converting, mirroring the C parse_digits(), and extends datetimetester's test_fromisoformat_fails with the affected inputs (the new cases now reject on both implementations). Fixes #152204. Prepared with AI assistance (Claude Code) and verified by hand against a debug build, against both the C and pure-Python implementations. Issue: gh-152204

Open Graph Description: _pydatetime._parse_isoformat_date reads each fixed-width field with int() on a slice, without checking that the slice is exactly N ASCII digits. int() accepts a leading +/-/whitespace and a short s...

X Description: _pydatetime._parse_isoformat_date reads each fixed-width field with int() on a slice, without checking that the slice is exactly N ASCII digits. int() accepts a leading +/-/whitespace and a short s...

Opengraph URL: https://github.com/python/cpython/pull/152205

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:09909809-f806-028b-5d21-ca217fed0ec5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCBF0:2679E9:36F12DA:494DDE4:6B02163C
html-safe-nonced7a2a46ab6720a66ca9dfee27a120e2fa941a69b3340cca37935c13fbded52f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkYwOjI2NzlFOTozNkYxMkRBOjQ5NERERTQ6NkIwMjE2M0MiLCJ2aXNpdG9yX2lkIjoiODMxMjA5MTU0MDIxNDM4ODI4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5bdab743b79ffcd2d9027d89d127cb112e6b7653e55b0c0307143c2888090b99
hovercard-subject-tagpull_request:3935801968
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/152205/files
twitter:imagehttps://avatars.githubusercontent.com/u/23011166?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/23011166?s=400&v=4
og:image:alt_pydatetime._parse_isoformat_date reads each fixed-width field with int() on a slice, without checking that the slice is exactly N ASCII digits. int() accepts a leading +/-/whitespace and a short s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/152205/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152205%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152205%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/152205/files
Reloadhttps://github.com/python/cpython/pull/152205/files
Reloadhttps://github.com/python/cpython/pull/152205/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
StanFromIrelandhttps://github.com/StanFromIreland
python:mainhttps://github.com/python/cpython/tree/main
tonghuaroot:fix-gh-152204-fromisoformat-date-fieldshttps://github.com/tonghuaroot/cpython/tree/fix-gh-152204-fromisoformat-date-fields
Conversation 41 https://github.com/python/cpython/pull/152205
Commits 8 https://github.com/python/cpython/pull/152205/commits
Checks 61 https://github.com/python/cpython/pull/152205/checks
Files changed https://github.com/python/cpython/pull/152205/files
Please reload this pagehttps://github.com/python/cpython/pull/152205/files
gh-152204: Validate date and time fields in _pydatetime.date{time}.fromisoformat https://github.com/python/cpython/pull/152205/files#top
Show all changes 8 commits https://github.com/python/cpython/pull/152205/files
87bb302 gh-152204: Validate date fields in pure-Python date.fromisoformat tonghuaroot Jun 25, 2026 https://github.com/python/cpython/pull/152205/commits/87bb302fd2cf8a520e2e720a37a7d9658f49e0e6
e780e2c Tighten the _read() comment tonghuaroot Jun 25, 2026 https://github.com/python/cpython/pull/152205/commits/e780e2c573704c77dcb88cc939636404465db233
46f6881 Validate with isascii() + isdigit() instead of a per-character check tonghuaroot Aug 19, 2026 https://github.com/python/cpython/pull/152205/commits/46f6881177841c54f46871fa573393093a6c2643
a025467 Validate the time fields too; move the digit reader to module level tonghuaroot Aug 19, 2026 https://github.com/python/cpython/pull/152205/commits/a025467d91eaa6f53d8aff70dacb0f44397b5b02
aed8e2d Merge branch 'main' and remove duplicate test cases tonghuaroot Aug 20, 2026 https://github.com/python/cpython/pull/152205/commits/aed8e2d60d4c37c6e66d602885e58d0c4e3b832f
9476ebc Restore the NEWS entry (dropped by the merge) and cover the time fields tonghuaroot Aug 20, 2026 https://github.com/python/cpython/pull/152205/commits/9476ebce8c26341ae225e27bc3ded15731cb845c
154340c Merge main; restore dropped tests, use isdigit() for the fraction, dr… tonghuaroot Aug 20, 2026 https://github.com/python/cpython/pull/152205/commits/154340c1008e359a3f63abd4cf633c09a59e6242
4fdec27 Fix test comment StanFromIreland Aug 23, 2026 https://github.com/python/cpython/pull/152205/commits/4fdec2716b3ca0d9e7b6e135cbe30afbdd59181e
Clear filters https://github.com/python/cpython/pull/152205/files
Please reload this pagehttps://github.com/python/cpython/pull/152205/files
Please reload this pagehttps://github.com/python/cpython/pull/152205/files
_pydatetime.py https://github.com/python/cpython/pull/152205/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
datetimetester.py https://github.com/python/cpython/pull/152205/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
2026-06-25-14-05-00.gh-issue-152204.k9Qm3v.rst https://github.com/python/cpython/pull/152205/files#diff-050297c27782d81e84a014515b8ff8c15feb1b92a630ce529d067bb186b6c636
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L433
Lib/_pydatetime.pyhttps://github.com/python/cpython/pull/152205/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
View file https://github.com/tonghuaroot/cpython/blob/4fdec2716b3ca0d9e7b6e135cbe30afbdd59181e/Lib/_pydatetime.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152205/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152205/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
https://github.com/python/cpython/pull/152205/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
https://github.com/python/cpython/pull/152205/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
https://github.com/python/cpython/pull/152205/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
https://github.com/python/cpython/pull/152205/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
https://github.com/python/cpython/pull/152205/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L434
Lib/test/datetimetester.pyhttps://github.com/python/cpython/pull/152205/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
View file https://github.com/tonghuaroot/cpython/blob/4fdec2716b3ca0d9e7b6e135cbe30afbdd59181e/Lib/test/datetimetester.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152205/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152205/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/152205/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/152205/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/152205/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
Misc/NEWS.d/next/Library/2026-06-25-14-05-00.gh-issue-152204.k9Qm3v.rsthttps://github.com/python/cpython/pull/152205/files#diff-050297c27782d81e84a014515b8ff8c15feb1b92a630ce529d067bb186b6c636
View file https://github.com/tonghuaroot/cpython/blob/4fdec2716b3ca0d9e7b6e135cbe30afbdd59181e/Misc/NEWS.d/next/Library/2026-06-25-14-05-00.gh-issue-152204.k9Qm3v.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152205/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/152205/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.