René's URL Explorer Experiment


Title: gh-151593: Fix dead lock in PyDict insert_split_key() by vstinner · Pull Request #152200 · python/cpython · GitHub

Open Graph Title: gh-151593: Fix dead lock in PyDict insert_split_key() by vstinner · Pull Request #152200 · python/cpython

X Title: gh-151593: Fix dead lock in PyDict insert_split_key() by vstinner · Pull Request #152200 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Do not hold LOCK_KEYS() lock when calling PyType_Modified() to avoid a deadlock. Issue: test_abc hangs on TSan Parallel Test on Free Threading #151593

X Description: Do not hold LOCK_KEYS() lock when calling PyType_Modified() to avoid a deadlock. Issue: test_abc hangs on TSan Parallel Test on Free Threading #151593

Opengraph URL: https://github.com/python/cpython/pull/152200

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:07429a10-e1d8-205d-e0f4-a06a8b5a6c8c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC084:12643E:596239:7862D3:6A504A18
html-safe-nonce27c5cb1c6d5cc47e705d58cbcd615ae873d75784ee59ad7a779bf40bf3e57e8a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDg0OjEyNjQzRTo1OTYyMzk6Nzg2MkQzOjZBNTA0QTE4IiwidmlzaXRvcl9pZCI6IjU3NjIyNzIyOTk1NTk0Mzg4NzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac83d4c0f612db7684c2c7bf3120b9746a4b02691783cbd2e031e03e8fb29eeccb
hovercard-subject-tagpull_request:3935572115
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/152200/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8475b0386ada2a9287a5c4cc1e34934bc07f31d6391b1907af8b7d24a1a04294/python/cpython/pull/152200
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8475b0386ada2a9287a5c4cc1e34934bc07f31d6391b1907af8b7d24a1a04294/python/cpython/pull/152200
og:image:altDo not hold LOCK_KEYS() lock when calling PyType_Modified() to avoid a deadlock. Issue: test_abc hangs on TSan Parallel Test on Free Threading #151593
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5741a45fe07e5f377d0d4c524a92e3056acc51bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/152200#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152200
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152200
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/152200
Reloadhttps://github.com/python/cpython/pull/152200
Reloadhttps://github.com/python/cpython/pull/152200
Please reload this pagehttps://github.com/python/cpython/pull/152200
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/152200
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:dict_deadlockhttps://github.com/vstinner/cpython/tree/dict_deadlock
Conversationhttps://github.com/python/cpython/pull/152200
Commits2 (2)https://github.com/python/cpython/pull/152200/commits
Checkshttps://github.com/python/cpython/pull/152200/checks
Files changedhttps://github.com/python/cpython/pull/152200/files
gh-151593: Fix dead lock in PyDict insert_split_key()https://github.com/python/cpython/pull/152200#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:dict_deadlockhttps://github.com/vstinner/cpython/tree/dict_deadlock
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 25, 2026https://github.com/python/cpython/pull/152200#issue-4744252701
Please reload this pagehttps://github.com/python/cpython/pull/152200
test_abc hangs on TSan Parallel Test on Free Threading #151593https://github.com/python/cpython/issues/151593
Please reload this pagehttps://github.com/python/cpython/pull/152200
https://github.com/vstinner
https://github.com/nascheme
pythongh-151593https://github.com/python/cpython/issues/151593
: Fix dead lock in PyDict insert_split_key()https://github.com/python/cpython/pull/152200/commits/bbc03598f7f43e1cca8b4c68e7e2f861e93bbeb8
bbc0359https://github.com/python/cpython/pull/152200/commits/bbc03598f7f43e1cca8b4c68e7e2f861e93bbeb8
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
markshannonhttps://github.com/markshannon
methanehttps://github.com/methane
code ownershttps://github.com/python/cpython/blob/6a82832a0bd12ff6154fcfcccc3b7b5644eab0e8/.github/CODEOWNERS#L215
June 25, 2026 13:31https://github.com/python/cpython/pull/152200#event-27201590957
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jun 25, 2026https://github.com/python/cpython/pull/152200#event-27201591135
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 25, 2026 https://github.com/python/cpython/pull/152200#ref-issue-4681988148
test_abc hangs on TSan Parallel Test on Free Threading #151593 https://github.com/python/cpython/issues/151593
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 25, 2026https://github.com/python/cpython/pull/152200#event-27201616698
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 25, 2026https://github.com/python/cpython/pull/152200#issuecomment-4799870716
Please reload this pagehttps://github.com/python/cpython/pull/152200
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 25, 2026 https://github.com/python/cpython/pull/152200#ref-pullrequest-4742390380
Temporarily allow the TSan (free-threading) job to fail #152173 https://github.com/python/cpython/pull/152173
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 25, 2026https://github.com/python/cpython/pull/152200#issuecomment-4799915665
@dpdanihttps://github.com/dpdani
@colesburyhttps://github.com/colesbury
@naschemehttps://github.com/nascheme
@naschemehttps://github.com/nascheme
commenthttps://github.com/python/cpython/issues/151593#issuecomment-4732702741
Please reload this pagehttps://github.com/python/cpython/pull/152200
https://github.com/dpdani
dpdanihttps://github.com/dpdani
Jun 25, 2026 https://github.com/python/cpython/pull/152200#pullrequestreview-4571523797
View reviewed changes https://github.com/python/cpython/pull/152200/files/bbc03598f7f43e1cca8b4c68e7e2f861e93bbeb8
dpdanihttps://github.com/dpdani
https://github.com/python/cpython/pull/152200#pullrequestreview-4571523797
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/152200
Objects/dictobject.chttps://github.com/python/cpython/pull/152200/files/bbc03598f7f43e1cca8b4c68e7e2f861e93bbeb8#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Please reload this pagehttps://github.com/python/cpython/pull/152200
https://github.com/vstinner
Add a comment on LOCK_KEYS() explaining _Py_LOCK_DONT_DETACHhttps://github.com/python/cpython/pull/152200/commits/d1a244142a10eb6233d93b07c6e1c9cc6ac4278b
d1a2441https://github.com/python/cpython/pull/152200/commits/d1a244142a10eb6233d93b07c6e1c9cc6ac4278b
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 25, 2026https://github.com/python/cpython/pull/152200#issuecomment-4800450860
@dpdanihttps://github.com/dpdani
Please reload this pagehttps://github.com/python/cpython/pull/152200
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Jun 25, 2026 https://github.com/python/cpython/pull/152200#pullrequestreview-4572562838
View reviewed changes https://github.com/python/cpython/pull/152200/files/d1a244142a10eb6233d93b07c6e1c9cc6ac4278b
colesburyhttps://github.com/colesbury
https://github.com/python/cpython/pull/152200#pullrequestreview-4572562838
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/152200
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 25, 2026https://github.com/python/cpython/pull/152200#event-27208445410
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
bef5706https://github.com/python/cpython/commit/bef570622263ecd58563f0474693c19c8545de73
Jun 25, 2026https://github.com/python/cpython/pull/152200#event-27213687028
Please reload this pagehttps://github.com/python/cpython/pull/152200
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
June 25, 2026 17:58https://github.com/python/cpython/pull/152200#event-27213688126
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jun 25, 2026https://github.com/python/cpython/pull/152200#event-27213689144
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 25, 2026https://github.com/python/cpython/pull/152200#issuecomment-4802659561
Please reload this pagehttps://github.com/python/cpython/pull/152200
gh-152238: Revert gh-150490 and gh-152200. #152232 https://github.com/python/cpython/pull/152232
dict insert_split_key() change introduces data-race #152238 https://github.com/python/cpython/issues/152238
naschemehttps://github.com/nascheme
Jun 26, 2026 https://github.com/python/cpython/pull/152200#ref-commit-9626ef8
https://github.com/nascheme
gh-152238https://github.com/python/cpython/issues/152238
: Reverthttps://github.com/python/cpython/commit/9626ef87f42fca564c3a74109b370d38076a79da
gh-150490https://github.com/python/cpython/issues/150490
andhttps://github.com/python/cpython/commit/9626ef87f42fca564c3a74109b370d38076a79da
gh-152200https://github.com/python/cpython/pull/152200
. (https://github.com/python/cpython/commit/9626ef87f42fca564c3a74109b370d38076a79da
gh-152232https://github.com/python/cpython/pull/152232
)https://github.com/python/cpython/commit/9626ef87f42fca564c3a74109b370d38076a79da
9626ef8https://github.com/python/cpython/commit/9626ef87f42fca564c3a74109b370d38076a79da
gh-151593https://github.com/python/cpython/issues/151593
#152200https://github.com/python/cpython/pull/152200
gh-150490https://github.com/python/cpython/issues/150490
#150489https://github.com/python/cpython/pull/150489
gh-150489https://github.com/python/cpython/pull/150489
gh-151593https://github.com/python/cpython/issues/151593
gh-152200https://github.com/python/cpython/pull/152200
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152200
https://github.com/colesbury
colesbury https://github.com/colesbury
https://github.com/python/cpython/pull/152200/files/d1a244142a10eb6233d93b07c6e1c9cc6ac4278b
https://github.com/methane
methane https://github.com/methane
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/dpdani
dpdani https://github.com/dpdani
https://github.com/python/cpython/pull/152200/files/bbc03598f7f43e1cca8b4c68e7e2f861e93bbeb8
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/152200
https://github.com/vstinner
https://github.com/colesbury
https://github.com/dpdani
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.