René's URL Explorer Experiment


Title: gh-152060: Fix datetime.fromisoformat() raising AssertionError in pure Python by tonghuaroot · Pull Request #152061 · python/cpython · GitHub

Open Graph Title: gh-152060: Fix datetime.fromisoformat() raising AssertionError in pure Python by tonghuaroot · Pull Request #152061 · python/cpython

X Title: gh-152060: Fix datetime.fromisoformat() raising AssertionError in pure Python by tonghuaroot · Pull Request #152061 · python/cpython

Description: Fixes #152060. _pydatetime._parse_isoformat_date() asserted that the date portion has length 7, 8 or 10. For some malformed inputs (e.g. '2020-2020', '2020-1234') the separator finder yields a 9-character date portion, so the assert fires and a bare AssertionError escapes datetime.fromisoformat(), which is documented to raise only ValueError. The C accelerator already raises ValueError. Because the check is an assert, the input also raises ValueError instead under python -O, so the behaviour differed by build flag. This replaces the assert with an explicit ValueError whose message matches the C implementation, so both implementations agree on every build. This is the sibling assert site to the one fixed in #151771 (gh-151770). date.fromisoformat() already validates the length before calling _parse_isoformat_date(), so it is unaffected. A regression test is added to test_fromisoformat_fails_datetime, which runs under both the C (_Fast) and pure-Python (_Pure) test classes. Issue: gh-152060

Open Graph Description: Fixes #152060. _pydatetime._parse_isoformat_date() asserted that the date portion has length 7, 8 or 10. For some malformed inputs (e.g. '2020-2020', '2020-1234') the separator find...

X Description: Fixes #152060. _pydatetime._parse_isoformat_date() asserted that the date portion has length 7, 8 or 10. For some malformed inputs (e.g. '2020-2020', '2020-1234') th...

Opengraph URL: https://github.com/python/cpython/pull/152061

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8cc18da8-a9e7-b76a-e856-8c605cb86a4e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC77A:28A483:1960EA0:2188BDA:6B0213DC
html-safe-nonce9b9adfd21b1b1d135700db03ce059cc8cc4fdaf2f7d0b26a6c8ad7918b83e844
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzdBOjI4QTQ4MzoxOTYwRUEwOjIxODhCREE6NkIwMjEzREMiLCJ2aXNpdG9yX2lkIjoiODQwOTkzOTQwMzU0NzQ4MTA1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac954cbe80ac3cfc9c0c54f80463a1e9fe75a7db684a5d5f4f311b031d42558900
hovercard-subject-tagpull_request:3926975143
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/152061/files
twitter:imagehttps://avatars.githubusercontent.com/u/23011166?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/23011166?s=400&v=4
og:image:altFixes #152060. _pydatetime._parse_isoformat_date() asserted that the date portion has length 7, 8 or 10. For some malformed inputs (e.g. '2020-2020', '2020-1234') the separator find...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/152061/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152061%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152061%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/152061/files
Reloadhttps://github.com/python/cpython/pull/152061/files
Reloadhttps://github.com/python/cpython/pull/152061/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
StanFromIrelandhttps://github.com/StanFromIreland
python:mainhttps://github.com/python/cpython/tree/main
tonghuaroot:fix-pydatetime-fromisoformat-assertionerrorhttps://github.com/tonghuaroot/cpython/tree/fix-pydatetime-fromisoformat-assertionerror
Conversation 13 https://github.com/python/cpython/pull/152061
Commits 2 https://github.com/python/cpython/pull/152061/commits
Checks 65 https://github.com/python/cpython/pull/152061/checks
Files changed https://github.com/python/cpython/pull/152061/files
Please reload this pagehttps://github.com/python/cpython/pull/152061/files
gh-152060: Fix datetime.fromisoformat() raising AssertionError in pure Python https://github.com/python/cpython/pull/152061/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/152061/files
d2b66b9 gh-152060: Fix datetime.fromisoformat() raising AssertionError in pur… tonghuaroot Jun 24, 2026 https://github.com/python/cpython/pull/152061/commits/d2b66b9c04403937f6362dde3ddca974c2755d88
e203639 gh-152060: Address review — simplify error message, drop duplicate te… tonghuaroot Jun 24, 2026 https://github.com/python/cpython/pull/152061/commits/e203639e9045b1d7ff2e58e3744995e3a5372675
Clear filters https://github.com/python/cpython/pull/152061/files
Please reload this pagehttps://github.com/python/cpython/pull/152061/files
Please reload this pagehttps://github.com/python/cpython/pull/152061/files
_pydatetime.py https://github.com/python/cpython/pull/152061/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
datetimetester.py https://github.com/python/cpython/pull/152061/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
2026-06-24-10-46-35.gh-issue-152060.f2asrt.rst https://github.com/python/cpython/pull/152061/files#diff-913ec0e67a50ff830fee3b6df7b54fe831e026b822c83a69e69a4c86ef33d14e
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L433
Lib/_pydatetime.pyhttps://github.com/python/cpython/pull/152061/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
View file https://github.com/tonghuaroot/cpython/blob/e203639e9045b1d7ff2e58e3744995e3a5372675/Lib/_pydatetime.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152061/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152061/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
https://github.com/python/cpython/pull/152061/files#diff-5dc97b7989952636b0cd6224bc01469715753358d6e2a9059707f0d06f83b141
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L434
Lib/test/datetimetester.pyhttps://github.com/python/cpython/pull/152061/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
View file https://github.com/tonghuaroot/cpython/blob/e203639e9045b1d7ff2e58e3744995e3a5372675/Lib/test/datetimetester.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152061/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152061/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/152061/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
Misc/NEWS.d/next/Library/2026-06-24-10-46-35.gh-issue-152060.f2asrt.rsthttps://github.com/python/cpython/pull/152061/files#diff-913ec0e67a50ff830fee3b6df7b54fe831e026b822c83a69e69a4c86ef33d14e
View file https://github.com/tonghuaroot/cpython/blob/e203639e9045b1d7ff2e58e3744995e3a5372675/Misc/NEWS.d/next/Library/2026-06-24-10-46-35.gh-issue-152060.f2asrt.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152061/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/152061/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.