René's URL Explorer Experiment


Title: gh-152052: Fix misleading json error for \uXXXX escape at end of input by tonghuaroot · Pull Request #152053 · python/cpython · GitHub

Open Graph Title: gh-152052: Fix misleading json error for \uXXXX escape at end of input by tonghuaroot · Pull Request #152053 · python/cpython

X Title: gh-152052: Fix misleading json error for \uXXXX escape at end of input by tonghuaroot · Pull Request #152053 · python/cpython

Description: The C accelerator of json reported Invalid \uXXXX escape where the pure-Python decoder reported Unterminated string starting at, for a \uXXXX escape whose final hex digit is the last character of the input. The two decoders disagreed on the error class, and the C one pointed the user at a non-existent invalid escape rather than the missing closing quote. Root cause in Modules/_json.c scanstring_unicode(): the bounds check used >= where > is correct. The four hex digits are read at indices end-4 .. end-1; when end == len those are all in bounds, so the escape is complete and valid and the string is merely unterminated. Changing >= to > lets control fall through to the existing Unterminated string starting at path, matching the pure-Python decoder (the two json error messages were synchronized in bpo-5067). Tests cover both decoders: test_fail.py::test_truncated_input asserts the exact message/position under TestCFail and TestPyFail (including a high surrogate and a surrogate pair at EOF, and a nested non-zero offset), and test_scanstring.py::test_bad_escapes gains two no-regression cases (a genuinely truncated escape and four non-hex chars at EOF) confirming the change does not weaken rejection of real invalid escapes. Fixes #152052 Issue: gh-152052

Open Graph Description: The C accelerator of json reported Invalid \uXXXX escape where the pure-Python decoder reported Unterminated string starting at, for a \uXXXX escape whose final hex digit is the last character of t...

X Description: The C accelerator of json reported Invalid \uXXXX escape where the pure-Python decoder reported Unterminated string starting at, for a \uXXXX escape whose final hex digit is the last character of t...

Opengraph URL: https://github.com/python/cpython/pull/152053

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:493bf951-a469-6af7-38f0-776c6ea49b40
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6FE:23DB5F:1062EE3:14902FB:6B023F6E
html-safe-noncecc69ab1cd8352c608366a389448dae5fde6cd802f745d5dba112b3763755f330
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkZFOjIzREI1RjoxMDYyRUUzOjE0OTAyRkI6NkIwMjNGNkUiLCJ2aXNpdG9yX2lkIjoiNDU5MTMyMjI0MDI0MjU2NDk3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac740e31b7dac0e9be2e3b79069cd3bc133961523f792570532d0fe46245d00b64
hovercard-subject-tagpull_request:3925740319
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/152053/files
twitter:imagehttps://avatars.githubusercontent.com/u/23011166?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/23011166?s=400&v=4
og:image:altThe C accelerator of json reported Invalid \uXXXX escape where the pure-Python decoder reported Unterminated string starting at, for a \uXXXX escape whose final hex digit is the last character of t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/152053/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152053%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F152053%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/152053/files
Reloadhttps://github.com/python/cpython/pull/152053/files
Reloadhttps://github.com/python/cpython/pull/152053/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
StanFromIrelandhttps://github.com/StanFromIreland
python:mainhttps://github.com/python/cpython/tree/main
tonghuaroot:fix-json-uXXXX-eof-unterminatedhttps://github.com/tonghuaroot/cpython/tree/fix-json-uXXXX-eof-unterminated
Conversation 6 https://github.com/python/cpython/pull/152053
Commits 3 https://github.com/python/cpython/pull/152053/commits
Checks 69 https://github.com/python/cpython/pull/152053/checks
Files changed https://github.com/python/cpython/pull/152053/files
Please reload this pagehttps://github.com/python/cpython/pull/152053/files
gh-152052: Fix misleading json error for \uXXXX escape at end of input https://github.com/python/cpython/pull/152053/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/152053/files
deb73e2 gh-152052: Fix misleading json error for \uXXXX escape at end of input tonghuaroot Jun 24, 2026 https://github.com/python/cpython/pull/152053/commits/deb73e2bf2c10494b74738bfe63a495429253f34
8573a97 gh-152052: trim test comments tonghuaroot Jun 24, 2026 https://github.com/python/cpython/pull/152053/commits/8573a979225c25b8788584b0bf4d93875daa6fe4
288b1b5 Shorten blurb StanFromIreland Jun 26, 2026 https://github.com/python/cpython/pull/152053/commits/288b1b5a22ebdba8f4a9a2c4c599c41601892fbd
Clear filters https://github.com/python/cpython/pull/152053/files
Please reload this pagehttps://github.com/python/cpython/pull/152053/files
Please reload this pagehttps://github.com/python/cpython/pull/152053/files
test_fail.py https://github.com/python/cpython/pull/152053/files#diff-93f1f1ed196df225271a2a3656a280ecae8caf6461c62f133cdf226123b1976c
test_scanstring.py https://github.com/python/cpython/pull/152053/files#diff-373fe1d432ceee6a9b96de65c73fd1f9cd5942da77ced897f98a86c4980dc5d3
2026-06-24-12-00-00.gh-issue-152052.yBssDE.rst https://github.com/python/cpython/pull/152053/files#diff-5d6a73ee287c59a579105d755182cd4ca6f231a504c3b8cc261ff5cea5a35fa0
_json.c https://github.com/python/cpython/pull/152053/files#diff-efe183ae0b85e5b8d9bbbc588452dd4de80b39fd5c5174ee499ba554217a39ed
Lib/test/test_json/test_fail.pyhttps://github.com/python/cpython/pull/152053/files#diff-93f1f1ed196df225271a2a3656a280ecae8caf6461c62f133cdf226123b1976c
View file https://github.com/tonghuaroot/cpython/blob/288b1b5a22ebdba8f4a9a2c4c599c41601892fbd/Lib/test/test_json/test_fail.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152053/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152053/files#diff-93f1f1ed196df225271a2a3656a280ecae8caf6461c62f133cdf226123b1976c
https://github.com/python/cpython/pull/152053/files#diff-93f1f1ed196df225271a2a3656a280ecae8caf6461c62f133cdf226123b1976c
Lib/test/test_json/test_scanstring.pyhttps://github.com/python/cpython/pull/152053/files#diff-373fe1d432ceee6a9b96de65c73fd1f9cd5942da77ced897f98a86c4980dc5d3
View file https://github.com/tonghuaroot/cpython/blob/288b1b5a22ebdba8f4a9a2c4c599c41601892fbd/Lib/test/test_json/test_scanstring.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152053/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152053/files#diff-373fe1d432ceee6a9b96de65c73fd1f9cd5942da77ced897f98a86c4980dc5d3
https://github.com/python/cpython/pull/152053/files#diff-373fe1d432ceee6a9b96de65c73fd1f9cd5942da77ced897f98a86c4980dc5d3
Misc/NEWS.d/next/Library/2026-06-24-12-00-00.gh-issue-152052.yBssDE.rsthttps://github.com/python/cpython/pull/152053/files#diff-5d6a73ee287c59a579105d755182cd4ca6f231a504c3b8cc261ff5cea5a35fa0
View file https://github.com/tonghuaroot/cpython/blob/288b1b5a22ebdba8f4a9a2c4c599c41601892fbd/Misc/NEWS.d/next/Library/2026-06-24-12-00-00.gh-issue-152052.yBssDE.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152053/{{ revealButtonHref }}
Modules/_json.chttps://github.com/python/cpython/pull/152053/files#diff-efe183ae0b85e5b8d9bbbc588452dd4de80b39fd5c5174ee499ba554217a39ed
View file https://github.com/tonghuaroot/cpython/blob/288b1b5a22ebdba8f4a9a2c4c599c41601892fbd/Modules/_json.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/152053/{{ revealButtonHref }}
https://github.com/python/cpython/pull/152053/files#diff-efe183ae0b85e5b8d9bbbc588452dd4de80b39fd5c5174ee499ba554217a39ed
https://github.com/python/cpython/pull/152053/files#diff-efe183ae0b85e5b8d9bbbc588452dd4de80b39fd5c5174ee499ba554217a39ed
Please reload this pagehttps://github.com/python/cpython/pull/152053/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.