René's URL Explorer Experiment


Title: gh-59396: Modernize tkinter.simpledialog by serhiy-storchaka · Pull Request #151848 · python/cpython · GitHub

Open Graph Title: gh-59396: Modernize tkinter.simpledialog by serhiy-storchaka · Pull Request #151848 · python/cpython

X Title: gh-59396: Modernize tkinter.simpledialog by serhiy-storchaka · Pull Request #151848 · python/cpython

Description: This reworks tkinter.simpledialog to match the look and feel of the native Tk dialogs: SimpleDialog is a port of ::tk_dialog, and Dialog is a base class whose button box is modelled on ::tk::MessageBox. SimpleDialog, askinteger, askfloat and askstring now use the themed tkinter.ttk widgets by default; the Dialog base class still defaults to the classic widgets for compatibility. Both classes gained a keyword-only use_ttk parameter to select the widget set. Both dialogs follow the message-box keyboard conventions: button accelerators (Alt + the underlined letter), a default ring that follows the keyboard focus, and that invokes the focused button. SimpleDialog gained bitmap and detail parameters, draws the standard icons with themed images in the ttk version, and accepts mappings of button options as buttons entries. The message and detail font and wrap length are taken from the Tk option database and can be overridden by the application. The new helpers _temp_grab_focus, _underline_ampersand and _find_alt_key_target can be reused by other tkinter dialogs, as _setup_dialog already is. Several bugs found by comparison with the Tcl sources were fixed. Issue: gh-59396

Open Graph Description: This reworks tkinter.simpledialog to match the look and feel of the native Tk dialogs: SimpleDialog is a port of ::tk_dialog, and Dialog is a base class whose button box is modelled on ::tk::Messag...

X Description: This reworks tkinter.simpledialog to match the look and feel of the native Tk dialogs: SimpleDialog is a port of ::tk_dialog, and Dialog is a base class whose button box is modelled on ::tk::Messag...

Opengraph URL: https://github.com/python/cpython/pull/151848

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:04df4325-cc12-7872-f322-a00c2aee088b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE794:1B675D:3215FDD:442DD10:6A53EF6F
html-safe-noncecf7163eda083706ec571e9c5d699d046c5152a1f4007462c135d5b8d9f5792b1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzk0OjFCNjc1RDozMjE1RkREOjQ0MkREMTA6NkE1M0VGNkYiLCJ2aXNpdG9yX2lkIjoiNzExNzgxNTE0NDEyMjY3NTA1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac297467fdfba59a0e9b5a42a8faf878d28d77be1cd081077e7133aacef450aca0
hovercard-subject-tagpull_request:3906962296
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/151848/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:altThis reworks tkinter.simpledialog to match the look and feel of the native Tk dialogs: SimpleDialog is a port of ::tk_dialog, and Dialog is a base class whose button box is modelled on ::tk::Messag...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/151848/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151848%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151848%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/151848/files
Reloadhttps://github.com/python/cpython/pull/151848/files
Reloadhttps://github.com/python/cpython/pull/151848/files
Please reload this pagehttps://github.com/python/cpython/pull/151848/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/151848/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:tkinter-simpledialoghttps://github.com/serhiy-storchaka/cpython/tree/tkinter-simpledialog
Conversation 2 https://github.com/python/cpython/pull/151848
Commits 6 https://github.com/python/cpython/pull/151848/commits
Checks 49 https://github.com/python/cpython/pull/151848/checks
Files changed https://github.com/python/cpython/pull/151848/files
Please reload this pagehttps://github.com/python/cpython/pull/151848/files
gh-59396: Modernize tkinter.simpledialog https://github.com/python/cpython/pull/151848/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/151848/files
758cdca gh-59396: Modernize tkinter.simpledialog serhiy-storchaka Jun 20, 2026 https://github.com/python/cpython/pull/151848/commits/758cdcaccab03c874997424ce6108a8de2a35c47
3a8c808 Reorder tests. serhiy-storchaka Jun 21, 2026 https://github.com/python/cpython/pull/151848/commits/3a8c80804461cd6a1dd1cb195c57a5a9465ace08
530eec3 Strengthen the test_background test. serhiy-storchaka Jun 21, 2026 https://github.com/python/cpython/pull/151848/commits/530eec39eb90258bcefe5937fedd1e8445a29d2e
14dbb05 Merge remote-tracking branch 'upstream/main' into tkinter-simpledialog serhiy-storchaka Jun 21, 2026 https://github.com/python/cpython/pull/151848/commits/14dbb055327beeb63eb68eb9cf916c3ae81b1293
2a0ad97 Improve the simpledialog demo. serhiy-storchaka Jun 21, 2026 https://github.com/python/cpython/pull/151848/commits/2a0ad97fc39d10157ba1cf0ab466fda7e3d94881
ec079f6 Merge remote-tracking branch 'upstream/main' into tkinter-simpledialog serhiy-storchaka Jun 23, 2026 https://github.com/python/cpython/pull/151848/commits/ec079f66211d576708478da96c02a432bd0ea3d8
Clear filters https://github.com/python/cpython/pull/151848/files
Please reload this pagehttps://github.com/python/cpython/pull/151848/files
Please reload this pagehttps://github.com/python/cpython/pull/151848/files
dialog.rst https://github.com/python/cpython/pull/151848/files#diff-35d7c69cbafb62edc14eb176f719235e3ad8d43330f189e4462126ad479b1e97
3.16.rst https://github.com/python/cpython/pull/151848/files#diff-e69e0be717f3409832d520e20348f62af39c9436ba1a9d82e842bc10e5eb51d7
test_simpledialog.py https://github.com/python/cpython/pull/151848/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651
simpledialog.py https://github.com/python/cpython/pull/151848/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
2026-06-20-22-55-22.gh-issue-59396.kT9wPq.rst https://github.com/python/cpython/pull/151848/files#diff-66d2ce11966d027c33db2ab6034010d8b9494eee550d127aa5ea17c73a7a37ae
Doc/library/dialog.rsthttps://github.com/python/cpython/pull/151848/files#diff-35d7c69cbafb62edc14eb176f719235e3ad8d43330f189e4462126ad479b1e97
View file https://github.com/serhiy-storchaka/cpython/blob/ec079f66211d576708478da96c02a432bd0ea3d8/Doc/library/dialog.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/151848/{{ revealButtonHref }}
https://github.com/python/cpython/pull/151848/files#diff-35d7c69cbafb62edc14eb176f719235e3ad8d43330f189e4462126ad479b1e97
https://github.com/python/cpython/pull/151848/files#diff-35d7c69cbafb62edc14eb176f719235e3ad8d43330f189e4462126ad479b1e97
https://github.com/python/cpython/pull/151848/files#diff-35d7c69cbafb62edc14eb176f719235e3ad8d43330f189e4462126ad479b1e97
https://github.com/python/cpython/pull/151848/files#diff-35d7c69cbafb62edc14eb176f719235e3ad8d43330f189e4462126ad479b1e97
https://github.com/python/cpython/pull/151848/files#diff-35d7c69cbafb62edc14eb176f719235e3ad8d43330f189e4462126ad479b1e97
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L116
Doc/whatsnew/3.16.rsthttps://github.com/python/cpython/pull/151848/files#diff-e69e0be717f3409832d520e20348f62af39c9436ba1a9d82e842bc10e5eb51d7
View file https://github.com/serhiy-storchaka/cpython/blob/ec079f66211d576708478da96c02a432bd0ea3d8/Doc/whatsnew/3.16.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/151848/{{ revealButtonHref }}
https://github.com/python/cpython/pull/151848/files#diff-e69e0be717f3409832d520e20348f62af39c9436ba1a9d82e842bc10e5eb51d7
https://github.com/python/cpython/pull/151848/files#diff-e69e0be717f3409832d520e20348f62af39c9436ba1a9d82e842bc10e5eb51d7
Please reload this pagehttps://github.com/python/cpython/pull/151848/files
Please reload this pagehttps://github.com/python/cpython/pull/151848/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.