René's URL Explorer Experiment


Title: gh-151815: Fix segfault in template_iter on allocation failure by timurmamedov1 · Pull Request #151821 · python/cpython · GitHub

Open Graph Title: gh-151815: Fix segfault in template_iter on allocation failure by timurmamedov1 · Pull Request #151821 · python/cpython

X Title: gh-151815: Fix segfault in template_iter on allocation failure by timurmamedov1 · Pull Request #151821 · python/cpython

Description: template_iter() allocates a templateiterobject with PyObject_GC_New (which does not zero memory), but only assigns stringsiter and interpolationsiter after both PyObject_GetIter calls succeed. If either call fails, Py_DECREF(iter) runs templateiter_clear, which calls Py_CLEAR on uninitialized pointers, causing a segfault. Fix: initialize both fields to NULL immediately after allocation so Py_CLEAR is safe on the error paths. Issue: gh-151815

Open Graph Description: template_iter() allocates a templateiterobject with PyObject_GC_New (which does not zero memory), but only assigns stringsiter and interpolationsiter after both PyObject_GetIter calls succeed. If e...

X Description: template_iter() allocates a templateiterobject with PyObject_GC_New (which does not zero memory), but only assigns stringsiter and interpolationsiter after both PyObject_GetIter calls succeed. If e...

Opengraph URL: https://github.com/python/cpython/pull/151821

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:11f60f71-db1c-5cbd-e767-9fc26ccaff98
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1DC:2FB335:1A6F478:2349F9D:6A52CE83
html-safe-nonce2e178dc39c96a93c4ecf9675cc624010fc9ab1a3a91cd14aa6db1ef103571e36
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMURDOjJGQjMzNToxQTZGNDc4OjIzNDlGOUQ6NkE1MkNFODMiLCJ2aXNpdG9yX2lkIjoiMTM4ODU2ODc0ODI2MTI5Nzc5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfa9b5c5e930e124fa8f8d8c55d96ff6fa39779846e275711ef78c235d030d229
hovercard-subject-tagpull_request:3905318692
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/151821/files
twitter:imagehttps://avatars.githubusercontent.com/u/259959684?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/259959684?s=400&v=4
og:image:alttemplate_iter() allocates a templateiterobject with PyObject_GC_New (which does not zero memory), but only assigns stringsiter and interpolationsiter after both PyObject_GetIter calls succeed. If e...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/151821/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151821%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151821%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/151821/files
Reloadhttps://github.com/python/cpython/pull/151821/files
Reloadhttps://github.com/python/cpython/pull/151821/files
Please reload this pagehttps://github.com/python/cpython/pull/151821/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/151821/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
timurmamedov1https://github.com/timurmamedov1
python:mainhttps://github.com/python/cpython/tree/main
timurmamedov1:gh-151815-fix-template-iter-segfaulthttps://github.com/timurmamedov1/cpython/tree/gh-151815-fix-template-iter-segfault
Conversation 7 https://github.com/python/cpython/pull/151821
Commits 2 https://github.com/python/cpython/pull/151821/commits
Checks 54 https://github.com/python/cpython/pull/151821/checks
Files changed https://github.com/python/cpython/pull/151821/files
Please reload this pagehttps://github.com/python/cpython/pull/151821/files
gh-151815: Fix segfault in template_iter on allocation failure https://github.com/python/cpython/pull/151821/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/151821/files
8e5d35c gh-151815: Fix segfault in template_iter on allocation failure timurmamedov1 Jun 21, 2026 https://github.com/python/cpython/pull/151821/commits/8e5d35c96edea86606b74a4baafed75a8b533e03
36af6ce Create sub-iterators before allocating the iterator object timurmamedov1 Jul 8, 2026 https://github.com/python/cpython/pull/151821/commits/36af6ce9ad48829919be2d1506733c06fa35af38
Clear filters https://github.com/python/cpython/pull/151821/files
Please reload this pagehttps://github.com/python/cpython/pull/151821/files
Please reload this pagehttps://github.com/python/cpython/pull/151821/files
2026-06-20-14-00-00.gh-issue-151815.TmplIt.rst https://github.com/python/cpython/pull/151821/files#diff-396761bf9c13f1433a03fdf571c3908b922ec3fb3790d01247cde980b9cff05c
templateobject.c https://github.com/python/cpython/pull/151821/files#diff-9d02d1ea1a6fbdad2badeaf127149158c3fdec1f1429a23f70f1cce175bfbd45
Misc/NEWS.d/next/Core_and_Builtins/2026-06-20-14-00-00.gh-issue-151815.TmplIt.rsthttps://github.com/python/cpython/pull/151821/files#diff-396761bf9c13f1433a03fdf571c3908b922ec3fb3790d01247cde980b9cff05c
View file https://github.com/python/cpython/blob/36af6ce9ad48829919be2d1506733c06fa35af38/Misc/NEWS.d/next/Core_and_Builtins/2026-06-20-14-00-00.gh-issue-151815.TmplIt.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/151821/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L354
Objects/templateobject.chttps://github.com/python/cpython/pull/151821/files#diff-9d02d1ea1a6fbdad2badeaf127149158c3fdec1f1429a23f70f1cce175bfbd45
View file https://github.com/python/cpython/blob/36af6ce9ad48829919be2d1506733c06fa35af38/Objects/templateobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/151821/{{ revealButtonHref }}
https://github.com/python/cpython/pull/151821/files#diff-9d02d1ea1a6fbdad2badeaf127149158c3fdec1f1429a23f70f1cce175bfbd45
https://github.com/python/cpython/pull/151821/files#diff-9d02d1ea1a6fbdad2badeaf127149158c3fdec1f1429a23f70f1cce175bfbd45
Please reload this pagehttps://github.com/python/cpython/pull/151821/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.