René's URL Explorer Experiment


Title: bpo-37788: fix reference leak caused by threading._shutdown_locks by akruis · Pull Request #15175 · python/cpython · GitHub

Open Graph Title: bpo-37788: fix reference leak caused by threading._shutdown_locks by akruis · Pull Request #15175 · python/cpython

X Title: bpo-37788: fix reference leak caused by threading._shutdown_locks by akruis · Pull Request #15175 · python/cpython

Description: If a program creates non-daemon threads but does not join them, the global set threading._shutdown_locks accumulates the shutdown locks of the threads. This pull request adds a test case for non-daemon threads without join. The test must not leak references, if called with python -m test -R: test_threading. This pull request also fixes the reference leak. The tstate->on_delete-hook now discards per thread shutdown locks from threading._shutdown_locks. https://bugs.python.org/issue37788

Open Graph Description: If a program creates non-daemon threads but does not join them, the global set threading._shutdown_locks accumulates the shutdown locks of the threads. This pull request adds a test case for non-da...

X Description: If a program creates non-daemon threads but does not join them, the global set threading._shutdown_locks accumulates the shutdown locks of the threads. This pull request adds a test case for non-da...

Opengraph URL: https://github.com/python/cpython/pull/15175

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:03a58b39-a7b8-c075-4401-6b3997f81a22
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD740:2987FD:1A37E5A:230319E:6A544A3D
html-safe-nonce69127fcbb6204ae118b92f4a6c6c829ead036ae926074962abfed486e6c7226b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzQwOjI5ODdGRDoxQTM3RTVBOjIzMDMxOUU6NkE1NDRBM0QiLCJ2aXNpdG9yX2lkIjoiMjYwNjMxMTIzOTMyOTI3MDMzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca49f0c8ba9e82488ed0cf4912a38451b50208029d3afca306d533cbb66f9789c
hovercard-subject-tagpull_request:305463167
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/15175/files
twitter:imagehttps://avatars.githubusercontent.com/u/659726?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/659726?s=400&v=4
og:image:altIf a program creates non-daemon threads but does not join them, the global set threading._shutdown_locks accumulates the shutdown locks of the threads. This pull request adds a test case for non-da...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/15175/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15175%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15175%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/15175/files
Reloadhttps://github.com/python/cpython/pull/15175/files
Reloadhttps://github.com/python/cpython/pull/15175/files
Please reload this pagehttps://github.com/python/cpython/pull/15175/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/15175/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
akruishttps://github.com/akruis
python:mainhttps://github.com/python/cpython/tree/main
akruis:bpo37788-fix-resource-leakhttps://github.com/akruis/cpython/tree/bpo37788-fix-resource-leak
Conversation 6 https://github.com/python/cpython/pull/15175
Commits 2 https://github.com/python/cpython/pull/15175/commits
Checks 0 https://github.com/python/cpython/pull/15175/checks
Files changed https://github.com/python/cpython/pull/15175/files
Please reload this pagehttps://github.com/python/cpython/pull/15175/files
bpo-37788: fix reference leak caused by threading._shutdown_locks https://github.com/python/cpython/pull/15175/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/15175/files
709c36b bpo-37788: Add a general test case for non-daemon threads without join akruis Aug 8, 2019 https://github.com/python/cpython/pull/15175/commits/709c36bedcb6206d99be21b986757e7b8fc373c8
05e1c45 bpo-37788: Fix a resource leak in threading._shutdown_locks akruis Aug 8, 2019 https://github.com/python/cpython/pull/15175/commits/05e1c456918ce68b374b47b31aea6b5610872785
Clear filters https://github.com/python/cpython/pull/15175/files
Please reload this pagehttps://github.com/python/cpython/pull/15175/files
Please reload this pagehttps://github.com/python/cpython/pull/15175/files
test_threading.py https://github.com/python/cpython/pull/15175/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
threading.py https://github.com/python/cpython/pull/15175/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
_threadmodule.c https://github.com/python/cpython/pull/15175/files#diff-23071700ee893f365a4c117210b9129d4ac6afe5cc6e52bb5cd4cabbc6816e07
Lib/test/test_threading.pyhttps://github.com/python/cpython/pull/15175/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
View file https://github.com/akruis/cpython/blob/05e1c456918ce68b374b47b31aea6b5610872785/Lib/test/test_threading.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15175/{{ revealButtonHref }}
https://github.com/python/cpython/pull/15175/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
https://github.com/python/cpython/pull/15175/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
Lib/threading.pyhttps://github.com/python/cpython/pull/15175/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
View file https://github.com/akruis/cpython/blob/05e1c456918ce68b374b47b31aea6b5610872785/Lib/threading.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15175/{{ revealButtonHref }}
https://github.com/python/cpython/pull/15175/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/15175/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
Modules/_threadmodule.chttps://github.com/python/cpython/pull/15175/files#diff-23071700ee893f365a4c117210b9129d4ac6afe5cc6e52bb5cd4cabbc6816e07
View file https://github.com/akruis/cpython/blob/05e1c456918ce68b374b47b31aea6b5610872785/Modules/_threadmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15175/{{ revealButtonHref }}
https://github.com/python/cpython/pull/15175/files#diff-23071700ee893f365a4c117210b9129d4ac6afe5cc6e52bb5cd4cabbc6816e07
https://github.com/python/cpython/pull/15175/files#diff-23071700ee893f365a4c117210b9129d4ac6afe5cc6e52bb5cd4cabbc6816e07
https://github.com/python/cpython/pull/15175/files#diff-23071700ee893f365a4c117210b9129d4ac6afe5cc6e52bb5cd4cabbc6816e07
vadmiumhttps://github.com/vadmium
Dec 11, 2020https://github.com/python/cpython/pull/15175/files#r540658581
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/15175/files
https://github.com/python/cpython/pull/15175/files#diff-23071700ee893f365a4c117210b9129d4ac6afe5cc6e52bb5cd4cabbc6816e07
https://github.com/python/cpython/pull/15175/files#diff-23071700ee893f365a4c117210b9129d4ac6afe5cc6e52bb5cd4cabbc6816e07
https://github.com/python/cpython/pull/15175/files#diff-23071700ee893f365a4c117210b9129d4ac6afe5cc6e52bb5cd4cabbc6816e07
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.