| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:528b4098-94bd-ae6e-c402-f6511c9b629b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AEC2:24A54A:DEC6C:127C19:6A5AABC3 |
| html-safe-nonce | 5516e708468d4df2e3e26493307a15a485f55ae48ef570deda5f44a17171b64e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUMyOjI0QTU0QTpERUM2QzoxMjdDMTk6NkE1QUFCQzMiLCJ2aXNpdG9yX2lkIjoiMjIwMDcyNDI0MTAzMzkyNjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 24be24f4475d3880d1c2a684d03a85c4664a8fa358ac95bd63628c1c52f8fb9f |
| hovercard-subject-tag | pull_request:305347367 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/15170/files |
| twitter:image | https://avatars.githubusercontent.com/u/887754?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/887754?s=400&v=4 |
| og:image:alt | https://bugs.python.org/issue37772 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 21c53da6db0c40484841ba32fe19ecf485e7e734334faab487cd59d884d2bb33 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6e85f20f54e1147d8162094880590864abefff6b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/15170/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15170%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15170%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/15170/files |
| Reload | https://github.com/python/cpython/pull/15170/files |
| Reload | https://github.com/python/cpython/pull/15170/files |
| Please reload this page | https://github.com/python/cpython/pull/15170/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/15170/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| jaraco | https://github.com/jaraco |
| python:master | https://github.com/python/cpython/tree/master |
| shireenrao:zipfile | https://github.com/shireenrao/cpython/tree/zipfile |
|
Conversation
59
| https://github.com/python/cpython/pull/15170 |
|
Commits
26
| https://github.com/python/cpython/pull/15170/commits |
|
Checks
0
| https://github.com/python/cpython/pull/15170/checks |
|
Files changed
| https://github.com/python/cpython/pull/15170/files |
| Please reload this page | https://github.com/python/cpython/pull/15170/files |
|
bpo-37772: fix zipfile.Path.iterdir() outputs
| https://github.com/python/cpython/pull/15170/files#top |
|
Show all changes
26 commits
| https://github.com/python/cpython/pull/15170/files |
|
11efec1
fix Path._add_implied_dirs to include all implied directories
shireenrao Aug 7, 2019
| https://github.com/python/cpython/pull/15170/commits/11efec105578f03e96bf83f3a3a6d3605b747623 |
|
12491c5
fix Path._add_implied_dirs to include all implied directories
shireenrao Aug 7, 2019
| https://github.com/python/cpython/pull/15170/commits/12491c584f29dbf6678e5f4041233a82ecdb6999 |
|
b7266c1
Optimize code by using sets instead of lists
shireenrao Aug 7, 2019
| https://github.com/python/cpython/pull/15170/commits/b7266c13f8586dd686d11a8e5f51922e448f5ab5 |
|
3ac5c04
merge branch to get updates
shireenrao Aug 7, 2019
| https://github.com/python/cpython/pull/15170/commits/3ac5c04fb494360c19f2c7a6d472aa7f928af0a4 |
|
10f50b1
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 7, 2019
| https://github.com/python/cpython/pull/15170/commits/10f50b156948335946df85d9cdec306b24c9b08b |
|
ca05ad6
fix Path._add_implied_dirs to include all implied directories
shireenrao Aug 7, 2019
| https://github.com/python/cpython/pull/15170/commits/ca05ad6988bbd548f86f90ee2fb55acb2d7b544d |
|
342a447
Optimize code by using sets instead of lists
shireenrao Aug 7, 2019
| https://github.com/python/cpython/pull/15170/commits/342a447ad60546b47e752e714de5f928c6f4cdd6 |
|
c36975f
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 7, 2019
| https://github.com/python/cpython/pull/15170/commits/c36975f8742da817e3f2590ec6ed7463e5d63b57 |
|
69109a7
Add tests to zipfile.Path.iterdir() fix
shireenrao Aug 9, 2019
| https://github.com/python/cpython/pull/15170/commits/69109a74779bc595422575ef939fe746144d405a |
|
42c9e51
Update test for zipfile.Path.iterdir()
shireenrao Aug 9, 2019
| https://github.com/python/cpython/pull/15170/commits/42c9e51fa8a16d5e72d0e4bf2a16a4819eaa8c17 |
|
5f63ce9
Merge branch 'zipfile' of github.com:shireenrao/cpython into zipfile
shireenrao Aug 9, 2019
| https://github.com/python/cpython/pull/15170/commits/5f63ce9c89f62c9ebf476d6506abddc1956a941e |
|
2c55595
remove whitespace from test file
shireenrao Aug 9, 2019
| https://github.com/python/cpython/pull/15170/commits/2c55595337665d1ca8b8c5112f9c318d7460b740 |
|
cedac04
Merge branch 'master' into zipfile
jaraco Aug 10, 2019
| https://github.com/python/cpython/pull/15170/commits/cedac04aa196b3224768517147fb1417a06619c7 |
|
64c50a3
Rewrite NEWS blurb to describe the user-facing impact and avoid imple…
jaraco Aug 10, 2019
| https://github.com/python/cpython/pull/15170/commits/64c50a3df9d7024144df3ef189ac18ed22e4627c |
|
9e9e42f
remove redundant [] within set comprehension
shireenrao Aug 10, 2019
| https://github.com/python/cpython/pull/15170/commits/9e9e42f4d0431fa5ab043830ae77e863afee78ee |
|
eeb5f98
Update to use unique_everseen to maintain order and other suggestions…
shireenrao Aug 10, 2019
| https://github.com/python/cpython/pull/15170/commits/eeb5f98396035b183cbecc1c2b20ceb52f873a87 |
|
7b1b6f5
remove whitespace and add back add_dirs in tests
shireenrao Aug 10, 2019
| https://github.com/python/cpython/pull/15170/commits/7b1b6f53cf55c02df47af1961c2469f1e928abd1 |
|
ad05c79
Add new standalone function parents using posixpath to get parents of…
shireenrao Aug 12, 2019
| https://github.com/python/cpython/pull/15170/commits/ad05c797655b029a1e11c49f0e7b45a93880f8dd |
|
9476650
removing whitespace (sorry)
shireenrao Aug 12, 2019
| https://github.com/python/cpython/pull/15170/commits/9476650b7fe5a53808ccd7df060cebb7d154552f |
|
f9c1706
Remove import pathlib from zipfile.py
shireenrao Aug 12, 2019
| https://github.com/python/cpython/pull/15170/commits/f9c1706454c00f3e412ea4bf421a5cd5b8ac4f19 |
|
c153a6f
Rewrite _parents as a slice on a generator of the ancestry of a path.
jaraco Aug 24, 2019
| https://github.com/python/cpython/pull/15170/commits/c153a6f1438fbe165737d9131d64bc8a76c71ecb |
|
0002c29
Remove check for '.' and '/', now that parents no longer returns those.
jaraco Aug 24, 2019
| https://github.com/python/cpython/pull/15170/commits/0002c296a64c0b9064ab51659b5bff2cc6ea6d0e |
|
c1cbec6
Separate calculation of implied dirs from adding those
jaraco Aug 24, 2019
| https://github.com/python/cpython/pull/15170/commits/c1cbec623aea9b416e59ea92a8407c827d4f7f82 |
|
78a584e
Re-use _implied_dirs in tests for generating zipfile with dir entries.
jaraco Aug 24, 2019
| https://github.com/python/cpython/pull/15170/commits/78a584efdf3b97e2c5376e6a61ed1a8031d1c074 |
|
2384aa7
Replace three fixtures (abcde, abcdef, abde) with one representative …
jaraco Aug 24, 2019
| https://github.com/python/cpython/pull/15170/commits/2384aa71220f8e8ed888d30b3d94d2ce2941ff91 |
|
be2a13a
Simplify implementation of _implied_dirs by collapsing the generation…
jaraco Aug 24, 2019
| https://github.com/python/cpython/pull/15170/commits/be2a13ad638d6865e09f19272b60f15794d68662 |
|
Clear filters
| https://github.com/python/cpython/pull/15170/files |
| Please reload this page | https://github.com/python/cpython/pull/15170/files |
| Please reload this page | https://github.com/python/cpython/pull/15170/files |
|
test_zipfile.py
| https://github.com/python/cpython/pull/15170/files#diff-88215aededc3f81c55ba2432fe67617be9fc3faff9cb10e0c01f710adfcba426 |
|
zipfile.py
| https://github.com/python/cpython/pull/15170/files#diff-b5cf7374d79aae191c1e38d0959527e0bbb7a95e0df5b125a8b1056cc2c54851 |
|
2019-08-07-23-48-09.bpo-37772.hLCvdn.rst
| https://github.com/python/cpython/pull/15170/files#diff-0aaa8ede92ee7f698eba772083613b87d5056461bb0a0a7ce390ef87d78afd2b |
| Lib/test/test_zipfile.py | https://github.com/python/cpython/pull/15170/files#diff-88215aededc3f81c55ba2432fe67617be9fc3faff9cb10e0c01f710adfcba426 |
|
View file
| https://github.com/shireenrao/cpython/blob/be2a13ad638d6865e09f19272b60f15794d68662/Lib/test/test_zipfile.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/15170/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/15170/files#diff-88215aededc3f81c55ba2432fe67617be9fc3faff9cb10e0c01f710adfcba426 |
|
| https://github.com/python/cpython/pull/15170/files#diff-88215aededc3f81c55ba2432fe67617be9fc3faff9cb10e0c01f710adfcba426 |
|
| https://github.com/python/cpython/pull/15170/files#diff-88215aededc3f81c55ba2432fe67617be9fc3faff9cb10e0c01f710adfcba426 |
| Lib/zipfile.py | https://github.com/python/cpython/pull/15170/files#diff-b5cf7374d79aae191c1e38d0959527e0bbb7a95e0df5b125a8b1056cc2c54851 |
|
View file
| https://github.com/shireenrao/cpython/blob/be2a13ad638d6865e09f19272b60f15794d68662/Lib/zipfile.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/15170/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/15170/files#diff-b5cf7374d79aae191c1e38d0959527e0bbb7a95e0df5b125a8b1056cc2c54851 |
|
| https://github.com/python/cpython/pull/15170/files#diff-b5cf7374d79aae191c1e38d0959527e0bbb7a95e0df5b125a8b1056cc2c54851 |
|
| https://github.com/python/cpython/pull/15170/files#diff-b5cf7374d79aae191c1e38d0959527e0bbb7a95e0df5b125a8b1056cc2c54851 |
|
| https://github.com/python/cpython/pull/15170/files#diff-b5cf7374d79aae191c1e38d0959527e0bbb7a95e0df5b125a8b1056cc2c54851 |
|
| https://github.com/python/cpython/pull/15170/files#diff-b5cf7374d79aae191c1e38d0959527e0bbb7a95e0df5b125a8b1056cc2c54851 |
|
| https://github.com/python/cpython/pull/15170/files#diff-b5cf7374d79aae191c1e38d0959527e0bbb7a95e0df5b125a8b1056cc2c54851 |
| Misc/NEWS.d/next/Library/2019-08-07-23-48-09.bpo-37772.hLCvdn.rst | https://github.com/python/cpython/pull/15170/files#diff-0aaa8ede92ee7f698eba772083613b87d5056461bb0a0a7ce390ef87d78afd2b |
|
View file
| https://github.com/shireenrao/cpython/blob/be2a13ad638d6865e09f19272b60f15794d68662/Misc/NEWS.d/next/Library/2019-08-07-23-48-09.bpo-37772.hLCvdn.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/15170/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |