René's URL Explorer Experiment


Title: bpo-21261: IDLE - add completion of dict sting keys by taleinat · Pull Request #15169 · python/cpython · GitHub

Open Graph Title: bpo-21261: IDLE - add completion of dict sting keys by taleinat · Pull Request #15169 · python/cpython

X Title: bpo-21261: IDLE - add completion of dict sting keys by taleinat · Pull Request #15169 · python/cpython

Description: This is a new implementation, created from scratch. I intentionally didn't base this on PR GH-1511 after reviewing it thoroughly. Note that completion is intentionally limited to keys of type str and bytes only. Additional changes made in this PR: The Escape key now closes the completion window. [already done separately] Completing a string or bytes dict key adds a closing square bracket. Some of the auto-completion tests have been changed a bit to run without a GUI. Significant refactoring and cleanup of some existing tests, with better use of mocking. The fake Text widget used for tests has had its index handling greatly improved. Added a very functional fake Listbox widget class. https://bugs.python.org/issue21261

Open Graph Description: This is a new implementation, created from scratch. I intentionally didn't base this on PR GH-1511 after reviewing it thoroughly. Note that completion is intentionally limited to keys of type s...

X Description: This is a new implementation, created from scratch. I intentionally didn't base this on PR GH-1511 after reviewing it thoroughly. Note that completion is intentionally limited to keys of ty...

Opengraph URL: https://github.com/python/cpython/pull/15169

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:98c4baad-699e-5ca2-73c2-3c8abc44fba3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB37C:24CA2A:4C0F769:656A6A0:6A6551D8
html-safe-nonce2e83fe8084fd167bc779b4663235bb71373d132bcfb54fe3c63f31e021a07101
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzdDOjI0Q0EyQTo0QzBGNzY5OjY1NkE2QTA6NkE2NTUxRDgiLCJ2aXNpdG9yX2lkIjoiMzM3MzA2MTA4Nzc5OTA5NTkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacda095099dbffbe3b4cd2f97e59639852f8949d39ae4278c4c6267422232c7afe
hovercard-subject-tagpull_request:305309478
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/15169/commits/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6
twitter:imagehttps://avatars.githubusercontent.com/u/532281?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/532281?s=400&v=4
og:image:altThis is a new implementation, created from scratch. I intentionally didn't base this on PR GH-1511 after reviewing it thoroughly. Note that completion is intentionally limited to keys of type s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release309153364422b3c499922d1a2a6404910a58ed8e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/15169/commits/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15169%2Fcommits%2Ff5ed669803ce34d420f9c2d6ac4e07b4553d2aa6
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F15169%2Fcommits%2Ff5ed669803ce34d420f9c2d6ac4e07b4553d2aa6
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/15169/commits/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6
Reloadhttps://github.com/python/cpython/pull/15169/commits/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6
Reloadhttps://github.com/python/cpython/pull/15169/commits/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6
Please reload this pagehttps://github.com/python/cpython/pull/15169/commits/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/15169/commits/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.4k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
taleinathttps://github.com/taleinat
python:mainhttps://github.com/python/cpython/tree/main
taleinat:idle-dict-key-completionhttps://github.com/taleinat/cpython/tree/idle-dict-key-completion
Conversation 71 https://github.com/python/cpython/pull/15169
Commits 32 https://github.com/python/cpython/pull/15169/commits
Checks 0 https://github.com/python/cpython/pull/15169/checks
Files changed https://github.com/python/cpython/pull/15169/files
Please reload this pagehttps://github.com/python/cpython/pull/15169/commits/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6
bpo-21261: IDLE - add completion of dict sting keys https://github.com/python/cpython/pull/15169/commits/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6#top
Show all changes 32 commits https://github.com/python/cpython/pull/15169/files
96052fe prefix preservation for str and bytes taleinat Aug 6, 2019 https://github.com/python/cpython/pull/15169/commits/96052fe4f5c812ea794448840d6f628b14913ba5
e995f9a refactor back to original interface of fetch_completions() taleinat Aug 7, 2019 https://github.com/python/cpython/pull/15169/commits/e995f9a45e819f3366fb336c8e05bdb0996a10b0
4a58931 refactor existing tests and improve mock_tk.Text._decode() taleinat Aug 7, 2019 https://github.com/python/cpython/pull/15169/commits/4a589311a1a00bd21fbf745e3f90b363fe42dc02
deca90e add tests taleinat Aug 7, 2019 https://github.com/python/cpython/pull/15169/commits/deca90ee32d64db3fb5ccf951b85a231bcee1d79
2abfa3f add a NEWS entry taleinat Aug 7, 2019 https://github.com/python/cpython/pull/15169/commits/2abfa3f94b614a0bbb8981c78afd5d0bde9f4d49
b5e7692 code cleanup and added comments taleinat Aug 7, 2019 https://github.com/python/cpython/pull/15169/commits/b5e76924e27a5a0dc326c9dc877ee95cf707975a
4d54812 whitespace fix taleinat Aug 8, 2019 https://github.com/python/cpython/pull/15169/commits/4d548121419fc5e4e36e7989e06cd9d337a90120
0b41286 Escape key closes the completion window taleinat Aug 8, 2019 https://github.com/python/cpython/pull/15169/commits/0b412865799bb19825c39965fd46103b68516e72
2929d52 a bit of code cleanup taleinat Aug 8, 2019 https://github.com/python/cpython/pull/15169/commits/2929d528858ab7ba4c3824f764d1390b13c09bf0
0d0e6e0 many major improvements taleinat Aug 8, 2019 https://github.com/python/cpython/pull/15169/commits/0d0e6e0231ccb1c465d467e8b0618bd38faa4880
0087526 implement try-open for dict keys, and fix handling of ']' taleinat Aug 8, 2019 https://github.com/python/cpython/pull/15169/commits/0087526fc31f7306e875bde65f34e2c4bffea49b
8a4cb1a fix whitespace taleinat Aug 8, 2019 https://github.com/python/cpython/pull/15169/commits/8a4cb1abcb8dde28930eeee8f1fe0f92a59b9598
f5ed669 improve NEWS entry wording and formatting taleinat Aug 8, 2019 https://github.com/python/cpython/pull/15169/commits/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6
f2ef1fa _is_completing_dict_key args: rename 'hp' and remove unused 'curline' taleinat Aug 8, 2019 https://github.com/python/cpython/pull/15169/commits/f2ef1fad04fd5501125595c128568c53dbe809ff
1d07f23 remove unused "user wants win" variables and function args taleinat Aug 9, 2019 https://github.com/python/cpython/pull/15169/commits/1d07f23fce8cda6654a10f3e7070e3850025e858
62e0f39 clean up code of _find_first_quote() taleinat Aug 10, 2019 https://github.com/python/cpython/pull/15169/commits/62e0f39d7b8349ebab1082649549a435e42bc803
a57a4f1 remove unnecessary "from tkinter import *" taleinat Aug 10, 2019 https://github.com/python/cpython/pull/15169/commits/a57a4f1c8ecef88f007e922c56d29a44955b5edb
b28eeac fix opening of dict key completion for expressions with func calls taleinat Aug 11, 2019 https://github.com/python/cpython/pull/15169/commits/b28eeace29ce6858fcbd80f97050ad4d61725367
167795e fix bug opening completions in the middle of a dict key string taleinat Aug 13, 2019 https://github.com/python/cpython/pull/15169/commits/167795e3c3138bf8509130f2bbde19e0e5271090
ad022eb escape non-BMP unicode characters in dict key string completions taleinat Aug 13, 2019 https://github.com/python/cpython/pull/15169/commits/ad022eb89e8ec7348d32b692ebc091d58106a020
81790db refactor _dict_key_reprs() to avoid compiling functions on every call taleinat Aug 13, 2019 https://github.com/python/cpython/pull/15169/commits/81790dbc06e2b56ed3c2db4e0f23619e27800f28
e8ecd50 update idle.rst taleinat Aug 13, 2019 https://github.com/python/cpython/pull/15169/commits/e8ecd50b2818e013b17ed537f5da8d1eb1d135ef
47f9d8a add a What's New entry taleinat Aug 13, 2019 https://github.com/python/cpython/pull/15169/commits/47f9d8ab474c21476adfba9d8e111603ab626373
82abc40 use sys.maxunicode and add doc-strings and informative comments taleinat Aug 14, 2019 https://github.com/python/cpython/pull/15169/commits/82abc404a34853296d75c72973b619bbe1db1196
8459bba be extra-safe and don't crash on import if sys.maxunicode < 0x10000 taleinat Aug 14, 2019 https://github.com/python/cpython/pull/15169/commits/8459bbab84c03a215da45e2516e46721a8a00025
5f89338 update comment taleinat Aug 24, 2019 https://github.com/python/cpython/pull/15169/commits/5f89338cbe7d60e9add76abcbc6fc281c86b9914
7a21705 Merge branch 'master' into idle-dict-key-completion taleinat Aug 31, 2019 https://github.com/python/cpython/pull/15169/commits/7a217051ed87a8351733bc2c0e81b9d30e45b6ec
c9e0307 fix completing after a bracket with no available dict key completions taleinat Aug 31, 2019 https://github.com/python/cpython/pull/15169/commits/c9e03072d18715820c0373cee27e1fdf34579a78
d97213d add a couple more test cases taleinat Aug 31, 2019 https://github.com/python/cpython/pull/15169/commits/d97213d7b839627465b47eb83db249c93733e38c
0c1f907 Merge branch 'master' into idle-dict-key-completion taleinat Nov 14, 2019 https://github.com/python/cpython/pull/15169/commits/0c1f9076a807606f178121e78915036ee0860c54
38c28f2 revert outdated additions to "What's New" docs taleinat Nov 14, 2019 https://github.com/python/cpython/pull/15169/commits/38c28f211f67f0fa288b2f12ce06142bc00017be
530e1f7 Merge branch 'master' into idle-dict-key-completion taleinat Sep 19, 2020 https://github.com/python/cpython/pull/15169/commits/530e1f75ef31606105a67d2c7e0c5738cdd44e22
Clear filters https://github.com/python/cpython/pull/15169/commits/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6
Please reload this pagehttps://github.com/python/cpython/pull/15169/commits/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6
Please reload this pagehttps://github.com/python/cpython/pull/15169/commits/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6
Prev https://github.com/python/cpython/pull/15169/commits/8a4cb1abcb8dde28930eeee8f1fe0f92a59b9598
Next https://github.com/python/cpython/pull/15169/commits/f2ef1fad04fd5501125595c128568c53dbe809ff
Please reload this pagehttps://github.com/python/cpython/pull/15169/commits/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6
https://github.com/taleinat
taleinathttps://github.com/python/cpython/commits?author=taleinat
Misc/NEWS.d/next/IDLE/2019-08-07-23-27-54.bpo-21261.sqNQCD.rsthttps://github.com/python/cpython/pull/15169/commits/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6#diff-968bae51ccc7b6b35c66d097ecf18599b2ea139be3b66e3fc411fb00c57ed77a
View file https://github.com/taleinat/cpython/blob/f5ed669803ce34d420f9c2d6ac4e07b4553d2aa6/Misc/NEWS.d/next/IDLE/2019-08-07-23-27-54.bpo-21261.sqNQCD.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/15169/commits/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.