Title: gh-146102:Fix cross-interpreter NotShareableError ref handling by lpyu001 · Pull Request #151578 · python/cpython · GitHub
Open Graph Title: gh-146102:Fix cross-interpreter NotShareableError ref handling by lpyu001 · Pull Request #151578 · python/cpython
X Title: gh-146102:Fix cross-interpreter NotShareableError ref handling by lpyu001 · Pull Request #151578 · python/cpython
Description: This fixes two ownership issues: _ensure_notshareableerror() now returns immediately when the current raised exception is already a NotShareableError. The function had restored ctx to the thread state but then continued using it, even though ownership had been handed back. _PyXI_UnwrapNotShareableError() now decrefs the exception taken from the thread state if _PyXI_InitFailure() fails, avoiding a leaked exception reference on that error path. The _pop_preserved() shadowed-variable leak is already fixed on this branch, so this PR does not touch it. glist:https://gist.github.com/devdanzin/a56b8cb579b1950b4206e8a42d6be650 Issue: gh-146102
Open Graph Description: This fixes two ownership issues: _ensure_notshareableerror() now returns immediately when the current raised exception is already a NotShareableError. The function had restored ctx to the thread s...
X Description: This fixes two ownership issues: _ensure_notshareableerror() now returns immediately when the current raised exception is already a NotShareableError. The function had restored ctx to the thread s...
Opengraph URL: https://github.com/python/cpython/pull/151578
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9136f6b8-0c25-a295-74f8-c2e1e5278d17 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B59A:B9394:4A53C6:654B65:6A513456 |
| html-safe-nonce | 538029b36d4b3764ecbb5ed1565478318a6c3951235fa869f8cbfe27bfbf5b32 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTlBOkI5Mzk0OjRBNTNDNjo2NTRCNjU6NkE1MTM0NTYiLCJ2aXNpdG9yX2lkIjoiMjAzMDY4MzQwMTQ0MzQyMzMxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d7bd7e14b5f881c6b191bc85c8659a57cc6ecd93656860a0ec0dd680c34fcad3 |
| hovercard-subject-tag | pull_request:3881320950 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/151578/files |
| twitter:image | https://avatars.githubusercontent.com/u/189712014?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/189712014?s=400&v=4 |
| og:image:alt | This fixes two ownership issues: _ensure_notshareableerror() now returns immediately when the current raised exception is already a NotShareableError. The function had restored ctx to the thread s... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e840f405b2718e8f2d55aafa9ff27dbce17e29d0c253011d05ea0fea3c78baff |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4ae6027e8ba70c79dc08249bb6cdc1a09d788496 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width