Title: gh-151422: Don't link libffi into _ctypes_test.so by hoodmane · Pull Request #151423 · python/cpython · GitHub
Open Graph Title: gh-151422: Don't link libffi into _ctypes_test.so by hoodmane · Pull Request #151423 · python/cpython
X Title: gh-151422: Don't link libffi into _ctypes_test.so by hoodmane · Pull Request #151423 · python/cpython
Description: Minor build fix. This makes the ctypes tests run on Emscripten. There is a bug in the Emscripten dynamic loader that caused any dynamic library that links libffi to fail to load. _ctypes_test.so unnecessarily links libffi so it would fail to load and tests that needed it were skipped. There are two test failures behind that: one involving stack overflows which we have to skip as usual, and one that assumes that the abi for a function that takes a single struct with two doubles is the same as the abi for a function that takes two double arguments. This is not true in webassembly so we skip the test. Issue: gh-151422
Open Graph Description: Minor build fix. This makes the ctypes tests run on Emscripten. There is a bug in the Emscripten dynamic loader that caused any dynamic library that links libffi to fail to load. _ctypes_test.so un...
X Description: Minor build fix. This makes the ctypes tests run on Emscripten. There is a bug in the Emscripten dynamic loader that caused any dynamic library that links libffi to fail to load. _ctypes_test.so un...
Opengraph URL: https://github.com/python/cpython/pull/151423
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d6cae3a6-b43e-8282-a972-43b6cfadf797 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D718:2D4C4C:5DF166:7DCA35:6A5347F1 |
| html-safe-nonce | fccebf956220cbcf9b503eca125596dbbc2b4405221cf12c944e6c0b68fbbf14 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzE4OjJENEM0Qzo1REYxNjY6N0RDQTM1OjZBNTM0N0YxIiwidmlzaXRvcl9pZCI6IjExNDMzNTI5ODkyNzAwOTk5NTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9b0b5e998fc76a496b8d5bbaf86bf954b7ce39ae98b0de980b9fa9d73edcea50 |
| hovercard-subject-tag | pull_request:3858151651 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/151423/files |
| twitter:image | https://avatars.githubusercontent.com/u/8739626?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8739626?s=400&v=4 |
| og:image:alt | Minor build fix. This makes the ctypes tests run on Emscripten. There is a bug in the Emscripten dynamic loader that caused any dynamic library that links libffi to fail to load. _ctypes_test.so un... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width