René's URL Explorer Experiment


Title: gh-146102: Don't clear exception on success in odictobject.c by vstinner · Pull Request #151347 · python/cpython · GitHub

Open Graph Title: gh-146102: Don't clear exception on success in odictobject.c by vstinner · Pull Request #151347 · python/cpython

X Title: gh-146102: Don't clear exception on success in odictobject.c by vstinner · Pull Request #151347 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Calling PyErr_Clear() on success can mask a pending exception. Replace it with an assertion checking that no exception is set. Issue: Umbrella issue: bugs found using cpython-review-toolkit #146102

X Description: Calling PyErr_Clear() on success can mask a pending exception. Replace it with an assertion checking that no exception is set. Issue: Umbrella issue: bugs found using cpython-review-toolkit #146102

Opengraph URL: https://github.com/python/cpython/pull/151347

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:a44738aa-6aed-21e2-103a-cdce01a6a6d6
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-id9438:57C75:5A1B5D:7F55DD:6A50FEA3
html-safe-nonce97908d30f95deac7c47329bedd1a5384f6d3d8d556bc743b6cbc87c911c1deb1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDM4OjU3Qzc1OjVBMUI1RDo3RjU1REQ6NkE1MEZFQTMiLCJ2aXNpdG9yX2lkIjoiMTEyMjAxNjQ0NjQ0MTkxNDAxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0dd22ece37cfbe112fcb7da36152955ce74c595f40ec77ec41d9924f875f150e
hovercard-subject-tagpull_request:3848082839
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/151347/checks
twitter:imagehttps://opengraph.githubassets.com/0e29bb3e65904aa989b8b4447e58f22e3f6d4acc6239474f71871ae01e3a1288/python/cpython/pull/151347
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0e29bb3e65904aa989b8b4447e58f22e3f6d4acc6239474f71871ae01e3a1288/python/cpython/pull/151347
og:image:altCalling PyErr_Clear() on success can mask a pending exception. Replace it with an assertion checking that no exception is set. Issue: Umbrella issue: bugs found using cpython-review-toolkit #146102
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
None38906a4da4e3e9fd88dfeacee232f5932c0c5f7495de3b4efc53ddfac7173d12
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release90441ea9b98e7491aa6ebcd135fccce4e2396f48
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/151347/checks#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151347%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151347%2Fchecks
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/151347/checks
Reloadhttps://github.com/python/cpython/pull/151347/checks
Reloadhttps://github.com/python/cpython/pull/151347/checks
Please reload this pagehttps://github.com/python/cpython/pull/151347/checks
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/151347/checks
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:odicthttps://github.com/vstinner/cpython/tree/odict
Conversationhttps://github.com/python/cpython/pull/151347
Commits1 (1)https://github.com/python/cpython/pull/151347/commits
Checkshttps://github.com/python/cpython/pull/151347/checks
Files changedhttps://github.com/python/cpython/pull/151347/files
gh-146102: Don't clear exception on success in odictobject.chttps://github.com/python/cpython/pull/151347/checks#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:odicthttps://github.com/vstinner/cpython/tree/odict
Please reload this pagehttps://github.com/python/cpython/pull/151347/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151347%2Fchecks
Check labels on: pull_request https://github.com/python/cpython/actions/runs/27354852208
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/27354852208/job/80826252544?pr=151347
Unresolved review https://github.com/python/cpython/actions/runs/27354852208/job/80826252432?pr=151347
Lint on: pull_request https://github.com/python/cpython/actions/runs/27354852685
lint https://github.com/python/cpython/actions/runs/27354852685/job/80826255393?pr=151347
Check labels on: pull_request https://github.com/python/cpython/actions/runs/27354852748
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/27354852748/job/80826254832?pr=151347
Unresolved review https://github.com/python/cpython/actions/runs/27354852748/job/80826254856?pr=151347
Tests on: pull_request https://github.com/python/cpython/actions/runs/27354853784
Change detection / Create context from changed files https://github.com/python/cpython/actions/runs/27354853784/job/80826258474?pr=151347
Docs https://github.com/python/cpython/actions/runs/27354853784/job/80826315045?pr=151347
Check if Autoconf files are up to date https://github.com/python/cpython/actions/runs/27354853784/job/80826312806?pr=151347
Check if generated files are up to date https://github.com/python/cpython/actions/runs/27354853784/job/80826312972?pr=151347
C API Docs / Check if all C APIs are documented https://github.com/python/cpython/actions/runs/27354853784/job/80826313398?pr=151347
Windows / Build and test (x64, switch-case) https://github.com/python/cpython/actions/runs/27354853784/job/80826313617?pr=151347
Windows (free-threading) / Build and test (x64, switch-case) https://github.com/python/cpython/actions/runs/27354853784/job/80826313575?pr=151347
Windows / Build and test (Win32, switch-case) https://github.com/python/cpython/actions/runs/27354853784/job/80826313643?pr=151347
Windows / Build and test (arm64, switch-case) https://github.com/python/cpython/actions/runs/27354853784/job/80826313709?pr=151347
Windows (free-threading) / Build and test (arm64, switch-case) https://github.com/python/cpython/actions/runs/27354853784/job/80826314004?pr=151347
Windows / Build and test (x64, tail-call) https://github.com/python/cpython/actions/runs/27354853784/job/80826313784?pr=151347
Windows (free-threading) / Build and test (x64, tail-call) https://github.com/python/cpython/actions/runs/27354853784/job/80826313941?pr=151347
Windows MSI${{ '' }} https://github.com/python/cpython/actions/runs/27354853784/job/80826314602?pr=151347
macOS / build and test (macos-26) https://github.com/python/cpython/actions/runs/27354853784/job/80826314011?pr=151347
macOS (free-threading) / build and test (macos-26) https://github.com/python/cpython/actions/runs/27354853784/job/80826313631?pr=151347
macOS / build and test (macos-26-intel) https://github.com/python/cpython/actions/runs/27354853784/job/80826313665?pr=151347
Ubuntu / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/27354853784/job/80826313832?pr=151347
Ubuntu / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/27354853784/job/80826313976?pr=151347
Ubuntu (free-threading) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/27354853784/job/80826313839?pr=151347
Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/27354853784/job/80826313765?pr=151347
Ubuntu (bolt) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/27354853784/job/80826313845?pr=151347
Ubuntu SSL tests (ubuntu-24.04, openssl, 1.1.1w) https://github.com/python/cpython/actions/runs/27354853784/job/80826313269?pr=151347
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.0.21) https://github.com/python/cpython/actions/runs/27354853784/job/80826313259?pr=151347
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.4.6) https://github.com/python/cpython/actions/runs/27354853784/job/80826313320?pr=151347
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.5.7) https://github.com/python/cpython/actions/runs/27354853784/job/80826313291?pr=151347
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.6.3) https://github.com/python/cpython/actions/runs/27354853784/job/80826313356?pr=151347
Ubuntu SSL tests (ubuntu-24.04, openssl, 4.0.1) https://github.com/python/cpython/actions/runs/27354853784/job/80826313363?pr=151347
Ubuntu SSL tests (ubuntu-24.04, aws-lc, 5.0.0) https://github.com/python/cpython/actions/runs/27354853784/job/80826313313?pr=151347
Android (aarch64) https://github.com/python/cpython/actions/runs/27354853784/job/80826312884?pr=151347
Android (x86_64) https://github.com/python/cpython/actions/runs/27354853784/job/80826312899?pr=151347
iOS https://github.com/python/cpython/actions/runs/27354853784/job/80826312931?pr=151347
Emscripten / build and test https://github.com/python/cpython/actions/runs/27354853784/job/80826313504?pr=151347
WASI / build and test https://github.com/python/cpython/actions/runs/27354853784/job/80826313564?pr=151347
Hypothesis tests on Ubuntu https://github.com/python/cpython/actions/runs/27354853784/job/80826312993?pr=151347
Address sanitizer (ubuntu-24.04) https://github.com/python/cpython/actions/runs/27354853784/job/80826312898?pr=151347
Sanitizers / TSan https://github.com/python/cpython/actions/runs/27354853784/job/80826313856?pr=151347
Sanitizers / TSan (free-threading) https://github.com/python/cpython/actions/runs/27354853784/job/80826313985?pr=151347
Sanitizers / UBSan https://github.com/python/cpython/actions/runs/27354853784/job/80826314094?pr=151347
Cross build Linux https://github.com/python/cpython/actions/runs/27354853784/job/80826313008?pr=151347
CIFuzz / cpython3 (address) https://github.com/python/cpython/actions/runs/27354853784/job/80826313713?pr=151347
CIFuzz / cpython3 (undefined) https://github.com/python/cpython/actions/runs/27354853784/job/80826313803?pr=151347
CIFuzz / cpython3 (memory) https://github.com/python/cpython/actions/runs/27354853784/job/80826313914?pr=151347
All required checks pass https://github.com/python/cpython/actions/runs/27354853784/job/80834524522?pr=151347
Check labels on: pull_request https://github.com/python/cpython/actions/runs/27354854708
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/27354854708/job/80826260987?pr=151347
Unresolved review https://github.com/python/cpython/actions/runs/27354854708/job/80826261152?pr=151347
ClusterFuzzLite/CIFuzz https://github.com/python/cpython/pull/151347/checks?check_run_id=80830969723
Check labels on: pull_request https://github.com/python/cpython/actions/runs/27463340741
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/27463340741/job/81181106411?pr=151347
Unresolved review https://github.com/python/cpython/actions/runs/27463340741/job/81181106427?pr=151347
Check labels on: pull_request https://github.com/python/cpython/actions/runs/27463340902
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/27463340902/job/81181106785?pr=151347
Unresolved review https://github.com/python/cpython/actions/runs/27463340902/job/81181106811?pr=151347
Check labels on: pull_request https://github.com/python/cpython/actions/runs/27537905450
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/27537905450/job/81391938450?pr=151347
Unresolved review https://github.com/python/cpython/actions/runs/27537905450/job/81391938347?pr=151347
Check whether this PR is a feature (contains a "type-feature" label) https://github.com/python/cpython/pull/151347/checks#annotation:3:16
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.