René's URL Explorer Experiment


Title: gh-146102: Don't clear exception on success in odictobject.c by vstinner · Pull Request #151347 · python/cpython · GitHub

Open Graph Title: gh-146102: Don't clear exception on success in odictobject.c by vstinner · Pull Request #151347 · python/cpython

X Title: gh-146102: Don't clear exception on success in odictobject.c by vstinner · Pull Request #151347 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Calling PyErr_Clear() on success can mask a pending exception. Replace it with an assertion checking that no exception is set. Issue: Umbrella issue: bugs found using cpython-review-toolkit #146102

X Description: Calling PyErr_Clear() on success can mask a pending exception. Replace it with an assertion checking that no exception is set. Issue: Umbrella issue: bugs found using cpython-review-toolkit #146102

Opengraph URL: https://github.com/python/cpython/pull/151347

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0571b8a0-de22-9ef3-1b2c-3d922cf33de6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9468:F5E51:ADC4440:B14F99B:6A50C6F1
html-safe-nonce8b57078200c9c31f1de11975eb24f108afc5c93c462e1915e3ad150a53d9a1d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDY4OkY1RTUxOkFEQzQ0NDA6QjE0Rjk5Qjo2QTUwQzZGMSIsInZpc2l0b3JfaWQiOiI0NzczNjg5OTE0NTc4NDg3MDI1IiwicmVnaW9uX2VkZ2UiOiJzZWEiLCJyZWdpb25fcmVuZGVyIjoic2VhIn0=
visitor-hmaca1eb18641228ce47530efd9403539fa2a43b0dee537c3152ab948e013391e46b
hovercard-subject-tagpull_request:3848082839
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/151347/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0e29bb3e65904aa989b8b4447e58f22e3f6d4acc6239474f71871ae01e3a1288/python/cpython/pull/151347
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0e29bb3e65904aa989b8b4447e58f22e3f6d4acc6239474f71871ae01e3a1288/python/cpython/pull/151347
og:image:altCalling PyErr_Clear() on success can mask a pending exception. Replace it with an assertion checking that no exception is set. Issue: Umbrella issue: bugs found using cpython-review-toolkit #146102
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
None72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release08e79d53fc070870d5b168356afebb1e286a2ffe
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/151347#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151347
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151347
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/151347
Reloadhttps://github.com/python/cpython/pull/151347
Reloadhttps://github.com/python/cpython/pull/151347
Please reload this pagehttps://github.com/python/cpython/pull/151347
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/151347
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:odicthttps://github.com/vstinner/cpython/tree/odict
Conversationhttps://github.com/python/cpython/pull/151347
Commits1 (1)https://github.com/python/cpython/pull/151347/commits
Checkshttps://github.com/python/cpython/pull/151347/checks
Files changedhttps://github.com/python/cpython/pull/151347/files
gh-146102: Don't clear exception on success in odictobject.chttps://github.com/python/cpython/pull/151347#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:odicthttps://github.com/vstinner/cpython/tree/odict
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 11, 2026https://github.com/python/cpython/pull/151347#issue-4641510737
Please reload this pagehttps://github.com/python/cpython/pull/151347
Umbrella issue: bugs found using cpython-review-toolkit #146102https://github.com/python/cpython/issues/146102
Please reload this pagehttps://github.com/python/cpython/pull/151347
https://github.com/vstinner
pythongh-146102https://github.com/python/cpython/issues/146102
: Don't clear exception on success in odictobject.chttps://github.com/python/cpython/pull/151347/commits/29ab5d805ebf12c81a8c7194c43e93d1cbfb3787
29ab5d8https://github.com/python/cpython/pull/151347/commits/29ab5d805ebf12c81a8c7194c43e93d1cbfb3787
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jun 11, 2026https://github.com/python/cpython/pull/151347#event-26631022336
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 11, 2026https://github.com/python/cpython/pull/151347#event-26631026105
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 11, 2026https://github.com/python/cpython/pull/151347#issuecomment-4681745413
https://gist.github.com/devdanzin/9015c335e324a94ea06932bdd643a7dchttps://gist.github.com/devdanzin/9015c335e324a94ea06932bdd643a7dc
Please reload this pagehttps://github.com/python/cpython/pull/151347
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 11, 2026 https://github.com/python/cpython/pull/151347#ref-issue-4094189245
Umbrella issue: bugs found using cpython-review-toolkit #146102 https://github.com/python/cpython/issues/146102
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 13, 2026 https://github.com/python/cpython/pull/151347#pullrequestreview-4491267094
View reviewed changes https://github.com/python/cpython/pull/151347/files/29ab5d805ebf12c81a8c7194c43e93d1cbfb3787
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 13, 2026https://github.com/python/cpython/pull/151347#event-26706787286
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
b3b7c00https://github.com/python/cpython/commit/b3b7c0025be4f9d08d5f4259b8ffc7b05fa0ba7f
Jun 15, 2026https://github.com/python/cpython/pull/151347#event-26750327992
Please reload this pagehttps://github.com/python/cpython/pull/151347
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
June 15, 2026 09:46https://github.com/python/cpython/pull/151347#event-26750330210
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jun 15, 2026https://github.com/python/cpython/pull/151347#event-26750330630
philthompson10https://github.com/philthompson10
Jun 17, 2026 https://github.com/python/cpython/pull/151347#ref-commit-8cd462e
https://github.com/vstinner
https://github.com/philthompson10
pythongh-146102https://github.com/python/cpython/issues/146102
: Don't clear exception on success in odictobject.c (https://github.com/philthompson10/cpython/commit/8cd462efe3ed536af628ab48c27f93035e10b57d
p…https://github.com/python/cpython/pull/151347
8cd462ehttps://github.com/philthompson10/cpython/commit/8cd462efe3ed536af628ab48c27f93035e10b57d
…ython#151347https://github.com/python/cpython/pull/151347
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151347
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/151347/files/29ab5d805ebf12c81a8c7194c43e93d1cbfb3787
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/151347
https://github.com/vstinner
https://github.com/serhiy-storchaka
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.