René's URL Explorer Experiment


Title: gh-149044: Improve Py_tp_base[s] docs & error message for non-type bases by encukou · Pull Request #151252 · python/cpython · GitHub

Open Graph Title: gh-149044: Improve Py_tp_base[s] docs & error message for non-type bases by encukou · Pull Request #151252 · python/cpython

X Title: gh-149044: Improve Py_tp_base[s] docs & error message for non-type bases by encukou · Pull Request #151252 · python/cpython

Description: The initial implementation of PEP 820 worsened the error message when non-types are given as base types in Py_tp_bases & Py_tp_base (as Peter noted in the review). Bring back the 'bases must be types' wording and add a 'got' note for easier debugging. Improve slot ID documentation, and soft-deprecate Py_tp_base (as per the PEP). Add more tests. Issue: gh-149044

Open Graph Description: The initial implementation of PEP 820 worsened the error message when non-types are given as base types in Py_tp_bases & Py_tp_base (as Peter noted in the review). Bring back the 'bases mus...

X Description: The initial implementation of PEP 820 worsened the error message when non-types are given as base types in Py_tp_bases & Py_tp_base (as Peter noted in the review). Bring back the 'b...

Opengraph URL: https://github.com/python/cpython/pull/151252

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7edc8639-642f-fc70-4e49-642747686b3f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC406:3DD488:3E228FA:4EF26A9:6B021668
html-safe-nonce61ba55830b189fb37da13862e4fd4046b7c3a7cf44d109b351c2287abf2c7f85
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDA2OjNERDQ4ODozRTIyOEZBOjRFRjI2QTk6NkIwMjE2NjgiLCJ2aXNpdG9yX2lkIjoiNTE0OTg4ODYxNjg5NzU4MjY5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac948e65e329817309f2bdfd096e0e582cfc5daa902b3d8d0ddb74b5e9a7da472b
hovercard-subject-tagpull_request:3839867639
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/151252/files
twitter:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
og:image:altThe initial implementation of PEP 820 worsened the error message when non-types are given as base types in Py_tp_bases & Py_tp_base (as Peter noted in the review). Bring back the 'bases mus...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/151252/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151252%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151252%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/151252/files
Reloadhttps://github.com/python/cpython/pull/151252/files
Reloadhttps://github.com/python/cpython/pull/151252/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:tp_base_unificationhttps://github.com/encukou/cpython/tree/tp_base_unification
Conversation 4 https://github.com/python/cpython/pull/151252
Commits 6 https://github.com/python/cpython/pull/151252/commits
Checks 58 https://github.com/python/cpython/pull/151252/checks
Files changed https://github.com/python/cpython/pull/151252/files
Please reload this pagehttps://github.com/python/cpython/pull/151252/files
gh-149044: Improve Py_tp_base[s] docs & error message for non-type bases https://github.com/python/cpython/pull/151252/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/151252/files
63d365a gh-149044: Improve Py_tp_base[s] docs & error message for non-type bases encukou Jun 10, 2026 https://github.com/python/cpython/pull/151252/commits/63d365a0cd7ca9b8c01e3770bdb8c7f25bf9b49b
b5e1cea Correct PyType_Spec member links encukou Jun 10, 2026 https://github.com/python/cpython/pull/151252/commits/b5e1ceae3f5d591b81ab327ab3be1855b009280d
c0105b9 Add :c: encukou Jun 10, 2026 https://github.com/python/cpython/pull/151252/commits/c0105b9d6f2a8aa013dfe8f8bd5d701955254e8a
4649993 Merge in the main branch encukou Jun 10, 2026 https://github.com/python/cpython/pull/151252/commits/46499935795e937cd9e4fe17086aa90847ea6cdd
0ca84f8 Update removed-ids.txt encukou Jun 11, 2026 https://github.com/python/cpython/pull/151252/commits/0ca84f8a761bb2fc81aec39fbe08cd7b010477cb
1de19c5 Merge in the main branch encukou Jun 11, 2026 https://github.com/python/cpython/pull/151252/commits/1de19c528f982e29f7057953ab8d545b2d818ef2
Clear filters https://github.com/python/cpython/pull/151252/files
Please reload this pagehttps://github.com/python/cpython/pull/151252/files
Please reload this pagehttps://github.com/python/cpython/pull/151252/files
type.rst https://github.com/python/cpython/pull/151252/files#diff-04d16413dd014ab960bcc7e5f56e3e087da668393f6525d10d099e5a86020016
typeobj.rst https://github.com/python/cpython/pull/151252/files#diff-560c6b0fbef4ddae510a4f11e165d0cd179a52506b470cead404d2b53e48bbe1
removed-ids.txt https://github.com/python/cpython/pull/151252/files#diff-9d5c67c6df6acf7f5545d77dc9abef86d93a79002f94d2042d2d4bbe3b09e0fc
3.15.rst https://github.com/python/cpython/pull/151252/files#diff-bd7a9c5b54eeb2b40e6db5e48e8d79d309d8738e776a40918773c6840189edf9
test_misc.py https://github.com/python/cpython/pull/151252/files#diff-4178d53cac5b09685584df43c65b66797dd4ca4df491b2081565d95ba90aaa36
test_slots.py https://github.com/python/cpython/pull/151252/files#diff-6880f476bbba09ccf3d6eed9cc998079ae58ea74b3b25e090693cf58249e094b
2026-06-10-15-22-44.gh-issue-149044.O7KEcs.rst https://github.com/python/cpython/pull/151252/files#diff-5a3730427c996edcad5604d8e162a06a0dc74a89c9fbe476571306b4a1b036f5
slots.c https://github.com/python/cpython/pull/151252/files#diff-634e34ad823b1ecf61ebd06d54f0920d75b54df96cd22d352c85faf456d37f66
typeobject.c https://github.com/python/cpython/pull/151252/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L114
Doc/c-api/type.rsthttps://github.com/python/cpython/pull/151252/files#diff-04d16413dd014ab960bcc7e5f56e3e087da668393f6525d10d099e5a86020016
View file https://github.com/encukou/cpython/blob/1de19c528f982e29f7057953ab8d545b2d818ef2/Doc/c-api/type.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/151252/{{ revealButtonHref }}
https://github.com/python/cpython/pull/151252/files#diff-04d16413dd014ab960bcc7e5f56e3e087da668393f6525d10d099e5a86020016
https://github.com/python/cpython/pull/151252/files#diff-04d16413dd014ab960bcc7e5f56e3e087da668393f6525d10d099e5a86020016
https://github.com/python/cpython/pull/151252/files#diff-04d16413dd014ab960bcc7e5f56e3e087da668393f6525d10d099e5a86020016
https://github.com/python/cpython/pull/151252/files#diff-04d16413dd014ab960bcc7e5f56e3e087da668393f6525d10d099e5a86020016
https://github.com/python/cpython/pull/151252/files#diff-04d16413dd014ab960bcc7e5f56e3e087da668393f6525d10d099e5a86020016
https://github.com/python/cpython/pull/151252/files#diff-04d16413dd014ab960bcc7e5f56e3e087da668393f6525d10d099e5a86020016
https://github.com/python/cpython/pull/151252/files#diff-04d16413dd014ab960bcc7e5f56e3e087da668393f6525d10d099e5a86020016
https://github.com/python/cpython/pull/151252/files#diff-04d16413dd014ab960bcc7e5f56e3e087da668393f6525d10d099e5a86020016
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L114
Doc/c-api/typeobj.rsthttps://github.com/python/cpython/pull/151252/files#diff-560c6b0fbef4ddae510a4f11e165d0cd179a52506b470cead404d2b53e48bbe1
View file https://github.com/encukou/cpython/blob/1de19c528f982e29f7057953ab8d545b2d818ef2/Doc/c-api/typeobj.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/151252/{{ revealButtonHref }}
https://github.com/python/cpython/pull/151252/files#diff-560c6b0fbef4ddae510a4f11e165d0cd179a52506b470cead404d2b53e48bbe1
https://github.com/python/cpython/pull/151252/files#diff-560c6b0fbef4ddae510a4f11e165d0cd179a52506b470cead404d2b53e48bbe1
https://github.com/python/cpython/pull/151252/files#diff-560c6b0fbef4ddae510a4f11e165d0cd179a52506b470cead404d2b53e48bbe1
https://github.com/python/cpython/pull/151252/files#diff-560c6b0fbef4ddae510a4f11e165d0cd179a52506b470cead404d2b53e48bbe1
Doc/tools/removed-ids.txthttps://github.com/python/cpython/pull/151252/files#diff-9d5c67c6df6acf7f5545d77dc9abef86d93a79002f94d2042d2d4bbe3b09e0fc
View file https://github.com/encukou/cpython/blob/1de19c528f982e29f7057953ab8d545b2d818ef2/Doc/tools/removed-ids.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/151252/{{ revealButtonHref }}
https://github.com/python/cpython/pull/151252/files#diff-9d5c67c6df6acf7f5545d77dc9abef86d93a79002f94d2042d2d4bbe3b09e0fc
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L116
Doc/whatsnew/3.15.rsthttps://github.com/python/cpython/pull/151252/files#diff-bd7a9c5b54eeb2b40e6db5e48e8d79d309d8738e776a40918773c6840189edf9
View file https://github.com/encukou/cpython/blob/1de19c528f982e29f7057953ab8d545b2d818ef2/Doc/whatsnew/3.15.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/151252/{{ revealButtonHref }}
https://github.com/python/cpython/pull/151252/files#diff-bd7a9c5b54eeb2b40e6db5e48e8d79d309d8738e776a40918773c6840189edf9
https://github.com/python/cpython/pull/151252/files#diff-bd7a9c5b54eeb2b40e6db5e48e8d79d309d8738e776a40918773c6840189edf9
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L356
Lib/test/test_capi/test_misc.pyhttps://github.com/python/cpython/pull/151252/files#diff-4178d53cac5b09685584df43c65b66797dd4ca4df491b2081565d95ba90aaa36
View file https://github.com/encukou/cpython/blob/1de19c528f982e29f7057953ab8d545b2d818ef2/Lib/test/test_capi/test_misc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/151252/{{ revealButtonHref }}
https://github.com/python/cpython/pull/151252/files#diff-4178d53cac5b09685584df43c65b66797dd4ca4df491b2081565d95ba90aaa36
https://github.com/python/cpython/pull/151252/files#diff-4178d53cac5b09685584df43c65b66797dd4ca4df491b2081565d95ba90aaa36
Lib/test/test_capi/test_slots.pyhttps://github.com/python/cpython/pull/151252/files#diff-6880f476bbba09ccf3d6eed9cc998079ae58ea74b3b25e090693cf58249e094b
View file https://github.com/encukou/cpython/blob/1de19c528f982e29f7057953ab8d545b2d818ef2/Lib/test/test_capi/test_slots.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/151252/{{ revealButtonHref }}
https://github.com/python/cpython/pull/151252/files#diff-6880f476bbba09ccf3d6eed9cc998079ae58ea74b3b25e090693cf58249e094b
Misc/NEWS.d/next/C_API/2026-06-10-15-22-44.gh-issue-149044.O7KEcs.rsthttps://github.com/python/cpython/pull/151252/files#diff-5a3730427c996edcad5604d8e162a06a0dc74a89c9fbe476571306b4a1b036f5
View file https://github.com/encukou/cpython/blob/1de19c528f982e29f7057953ab8d545b2d818ef2/Misc/NEWS.d/next/C_API/2026-06-10-15-22-44.gh-issue-149044.O7KEcs.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/151252/{{ revealButtonHref }}
Modules/_testlimitedcapi/slots.chttps://github.com/python/cpython/pull/151252/files#diff-634e34ad823b1ecf61ebd06d54f0920d75b54df96cd22d352c85faf456d37f66
View file https://github.com/encukou/cpython/blob/1de19c528f982e29f7057953ab8d545b2d818ef2/Modules/_testlimitedcapi/slots.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/151252/{{ revealButtonHref }}
https://github.com/python/cpython/pull/151252/files#diff-634e34ad823b1ecf61ebd06d54f0920d75b54df96cd22d352c85faf456d37f66
https://github.com/python/cpython/pull/151252/files#diff-634e34ad823b1ecf61ebd06d54f0920d75b54df96cd22d352c85faf456d37f66
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L217
Objects/typeobject.chttps://github.com/python/cpython/pull/151252/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
View file https://github.com/encukou/cpython/blob/1de19c528f982e29f7057953ab8d545b2d818ef2/Objects/typeobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/151252/{{ revealButtonHref }}
https://github.com/python/cpython/pull/151252/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/151252/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/151252/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/151252/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/151252/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/151252/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/151252/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/151252/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.