René's URL Explorer Experiment


Title: gh-149044: Improve Py_tp_base[s] docs & error message for non-type bases by encukou · Pull Request #151252 · python/cpython · GitHub

Open Graph Title: gh-149044: Improve Py_tp_base[s] docs & error message for non-type bases by encukou · Pull Request #151252 · python/cpython

X Title: gh-149044: Improve Py_tp_base[s] docs & error message for non-type bases by encukou · Pull Request #151252 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: The initial implementation of PEP 820 worsened the error message when non-types are given as base types in Py_tp_bases & Py_tp_base (as Peter noted in the review). Bring back the 'bases mus...

X Description: The initial implementation of PEP 820 worsened the error message when non-types are given as base types in Py_tp_bases & Py_tp_base (as Peter noted in the review). Bring back the 'b...

Opengraph URL: https://github.com/python/cpython/pull/151252

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c827d9d3-ccf6-c705-979b-f344f263bde6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE72A:2D40DE:303DDD5:3D6DEF5:6B0205F6
html-safe-nonce5b3bf1688e717a30aa55aae156a3e5583de1942f867a3df9868c54ba6c9c6bd6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzJBOjJENDBERTozMDNEREQ1OjNENkRFRjU6NkIwMjA1RjYiLCJ2aXNpdG9yX2lkIjoiMjMwNDI3NDk1NzEwMzkyNDcyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace9716c03f5d6e192021de0bd873cd12e8d61226a475e827ecb40e6c62c4dbb40
hovercard-subject-tagpull_request:3839867639
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/151252/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/34c985ba859b31502791609ecde86e4ee752a0ea7832f5ec6ed7076bfb6b5abe/python/cpython/pull/151252
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/34c985ba859b31502791609ecde86e4ee752a0ea7832f5ec6ed7076bfb6b5abe/python/cpython/pull/151252
og:image:altThe initial implementation of PEP 820 worsened the error message when non-types are given as base types in Py_tp_bases & Py_tp_base (as Peter noted in the review). Bring back the 'bases mus...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/151252#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151252
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151252
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/151252
Reloadhttps://github.com/python/cpython/pull/151252
Reloadhttps://github.com/python/cpython/pull/151252
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:tp_base_unificationhttps://github.com/encukou/cpython/tree/tp_base_unification
Conversationhttps://github.com/python/cpython/pull/151252
Commits6 (6)https://github.com/python/cpython/pull/151252/commits
Checkshttps://github.com/python/cpython/pull/151252/checks
Files changedhttps://github.com/python/cpython/pull/151252/files
gh-149044: Improve Py_tp_base[s] docs & error message for non-type baseshttps://github.com/python/cpython/pull/151252#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:tp_base_unificationhttps://github.com/encukou/cpython/tree/tp_base_unification
https://github.com/encukou
encukouhttps://github.com/encukou
Jun 10, 2026https://github.com/python/cpython/pull/151252#issue-4631715631
Please reload this pagehttps://github.com/python/cpython/pull/151252
noted in the reviewhttps://github.com/python/cpython/pull/149055#discussion_r3182169798
Implement PEP 820 – PySlot: Unified slot system for the C API #149044https://github.com/python/cpython/issues/149044
Please reload this pagehttps://github.com/python/cpython/pull/151252
https://github.com/encukou
pythongh-149044https://github.com/python/cpython/issues/149044
: Improve Py_tp_base[s] docs & error message for non-t…https://github.com/python/cpython/pull/151252/commits/63d365a0cd7ca9b8c01e3770bdb8c7f25bf9b49b
63d365ahttps://github.com/python/cpython/pull/151252/commits/63d365a0cd7ca9b8c01e3770bdb8c7f25bf9b49b
https://github.com/encukou
encukouhttps://github.com/encukou
AA-Turnerhttps://github.com/AA-Turner
ZeroIntensityhttps://github.com/ZeroIntensity
markshannonhttps://github.com/markshannon
code ownershttps://github.com/python/cpython/blob/8c0e2515bb0059b75e264cc5baeb27bb17337c83/.github/CODEOWNERS#L116
June 10, 2026 13:33https://github.com/python/cpython/pull/151252#event-26576538854
https://github.com/encukou
encukouhttps://github.com/encukou
topic-C-API https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-C-API
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Jun 10, 2026https://github.com/python/cpython/pull/151252#event-26576539323
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 10, 2026https://github.com/python/cpython/pull/151252#event-26576542080
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 10, 2026 https://github.com/python/cpython/pull/151252#ref-issue-4334418004
Implement PEP 820 – PySlot: Unified slot system for the C API #149044 https://github.com/python/cpython/issues/149044
https://github.com/encukou
encukouhttps://github.com/encukou
Jun 10, 2026 https://github.com/python/cpython/pull/151252#ref-pullrequest-4337137719
gh-149044: Implement PEP 820 – PySlot: Unified slot system for the C API #149055 https://github.com/python/cpython/pull/149055
https://github.com/apps/read-the-docs-community
read-the-docs-communityhttps://github.com/apps/read-the-docs-community
Jun 10, 2026https://github.com/python/cpython/pull/151252#issuecomment-4670818239
Please reload this pagehttps://github.com/python/cpython/pull/151252
cpython-previewshttps://app.readthedocs.org/projects/cpython-previews/
#33091696https://app.readthedocs.org/projects/cpython-previews/builds/33091696/
1de19c5https://github.com/python/cpython/commit/1de19c528f982e29f7057953ab8d545b2d818ef2
mainhttps://cpython-previews.readthedocs.io/en/main/
8c0e251https://github.com/python/cpython/commit/8c0e2515bb0059b75e264cc5baeb27bb17337c83
  🔍 Preview build   https://cpython-previews--151252.org.readthedocs.build/en/151252/
library/asyncio-threading.htmlhttps://cpython-previews--151252.org.readthedocs.build/en/151252/library/asyncio-threading.html
c-api/stable.htmlhttps://cpython-previews--151252.org.readthedocs.build/en/151252/c-api/stable.html
c-api/type.htmlhttps://cpython-previews--151252.org.readthedocs.build/en/151252/c-api/type.html
c-api/typeobj.htmlhttps://cpython-previews--151252.org.readthedocs.build/en/151252/c-api/typeobj.html
howto/annotations.htmlhttps://cpython-previews--151252.org.readthedocs.build/en/151252/howto/annotations.html
howto/argparse.htmlhttps://cpython-previews--151252.org.readthedocs.build/en/151252/howto/argparse.html
howto/curses.htmlhttps://cpython-previews--151252.org.readthedocs.build/en/151252/howto/curses.html
howto/descriptor.htmlhttps://cpython-previews--151252.org.readthedocs.build/en/151252/howto/descriptor.html
howto/functional.htmlhttps://cpython-previews--151252.org.readthedocs.build/en/151252/howto/functional.html
howto/instrumentation.htmlhttps://cpython-previews--151252.org.readthedocs.build/en/151252/howto/instrumentation.html
howto/ipaddress.htmlhttps://cpython-previews--151252.org.readthedocs.build/en/151252/howto/ipaddress.html
Please reload this pagehttps://github.com/python/cpython/pull/151252
encukouhttps://github.com/encukou
June 10, 2026 16:00https://github.com/python/cpython/pull/151252#commits-pushed-b5e1cea
https://github.com/encukou
Correct PyType_Spec member linkshttps://github.com/python/cpython/pull/151252/commits/b5e1ceae3f5d591b81ab327ab3be1855b009280d
b5e1ceahttps://github.com/python/cpython/pull/151252/commits/b5e1ceae3f5d591b81ab327ab3be1855b009280d
https://github.com/encukou
Add :c:https://github.com/python/cpython/pull/151252/commits/c0105b9d6f2a8aa013dfe8f8bd5d701955254e8a
c0105b9https://github.com/python/cpython/pull/151252/commits/c0105b9d6f2a8aa013dfe8f8bd5d701955254e8a
https://github.com/encukou
Merge in the main branchhttps://github.com/python/cpython/pull/151252/commits/46499935795e937cd9e4fe17086aa90847ea6cdd
4649993https://github.com/python/cpython/pull/151252/commits/46499935795e937cd9e4fe17086aa90847ea6cdd
https://github.com/encukou
Update removed-ids.txthttps://github.com/python/cpython/pull/151252/commits/0ca84f8a761bb2fc81aec39fbe08cd7b010477cb
0ca84f8https://github.com/python/cpython/pull/151252/commits/0ca84f8a761bb2fc81aec39fbe08cd7b010477cb
https://github.com/encukou
Merge in the main branchhttps://github.com/python/cpython/pull/151252/commits/1de19c528f982e29f7057953ab8d545b2d818ef2
1de19c5https://github.com/python/cpython/pull/151252/commits/1de19c528f982e29f7057953ab8d545b2d818ef2
https://github.com/encukou
encukouhttps://github.com/encukou
StanFromIrelandhttps://github.com/StanFromIreland
hugovkhttps://github.com/hugovk
code ownershttps://github.com/python/cpython/blob/2d3381035df24fbf512d897daa19a1040f7af3fd/.github/CODEOWNERS#L108
June 11, 2026 10:27https://github.com/python/cpython/pull/151252#event-26620083406
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 13, 2026 https://github.com/python/cpython/pull/151252#pullrequestreview-4491315556
View reviewed changes https://github.com/python/cpython/pull/151252/files/1de19c528f982e29f7057953ab8d545b2d818ef2
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 13, 2026https://github.com/python/cpython/pull/151252#event-26707364786
https://github.com/encukou
encukouhttps://github.com/encukou
16185e9https://github.com/python/cpython/commit/16185e9fe2037d2171626f79c3d099bd7772b53e
Jun 17, 2026https://github.com/python/cpython/pull/151252#event-26862662925
Please reload this pagehttps://github.com/python/cpython/pull/151252
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jun 17, 2026https://github.com/python/cpython/pull/151252#issuecomment-4730735565
@encukouhttps://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/151252
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jun 17, 2026https://github.com/python/cpython/pull/151252#event-26862665984
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 17, 2026https://github.com/python/cpython/pull/151252#issuecomment-4730738841
GH-151606https://github.com/python/cpython/pull/151606
3.15 branchhttps://github.com/python/cpython/tree/3.15
Please reload this pagehttps://github.com/python/cpython/pull/151252
https://github.com/encukou
encukouhttps://github.com/encukou
June 17, 2026 13:27https://github.com/python/cpython/pull/151252#event-26862680597
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.15 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.15%22
Jun 17, 2026https://github.com/python/cpython/pull/151252#event-26862681603
philthompson10https://github.com/philthompson10
Jun 17, 2026 https://github.com/python/cpython/pull/151252#ref-commit-95034cc
https://github.com/encukou
https://github.com/philthompson10
pythongh-149044https://github.com/python/cpython/issues/149044
: Improve Py_tp_base[s] docs & error message for non-t…https://github.com/philthompson10/cpython/commit/95034cce258bd9adade917008db06b110b50c1f9
95034cchttps://github.com/philthompson10/cpython/commit/95034cce258bd9adade917008db06b110b50c1f9
pythonGH-151252https://github.com/python/cpython/pull/151252
encukouhttps://github.com/encukou
Jun 18, 2026 https://github.com/python/cpython/pull/151252#ref-commit-e9c7cc1
https://github.com/miss-islington
https://github.com/encukou
[3.15]https://github.com/python/cpython/commit/e9c7cc1f0b67a582cb44791d72ce0b858f937e0d
gh-149044https://github.com/python/cpython/issues/149044
: Improve Py_tp_base[s] docs & error message for non-…https://github.com/python/cpython/commit/e9c7cc1f0b67a582cb44791d72ce0b858f937e0d
e9c7cc1https://github.com/python/cpython/commit/e9c7cc1f0b67a582cb44791d72ce0b858f937e0d
GH-151252https://github.com/python/cpython/pull/151252
GH-151606https://github.com/python/cpython/pull/151606
gh-149044https://github.com/python/cpython/issues/149044
GH-151252https://github.com/python/cpython/pull/151252
16185e9https://github.com/python/cpython/commit/16185e9fe2037d2171626f79c3d099bd7772b53e
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 18, 2026https://github.com/python/cpython/pull/151252#issuecomment-4739755990
e9c7cc1https://github.com/python/cpython/commit/e9c7cc1f0b67a582cb44791d72ce0b858f937e0d
the buildbot page in the devguidehttps://devguide.python.org/buildbots/
https://buildbot.python.org/#/builders/2019/builds/205https://buildbot.python.org/#/builders/2019/builds/205
e9c7cc1https://github.com/python/cpython/commit/e9c7cc1f0b67a582cb44791d72ce0b858f937e0d
https://buildbot.python.org/#/builders/2019/builds/205https://buildbot.python.org/#/builders/2019/builds/205
Please reload this pagehttps://github.com/python/cpython/pull/151252
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151252
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/151252/files/1de19c528f982e29f7057953ab8d545b2d818ef2
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/AA-Turner
AA-Turner https://github.com/AA-Turner
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
https://github.com/hugovk
hugovk https://github.com/hugovk
https://github.com/StanFromIreland
StanFromIreland https://github.com/StanFromIreland
Please reload this pagehttps://github.com/python/cpython/pull/151252
topic-C-API https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-C-API
Please reload this pagehttps://github.com/python/cpython/pull/151252
https://github.com/encukou
https://github.com/bedevere-bot
https://github.com/serhiy-storchaka
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.