René's URL Explorer Experiment


Title: gh-150942: Speed up ElementTree attribute parsing by deadlovelll · Pull Request #151209 · python/cpython · GitHub

Open Graph Title: gh-150942: Speed up ElementTree attribute parsing by deadlovelll · Pull Request #151209 · python/cpython

X Title: gh-150942: Speed up ElementTree attribute parsing by deadlovelll · Pull Request #151209 · python/cpython

Description: expat_start_handler() in Modules/_elementtree.c calls a PyDict_SetItem() and two Py_DECREF() while building attrib dictionary. Replaced it with reference-stealing _PyDict_SetItem_Take2(), dropped the pair of Py_DECREF(). Benchmark: import pyperf import xml.etree.ElementTree as ET def make_doc(n_elements, n_attrs): attrs = " ".join(f'a{i}="v{i}"' for i in range(n_attrs)) body = "".join(f"" for _ in range(n_elements)) return f"{body}" DOCS = { "many-attrs-per-elem": make_doc(n_elements=2000, n_attrs=16), "few-attrs-many-elems": make_doc(n_elements=20000, n_attrs=2), "wide-attrs": make_doc(n_elements=200, n_attrs=64), } if __name__ == "__main__": runner = pyperf.Runner() for name, xml in DOCS.items(): runner.bench_func(f"ET.fromstring {name}", ET.fromstring, xml) Results: +------------------------------------+---------+-----------------------+ | Benchmark | base | opt | +====================================+=========+=======================+ | ET.fromstring many-attrs-per-elem | 9.07 ms | 8.51 ms: 1.07x faster | +------------------------------------+---------+-----------------------+ | ET.fromstring few-attrs-many-elems | 20.3 ms | 19.6 ms: 1.03x faster | +------------------------------------+---------+-----------------------+ | ET.fromstring wide-attrs | 3.29 ms | 3.08 ms: 1.07x faster | +------------------------------------+---------+-----------------------+ | Geometric mean | (ref) | 1.06x faster | +------------------------------------+---------+-----------------------+ Issue: gh-150942

Open Graph Description: expat_start_handler() in Modules/_elementtree.c calls a PyDict_SetItem() and two Py_DECREF() while building attrib dictionary. Replaced it with reference-stealing _PyDict_SetItem_Take2(), dropped t...

X Description: expat_start_handler() in Modules/_elementtree.c calls a PyDict_SetItem() and two Py_DECREF() while building attrib dictionary. Replaced it with reference-stealing _PyDict_SetItem_Take2(), dropped t...

Opengraph URL: https://github.com/python/cpython/pull/151209

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e1a4edfb-b1e7-29a2-933f-7a33f3fde995
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA118:213839:3E84642:4FCB710:6B020A42
html-safe-nonce096c2abb1005b27d8d2f32795ab0d6d9081756a2255d3e569885c5f6a452f881
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTE4OjIxMzgzOTozRTg0NjQyOjRGQ0I3MTA6NkIwMjBBNDIiLCJ2aXNpdG9yX2lkIjoiMTUzMjc3MTgxOTk2OTQ0ODUxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf5347856a31989cef3d45eb5b15b1355e933aab65ebf109ea7049d4e009b987e
hovercard-subject-tagpull_request:3834321271
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/151209/files
twitter:imagehttps://avatars.githubusercontent.com/u/128279579?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/128279579?s=400&v=4
og:image:altexpat_start_handler() in Modules/_elementtree.c calls a PyDict_SetItem() and two Py_DECREF() while building attrib dictionary. Replaced it with reference-stealing _PyDict_SetItem_Take2(), dropped t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/151209/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151209%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F151209%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/151209/files
Reloadhttps://github.com/python/cpython/pull/151209/files
Reloadhttps://github.com/python/cpython/pull/151209/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
deadlovelllhttps://github.com/deadlovelll
python:mainhttps://github.com/python/cpython/tree/main
deadlovelll:gh-150942-elementtree-attrib-take2https://github.com/deadlovelll/cpython/tree/gh-150942-elementtree-attrib-take2
Conversation 6 https://github.com/python/cpython/pull/151209
Commits 2 https://github.com/python/cpython/pull/151209/commits
Checks 49 https://github.com/python/cpython/pull/151209/checks
Files changed 1 https://github.com/python/cpython/pull/151209/files
gh-150942: Speed up ElementTree attribute parsing https://github.com/python/cpython/pull/151209/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/151209/files
8ac090f gh-150942: Speed up ElementTree attribute parsing deadlovelll Jun 9, 2026 https://github.com/python/cpython/pull/151209/commits/8ac090f759e265ff5346cd81b7629c0c93d77bff
09b5284 Remove news entry deadlovelll Jun 9, 2026 https://github.com/python/cpython/pull/151209/commits/09b5284f7ff6d9e19e65b2dee996e54ae6a7b776
Clear filters https://github.com/python/cpython/pull/151209/files
Please reload this pagehttps://github.com/python/cpython/pull/151209/files
Please reload this pagehttps://github.com/python/cpython/pull/151209/files
Modules/_elementtree.chttps://github.com/python/cpython/pull/151209/files#diff-72f80c6ac0294ae74c7b014c12bcf229e9df089ab19018ea35fd61c58fdb69ac
View file https://github.com/python/cpython/blob/09b5284f7ff6d9e19e65b2dee996e54ae6a7b776/Modules/_elementtree.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/151209/{{ revealButtonHref }}
https://github.com/python/cpython/pull/151209/files#diff-72f80c6ac0294ae74c7b014c12bcf229e9df089ab19018ea35fd61c58fdb69ac
https://github.com/python/cpython/pull/151209/files#diff-72f80c6ac0294ae74c7b014c12bcf229e9df089ab19018ea35fd61c58fdb69ac
Please reload this pagehttps://github.com/python/cpython/pull/151209/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.