René's URL Explorer Experiment

Title: gh-151126: Add missing `PyErr_NoMemory` in `_winapi` module by sobolevn · Pull Request #151154 · python/cpython · GitHub

Open Graph Title: gh-151126: Add missing `PyErr_NoMemory` in `_winapi` module by sobolevn · Pull Request #151154 · python/cpython

X Title: gh-151126: Add missing `PyErr_NoMemory` in `_winapi` module by sobolevn · Pull Request #151154 · python/cpython

Description: This place misses it: cpython/Modules/_winapi.c Lines 1196 to 1198 in 9fdbade ret = PyMem_Malloc(*size); if (ret == NULL) goto cleanup; It is used as: attribute_list->handle_list = gethandlelist(value, "handle_list", &handle_list_size); if (attribute_list->handle_list == NULL && PyErr_Occurred()) { ret = -1; goto cleanup; } It would be rather strange to swallow MemoryError here. Before that we allow KeyError to pass silently and return early if this code path should not be taken: value = PyMapping_GetItemString(mapping, name); if (!value) { PyErr_Clear(); return NULL; } All other error paths in the same function set exceptions, except this if: cpython/Modules/_winapi.c Lines 1278 to 1282 in 9fdbade attribute_list->attribute_list = PyMem_Malloc(attribute_list_size); if (attribute_list->attribute_list == NULL) { ret = -1; goto cleanup; } Later this NULL is returned from _winapi.CreateProcess without an exception set. Issue: gh-151126

Open Graph Description: This place misses it: cpython/Modules/_winapi.c Lines 1196 to 1198 in 9fdbade ret = PyMem_Malloc(*size);...

X Description: This place misses it: cpython/Modules/_winapi.c Lines 1196 to 1198 in 9fdbade ret = PyMem_Malloc(*size);...

Opengraph URL: https://github.com/python/cpython/pull/151154

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width