Title: gh-150942: Speed up frame local item collection by omkar-334 · Pull Request #151002 · python/cpython · GitHub
Open Graph Title: gh-150942: Speed up frame local item collection by omkar-334 · Pull Request #151002 · python/cpython
X Title: gh-150942: Speed up frame local item collection by omkar-334 · Pull Request #151002 · python/cpython
Description: Use _PyList_AppendTakeRef while collecting frame-local (name, value) pairs instead of PyList_Append followed by Py_DECREF, removing an incref/decref pair per returned item pair. benchmarks Benchmark main this PR speedup frame_locals_items_100locals 9.09 ms 8.61 ms 1.06x frame_locals_items_1000locals 17.19 ms 16.59 ms 1.04x frame_locals_items_5000locals 29.92 ms 28.94 ms 1.03x geomean 1.04x Benchmark script """Micro-benchmark for frame.f_locals.items() result-list building.""" from __future__ import annotations import argparse import json import statistics import sys import time from pathlib import Path def make_frame(local_count: int): assignments = "\n".join(f" v{i} = {i}" for i in range(local_count)) src = ( "def make_frame():\n" f"{assignments}\n" " return sys._getframe()\n" ) ns = {"sys": sys} exec(src, ns) return ns["make_frame"]() def time_items(frame, loops: int) -> float: t0 = time.perf_counter_ns() for _ in range(loops): frame.f_locals.items() return (time.perf_counter_ns() - t0) / 1e9 def main() -> int: ap = argparse.ArgumentParser() ap.add_argument("--locals", type=int, default=1_000) ap.add_argument("--loops", type=int, default=2_000) ap.add_argument("--trials", type=int, default=15) ap.add_argument("--warmup", type=int, default=3) ap.add_argument("--label", default="run") ap.add_argument("--outdir", default="results/frame-locals-items") args = ap.parse_args() frame = make_frame(args.locals) item_count = len(frame.f_locals.items()) for _ in range(args.warmup): time_items(frame, args.loops) trials = [time_items(frame, args.loops) for _ in range(args.trials)] outdir = Path(args.outdir) outdir.mkdir(parents=True, exist_ok=True) summary = { "label": args.label, "python": sys.executable, "locals": args.locals, "item_count": item_count, "loops": args.loops, "trials": args.trials, "warmup": args.warmup, "items_built": item_count * args.loops, "seconds": { "min": min(trials), "median": statistics.median(trials), "mean": statistics.fmean(trials), "stdev": statistics.pstdev(trials), "all": trials, }, "items_per_sec_at_min": (item_count * args.loops) / min(trials), } out = outdir / f"bench_{args.label}.json" out.write_text(json.dumps(summary, indent=2)) s = summary["seconds"] print( f"{args.label}: min={s['min']*1000:.2f}ms median={s['median']*1000:.2f}ms " f"mean={s['mean']*1000:.2f}ms stdev={s['stdev']*1000:.2f}ms " f"items/s@min={summary['items_per_sec_at_min']:.2e}" ) print(f"wrote {out}") return 0 if __name__ == "__main__": raise SystemExit(main()) Issue: gh-150942
Open Graph Description: Use _PyList_AppendTakeRef while collecting frame-local (name, value) pairs instead of PyList_Append followed by Py_DECREF, removing an incref/decref pair per returned item pair. benchmarks Bench...
X Description: Use _PyList_AppendTakeRef while collecting frame-local (name, value) pairs instead of PyList_Append followed by Py_DECREF, removing an incref/decref pair per returned item pair. benchmarks Bench...
Opengraph URL: https://github.com/python/cpython/pull/151002
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3bcd4dd3-550c-0a0a-b89d-6f5e97ec0b97 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C9A0:928E2:366730E:487F074:6B020C68 |
| html-safe-nonce | 672795dc5b5cd144ca7d03cc74e552f233d97324e3089b2af5d886bac4d97ae3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUEwOjkyOEUyOjM2NjczMEU6NDg3RjA3NDo2QjAyMEM2OCIsInZpc2l0b3JfaWQiOiIxMDA1Mjc2NjE5NzEzMTU0MTUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 62549a0092bca6b9d54e242a4f145af985ad60c452227a6271e9f4162d6b84d7 |
| hovercard-subject-tag | pull_request:3814159383 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/151002/files |
| twitter:image | https://avatars.githubusercontent.com/u/40126336?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40126336?s=400&v=4 |
| og:image:alt | Use _PyList_AppendTakeRef while collecting frame-local (name, value) pairs instead of PyList_Append followed by Py_DECREF, removing an incref/decref pair per returned item pair. benchmarks Bench... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width