| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3c672cb9-b9f0-6030-27ed-6104a88f18ab |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A990:381E5:A4DD8:E187F:6A5059F2 |
| html-safe-nonce | ea67ea6d044fb5e297d8e787adae5a8910edbf325feb1fea9144904b8bfc0565 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTkwOjM4MUU1OkE0REQ4OkUxODdGOjZBNTA1OUYyIiwidmlzaXRvcl9pZCI6IjY0OTkzMzg3NDk2OTE4NDUxMDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 37de71e5cc8ef63aac163f5a5918e679a50e955cc7ebdc6b82a03274f7e0c858 |
| hovercard-subject-tag | pull_request:3750019019 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/150489/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/18d540bee733c0a047fd60d12efabec6ffd7627a0b08fb16f74847d0e43a975d/python/cpython/pull/150489 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/18d540bee733c0a047fd60d12efabec6ffd7627a0b08fb16f74847d0e43a975d/python/cpython/pull/150489 |
| og:image:alt | When we insert into a split dictionary we update the shared keys version - this is used to invalidate caches for loading methods and loading class values and requires us to check the keys version. ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DinoV |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/150489#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F150489 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F150489 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/150489 |
| Reload | https://github.com/python/cpython/pull/150489 |
| Reload | https://github.com/python/cpython/pull/150489 |
| Please reload this page | https://github.com/python/cpython/pull/150489 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/150489 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| DinoV | https://github.com/DinoV |
| python:main | https://github.com/python/cpython/tree/main |
| DinoV:sharedkeys_type | https://github.com/DinoV/cpython/tree/sharedkeys_type |
| Conversation | https://github.com/python/cpython/pull/150489 |
| Commits2 (2) | https://github.com/python/cpython/pull/150489/commits |
| Checks | https://github.com/python/cpython/pull/150489/checks |
| Files changed | https://github.com/python/cpython/pull/150489/files |
| gh-150490: Raise PyType_Modified for insertion into split dictionary | https://github.com/python/cpython/pull/150489#top |
| DinoV | https://github.com/DinoV |
| python:main | https://github.com/python/cpython/tree/main |
| DinoV:sharedkeys_type | https://github.com/DinoV/cpython/tree/sharedkeys_type |
|
| https://github.com/DinoV |
| DinoV | https://github.com/DinoV |
| May 26, 2026 | https://github.com/python/cpython/pull/150489#issue-4526362728 |
| Please reload this page | https://github.com/python/cpython/pull/150489 |
| Raise PyType_Modified on split key insertion to avoid cached keys version check #150490 | https://github.com/python/cpython/issues/150490 |
| Please reload this page | https://github.com/python/cpython/pull/150489 |
| https://github.com/DinoV |
| DinoV | https://github.com/DinoV |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| May 26, 2026 | https://github.com/python/cpython/pull/150489#event-25979988864 |
| https://github.com/DinoV |
| DinoV | https://github.com/DinoV |
| May 26, 2026 | https://github.com/python/cpython/pull/150489#event-25980016853 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
May 26, 2026
| https://github.com/python/cpython/pull/150489#ref-issue-4526368821 |
|
Raise PyType_Modified on split key insertion to avoid cached keys version check
#150490
| https://github.com/python/cpython/issues/150490 |
| https://github.com/DinoV |
| DinoV | https://github.com/DinoV |
| force-pushed | https://github.com/python/cpython/compare/226cf2912fc401735af9358270576a252c1013d3..8406f6f4eb907b6cd68ff853b5ec8e89e1a6925e |
| 226cf29 | https://github.com/python/cpython/commit/226cf2912fc401735af9358270576a252c1013d3 |
| 8406f6f | https://github.com/python/cpython/commit/8406f6f4eb907b6cd68ff853b5ec8e89e1a6925e |
|
Compare
| https://github.com/python/cpython/compare/226cf2912fc401735af9358270576a252c1013d3..8406f6f4eb907b6cd68ff853b5ec8e89e1a6925e |
| May 26, 2026 20:17 | https://github.com/python/cpython/pull/150489#event-25984871283 |
| https://github.com/DinoV |
| DinoV | https://github.com/DinoV |
| May 26, 2026 20:52 | https://github.com/python/cpython/pull/150489#event-25986065120 |
| https://github.com/DinoV |
| DinoV | https://github.com/DinoV |
| markshannon | https://github.com/markshannon |
| methane | https://github.com/methane |
| code owners | https://github.com/python/cpython/blob/8ab7b43a14bed4780febbd7586a41cfe459aa6d5/.github/CODEOWNERS#L215 |
| May 26, 2026 20:52 | https://github.com/python/cpython/pull/150489#event-25986065525 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| May 26, 2026 | https://github.com/python/cpython/pull/150489#event-25986067127 |
| https://github.com/markshannon |
| markshannon | https://github.com/markshannon |
|
May 28, 2026
| https://github.com/python/cpython/pull/150489#pullrequestreview-4383179192 |
|
View reviewed changes
| https://github.com/python/cpython/pull/150489/files |
| markshannon | https://github.com/markshannon |
| https://github.com/python/cpython/pull/150489#pullrequestreview-4383179192 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/150489 |
| Include/internal/pycore_dict.h | https://github.com/python/cpython/pull/150489/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4 |
| Please reload this page | https://github.com/python/cpython/pull/150489 |
| Lib/test/test_capi/test_opt.py | https://github.com/python/cpython/pull/150489/files#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439 |
| Please reload this page | https://github.com/python/cpython/pull/150489 |
| Objects/dictobject.c | https://github.com/python/cpython/pull/150489/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae |
| markshannon | https://github.com/markshannon |
| May 28, 2026 | https://github.com/python/cpython/pull/150489#discussion_r3319586277 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/150489 |
| DinoV | https://github.com/DinoV |
| May 28, 2026 | https://github.com/python/cpython/pull/150489#discussion_r3320294297 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/150489 |
| DinoV | https://github.com/DinoV |
| June 5, 2026 10:39 | https://github.com/python/cpython/pull/150489#commits-pushed-2d9799f |
|
| https://github.com/DinoV |
| Raise PyType_Modified for insertion into split dictionary | https://github.com/python/cpython/pull/150489/commits/2d9799fa7101b730ae27ebd0f83bcb18d2b10f65 |
| 2d9799f | https://github.com/python/cpython/pull/150489/commits/2d9799fa7101b730ae27ebd0f83bcb18d2b10f65 |
|
| https://github.com/DinoV |
| Bring back tests | https://github.com/python/cpython/pull/150489/commits/fabf182924a8a9b8204abcb049d2d74fe50aa0b1 |
| fabf182 | https://github.com/python/cpython/pull/150489/commits/fabf182924a8a9b8204abcb049d2d74fe50aa0b1 |
| https://github.com/DinoV |
| DinoV | https://github.com/DinoV |
| force-pushed | https://github.com/python/cpython/compare/c933107ac386c582427d0b0f3a5d94d741933192..fabf182924a8a9b8204abcb049d2d74fe50aa0b1 |
| c933107 | https://github.com/python/cpython/commit/c933107ac386c582427d0b0f3a5d94d741933192 |
| fabf182 | https://github.com/python/cpython/commit/fabf182924a8a9b8204abcb049d2d74fe50aa0b1 |
|
Compare
| https://github.com/python/cpython/compare/c933107ac386c582427d0b0f3a5d94d741933192..fabf182924a8a9b8204abcb049d2d74fe50aa0b1 |
| June 5, 2026 17:40 | https://github.com/python/cpython/pull/150489#event-26396534090 |
| https://github.com/markshannon |
| markshannon | https://github.com/markshannon |
|
Jun 11, 2026
| https://github.com/python/cpython/pull/150489#pullrequestreview-4477679020 |
|
View reviewed changes
| https://github.com/python/cpython/pull/150489/files/fabf182924a8a9b8204abcb049d2d74fe50aa0b1 |
| markshannon | https://github.com/markshannon |
| https://github.com/python/cpython/pull/150489#pullrequestreview-4477679020 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #142889 | https://github.com/python/cpython/issues/142889 |
| Please reload this page | https://github.com/python/cpython/pull/150489 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jun 11, 2026 | https://github.com/python/cpython/pull/150489#event-26630372240 |
| https://github.com/DinoV |
| DinoV | https://github.com/DinoV |
| efb2fff | https://github.com/python/cpython/commit/efb2fffae1fc728a5467672e6781cdf2df9bfec3 |
| Jun 11, 2026 | https://github.com/python/cpython/pull/150489#event-26636402955 |
| Please reload this page | https://github.com/python/cpython/pull/150489 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Jun 11, 2026 | https://github.com/python/cpython/pull/150489#event-26636405231 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Jun 17, 2026 | https://github.com/python/cpython/pull/150489#issuecomment-4731749459 |
| gh-151593 | https://github.com/python/cpython/issues/151593 |
| Please reload this page | https://github.com/python/cpython/pull/150489 |
| philthompson10 | https://github.com/philthompson10 |
|
Jun 17, 2026
| https://github.com/python/cpython/pull/150489#ref-commit-d0d4e35 |
|
| https://github.com/DinoV |
|
| https://github.com/philthompson10 |
| pythongh-150490 | https://github.com/python/cpython/issues/150490 |
| : Raise PyType_Modified for insertion into split dicti… | https://github.com/philthompson10/cpython/commit/d0d4e3500ab6f8b3a73d86b0eacd5893d58c1895 |
| d0d4e35 | https://github.com/philthompson10/cpython/commit/d0d4e3500ab6f8b3a73d86b0eacd5893d58c1895 |
| python#150489 | https://github.com/python/cpython/pull/150489 |
|
gh-151593: Avoid deadlock in insert_split_key().
#152133
| https://github.com/python/cpython/pull/152133 |
|
gh-152238: Revert gh-150490 and gh-152200.
#152232
| https://github.com/python/cpython/pull/152232 |
| nascheme | https://github.com/nascheme |
|
Jun 26, 2026
| https://github.com/python/cpython/pull/150489#ref-commit-9626ef8 |
|
| https://github.com/nascheme |
| gh-152238 | https://github.com/python/cpython/issues/152238 |
| : Revert | https://github.com/python/cpython/commit/9626ef87f42fca564c3a74109b370d38076a79da |
| gh-150490 | https://github.com/python/cpython/issues/150490 |
| and | https://github.com/python/cpython/commit/9626ef87f42fca564c3a74109b370d38076a79da |
| gh-152200 | https://github.com/python/cpython/pull/152200 |
| . ( | https://github.com/python/cpython/commit/9626ef87f42fca564c3a74109b370d38076a79da |
| gh-152232 | https://github.com/python/cpython/pull/152232 |
| ) | https://github.com/python/cpython/commit/9626ef87f42fca564c3a74109b370d38076a79da |
| 9626ef8 | https://github.com/python/cpython/commit/9626ef87f42fca564c3a74109b370d38076a79da |
| gh-151593 | https://github.com/python/cpython/issues/151593 |
| #152200 | https://github.com/python/cpython/pull/152200 |
| gh-150490 | https://github.com/python/cpython/issues/150490 |
| #150489 | https://github.com/python/cpython/pull/150489 |
| gh-150489 | https://github.com/python/cpython/pull/150489 |
| gh-151593 | https://github.com/python/cpython/issues/151593 |
| gh-152200 | https://github.com/python/cpython/pull/152200 |
| https://github.com/DinoV |
| DinoV | https://github.com/DinoV |
|
Jul 2, 2026
| https://github.com/python/cpython/pull/150489#ref-pullrequest-4797182288 |
|
gh-150490: Raise PyType_Modified for insertion into split dictionary (take 2)
#152914
| https://github.com/python/cpython/pull/152914 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F150489 |
|
| https://github.com/markshannon |
|
markshannon
| https://github.com/markshannon |
|
| https://github.com/python/cpython/pull/150489/files/fabf182924a8a9b8204abcb049d2d74fe50aa0b1 |
|
| https://github.com/methane |
|
methane
| https://github.com/methane |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/150489 |
|
| https://github.com/DinoV |
|
| https://github.com/vstinner |
|
| https://github.com/markshannon |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |