René's URL Explorer Experiment


Title: [3.14] gh-145235: Make dict watcher API thread-safe for free-threaded builds (gh-145233) by colesbury · Pull Request #149691 · python/cpython · GitHub

Open Graph Title: [3.14] gh-145235: Make dict watcher API thread-safe for free-threaded builds (gh-145233) by colesbury · Pull Request #149691 · python/cpython

X Title: [3.14] gh-145235: Make dict watcher API thread-safe for free-threaded builds (gh-145233) by colesbury · Pull Request #149691 · python/cpython

Description: In free-threaded builds, concurrent calls to PyDict_AddWatcher, PyDict_ClearWatcher, PyDict_Watch, and PyDict_Unwatch can race on the shared callback array and the per-dict watcher tags. This change adds a mutex to serialize watcher registration and removal, atomic operations for tag updates, and atomic acquire/release synchronization for callback dispatch in _PyDict_SendEvent. (cherry picked from commit 8a48959) Issue: gh-145235

Open Graph Description: In free-threaded builds, concurrent calls to PyDict_AddWatcher, PyDict_ClearWatcher, PyDict_Watch, and PyDict_Unwatch can race on the shared callback array and the per-dict watcher tags. This chang...

X Description: In free-threaded builds, concurrent calls to PyDict_AddWatcher, PyDict_ClearWatcher, PyDict_Watch, and PyDict_Unwatch can race on the shared callback array and the per-dict watcher tags. This chang...

Opengraph URL: https://github.com/python/cpython/pull/149691

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:62459b6d-6513-fb70-e40f-40020c4aee0d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCFE:29AEE8:36C0D32:48E5BCF:6B020B18
html-safe-noncedbce812a9e13f4321165dd2bf4a84061751ace536bbc1a5cc062c7912a608200
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0ZFOjI5QUVFODozNkMwRDMyOjQ4RTVCQ0Y6NkIwMjBCMTgiLCJ2aXNpdG9yX2lkIjoiNzM3MjMwMzQ5MjcwNDI0MjQ1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac914e379928e9b380500b120990b9b8f3a1dc26a8476c0c83f860ba2c1af74614
hovercard-subject-tagpull_request:3663394898
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/149691/files
twitter:imagehttps://avatars.githubusercontent.com/u/655866?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/655866?s=400&v=4
og:image:altIn free-threaded builds, concurrent calls to PyDict_AddWatcher, PyDict_ClearWatcher, PyDict_Watch, and PyDict_Unwatch can race on the shared callback array and the per-dict watcher tags. This chang...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/149691/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149691%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149691%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/149691/files
Reloadhttps://github.com/python/cpython/pull/149691/files
Reloadhttps://github.com/python/cpython/pull/149691/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
colesburyhttps://github.com/colesbury
python:3.14https://github.com/python/cpython/tree/3.14
colesbury:backport-8a48959-3.14https://github.com/colesbury/cpython/tree/backport-8a48959-3.14
Conversation 1 https://github.com/python/cpython/pull/149691
Commits 2 https://github.com/python/cpython/pull/149691/commits
Checks 62 https://github.com/python/cpython/pull/149691/checks
Files changed https://github.com/python/cpython/pull/149691/files
Please reload this pagehttps://github.com/python/cpython/pull/149691/files
[3.14] gh-145235: Make dict watcher API thread-safe for free-threaded builds (gh-145233) https://github.com/python/cpython/pull/149691/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/149691/files
03624a4 [3.14] gh-145235: Make dict watcher API thread-safe for free-threaded… yoney May 11, 2026 https://github.com/python/cpython/pull/149691/commits/03624a45e5e964786c78c6bffd14774b953eb22c
50e2ab0 Regenerate abidump colesbury May 11, 2026 https://github.com/python/cpython/pull/149691/commits/50e2ab0ff1af3efe09165db6af9c8a16c02c8e5a
Clear filters https://github.com/python/cpython/pull/149691/files
Please reload this pagehttps://github.com/python/cpython/pull/149691/files
Please reload this pagehttps://github.com/python/cpython/pull/149691/files
python3.14.abi https://github.com/python/cpython/pull/149691/files#diff-711df0c7d042eea79c175d0e4cc95952e43addfc4538d0765565e776c6cc01bd
pycore_dict_state.h https://github.com/python/cpython/pull/149691/files#diff-3263c8b16705dc3ea3e56b42dbbc78ab240468ecf9c572eddc3a417dc986a4c7
pycore_pyatomic_ft_wrappers.h https://github.com/python/cpython/pull/149691/files#diff-ce601684210b2d7f8f955bb70eb6836e92f54d7d0ec6cd87e6d9da2b974ab7f7
test_dict_watcher.py https://github.com/python/cpython/pull/149691/files#diff-92f2acae1b01564a2caa4d5fece4d0904cd6dc8fb3d163c5dc9d416d6771c1ae
2026-02-25-13-37-10.gh-issue-145235.-1ySNR.rst https://github.com/python/cpython/pull/149691/files#diff-9ca8195791f673ad74a61c6fca9b95074b1ab94f8579acb4a57944ed0868b487
watchers.c https://github.com/python/cpython/pull/149691/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
dictobject.c https://github.com/python/cpython/pull/149691/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
optimizer_analysis.c https://github.com/python/cpython/pull/149691/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
pystate.c https://github.com/python/cpython/pull/149691/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
ignored.tsv https://github.com/python/cpython/pull/149691/files#diff-fa2373a9a002e491408e623369773045f4b7de90114b9f5ba6933bfbf2d8c45c
https://github.com/python/cpython/blob/3.14/.github/CODEOWNERS#L229
Doc/data/python3.14.abihttps://github.com/python/cpython/pull/149691/files#diff-711df0c7d042eea79c175d0e4cc95952e43addfc4538d0765565e776c6cc01bd
View file https://github.com/colesbury/cpython/blob/50e2ab0ff1af3efe09165db6af9c8a16c02c8e5a/Doc/data/python3.14.abi
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/python/cpython/pull/149691/files
https://github.com/python/cpython/blob/3.14/.github/CODEOWNERS#L88
Include/internal/pycore_dict_state.hhttps://github.com/python/cpython/pull/149691/files#diff-3263c8b16705dc3ea3e56b42dbbc78ab240468ecf9c572eddc3a417dc986a4c7
View file https://github.com/colesbury/cpython/blob/50e2ab0ff1af3efe09165db6af9c8a16c02c8e5a/Include/internal/pycore_dict_state.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149691/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149691/files#diff-3263c8b16705dc3ea3e56b42dbbc78ab240468ecf9c572eddc3a417dc986a4c7
https://github.com/python/cpython/pull/149691/files#diff-3263c8b16705dc3ea3e56b42dbbc78ab240468ecf9c572eddc3a417dc986a4c7
Include/internal/pycore_pyatomic_ft_wrappers.hhttps://github.com/python/cpython/pull/149691/files#diff-ce601684210b2d7f8f955bb70eb6836e92f54d7d0ec6cd87e6d9da2b974ab7f7
View file https://github.com/colesbury/cpython/blob/50e2ab0ff1af3efe09165db6af9c8a16c02c8e5a/Include/internal/pycore_pyatomic_ft_wrappers.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149691/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149691/files#diff-ce601684210b2d7f8f955bb70eb6836e92f54d7d0ec6cd87e6d9da2b974ab7f7
https://github.com/python/cpython/pull/149691/files#diff-ce601684210b2d7f8f955bb70eb6836e92f54d7d0ec6cd87e6d9da2b974ab7f7
https://github.com/python/cpython/pull/149691/files#diff-ce601684210b2d7f8f955bb70eb6836e92f54d7d0ec6cd87e6d9da2b974ab7f7
https://github.com/python/cpython/pull/149691/files#diff-ce601684210b2d7f8f955bb70eb6836e92f54d7d0ec6cd87e6d9da2b974ab7f7
Lib/test/test_free_threading/test_dict_watcher.pyhttps://github.com/python/cpython/pull/149691/files#diff-92f2acae1b01564a2caa4d5fece4d0904cd6dc8fb3d163c5dc9d416d6771c1ae
View file https://github.com/colesbury/cpython/blob/50e2ab0ff1af3efe09165db6af9c8a16c02c8e5a/Lib/test/test_free_threading/test_dict_watcher.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149691/{{ revealButtonHref }}
Misc/NEWS.d/next/C_API/2026-02-25-13-37-10.gh-issue-145235.-1ySNR.rsthttps://github.com/python/cpython/pull/149691/files#diff-9ca8195791f673ad74a61c6fca9b95074b1ab94f8579acb4a57944ed0868b487
View file https://github.com/colesbury/cpython/blob/50e2ab0ff1af3efe09165db6af9c8a16c02c8e5a/Misc/NEWS.d/next/C_API/2026-02-25-13-37-10.gh-issue-145235.-1ySNR.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149691/{{ revealButtonHref }}
Modules/_testcapi/watchers.chttps://github.com/python/cpython/pull/149691/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
View file https://github.com/colesbury/cpython/blob/50e2ab0ff1af3efe09165db6af9c8a16c02c8e5a/Modules/_testcapi/watchers.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149691/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149691/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/149691/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/149691/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/149691/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/149691/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/149691/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/149691/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/149691/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/blob/3.14/.github/CODEOWNERS#L38
Objects/dictobject.chttps://github.com/python/cpython/pull/149691/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
View file https://github.com/colesbury/cpython/blob/50e2ab0ff1af3efe09165db6af9c8a16c02c8e5a/Objects/dictobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149691/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149691/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/149691/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/149691/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/149691/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/pull/149691/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
https://github.com/python/cpython/blob/3.14/.github/CODEOWNERS#L54
Python/optimizer_analysis.chttps://github.com/python/cpython/pull/149691/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
View file https://github.com/colesbury/cpython/blob/50e2ab0ff1af3efe09165db6af9c8a16c02c8e5a/Python/optimizer_analysis.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149691/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149691/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/pull/149691/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/pull/149691/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/pull/149691/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/pull/149691/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/pull/149691/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/pull/149691/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/pull/149691/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
https://github.com/python/cpython/blob/3.14/.github/CODEOWNERS#L78
Python/pystate.chttps://github.com/python/cpython/pull/149691/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
View file https://github.com/colesbury/cpython/blob/50e2ab0ff1af3efe09165db6af9c8a16c02c8e5a/Python/pystate.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149691/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149691/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/149691/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/blob/3.14/.github/CODEOWNERS#L62
Tools/c-analyzer/cpython/ignored.tsvhttps://github.com/python/cpython/pull/149691/files#diff-fa2373a9a002e491408e623369773045f4b7de90114b9f5ba6933bfbf2d8c45c
View file https://github.com/colesbury/cpython/blob/50e2ab0ff1af3efe09165db6af9c8a16c02c8e5a/Tools/c-analyzer/cpython/ignored.tsv
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149691/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149691/files#diff-fa2373a9a002e491408e623369773045f4b7de90114b9f5ba6933bfbf2d8c45c
https://github.com/python/cpython/pull/149691/files#diff-fa2373a9a002e491408e623369773045f4b7de90114b9f5ba6933bfbf2d8c45c
Please reload this pagehttps://github.com/python/cpython/pull/149691/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.