René's URL Explorer Experiment


Title: gh-149614: Restore deepcopiability of argparse.ArgumentParser instances by DavidCEllis · Pull Request #149617 · python/cpython · GitHub

Open Graph Title: gh-149614: Restore deepcopiability of argparse.ArgumentParser instances by DavidCEllis · Pull Request #149617 · python/cpython

X Title: gh-149614: Restore deepcopiability of argparse.ArgumentParser instances by DavidCEllis · Pull Request #149617 · python/cpython

Description: With the creation of the _ColorlessTheme to avoid importing _colorize early the new class unfortunately was returning empty strings for __deepcopy__ along with other dunder methods which broke deepcopy. I've added tests for copy and deepcopy based on the test for pickle. Being more cautious, I've narrowed the class to only returning empty strings on attributes matching those taken from _colorize. This does mean making sure the set remains in sync which could be more annoying to maintain, it would also be possible to just exclude anything starting with _. I've updated the test that checks this theme to directly check they are in sync. Issue: gh-149614

Open Graph Description: With the creation of the _ColorlessTheme to avoid importing _colorize early the new class unfortunately was returning empty strings for __deepcopy__ along with other dunder methods which broke deep...

X Description: With the creation of the _ColorlessTheme to avoid importing _colorize early the new class unfortunately was returning empty strings for __deepcopy__ along with other dunder methods which broke deep...

Opengraph URL: https://github.com/python/cpython/pull/149617

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a488b4cf-ae4e-5936-3aac-86a361e0ec3c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF68:2C69FC:1572DC2:1C7DD40:6B01FF78
html-safe-nonce3eceec3fea534b81500b2c5edfe983ccf362c56603b7fe729c9bc6116bbe8818
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjY4OjJDNjlGQzoxNTcyREMyOjFDN0RENDA6NkIwMUZGNzgiLCJ2aXNpdG9yX2lkIjoiNjI1NTE4MTI0NDg4NDE4OTA0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac04d9af5552c4110b0f189b45144bdfd4c5f7fd87a55b8037bfc0f5b846fcbb5b
hovercard-subject-tagpull_request:3655825775
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/149617/files
twitter:imagehttps://avatars.githubusercontent.com/u/15880420?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15880420?s=400&v=4
og:image:altWith the creation of the _ColorlessTheme to avoid importing _colorize early the new class unfortunately was returning empty strings for __deepcopy__ along with other dunder methods which broke deep...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/149617/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149617%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149617%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/149617/files
Reloadhttps://github.com/python/cpython/pull/149617/files
Reloadhttps://github.com/python/cpython/pull/149617/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
savannahostrowskihttps://github.com/savannahostrowski
python:mainhttps://github.com/python/cpython/tree/main
DavidCEllis:unbreak-argparse-copyhttps://github.com/DavidCEllis/cpython/tree/unbreak-argparse-copy
Conversation 20 https://github.com/python/cpython/pull/149617
Commits 12 https://github.com/python/cpython/pull/149617/commits
Checks 64 https://github.com/python/cpython/pull/149617/checks
Files changed https://github.com/python/cpython/pull/149617/files
Please reload this pagehttps://github.com/python/cpython/pull/149617/files
gh-149614: Restore deepcopiability of argparse.ArgumentParser instances https://github.com/python/cpython/pull/149617/files#top
Show all changes 12 commits https://github.com/python/cpython/pull/149617/files
e3c3dbe Add tests to check an argument parser is copiable. DavidCEllis May 9, 2026 https://github.com/python/cpython/pull/149617/commits/e3c3dbec1dbfaaaf0c81c69778a8db98b3e3d4d8
0457d17 Only return empty strings for the specific color fields in argparse. DavidCEllis May 9, 2026 https://github.com/python/cpython/pull/149617/commits/0457d17a57ee4c8221f03321986a1535af899b6e
9516991 rename class attribute DavidCEllis May 9, 2026 https://github.com/python/cpython/pull/149617/commits/9516991ebd005224e823a63c3b97b29a06667a3f
e290465 Test the field lists match directly DavidCEllis May 9, 2026 https://github.com/python/cpython/pull/149617/commits/e290465e71427dc8a82494dabc6bcf3cc23a3f02
3b5f635 📜🤖 Added by blurb_it. blurb-it[bot] May 9, 2026 https://github.com/python/cpython/pull/149617/commits/3b5f6356a930c7cf4dee1d40b0892201d808c245
0475e1a Only raise on dunder names DavidCEllis May 9, 2026 https://github.com/python/cpython/pull/149617/commits/0475e1adc13800c6fa93d1b4e4b4d285a88df530
dab2c92 On the unlikely chance that object adds a `__deepcopy__`, let's just use DavidCEllis May 9, 2026 https://github.com/python/cpython/pull/149617/commits/dab2c92d230c157c602c10ea1ff1d55fdd4a4109
b42718d Raise on any private attribute DavidCEllis May 9, 2026 https://github.com/python/cpython/pull/149617/commits/b42718dbd65e6b5039766bc02a34c249ee6a132a
5646376 Test shallow and deep copy behaviour is as expected. DavidCEllis May 9, 2026 https://github.com/python/cpython/pull/149617/commits/564637658a17f19341490e4850d683eaf7510c17
c665917 Merge remote-tracking branch 'origin/unbreak-argparse-copy' into unbr… DavidCEllis May 9, 2026 https://github.com/python/cpython/pull/149617/commits/c6659176e8e44d4e33b4fd192a4fc91efebec42f
3a79f28 Update Misc/NEWS.d/next/Library/2026-05-09-21-02-08.gh-issue-149614.U… DavidCEllis May 11, 2026 https://github.com/python/cpython/pull/149617/commits/3a79f28d2a148e1413da12f080b783e6c607fbcf
78007b9 Merge branch 'main' into unbreak-argparse-copy savannahostrowski May 11, 2026 https://github.com/python/cpython/pull/149617/commits/78007b9cf6f4687c431c9abb327b14bb0fd95dff
Clear filters https://github.com/python/cpython/pull/149617/files
Please reload this pagehttps://github.com/python/cpython/pull/149617/files
Please reload this pagehttps://github.com/python/cpython/pull/149617/files
argparse.py https://github.com/python/cpython/pull/149617/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
test_argparse.py https://github.com/python/cpython/pull/149617/files#diff-c7651634d84a017884451f95f6535a1d2efbeacee1cca7cc1e27fdc748804aa1
2026-05-09-21-02-08.gh-issue-149614.U4snj3.rst https://github.com/python/cpython/pull/149617/files#diff-f9e33a6d061a20a530222c09d4a7dcfe4a73ef30f7df123d019830d03c0ca9d5
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L370
Lib/argparse.pyhttps://github.com/python/cpython/pull/149617/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
View file https://github.com/DavidCEllis/cpython/blob/78007b9cf6f4687c431c9abb327b14bb0fd95dff/Lib/argparse.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149617/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149617/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
Please reload this pagehttps://github.com/python/cpython/pull/149617/files
https://github.com/python/cpython/pull/149617/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L371
Lib/test/test_argparse.pyhttps://github.com/python/cpython/pull/149617/files#diff-c7651634d84a017884451f95f6535a1d2efbeacee1cca7cc1e27fdc748804aa1
View file https://github.com/DavidCEllis/cpython/blob/78007b9cf6f4687c431c9abb327b14bb0fd95dff/Lib/test/test_argparse.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149617/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149617/files#diff-c7651634d84a017884451f95f6535a1d2efbeacee1cca7cc1e27fdc748804aa1
Please reload this pagehttps://github.com/python/cpython/pull/149617/files
Please reload this pagehttps://github.com/python/cpython/pull/149617/files
Please reload this pagehttps://github.com/python/cpython/pull/149617/files
https://github.com/python/cpython/pull/149617/files#diff-c7651634d84a017884451f95f6535a1d2efbeacee1cca7cc1e27fdc748804aa1
https://github.com/python/cpython/pull/149617/files#diff-c7651634d84a017884451f95f6535a1d2efbeacee1cca7cc1e27fdc748804aa1
https://github.com/python/cpython/pull/149617/files#diff-c7651634d84a017884451f95f6535a1d2efbeacee1cca7cc1e27fdc748804aa1
Misc/NEWS.d/next/Library/2026-05-09-21-02-08.gh-issue-149614.U4snj3.rsthttps://github.com/python/cpython/pull/149617/files#diff-f9e33a6d061a20a530222c09d4a7dcfe4a73ef30f7df123d019830d03c0ca9d5
View file https://github.com/DavidCEllis/cpython/blob/78007b9cf6f4687c431c9abb327b14bb0fd95dff/Misc/NEWS.d/next/Library/2026-05-09-21-02-08.gh-issue-149614.U4snj3.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149617/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/149617/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.