René's URL Explorer Experiment


Title: [3.15] gh-149430: Fix edge-cases in `profiling.sampling` outputs (GH-149431) by miss-islington · Pull Request #149602 · python/cpython · GitHub

Open Graph Title: [3.15] gh-149430: Fix edge-cases in `profiling.sampling` outputs (GH-149431) by miss-islington · Pull Request #149602 · python/cpython

X Title: [3.15] gh-149430: Fix edge-cases in `profiling.sampling` outputs (GH-149431) by miss-islington · Pull Request #149602 · python/cpython

Description: The line highlights on the heatmap are driven by the URL hash and the :target selector. When clicking a caller/callee link for the line that was already selected, the hash doesn't change, so the browser keeps the existing target state and doesn't restart the animation. Due to this the highlight only works the first time. With this fix, line navigation goes through JavaScript. If the target URL already points to the current location, the highlight is replayed by clearing the animation, forcing style recalculation, and restoring it. The baseline_self variable isn't initialized for structural elided roots. This variable is accessed later unconditionally and leads to a crash. The child process ends up being invoked with --diff_flamegraph instead of the correct argument. (cherry picked from commit 9587726) Co-authored-by: László Kiss Kollár kiss.kollar.laszlo@gmail.com Issue: gh-149430

Open Graph Description: The line highlights on the heatmap are driven by the URL hash and the :target selector. When clicking a caller/callee link for the line that was already selected, the hash doesn't change, so th...

X Description: The line highlights on the heatmap are driven by the URL hash and the :target selector. When clicking a caller/callee link for the line that was already selected, the hash doesn't change, s...

Opengraph URL: https://github.com/python/cpython/pull/149602

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6ea0888c-78fa-492d-f13a-fb600099e6b1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC91A:B53AF:3406B68:45430E1:6B01FB56
html-safe-noncef035a5fd1ddc67525ae622f97c54d2e0de1f4ac6a6b5b1d7b401a3e722f58bd6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTFBOkI1M0FGOjM0MDZCNjg6NDU0MzBFMTo2QjAxRkI1NiIsInZpc2l0b3JfaWQiOiIyNjU5ODEzMzI5MTE5MzQ1NDk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac09fc8af7ce1bc3fb2de46d5504b42d798f6be9be5a4cc13ff30daae75cb61ea8
hovercard-subject-tagpull_request:3654903593
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/149602/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altThe line highlights on the heatmap are driven by the URL hash and the :target selector. When clicking a caller/callee link for the line that was already selected, the hash doesn't change, so th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/149602/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149602%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149602%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/149602/files
Reloadhttps://github.com/python/cpython/pull/149602/files
Reloadhttps://github.com/python/cpython/pull/149602/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:3.15https://github.com/python/cpython/tree/3.15
miss-islington:backport-9587726-3.15https://github.com/miss-islington/cpython/tree/backport-9587726-3.15
Conversation 0 https://github.com/python/cpython/pull/149602
Commits 1 https://github.com/python/cpython/pull/149602/commits
Checks 52 https://github.com/python/cpython/pull/149602/checks
Files changed https://github.com/python/cpython/pull/149602/files
Please reload this pagehttps://github.com/python/cpython/pull/149602/files
[3.15] gh-149430: Fix edge-cases in profiling.sampling outputs (GH-149431) https://github.com/python/cpython/pull/149602/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/149602/files
f5b6fa0 gh-149430: Fix edge-cases in `profiling.sampling` outputs (GH-149431) lkollar May 9, 2026 https://github.com/python/cpython/pull/149602/commits/f5b6fa03c1b2c34217f019f2ecbc3fa18b2c0f58
Clear filters https://github.com/python/cpython/pull/149602/files
Please reload this pagehttps://github.com/python/cpython/pull/149602/files
Please reload this pagehttps://github.com/python/cpython/pull/149602/files
heatmap.js https://github.com/python/cpython/pull/149602/files#diff-d2f8f7454f9f65efbe693968d97d70c8287add2e48c1440dca32470ae285f1da
cli.py https://github.com/python/cpython/pull/149602/files#diff-51671a4eea64fc8902d5f510e433ab2949b6b5b6d944ec963ab541d5ee315e0f
stack_collector.py https://github.com/python/cpython/pull/149602/files#diff-30798ab579c76386ef4bc482ff5d57ec1b76978d34b3fd2556a158ddc0fb941e
test_children.py https://github.com/python/cpython/pull/149602/files#diff-7e9fec5e21826697b97ad17df5583ca56837d23f5ea1856c5a4e80dec1b18899
test_collectors.py https://github.com/python/cpython/pull/149602/files#diff-8436f3f406ad4ede0e395a9a742e325aee99447b5cdac2a56839230c0e519bd2
https://github.com/python/cpython/blob/3.15/.github/CODEOWNERS#L551
Lib/profiling/sampling/_heatmap_assets/heatmap.jshttps://github.com/python/cpython/pull/149602/files#diff-d2f8f7454f9f65efbe693968d97d70c8287add2e48c1440dca32470ae285f1da
View file https://github.com/miss-islington/cpython/blob/f5b6fa03c1b2c34217f019f2ecbc3fa18b2c0f58/Lib/profiling/sampling/_heatmap_assets/heatmap.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149602/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149602/files#diff-d2f8f7454f9f65efbe693968d97d70c8287add2e48c1440dca32470ae285f1da
https://github.com/python/cpython/pull/149602/files#diff-d2f8f7454f9f65efbe693968d97d70c8287add2e48c1440dca32470ae285f1da
https://github.com/python/cpython/pull/149602/files#diff-d2f8f7454f9f65efbe693968d97d70c8287add2e48c1440dca32470ae285f1da
https://github.com/python/cpython/pull/149602/files#diff-d2f8f7454f9f65efbe693968d97d70c8287add2e48c1440dca32470ae285f1da
https://github.com/python/cpython/blob/3.15/.github/CODEOWNERS#L551
Lib/profiling/sampling/cli.pyhttps://github.com/python/cpython/pull/149602/files#diff-51671a4eea64fc8902d5f510e433ab2949b6b5b6d944ec963ab541d5ee315e0f
View file https://github.com/miss-islington/cpython/blob/f5b6fa03c1b2c34217f019f2ecbc3fa18b2c0f58/Lib/profiling/sampling/cli.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149602/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149602/files#diff-51671a4eea64fc8902d5f510e433ab2949b6b5b6d944ec963ab541d5ee315e0f
https://github.com/python/cpython/pull/149602/files#diff-51671a4eea64fc8902d5f510e433ab2949b6b5b6d944ec963ab541d5ee315e0f
https://github.com/python/cpython/blob/3.15/.github/CODEOWNERS#L551
Lib/profiling/sampling/stack_collector.pyhttps://github.com/python/cpython/pull/149602/files#diff-30798ab579c76386ef4bc482ff5d57ec1b76978d34b3fd2556a158ddc0fb941e
View file https://github.com/miss-islington/cpython/blob/f5b6fa03c1b2c34217f019f2ecbc3fa18b2c0f58/Lib/profiling/sampling/stack_collector.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149602/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149602/files#diff-30798ab579c76386ef4bc482ff5d57ec1b76978d34b3fd2556a158ddc0fb941e
https://github.com/python/cpython/pull/149602/files#diff-30798ab579c76386ef4bc482ff5d57ec1b76978d34b3fd2556a158ddc0fb941e
https://github.com/python/cpython/blob/3.15/.github/CODEOWNERS#L552
Lib/test/test_profiling/test_sampling_profiler/test_children.pyhttps://github.com/python/cpython/pull/149602/files#diff-7e9fec5e21826697b97ad17df5583ca56837d23f5ea1856c5a4e80dec1b18899
View file https://github.com/miss-islington/cpython/blob/f5b6fa03c1b2c34217f019f2ecbc3fa18b2c0f58/Lib/test/test_profiling/test_sampling_profiler/test_children.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149602/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149602/files#diff-7e9fec5e21826697b97ad17df5583ca56837d23f5ea1856c5a4e80dec1b18899
https://github.com/python/cpython/pull/149602/files#diff-7e9fec5e21826697b97ad17df5583ca56837d23f5ea1856c5a4e80dec1b18899
https://github.com/python/cpython/blob/3.15/.github/CODEOWNERS#L552
Lib/test/test_profiling/test_sampling_profiler/test_collectors.pyhttps://github.com/python/cpython/pull/149602/files#diff-8436f3f406ad4ede0e395a9a742e325aee99447b5cdac2a56839230c0e519bd2
View file https://github.com/miss-islington/cpython/blob/f5b6fa03c1b2c34217f019f2ecbc3fa18b2c0f58/Lib/test/test_profiling/test_sampling_profiler/test_collectors.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149602/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149602/files#diff-8436f3f406ad4ede0e395a9a742e325aee99447b5cdac2a56839230c0e519bd2
https://github.com/python/cpython/pull/149602/files#diff-8436f3f406ad4ede0e395a9a742e325aee99447b5cdac2a56839230c0e519bd2
https://github.com/python/cpython/pull/149602/files#diff-8436f3f406ad4ede0e395a9a742e325aee99447b5cdac2a56839230c0e519bd2
https://github.com/python/cpython/pull/149602/files#diff-8436f3f406ad4ede0e395a9a742e325aee99447b5cdac2a56839230c0e519bd2
https://github.com/python/cpython/pull/149602/files#diff-8436f3f406ad4ede0e395a9a742e325aee99447b5cdac2a56839230c0e519bd2
https://github.com/python/cpython/pull/149602/files#diff-8436f3f406ad4ede0e395a9a742e325aee99447b5cdac2a56839230c0e519bd2
Please reload this pagehttps://github.com/python/cpython/pull/149602/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.