René's URL Explorer Experiment


Title: bpo-37628: Fix IDLE config sample sizes by taleinat · Pull Request #14958 · python/cpython · GitHub

Open Graph Title: bpo-37628: Fix IDLE config sample sizes by taleinat · Pull Request #14958 · python/cpython

X Title: bpo-37628: Fix IDLE config sample sizes by taleinat · Pull Request #14958 · python/cpython

Description: This fixes the issue where setting a large font size makes the config dialog grow, in some cases making it unusable by pushing the dialog buttons (e.g. "Ok", "Cancel") off-screen. Tested on Windows 10 and Ubuntu 18.10. https://bugs.python.org/issue37628

Open Graph Description: This fixes the issue where setting a large font size makes the config dialog grow, in some cases making it unusable by pushing the dialog buttons (e.g. "Ok", "Cancel") off-scree...

X Description: This fixes the issue where setting a large font size makes the config dialog grow, in some cases making it unusable by pushing the dialog buttons (e.g. "Ok", "Cancel&...

Opengraph URL: https://github.com/python/cpython/pull/14958

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f5794f3e-7abf-7d0c-9c54-2f2fb0bbf6cb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE12:7B9AE:E23452:135E153:6A4DCF84
html-safe-nonce7f5fa49601eabb2e7d476ca250dd90f41e0664fc0244e3eab7ee1a4643f5a818
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTEyOjdCOUFFOkUyMzQ1MjoxMzVFMTUzOjZBNERDRjg0IiwidmlzaXRvcl9pZCI6IjQ0Nzg5NTQ3MjQ1NTc0NDI5NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd259096253d7c2e5536e5b714b4c321483e511cac71a8451f00fd9a403f212f8
hovercard-subject-tagpull_request:301528134
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/14958/files
twitter:imagehttps://avatars.githubusercontent.com/u/532281?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/532281?s=400&v=4
og:image:altThis fixes the issue where setting a large font size makes the config dialog grow, in some cases making it unusable by pushing the dialog buttons (e.g. "Ok", "Cancel") off-scree...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/14958/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14958%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14958%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/14958/files
Reloadhttps://github.com/python/cpython/pull/14958/files
Reloadhttps://github.com/python/cpython/pull/14958/files
Please reload this pagehttps://github.com/python/cpython/pull/14958/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/14958/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terryjreedyhttps://github.com/terryjreedy
python:masterhttps://github.com/python/cpython/tree/master
taleinat:bpo-37628/IDLE-font-config-window-sizehttps://github.com/taleinat/cpython/tree/bpo-37628/IDLE-font-config-window-size
Conversation 29 https://github.com/python/cpython/pull/14958
Commits 20 https://github.com/python/cpython/pull/14958/commits
Checks 0 https://github.com/python/cpython/pull/14958/checks
Files changed https://github.com/python/cpython/pull/14958/files
Please reload this pagehttps://github.com/python/cpython/pull/14958/files
bpo-37628: Fix IDLE config sample sizes https://github.com/python/cpython/pull/14958/files#top
Show all changes 20 commits https://github.com/python/cpython/pull/14958/files
ed7d279 refactor TextFrame, extracting just the basic scrollable text widget taleinat Jul 26, 2019 https://github.com/python/cpython/pull/14958/commits/ed7d279c7af20760b07f24774bb2776963658667
f67f6b9 use a scrollable text widget for the font config page's preview taleinat Jul 26, 2019 https://github.com/python/cpython/pull/14958/commits/f67f6b99c1b2c7b641d6b346f375e51234517da1
0092a93 highlight page sample also a fixed-sized, scrollable text widget taleinat Jul 26, 2019 https://github.com/python/cpython/pull/14958/commits/0092a9338227412bc4d5d955af36af0e7cb981f8
3380193 refactor: make self.font_sample and self.highlight_sample consistent taleinat Jul 26, 2019 https://github.com/python/cpython/pull/14958/commits/3380193ae9fd10061f2e5d8ddfb79b976fbae027
b1dc2dd rename for clarity: add_config_hook -> add_config_callback taleinat Jul 26, 2019 https://github.com/python/cpython/pull/14958/commits/b1dc2dd2bee37f9b8da6fb9b460fdc39468a53d3
48e97ce Omit unneeded extra line number. terryjreedy Jul 26, 2019 https://github.com/python/cpython/pull/14958/commits/48e97ce87b9751352c534491d80a7ba68c271cc1
f78427a Use horizontal scroller for font sample. terryjreedy Jul 26, 2019 https://github.com/python/cpython/pull/14958/commits/f78427a31e47e9c9c92924279555056688399ec4
221e051 Condense 'font_sample_scrollable_frame' to 'font_sample__frame. terryjreedy Jul 26, 2019 https://github.com/python/cpython/pull/14958/commits/221e0513fef49c1356b1cc06ee6af37711c37bbf
34c218a Blurb. terryjreedy Jul 26, 2019 https://github.com/python/cpython/pull/14958/commits/34c218a0952b27da8d8ce88fbaa121de027a58fb
b954c06 Meaningful names for callback functions. terryjreedy Jul 27, 2019 https://github.com/python/cpython/pull/14958/commits/b954c06b16a992ba7b1f2dc4bcbe4f948bda75ef
72015a9 rename 'text' input param to 'contents' and use 'text' as local var taleinat Jul 27, 2019 https://github.com/python/cpython/pull/14958/commits/72015a92b67acecd05009da02bc0e6298274babb
b5c467d fix double-underscore typo taleinat Jul 27, 2019 https://github.com/python/cpython/pull/14958/commits/b5c467d0eaa2de42e1c0298d7f79978346257410
7100ec9 re-instate use of 'text' local variable in ScrollableTextFrame code taleinat Jul 27, 2019 https://github.com/python/cpython/pull/14958/commits/7100ec949993fa9388cb2452e8737644e6347388
977c219 simplify ScrollableTextFrame, removing the config callback taleinat Jul 27, 2019 https://github.com/python/cpython/pull/14958/commits/977c2198720590d7db0944aac0a7205a349fb44c
3d8729d Rename AutoHiddenScrollbar to AutoHideScrollbar terryjreedy Jul 27, 2019 https://github.com/python/cpython/pull/14958/commits/3d8729d2e6af7cb2243e83be1d9541985bc74662
501fde2 Fix textview htest. terryjreedy Jul 27, 2019 https://github.com/python/cpython/pull/14958/commits/501fde24a1059055cb7ed6eff356b43ce33d8bc0
52cfa62 Restore coverage, reduced in prior issue, to 100%. terryjreedy Jul 27, 2019 https://github.com/python/cpython/pull/14958/commits/52cfa6282bf53553d6a778393ed1007ed8d081eb
2cbf9e5 Double space between classes. terryjreedy Jul 27, 2019 https://github.com/python/cpython/pull/14958/commits/2cbf9e52d682818491e12c64d7ab0667a61f9c66
59eba51 Spacing terryjreedy Jul 27, 2019 https://github.com/python/cpython/pull/14958/commits/59eba516b5e1fe24742aa35aaca97776581fa4f2
f6ac725 Combine configuration. terryjreedy Jul 27, 2019 https://github.com/python/cpython/pull/14958/commits/f6ac725bf6ad1e7b1cad75e6b46120858b8fc01f
Clear filters https://github.com/python/cpython/pull/14958/files
Please reload this pagehttps://github.com/python/cpython/pull/14958/files
Please reload this pagehttps://github.com/python/cpython/pull/14958/files
configdialog.py https://github.com/python/cpython/pull/14958/files#diff-7399589961fc12d44599e3fd8e36010cf7b20dead5db3f82c461a0453708b9be
htest.py https://github.com/python/cpython/pull/14958/files#diff-86170e6b99cdcc74ebcda51c3ed5e27e8da1edfee1526308e90fb2b0839bea94
test_textview.py https://github.com/python/cpython/pull/14958/files#diff-49257264080886a64c3373eedfcb41940c8378807ab923536f2194eb1d6fb74a
textview.py https://github.com/python/cpython/pull/14958/files#diff-9b9d5a04c3b7057f8516da928548ed82ee3429602ed271c372dbe035e72f0379
2019-07-26-17-51-13.bpo-37628.kX4AUF.rst https://github.com/python/cpython/pull/14958/files#diff-52279441beaab548384b4568d7a73d66cde84785d39d2a87b2f2b1e84a860f9c
Lib/idlelib/configdialog.pyhttps://github.com/python/cpython/pull/14958/files#diff-7399589961fc12d44599e3fd8e36010cf7b20dead5db3f82c461a0453708b9be
View file https://github.com/taleinat/cpython/blob/f6ac725bf6ad1e7b1cad75e6b46120858b8fc01f/Lib/idlelib/configdialog.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14958/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14958/files#diff-7399589961fc12d44599e3fd8e36010cf7b20dead5db3f82c461a0453708b9be
https://github.com/python/cpython/pull/14958/files#diff-7399589961fc12d44599e3fd8e36010cf7b20dead5db3f82c461a0453708b9be
https://github.com/python/cpython/pull/14958/files#diff-7399589961fc12d44599e3fd8e36010cf7b20dead5db3f82c461a0453708b9be
https://github.com/python/cpython/pull/14958/files#diff-7399589961fc12d44599e3fd8e36010cf7b20dead5db3f82c461a0453708b9be
https://github.com/python/cpython/pull/14958/files#diff-7399589961fc12d44599e3fd8e36010cf7b20dead5db3f82c461a0453708b9be
https://github.com/python/cpython/pull/14958/files#diff-7399589961fc12d44599e3fd8e36010cf7b20dead5db3f82c461a0453708b9be
https://github.com/python/cpython/pull/14958/files#diff-7399589961fc12d44599e3fd8e36010cf7b20dead5db3f82c461a0453708b9be
https://github.com/python/cpython/pull/14958/files#diff-7399589961fc12d44599e3fd8e36010cf7b20dead5db3f82c461a0453708b9be
https://github.com/python/cpython/pull/14958/files#diff-7399589961fc12d44599e3fd8e36010cf7b20dead5db3f82c461a0453708b9be
https://github.com/python/cpython/pull/14958/files#diff-7399589961fc12d44599e3fd8e36010cf7b20dead5db3f82c461a0453708b9be
https://github.com/python/cpython/pull/14958/files#diff-7399589961fc12d44599e3fd8e36010cf7b20dead5db3f82c461a0453708b9be
Lib/idlelib/idle_test/htest.pyhttps://github.com/python/cpython/pull/14958/files#diff-86170e6b99cdcc74ebcda51c3ed5e27e8da1edfee1526308e90fb2b0839bea94
View file https://github.com/taleinat/cpython/blob/f6ac725bf6ad1e7b1cad75e6b46120858b8fc01f/Lib/idlelib/idle_test/htest.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14958/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14958/files#diff-86170e6b99cdcc74ebcda51c3ed5e27e8da1edfee1526308e90fb2b0839bea94
https://github.com/python/cpython/pull/14958/files#diff-86170e6b99cdcc74ebcda51c3ed5e27e8da1edfee1526308e90fb2b0839bea94
Lib/idlelib/idle_test/test_textview.pyhttps://github.com/python/cpython/pull/14958/files#diff-49257264080886a64c3373eedfcb41940c8378807ab923536f2194eb1d6fb74a
View file https://github.com/taleinat/cpython/blob/f6ac725bf6ad1e7b1cad75e6b46120858b8fc01f/Lib/idlelib/idle_test/test_textview.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14958/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14958/files#diff-49257264080886a64c3373eedfcb41940c8378807ab923536f2194eb1d6fb74a
https://github.com/python/cpython/pull/14958/files#diff-49257264080886a64c3373eedfcb41940c8378807ab923536f2194eb1d6fb74a
https://github.com/python/cpython/pull/14958/files#diff-49257264080886a64c3373eedfcb41940c8378807ab923536f2194eb1d6fb74a
https://github.com/python/cpython/pull/14958/files#diff-49257264080886a64c3373eedfcb41940c8378807ab923536f2194eb1d6fb74a
Lib/idlelib/textview.pyhttps://github.com/python/cpython/pull/14958/files#diff-9b9d5a04c3b7057f8516da928548ed82ee3429602ed271c372dbe035e72f0379
View file https://github.com/taleinat/cpython/blob/f6ac725bf6ad1e7b1cad75e6b46120858b8fc01f/Lib/idlelib/textview.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14958/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14958/files#diff-9b9d5a04c3b7057f8516da928548ed82ee3429602ed271c372dbe035e72f0379
https://github.com/python/cpython/pull/14958/files#diff-9b9d5a04c3b7057f8516da928548ed82ee3429602ed271c372dbe035e72f0379
Please reload this pagehttps://github.com/python/cpython/pull/14958/files
https://github.com/python/cpython/pull/14958/files#diff-9b9d5a04c3b7057f8516da928548ed82ee3429602ed271c372dbe035e72f0379
https://github.com/python/cpython/pull/14958/files#diff-9b9d5a04c3b7057f8516da928548ed82ee3429602ed271c372dbe035e72f0379
https://github.com/python/cpython/pull/14958/files#diff-9b9d5a04c3b7057f8516da928548ed82ee3429602ed271c372dbe035e72f0379
https://github.com/python/cpython/pull/14958/files#diff-9b9d5a04c3b7057f8516da928548ed82ee3429602ed271c372dbe035e72f0379
https://github.com/python/cpython/pull/14958/files#diff-9b9d5a04c3b7057f8516da928548ed82ee3429602ed271c372dbe035e72f0379
Misc/NEWS.d/next/IDLE/2019-07-26-17-51-13.bpo-37628.kX4AUF.rsthttps://github.com/python/cpython/pull/14958/files#diff-52279441beaab548384b4568d7a73d66cde84785d39d2a87b2f2b1e84a860f9c
View file https://github.com/taleinat/cpython/blob/f6ac725bf6ad1e7b1cad75e6b46120858b8fc01f/Misc/NEWS.d/next/IDLE/2019-07-26-17-51-13.bpo-37628.kX4AUF.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14958/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.