René's URL Explorer Experiment


Title: gh-112821: Fix rlcompleter failures on objects with descriptors by mdboom · Pull Request #149577 · python/cpython · GitHub

Open Graph Title: gh-112821: Fix rlcompleter failures on objects with descriptors by mdboom · Pull Request #149577 · python/cpython

X Title: gh-112821: Fix rlcompleter failures on objects with descriptors by mdboom · Pull Request #149577 · python/cpython

Description: This issue came to light for me when it was discovered that autocompletion didn't work for a library I help maintain, written mainly in Cython. Cython implements @property-annotated methods on its cdef classes as getset descriptors. The rlcompleter logic doesn't exclude these (like it does regular Python properties) since isinstance(member, property) is False. It then goes on to call the getter, which in some cases (in our library at least) raises an exception. Any exception other than an AttributeError causes the rlcompleter to short circuit completely and not offer any options. This is a more surgical (rlcompleter-only) solution than what was proposed in #112821. If adding ABCs is preferred, I could do that. Restore the try/except removed in #27401 Create abstract classes for descriptors in _collections_abc (e.g. ImplementsGet, ImplementsSet, ImplementsDelete) and in rlcompleter, rather than checking for isinstance(obj, property), use isinstance(obj, ImplementsGet). #112821 also mentioned: This might cause false positives for method descriptors though. I think this is handled here, but I also may not fully understand this specific issue. Issue: gh-112821

Open Graph Description: This issue came to light for me when it was discovered that autocompletion didn't work for a library I help maintain, written mainly in Cython. Cython implements @property-annotated methods on...

X Description: This issue came to light for me when it was discovered that autocompletion didn't work for a library I help maintain, written mainly in Cython. Cython implements @property-annotated method...

Opengraph URL: https://github.com/python/cpython/pull/149577

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8f84e12e-30b3-f51f-83fa-5d09d7cd9852
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC580:1E4EA2:5B5707:7D65CA:6AF849B6
html-safe-nonce1eaf95b65e9ab69d7f93b754efdb6a23a8be5165f37c8acb1cec4aa14c8ad39b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTgwOjFFNEVBMjo1QjU3MDc6N0Q2NUNBOjZBRjg0OUI2IiwidmlzaXRvcl9pZCI6IjQ2NDk0NzE1MjMyODk1ODIwMDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3dbd64a45330b6b048761a53264a088e4dd6051b26ac66bddb2def94cf9ac3c6
hovercard-subject-tagpull_request:3651660560
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/149577/files
twitter:imagehttps://avatars.githubusercontent.com/u/38294?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/38294?s=400&v=4
og:image:altThis issue came to light for me when it was discovered that autocompletion didn't work for a library I help maintain, written mainly in Cython. Cython implements @property-annotated methods on...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5713ecd83001b2f55c3509fb7a292bf7d66d0f167c7ae87a9f7eaec5a52bf8db
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release653be32ff5c755082a4db662491bfbbcfc9112c1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/149577/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149577%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149577%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/149577/files
Reloadhttps://github.com/python/cpython/pull/149577/files
Reloadhttps://github.com/python/cpython/pull/149577/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
mdboomhttps://github.com/mdboom
python:mainhttps://github.com/python/cpython/tree/main
mdboom:issue112821https://github.com/mdboom/cpython/tree/issue112821
Conversation 7 https://github.com/python/cpython/pull/149577
Commits 2 https://github.com/python/cpython/pull/149577/commits
Checks 60 https://github.com/python/cpython/pull/149577/checks
Files changed https://github.com/python/cpython/pull/149577/files
Please reload this pagehttps://github.com/python/cpython/pull/149577/files
gh-112821: Fix rlcompleter failures on objects with descriptors https://github.com/python/cpython/pull/149577/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/149577/files
2da4d91 gh-112821: Fix rlcompleter failures on objects with descriptors mdboom May 8, 2026 https://github.com/python/cpython/pull/149577/commits/2da4d91b54d216493f303b31cb8a466ab6efd0f5
dbd4156 Confirm no accesses mdboom May 8, 2026 https://github.com/python/cpython/pull/149577/commits/dbd4156f4cadec13a313840ea4380f5c71362dbf
Clear filters https://github.com/python/cpython/pull/149577/files
Please reload this pagehttps://github.com/python/cpython/pull/149577/files
Please reload this pagehttps://github.com/python/cpython/pull/149577/files
rlcompleter.py https://github.com/python/cpython/pull/149577/files#diff-4c595af1c40cad3e9df9558541803a1e3b09173e61cd6ebcc7999baf2c77a876
test_rlcompleter.py https://github.com/python/cpython/pull/149577/files#diff-1fca42d4e5423d0d1cc14f41f8f79319eaec3aa51d6810e04b2fea720a99eb18
2026-05-08-15-08-35.gh-issue-112821.t9T1YD.rst https://github.com/python/cpython/pull/149577/files#diff-47a1ae8e90964fa405166d8274d2a9bacd515df371555f1343ddb89b0a4d70c6
Lib/rlcompleter.pyhttps://github.com/python/cpython/pull/149577/files#diff-4c595af1c40cad3e9df9558541803a1e3b09173e61cd6ebcc7999baf2c77a876
View file https://github.com/mdboom/cpython/blob/dbd4156f4cadec13a313840ea4380f5c71362dbf/Lib/rlcompleter.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149577/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149577/files#diff-4c595af1c40cad3e9df9558541803a1e3b09173e61cd6ebcc7999baf2c77a876
JelleZijlstrahttps://github.com/JelleZijlstra
May 10, 2026https://github.com/python/cpython/pull/149577/files#r3215468499
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/149577/files
mdboomhttps://github.com/mdboom
May 11, 2026https://github.com/python/cpython/pull/149577/files#r3215937463
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/149577/files
https://github.com/python/cpython/pull/149577/files#diff-4c595af1c40cad3e9df9558541803a1e3b09173e61cd6ebcc7999baf2c77a876
Lib/test/test_rlcompleter.pyhttps://github.com/python/cpython/pull/149577/files#diff-1fca42d4e5423d0d1cc14f41f8f79319eaec3aa51d6810e04b2fea720a99eb18
View file https://github.com/mdboom/cpython/blob/dbd4156f4cadec13a313840ea4380f5c71362dbf/Lib/test/test_rlcompleter.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149577/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149577/files#diff-1fca42d4e5423d0d1cc14f41f8f79319eaec3aa51d6810e04b2fea720a99eb18
https://github.com/python/cpython/pull/149577/files#diff-1fca42d4e5423d0d1cc14f41f8f79319eaec3aa51d6810e04b2fea720a99eb18
https://github.com/python/cpython/pull/149577/files#diff-1fca42d4e5423d0d1cc14f41f8f79319eaec3aa51d6810e04b2fea720a99eb18
Misc/NEWS.d/next/Library/2026-05-08-15-08-35.gh-issue-112821.t9T1YD.rsthttps://github.com/python/cpython/pull/149577/files#diff-47a1ae8e90964fa405166d8274d2a9bacd515df371555f1343ddb89b0a4d70c6
View file https://github.com/mdboom/cpython/blob/dbd4156f4cadec13a313840ea4380f5c71362dbf/Misc/NEWS.d/next/Library/2026-05-08-15-08-35.gh-issue-112821.t9T1YD.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149577/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/149577/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.