René's URL Explorer Experiment


Title: bpo-37409: fix relative import with no parent by benjimin · Pull Request #14956 · python/cpython · GitHub

Open Graph Title: bpo-37409: fix relative import with no parent by benjimin · Pull Request #14956 · python/cpython

X Title: bpo-37409: fix relative import with no parent by benjimin · Pull Request #14956 · python/cpython

Description: builtins.__import__ was missing a check to flag that if no dot was found in the __name__ of a module that isn't explicitly a submodule of a package then a relative import is incorrect. https://bugs.python.org/issue37409

Open Graph Description: builtins.__import__ was missing a check to flag that if no dot was found in the __name__ of a module that isn't explicitly a submodule of a package then a relative import is incorrect. https:/...

X Description: builtins.__import__ was missing a check to flag that if no dot was found in the __name__ of a module that isn't explicitly a submodule of a package then a relative import is incorrect. htt...

Opengraph URL: https://github.com/python/cpython/pull/14956

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0e48ef2a-3a9c-4f35-e652-3fbd7876c142
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9854:A5753:5F9FF3:820564:6A55A084
html-safe-nonceadd5ba8597a5fd97e6800b6a30c6204fe97747b4b98f792a1b0abbc49f226b75
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODU0OkE1NzUzOjVGOUZGMzo4MjA1NjQ6NkE1NUEwODQiLCJ2aXNpdG9yX2lkIjoiMjIyMzg3NjAyOTc1OTcyNTcwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace19206b8faf95829c1e12b748e0064dd729e891203b0205c485b71e13c7efabe
hovercard-subject-tagpull_request:301445315
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/14956/files
twitter:imagehttps://avatars.githubusercontent.com/u/12852539?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12852539?s=400&v=4
og:image:altbuiltins.__import__ was missing a check to flag that if no dot was found in the __name__ of a module that isn't explicitly a submodule of a package then a relative import is incorrect. https:/...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaa21baa44893467b0b640d0300538f84ca8c475b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/14956/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14956%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14956%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/14956/files
Reloadhttps://github.com/python/cpython/pull/14956/files
Reloadhttps://github.com/python/cpython/pull/14956/files
Please reload this pagehttps://github.com/python/cpython/pull/14956/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/14956/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
brettcannonhttps://github.com/brettcannon
python:masterhttps://github.com/python/cpython/tree/master
benjimin:importfixhttps://github.com/benjimin/cpython/tree/importfix
Conversation 30 https://github.com/python/cpython/pull/14956
Commits 14 https://github.com/python/cpython/pull/14956/commits
Checks 0 https://github.com/python/cpython/pull/14956/checks
Files changed https://github.com/python/cpython/pull/14956/files
Please reload this pagehttps://github.com/python/cpython/pull/14956/files
bpo-37409: fix relative import with no parent https://github.com/python/cpython/pull/14956/files#top
Show all changes 14 commits https://github.com/python/cpython/pull/14956/files
effff9a Regression tests for bpo-37409 benjimin Jun 29, 2019 https://github.com/python/cpython/pull/14956/commits/effff9ad27951beb989b600a965e65d2289aeb59
3ec4c49 bpo-37409: fix builtin/importlib discrepancy for "from . import *" wh… benjimin Jul 24, 2019 https://github.com/python/cpython/pull/14956/commits/3ec4c49e22339c40656be3beceb8deeeabe0e5a3
201c40b Update Lib/test/test_builtin.py benjimin Aug 5, 2019 https://github.com/python/cpython/pull/14956/commits/201c40b178bea6856a22e1f57703444cde6c7cf8
3fc5481 Update Lib/test/test_builtin.py benjimin Aug 5, 2019 https://github.com/python/cpython/pull/14956/commits/3fc5481fee7fde000d17112c442124b9a9b0a356
4a3f487 Update Lib/test/test_import/__init__.py benjimin Aug 5, 2019 https://github.com/python/cpython/pull/14956/commits/4a3f487791cb4b7aac8b3dae60dd9dfb1246f25c
c240df5 Clearer code benjimin Aug 5, 2019 https://github.com/python/cpython/pull/14956/commits/c240df50ccc0b4d28a340b02c73f416ae33344b2
5090880 Update Lib/test/test_builtin.py benjimin Aug 6, 2019 https://github.com/python/cpython/pull/14956/commits/5090880fe19ad7179b8ec67d60830ab5ef8aa37c
57b47b7 📜🤖 Added by blurb_it. blurb-it[bot] Aug 6, 2019 https://github.com/python/cpython/pull/14956/commits/57b47b7acf4676a7ea42005b95df31fa74c89d6b
6f7f476 Clarify test name benjimin Aug 6, 2019 https://github.com/python/cpython/pull/14956/commits/6f7f4768965de37a3ea888f15c34fd57e3c89e9b
634fbcb Update Python/import.c benjimin Aug 10, 2019 https://github.com/python/cpython/pull/14956/commits/634fbcbe2cb821a6a6fb495cc0bfdbf6d954f5be
65d7c2e Update Python/import.c benjimin Aug 10, 2019 https://github.com/python/cpython/pull/14956/commits/65d7c2e3b9f89bd8a8ab33fd647f9478e8906737
178163c Update Lib/test/test_import/__init__.py benjimin Aug 10, 2019 https://github.com/python/cpython/pull/14956/commits/178163c533d9f5689662156b5432c0acc1450951
fac9e37 Update Misc/NEWS.d/next/Core and Builtins/2019-08-06-23-39-05.bpo-374… benjimin Aug 10, 2019 https://github.com/python/cpython/pull/14956/commits/fac9e37b994fc51d0d596d58f5bf1dc2ef46656f
e0730ff Update Python/import.c benjimin Aug 10, 2019 https://github.com/python/cpython/pull/14956/commits/e0730ff1f94229e1f922245336607b8604b4abf8
Clear filters https://github.com/python/cpython/pull/14956/files
Please reload this pagehttps://github.com/python/cpython/pull/14956/files
Please reload this pagehttps://github.com/python/cpython/pull/14956/files
test_builtin.py https://github.com/python/cpython/pull/14956/files#diff-f23235c1f5dea0e2d79b33a58e00025ad3c440f96bb76013a1a37868e70a776b
__init__.py https://github.com/python/cpython/pull/14956/files#diff-ea25b7196846cae64e3ed2b3fb2e1ee420961442fcd801a07bcd9000178bbd58
ACKS https://github.com/python/cpython/pull/14956/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
2019-08-06-23-39-05.bpo-37409.1qwzn2.rst https://github.com/python/cpython/pull/14956/files#diff-b18fe024538e950697dca124e56aa4ba1fcacf45bcffb6b2a808f711eb35ff7c
import.c https://github.com/python/cpython/pull/14956/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
Lib/test/test_builtin.pyhttps://github.com/python/cpython/pull/14956/files#diff-f23235c1f5dea0e2d79b33a58e00025ad3c440f96bb76013a1a37868e70a776b
View file https://github.com/benjimin/cpython/blob/e0730ff1f94229e1f922245336607b8604b4abf8/Lib/test/test_builtin.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14956/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14956/files#diff-f23235c1f5dea0e2d79b33a58e00025ad3c440f96bb76013a1a37868e70a776b
https://github.com/python/cpython/pull/14956/files#diff-f23235c1f5dea0e2d79b33a58e00025ad3c440f96bb76013a1a37868e70a776b
Lib/test/test_import/__init__.pyhttps://github.com/python/cpython/pull/14956/files#diff-ea25b7196846cae64e3ed2b3fb2e1ee420961442fcd801a07bcd9000178bbd58
View file https://github.com/benjimin/cpython/blob/e0730ff1f94229e1f922245336607b8604b4abf8/Lib/test/test_import/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14956/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14956/files#diff-ea25b7196846cae64e3ed2b3fb2e1ee420961442fcd801a07bcd9000178bbd58
Please reload this pagehttps://github.com/python/cpython/pull/14956/files
https://github.com/python/cpython/pull/14956/files#diff-ea25b7196846cae64e3ed2b3fb2e1ee420961442fcd801a07bcd9000178bbd58
Misc/ACKShttps://github.com/python/cpython/pull/14956/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
View file https://github.com/benjimin/cpython/blob/e0730ff1f94229e1f922245336607b8604b4abf8/Misc/ACKS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14956/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14956/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
https://github.com/python/cpython/pull/14956/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
Misc/NEWS.d/next/Core and Builtins/2019-08-06-23-39-05.bpo-37409.1qwzn2.rsthttps://github.com/python/cpython/pull/14956/files#diff-b18fe024538e950697dca124e56aa4ba1fcacf45bcffb6b2a808f711eb35ff7c
View file https://github.com/benjimin/cpython/blob/e0730ff1f94229e1f922245336607b8604b4abf8/Misc/NEWS.d/next/Core%20and%20Builtins/2019-08-06-23-39-05.bpo-37409.1qwzn2.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14956/{{ revealButtonHref }}
Python/import.chttps://github.com/python/cpython/pull/14956/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
View file https://github.com/benjimin/cpython/blob/e0730ff1f94229e1f922245336607b8604b4abf8/Python/import.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14956/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14956/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/14956/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
Please reload this pagehttps://github.com/python/cpython/pull/14956/files
Please reload this pagehttps://github.com/python/cpython/pull/14956/files
https://github.com/python/cpython/pull/14956/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.