René's URL Explorer Experiment


Title: gh-149388: Make PipeHandle.close idempotent by mxschmitt · Pull Request #149518 · python/cpython · GitHub

Open Graph Title: gh-149388: Make PipeHandle.close idempotent by mxschmitt · Pull Request #149518 · python/cpython

X Title: gh-149388: Make PipeHandle.close idempotent by mxschmitt · Pull Request #149518 · python/cpython

Description: Fixes #149388. Applies @kumaraditya303's suggestion from the issue thread: clear _handle before calling CloseHandle, so that when CloseHandle raises on an already-closed handle, _handle is already None and neither a second close() nor __del__ re-raises. The new regression test in test_windows_utils.PipeTests fails on main: FAIL: test_pipe_handle_close_after_external_close AssertionError: 792 is not None and passes with the patch. Full python -m test test_asyncio is green on the patched build (2524 tests, 0 failures). The end-to-end repro from the issue (repro_v2.py) goes from 6/20 → 0/60 trials firing WinError 6. Verified against a locally built CPython 3.16.0a0 (Windows x86_64) from this branch. Issue: gh-149388

Open Graph Description: Fixes #149388. Applies @kumaraditya303's suggestion from the issue thread: clear _handle before calling CloseHandle, so that when CloseHandle raises on an already-closed handle, _handle is alre...

X Description: Fixes #149388. Applies @kumaraditya303's suggestion from the issue thread: clear _handle before calling CloseHandle, so that when CloseHandle raises on an already-closed handle, _handle is ...

Opengraph URL: https://github.com/python/cpython/pull/149518

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:93914546-c8a5-85a1-1542-9696a0346495
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC1E:1201C:35A5484:473685E:6B01FB97
html-safe-noncea03bf6c11cd9529c62608483e2263b7a88b89fd0c9cc9f582ede7fcc7671225a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzFFOjEyMDFDOjM1QTU0ODQ6NDczNjg1RTo2QjAxRkI5NyIsInZpc2l0b3JfaWQiOiIyNDIwMjQ4Mzg1NTg1MDE5Nzk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac72622971d04c99958867235c38ad3d283b916e2a5df168ccb3683821555ff418
hovercard-subject-tagpull_request:3646055209
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/149518/files
twitter:imagehttps://avatars.githubusercontent.com/u/17984549?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17984549?s=400&v=4
og:image:altFixes #149388. Applies @kumaraditya303's suggestion from the issue thread: clear _handle before calling CloseHandle, so that when CloseHandle raises on an already-closed handle, _handle is alre...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/149518/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149518%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149518%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/149518/files
Reloadhttps://github.com/python/cpython/pull/149518/files
Reloadhttps://github.com/python/cpython/pull/149518/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
mxschmitt:gh-149388-pipehandle-close-idempotenthttps://github.com/mxschmitt/cpython/tree/gh-149388-pipehandle-close-idempotent
Conversation 17 https://github.com/python/cpython/pull/149518
Commits 1 https://github.com/python/cpython/pull/149518/commits
Checks 68 https://github.com/python/cpython/pull/149518/checks
Files changed https://github.com/python/cpython/pull/149518/files
Please reload this pagehttps://github.com/python/cpython/pull/149518/files
gh-149388: Make PipeHandle.close idempotent https://github.com/python/cpython/pull/149518/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/149518/files
d2b941f gh-149388: Make PipeHandle.close idempotent mxschmitt May 7, 2026 https://github.com/python/cpython/pull/149518/commits/d2b941f3455687cf2bbddf41659c1624d7de1400
Clear filters https://github.com/python/cpython/pull/149518/files
Please reload this pagehttps://github.com/python/cpython/pull/149518/files
Please reload this pagehttps://github.com/python/cpython/pull/149518/files
windows_utils.py https://github.com/python/cpython/pull/149518/files#diff-a95caa16983395b7ad30f3f9525cbe1c1bb11f2f710bbed6cc9759a14c2eb088
test_windows_utils.py https://github.com/python/cpython/pull/149518/files#diff-13fe5ff0e526b70a903700ae9b1ffae59f24e0ad2c5bf2c13f968bdb8f0bc2b7
2026-05-07-21-58-17.gh-issue-149388.DDBPeA.rst https://github.com/python/cpython/pull/149518/files#diff-2984f81320a132164b80e8b6a2c95e3a1d21a3828c71913495c4cfff9711b65d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L376
Lib/asyncio/windows_utils.pyhttps://github.com/python/cpython/pull/149518/files#diff-a95caa16983395b7ad30f3f9525cbe1c1bb11f2f710bbed6cc9759a14c2eb088
View file https://github.com/mxschmitt/cpython/blob/d2b941f3455687cf2bbddf41659c1624d7de1400/Lib/asyncio/windows_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149518/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149518/files#diff-a95caa16983395b7ad30f3f9525cbe1c1bb11f2f710bbed6cc9759a14c2eb088
https://github.com/python/cpython/pull/149518/files#diff-a95caa16983395b7ad30f3f9525cbe1c1bb11f2f710bbed6cc9759a14c2eb088
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L377
Lib/test/test_asyncio/test_windows_utils.pyhttps://github.com/python/cpython/pull/149518/files#diff-13fe5ff0e526b70a903700ae9b1ffae59f24e0ad2c5bf2c13f968bdb8f0bc2b7
View file https://github.com/mxschmitt/cpython/blob/d2b941f3455687cf2bbddf41659c1624d7de1400/Lib/test/test_asyncio/test_windows_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149518/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149518/files#diff-13fe5ff0e526b70a903700ae9b1ffae59f24e0ad2c5bf2c13f968bdb8f0bc2b7
https://github.com/python/cpython/pull/149518/files#diff-13fe5ff0e526b70a903700ae9b1ffae59f24e0ad2c5bf2c13f968bdb8f0bc2b7
Misc/NEWS.d/next/Library/2026-05-07-21-58-17.gh-issue-149388.DDBPeA.rsthttps://github.com/python/cpython/pull/149518/files#diff-2984f81320a132164b80e8b6a2c95e3a1d21a3828c71913495c4cfff9711b65d
View file https://github.com/mxschmitt/cpython/blob/d2b941f3455687cf2bbddf41659c1624d7de1400/Misc/NEWS.d/next/Library/2026-05-07-21-58-17.gh-issue-149388.DDBPeA.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149518/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/149518/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.