René's URL Explorer Experiment


Title: gh-149388: Make PipeHandle.close idempotent by mxschmitt · Pull Request #149518 · python/cpython · GitHub

Open Graph Title: gh-149388: Make PipeHandle.close idempotent by mxschmitt · Pull Request #149518 · python/cpython

X Title: gh-149388: Make PipeHandle.close idempotent by mxschmitt · Pull Request #149518 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Fixes #149388. Applies @kumaraditya303's suggestion from the issue thread: clear _handle before calling CloseHandle, so that when CloseHandle raises on an already-closed handle, _handle is alre...

X Description: Fixes #149388. Applies @kumaraditya303's suggestion from the issue thread: clear _handle before calling CloseHandle, so that when CloseHandle raises on an already-closed handle, _handle is ...

Opengraph URL: https://github.com/python/cpython/pull/149518

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:008ab811-a612-e5e7-a424-ce75c0ee119a
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-idE09C:3E418A:1BABB59:244BCD7:6B021CD7
html-safe-nonce7448eb745f8298c8c8a28fac99b3c8e9ee71a64f11fec687c7a4000f42294b51
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDlDOjNFNDE4QToxQkFCQjU5OjI0NEJDRDc6NkIwMjFDRDciLCJ2aXNpdG9yX2lkIjoiNzg2ODEzMzQ1Mzg2NTI5NTA2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8271c6e3a7ad5d9ac21418ea71dbce9224e795793db14af30dcc033c05f280be
hovercard-subject-tagpull_request:3646055209
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/149518/checks
twitter:imagehttps://opengraph.githubassets.com/5f81775d6950302363e99d4b032defe3aaf35b3bdf660271ded78296b9eb7d53/python/cpython/pull/149518
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5f81775d6950302363e99d4b032defe3aaf35b3bdf660271ded78296b9eb7d53/python/cpython/pull/149518
og:image:altFixes #149388. Applies @kumaraditya303's suggestion from the issue thread: clear _handle before calling CloseHandle, so that when CloseHandle raises on an already-closed handle, _handle is alre...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemxschmitt
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/149518/checks#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149518%2Fchecks
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149518%2Fchecks
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/149518/checks
Reloadhttps://github.com/python/cpython/pull/149518/checks
Reloadhttps://github.com/python/cpython/pull/149518/checks
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
mxschmitt:gh-149388-pipehandle-close-idempotenthttps://github.com/mxschmitt/cpython/tree/gh-149388-pipehandle-close-idempotent
Conversationhttps://github.com/python/cpython/pull/149518
Commits1 (1)https://github.com/python/cpython/pull/149518/commits
Checkshttps://github.com/python/cpython/pull/149518/checks
Files changedhttps://github.com/python/cpython/pull/149518/files
gh-149388: Make PipeHandle.close idempotenthttps://github.com/python/cpython/pull/149518/checks#top
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
mxschmitt:gh-149388-pipehandle-close-idempotenthttps://github.com/mxschmitt/cpython/tree/gh-149388-pipehandle-close-idempotent
Please reload this pagehttps://github.com/python/cpython/pull/149518/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149518%2Fchecks
Lint on: pull_request https://github.com/python/cpython/actions/runs/25567883689
lint https://github.com/python/cpython/actions/runs/25567883689/job/75055882825?pr=149518
Check labels on: pull_request https://github.com/python/cpython/actions/runs/25567883705
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/25567883705/job/75055882682?pr=149518
Unresolved review https://github.com/python/cpython/actions/runs/25567883705/job/75055882700?pr=149518
Tests on: pull_request https://github.com/python/cpython/actions/runs/25567883859
Change detection / Create context from changed files https://github.com/python/cpython/actions/runs/25567883859/job/75055883669?pr=149518
Docs / Docs https://github.com/python/cpython/actions/runs/25567883859/job/75055938070?pr=149518
Docs / Doctest https://github.com/python/cpython/actions/runs/25567883859/job/75055938195?pr=149518
Docs / Check EPUB https://github.com/python/cpython/actions/runs/25567883859/job/75055938073?pr=149518
Docs / Check for removed HTML IDs / Check for removed HTML IDs https://github.com/python/cpython/actions/runs/25567883859/job/75056247961?pr=149518
Check if Autoconf files are up to date https://github.com/python/cpython/actions/runs/25567883859/job/75055937444?pr=149518
Check if generated files are up to date https://github.com/python/cpython/actions/runs/25567883859/job/75055937519?pr=149518
C API Docs / Check if all C APIs are documented https://github.com/python/cpython/actions/runs/25567883859/job/75055937604?pr=149518
Windows / Build and test (x64, switch-case) https://github.com/python/cpython/actions/runs/25567883859/job/75055937939?pr=149518
Windows (free-threading) / Build and test (x64, switch-case) https://github.com/python/cpython/actions/runs/25567883859/job/75055937966?pr=149518
Windows / Build and test (Win32, switch-case) https://github.com/python/cpython/actions/runs/25567883859/job/75055938044?pr=149518
Windows / Build and test (arm64, switch-case) https://github.com/python/cpython/actions/runs/25567883859/job/75055937907?pr=149518
Windows (free-threading) / Build and test (arm64, switch-case) https://github.com/python/cpython/actions/runs/25567883859/job/75055937928?pr=149518
Windows / Build and test (x64, tail-call) https://github.com/python/cpython/actions/runs/25567883859/job/75055937880?pr=149518
Windows (free-threading) / Build and test (x64, tail-call) https://github.com/python/cpython/actions/runs/25567883859/job/75055937984?pr=149518
Windows MSI${{ '' }} https://github.com/python/cpython/actions/runs/25567883859/job/75055937711?pr=149518
macOS / build and test (macos-26) https://github.com/python/cpython/actions/runs/25567883859/job/75055937829?pr=149518
macOS (free-threading) / build and test (macos-26) https://github.com/python/cpython/actions/runs/25567883859/job/75055937851?pr=149518
macOS / build and test (macos-15-intel) https://github.com/python/cpython/actions/runs/25567883859/job/75055937799?pr=149518
Ubuntu / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/25567883859/job/75055938064?pr=149518
Ubuntu / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/25567883859/job/75055938017?pr=149518
Ubuntu (free-threading) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/25567883859/job/75055937992?pr=149518
Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/25567883859/job/75055938008?pr=149518
Ubuntu (bolt) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/25567883859/job/75055938059?pr=149518
Ubuntu SSL tests (ubuntu-24.04, openssl, 1.1.1w) https://github.com/python/cpython/actions/runs/25567883859/job/75055937640?pr=149518
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.0.20) https://github.com/python/cpython/actions/runs/25567883859/job/75055937616?pr=149518
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.3.7) https://github.com/python/cpython/actions/runs/25567883859/job/75055937668?pr=149518
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.4.5) https://github.com/python/cpython/actions/runs/25567883859/job/75055937663?pr=149518
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.5.6) https://github.com/python/cpython/actions/runs/25567883859/job/75055937658?pr=149518
Ubuntu SSL tests (ubuntu-24.04, openssl, 3.6.2) https://github.com/python/cpython/actions/runs/25567883859/job/75055937642?pr=149518
Ubuntu SSL tests (ubuntu-24.04, openssl, 4.0.0) https://github.com/python/cpython/actions/runs/25567883859/job/75055937647?pr=149518
Ubuntu SSL tests (ubuntu-24.04, aws-lc, 1.72.1) https://github.com/python/cpython/actions/runs/25567883859/job/75055937644?pr=149518
Android (aarch64) https://github.com/python/cpython/actions/runs/25567883859/job/75055937618?pr=149518
Android (x86_64) https://github.com/python/cpython/actions/runs/25567883859/job/75055937622?pr=149518
iOS https://github.com/python/cpython/actions/runs/25567883859/job/75055937562?pr=149518
Emscripten / build and test https://github.com/python/cpython/actions/runs/25567883859/job/75055937740?pr=149518
WASI / build and test https://github.com/python/cpython/actions/runs/25567883859/job/75055937717?pr=149518
Hypothesis tests on Ubuntu https://github.com/python/cpython/actions/runs/25567883859/job/75055937598?pr=149518
Address sanitizer (ubuntu-24.04) https://github.com/python/cpython/actions/runs/25567883859/job/75055937490?pr=149518
Sanitizers / TSan https://github.com/python/cpython/actions/runs/25567883859/job/75055937991?pr=149518
Sanitizers / TSan (free-threading) https://github.com/python/cpython/actions/runs/25567883859/job/75055937982?pr=149518
Sanitizers / UBSan https://github.com/python/cpython/actions/runs/25567883859/job/75055938000?pr=149518
Cross build Linux https://github.com/python/cpython/actions/runs/25567883859/job/75055937656?pr=149518
CIFuzz${{ '' }} https://github.com/python/cpython/actions/runs/25567883859/job/75055937868?pr=149518
All required checks pass https://github.com/python/cpython/actions/runs/25567883859/job/75060109664?pr=149518
Check labels on: pull_request https://github.com/python/cpython/actions/runs/25603165620
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/25603165620/job/75160423264?pr=149518
Unresolved review https://github.com/python/cpython/actions/runs/25603165620/job/75160423265?pr=149518
Check labels on: pull_request https://github.com/python/cpython/actions/runs/25603165857
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/25603165857/job/75160423643?pr=149518
Unresolved review https://github.com/python/cpython/actions/runs/25603165857/job/75160423630?pr=149518
Check labels on: pull_request https://github.com/python/cpython/actions/runs/25603193174
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/25603193174/job/75160492928?pr=149518
Unresolved review https://github.com/python/cpython/actions/runs/25603193174/job/75160492918?pr=149518
Check labels on: pull_request https://github.com/python/cpython/actions/runs/25603193179
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/25603193179/job/75160492956?pr=149518
Unresolved review https://github.com/python/cpython/actions/runs/25603193179/job/75160492962?pr=149518
Check labels on: pull_request https://github.com/python/cpython/actions/runs/25603193205
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/25603193205/job/75160492970?pr=149518
Unresolved review https://github.com/python/cpython/actions/runs/25603193205/job/75160492966?pr=149518
Check labels on: pull_request https://github.com/python/cpython/actions/runs/25603193279
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/25603193279/job/75160493109?pr=149518
Unresolved review https://github.com/python/cpython/actions/runs/25603193279/job/75160493113?pr=149518
Check labels on: pull_request https://github.com/python/cpython/actions/runs/25603231695
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/25603231695/job/75160597434?pr=149518
Unresolved review https://github.com/python/cpython/actions/runs/25603231695/job/75160597442?pr=149518
Check labels on: pull_request https://github.com/python/cpython/actions/runs/25603236097
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/25603236097/job/75160608637?pr=149518
Unresolved review https://github.com/python/cpython/actions/runs/25603236097/job/75160608633?pr=149518
Check labels on: pull_request https://github.com/python/cpython/actions/runs/25603237735
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/25603237735/job/75160613021?pr=149518
Unresolved review https://github.com/python/cpython/actions/runs/25603237735/job/75160613018?pr=149518
Check labels on: pull_request https://github.com/python/cpython/actions/runs/25603239671
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/25603239671/job/75160617818?pr=149518
Unresolved review https://github.com/python/cpython/actions/runs/25603239671/job/75160617819?pr=149518
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.