René's URL Explorer Experiment


Title: gh-106693: Revert "Explicitly mark ob_sval as unsigned char to avoid UB (#106826)" by hugovk · Pull Request #149514 · python/cpython · GitHub

Open Graph Title: gh-106693: Revert "Explicitly mark ob_sval as unsigned char to avoid UB (#106826)" by hugovk · Pull Request #149514 · python/cpython

X Title: gh-106693: Revert "Explicitly mark ob_sval as unsigned char to avoid UB (#106826)" by hugovk · Pull Request #149514 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This reverts commit fbba343 and 310fe88. Was set to automerge 8 months, and three days ago, respectively, but weren't meant to merge right now. I'd temporarily removed branch protection to ...

X Description: This reverts commit fbba343 and 310fe88. Was set to automerge 8 months, and three days ago, respectively, but weren't meant to merge right now. I'd temporarily removed branch protec...

Opengraph URL: https://github.com/python/cpython/pull/149514

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f5562bab-2a75-8af1-b7f0-2a2b1add8f94
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id96A6:1148D3:37938FC:46E6EC2:6B01F738
html-safe-nonce12113f4a73dab1602075322aad7a25d9e8d3285e4298083a702069a70bf2f2fe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkE2OjExNDhEMzozNzkzOEZDOjQ2RTZFQzI6NkIwMUY3MzgiLCJ2aXNpdG9yX2lkIjoiNTA3NTA4ODc5NzkxMDMwMDQ3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7b1183d50d1bab79c3cc1a202ebc1783ab8c981a279d052eb5b8276ea5339550
hovercard-subject-tagpull_request:3645408895
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/149514/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/35de6f821fa2397520ead3eb57c64a0b0d538bf28eeb589ab064ed2fdc6d2b88/python/cpython/pull/149514
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/35de6f821fa2397520ead3eb57c64a0b0d538bf28eeb589ab064ed2fdc6d2b88/python/cpython/pull/149514
og:image:altThis reverts commit fbba343 and 310fe88. Was set to automerge 8 months, and three days ago, respectively, but weren't meant to merge right now. I'd temporarily removed branch protection to ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehugovk
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/149514#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149514
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149514
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/149514
Reloadhttps://github.com/python/cpython/pull/149514
Reloadhttps://github.com/python/cpython/pull/149514
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
hugovkhttps://github.com/hugovk
python:mainhttps://github.com/python/cpython/tree/main
hugovk:3.16-revert-fbba343https://github.com/hugovk/cpython/tree/3.16-revert-fbba343
Conversationhttps://github.com/python/cpython/pull/149514
Commits2 (2)https://github.com/python/cpython/pull/149514/commits
Checkshttps://github.com/python/cpython/pull/149514/checks
Files changedhttps://github.com/python/cpython/pull/149514/files
gh-106693: Revert "Explicitly mark ob_sval as unsigned char to avoid UB (#106826)"https://github.com/python/cpython/pull/149514#top
hugovkhttps://github.com/hugovk
python:mainhttps://github.com/python/cpython/tree/main
hugovk:3.16-revert-fbba343https://github.com/hugovk/cpython/tree/3.16-revert-fbba343
https://github.com/hugovk
hugovkhttps://github.com/hugovk
May 7, 2026https://github.com/python/cpython/pull/149514#issue-4401494812
Please reload this pagehttps://github.com/python/cpython/pull/149514
fbba343https://github.com/python/cpython/commit/fbba343622c9e4a38c8ef0f0b0e311164394d76a
310fe88https://github.com/python/cpython/commit/310fe88994249a5a02e20d1211b8fc067e34aa78
#149500https://github.com/python/cpython/pull/149500
Possible UB in bytes_characters #106693https://github.com/python/cpython/issues/106693
Please reload this pagehttps://github.com/python/cpython/pull/149514
https://github.com/hugovk
Revert "https://github.com/python/cpython/pull/149514/commits/fbdda04ea23a2d7131c4f453780aac4593801958
pythongh-106693https://github.com/python/cpython/issues/106693
: Explicitly mark ob_sval as unsigned char to …https://github.com/python/cpython/pull/149514/commits/fbdda04ea23a2d7131c4f453780aac4593801958
fbdda04https://github.com/python/cpython/pull/149514/commits/fbdda04ea23a2d7131c4f453780aac4593801958
python#106826https://github.com/python/cpython/pull/106826
fbba343https://github.com/hugovk/cpython/commit/fbba343622c9e4a38c8ef0f0b0e311164394d76a
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 7, 2026 https://github.com/python/cpython/pull/149514#ref-issue-1801717214
Possible UB in bytes_characters #106693 https://github.com/python/cpython/issues/106693
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 7, 2026https://github.com/python/cpython/pull/149514#event-25277155618
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
May 7, 2026 https://github.com/python/cpython/pull/149514#pullrequestreview-4247193643
View reviewed changes https://github.com/python/cpython/pull/149514/files/fbdda04ea23a2d7131c4f453780aac4593801958
pablogsalhttps://github.com/pablogsal
https://github.com/python/cpython/pull/149514#pullrequestreview-4247193643
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/149514
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 7, 2026https://github.com/python/cpython/pull/149514#event-25277202605
https://github.com/zware
zwarehttps://github.com/zware
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 7, 2026https://github.com/python/cpython/pull/149514#event-25277233611
https://github.com/hugovk
Revert "https://github.com/python/cpython/pull/149514/commits/fdf75b30a354d65df10fa1addf91c5b24d421cd8
pythongh-79638https://github.com/python/cpython/issues/79638
: Treat an unreachable robots.txt as "disallow …https://github.com/python/cpython/pull/149514/commits/fdf75b30a354d65df10fa1addf91c5b24d421cd8
fdf75b3https://github.com/python/cpython/pull/149514/commits/fdf75b30a354d65df10fa1addf91c5b24d421cd8
pythonGH-138555https://github.com/python/cpython/pull/138555
310fe88https://github.com/hugovk/cpython/commit/310fe88994249a5a02e20d1211b8fc067e34aa78
https://github.com/hugovk
hugovkhttps://github.com/hugovk
berkerpeksaghttps://github.com/berkerpeksag
code ownerhttps://github.com/python/cpython/blob/310fe88994249a5a02e20d1211b8fc067e34aa78/.github/CODEOWNERS#L627
May 7, 2026 20:03https://github.com/python/cpython/pull/149514#event-25277957900
https://github.com/hugovk
hugovkhttps://github.com/hugovk
May 7, 2026 https://github.com/python/cpython/pull/149514#ref-pullrequest-3388345697
gh-79638: Treat an unreachable robots.txt as "disallow all" #138555 https://github.com/python/cpython/pull/138555
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
May 7, 2026 https://github.com/python/cpython/pull/149514#pullrequestreview-4247360370
View reviewed changes https://github.com/python/cpython/pull/149514/files/fdf75b30a354d65df10fa1addf91c5b24d421cd8
StanFromIrelandhttps://github.com/StanFromIreland
https://github.com/python/cpython/pull/149514#pullrequestreview-4247360370
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/149514
https://github.com/hugovk
hugovkhttps://github.com/hugovk
f0daba1https://github.com/python/cpython/commit/f0daba1652cbf2eb04feaf21f9c913023f286e7e
May 7, 2026https://github.com/python/cpython/pull/149514#event-25279180574
Please reload this pagehttps://github.com/python/cpython/pull/149514
https://github.com/hugovk
hugovkhttps://github.com/hugovk
May 7, 2026 20:39https://github.com/python/cpython/pull/149514#event-25279181587
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 7, 2026https://github.com/python/cpython/pull/149514#event-25279182282
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 28, 2026 https://github.com/python/cpython/pull/149514#ref-pullrequest-4763371707
gh-79638: Restore "Treat an unreachable robots.txt as disallow all" #152525 https://github.com/python/cpython/pull/152525
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 5, 2026 https://github.com/python/cpython/pull/149514#ref-commit-70100b9
https://github.com/serhiy-storchaka
https://github.com/claude
gh-79638https://github.com/python/cpython/issues/79638
: Restore "Treat an unreachable robots.txt as disallow all" (https://github.com/python/cpython/commit/70100b9ea0b43a95226eee45652a5735bb91e9c7
G…https://github.com/python/cpython/pull/152525
70100b9https://github.com/python/cpython/commit/70100b9ea0b43a95226eee45652a5735bb91e9c7
…H-152525https://github.com/python/cpython/pull/152525
f0daba1https://github.com/python/cpython/commit/f0daba1652cbf2eb04feaf21f9c913023f286e7e
gh-106693https://github.com/python/cpython/issues/106693
GH-149514https://github.com/python/cpython/pull/149514
GH-149569https://github.com/python/cpython/pull/149569
[3.15] gh-79638: Restore "Treat an unreachable robots.txt as disallow all" (GH-152525) #153107 https://github.com/python/cpython/pull/153107
[3.14] gh-79638: Restore "Treat an unreachable robots.txt as disallow all" (GH-152525) #153108 https://github.com/python/cpython/pull/153108
[3.13] gh-79638: Restore "Treat an unreachable robots.txt as disallow all" (GH-152525) #153109 https://github.com/python/cpython/pull/153109
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 5, 2026 https://github.com/python/cpython/pull/149514#ref-commit-d35cfee
https://github.com/miss-islington
https://github.com/serhiy-storchaka
https://github.com/claude
[3.13]https://github.com/python/cpython/commit/d35cfee409db4eceeaa389c206e4a18eeb6eaf9d
gh-79638https://github.com/python/cpython/issues/79638
: Restore "Treat an unreachable robots.txt as disallow…https://github.com/python/cpython/commit/d35cfee409db4eceeaa389c206e4a18eeb6eaf9d
d35cfeehttps://github.com/python/cpython/commit/d35cfee409db4eceeaa389c206e4a18eeb6eaf9d
GH-152525https://github.com/python/cpython/pull/152525
GH-153109https://github.com/python/cpython/pull/153109
f0daba1https://github.com/python/cpython/commit/f0daba1652cbf2eb04feaf21f9c913023f286e7e
gh-106693https://github.com/python/cpython/issues/106693
GH-149514https://github.com/python/cpython/pull/149514
GH-149569https://github.com/python/cpython/pull/149569
70100b9https://github.com/python/cpython/commit/70100b9ea0b43a95226eee45652a5735bb91e9c7
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 5, 2026 https://github.com/python/cpython/pull/149514#ref-commit-a624878
https://github.com/miss-islington
https://github.com/serhiy-storchaka
https://github.com/claude
[3.14]https://github.com/python/cpython/commit/a624878b25582ed018ae0ea347bb672f5704e1a1
gh-79638https://github.com/python/cpython/issues/79638
: Restore "Treat an unreachable robots.txt as disallow…https://github.com/python/cpython/commit/a624878b25582ed018ae0ea347bb672f5704e1a1
a624878https://github.com/python/cpython/commit/a624878b25582ed018ae0ea347bb672f5704e1a1
GH-152525https://github.com/python/cpython/pull/152525
GH-153108https://github.com/python/cpython/pull/153108
f0daba1https://github.com/python/cpython/commit/f0daba1652cbf2eb04feaf21f9c913023f286e7e
gh-106693https://github.com/python/cpython/issues/106693
GH-149514https://github.com/python/cpython/pull/149514
GH-149569https://github.com/python/cpython/pull/149569
70100b9https://github.com/python/cpython/commit/70100b9ea0b43a95226eee45652a5735bb91e9c7
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 5, 2026 https://github.com/python/cpython/pull/149514#ref-commit-2a5f9e0
https://github.com/miss-islington
https://github.com/serhiy-storchaka
https://github.com/claude
[3.15]https://github.com/python/cpython/commit/2a5f9e0e24f270c77d0eb11b69fe99e6c8aecd8f
gh-79638https://github.com/python/cpython/issues/79638
: Restore "Treat an unreachable robots.txt as disallow…https://github.com/python/cpython/commit/2a5f9e0e24f270c77d0eb11b69fe99e6c8aecd8f
2a5f9e0https://github.com/python/cpython/commit/2a5f9e0e24f270c77d0eb11b69fe99e6c8aecd8f
GH-152525https://github.com/python/cpython/pull/152525
GH-153107https://github.com/python/cpython/pull/153107
f0daba1https://github.com/python/cpython/commit/f0daba1652cbf2eb04feaf21f9c913023f286e7e
gh-106693https://github.com/python/cpython/issues/106693
GH-149514https://github.com/python/cpython/pull/149514
GH-149569https://github.com/python/cpython/pull/149569
70100b9https://github.com/python/cpython/commit/70100b9ea0b43a95226eee45652a5735bb91e9c7
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 8, 2026 https://github.com/python/cpython/pull/149514#ref-commit-b9466eb
https://github.com/serhiy-storchaka
https://github.com/claude
pythongh-79638https://github.com/python/cpython/issues/79638
: Restore "Treat an unreachable robots.txt as disallow …https://github.com/serhiy-storchaka/cpython/commit/b9466ebcb967d0192fb1ae059381e9f0f784a1ed
b9466ebhttps://github.com/serhiy-storchaka/cpython/commit/b9466ebcb967d0192fb1ae059381e9f0f784a1ed
f0daba1https://github.com/serhiy-storchaka/cpython/commit/f0daba1652cbf2eb04feaf21f9c913023f286e7e
pythongh-106693https://github.com/python/cpython/issues/106693
pythonGH-149514https://github.com/python/cpython/pull/149514
pythonGH-149569https://github.com/python/cpython/pull/149569
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149514
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
https://github.com/python/cpython/pull/149514/files/fbdda04ea23a2d7131c4f453780aac4593801958
https://github.com/StanFromIreland
StanFromIreland https://github.com/StanFromIreland
https://github.com/python/cpython/pull/149514/files/fdf75b30a354d65df10fa1addf91c5b24d421cd8
https://github.com/berkerpeksag
berkerpeksag https://github.com/berkerpeksag
Please reload this pagehttps://github.com/python/cpython/pull/149514
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/149514
https://github.com/hugovk
https://github.com/pablogsal
https://github.com/StanFromIreland
https://github.com/zware
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.