René's URL Explorer Experiment


Title: gh-149306: Improve error messages in wave module to include the offending value by htjworld · Pull Request #149307 · python/cpython · GitHub

Open Graph Title: gh-149306: Improve error messages in wave module to include the offending value by htjworld · Pull Request #149307 · python/cpython

X Title: gh-149306: Improve error messages in wave module to include the offending value by htjworld · Pull Request #149307 · python/cpython

Description: Summary Include the offending value in wave.Error messages raised by: Wave_read._read_fmt_chunk (parses WAV file header) Wave_write.setnchannels Wave_write.setsampwidth Wave_write.setframerate Before: wave.Error: bad # of channels wave.Error: bad sample width wave.Error: bad frame rate After: wave.Error: bad # of channels: 0 wave.Error: bad sample width: 0 wave.Error: bad frame rate: -1 Motivation Wave_read: Values come from the WAV file header — they never appear in the traceback. The error message is the only debugging clue. Wave_write: When values originate from variables, configuration files, or parsed data rather than literals, the traceback shows the call site but not the value itself. For example, w.setframerate(config['rate']) raises bad frame rate with no indication of what config['rate'] was. This extends the clear-feedback approach introduced in gh-144976, which fixed the validation order in setframerate to raise immediately at the point of the mistake. Showing the offending value is the natural next step. For setframerate, the original value (before int(round())) is shown rather than the rounded result, so callers see exactly what they passed. Precedent statistics: raise StatisticsError(f'No negative inputs allowed: {x!r}') (gh-149246) asyncio: raise ValueError(f'A Stream Socket was expected, got {sock!r}') Notes Error type is unchanged; only the message text is refined. The bits/bytes unit ambiguity in bad sample width predates this PR and can be addressed separately. NaN/Inf handling in setframerate is pre-existing behaviour and out of scope here. Issue: gh-149306

Open Graph Description: Summary Include the offending value in wave.Error messages raised by: Wave_read._read_fmt_chunk (parses WAV file header) Wave_write.setnchannels Wave_write.setsampwidth Wave_write.setframerate Be...

X Description: Summary Include the offending value in wave.Error messages raised by: Wave_read._read_fmt_chunk (parses WAV file header) Wave_write.setnchannels Wave_write.setsampwidth Wave_write.setframerate Be...

Opengraph URL: https://github.com/python/cpython/pull/149307

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:00f7d63c-41c6-1106-95cc-ce5e8b258073
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCB04:268458:358E96:49991C:6AECCB7E
html-safe-nonce0a0b054272e8e0a0697f3c0d9852480d464701d78a5dac103c7d4b4117901f08
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjA0OjI2ODQ1ODozNThFOTY6NDk5OTFDOjZBRUNDQjdFIiwidmlzaXRvcl9pZCI6IjQzMTE5MDc5NjMwNjkzMjAwNjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf620ce21e927ba0df2a18528190f331712085c3788ca4665dd74595fdf3b7612
hovercard-subject-tagpull_request:3619142718
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/149307/files
twitter:imagehttps://avatars.githubusercontent.com/u/116538001?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/116538001?s=400&v=4
og:image:altSummary Include the offending value in wave.Error messages raised by: Wave_read._read_fmt_chunk (parses WAV file header) Wave_write.setnchannels Wave_write.setsampwidth Wave_write.setframerate Be...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonedc0b519c5798dc1150b88dc4c06a8b9634d0069218dc04e469970e76aad74016
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb139f0bf57b59bf9a8c4abb0849924d6c6ca559
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/149307/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149307%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149307%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/149307/files
Reloadhttps://github.com/python/cpython/pull/149307/files
Reloadhttps://github.com/python/cpython/pull/149307/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.3k (2.3k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
htjworldhttps://github.com/htjworld
python:mainhttps://github.com/python/cpython/tree/main
htjworld:gh-149306-wave-error-messageshttps://github.com/htjworld/cpython/tree/gh-149306-wave-error-messages
Conversation 10 https://github.com/python/cpython/pull/149307
Commits 3 https://github.com/python/cpython/pull/149307/commits
Checks 51 https://github.com/python/cpython/pull/149307/checks
Files changed https://github.com/python/cpython/pull/149307/files
Please reload this pagehttps://github.com/python/cpython/pull/149307/files
gh-149306: Improve error messages in wave module to include the offending value https://github.com/python/cpython/pull/149307/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/149307/files
d1ba708 gh-149306: Improve error messages in wave module to include the offen… htjworld May 3, 2026 https://github.com/python/cpython/pull/149307/commits/d1ba7081e2f5e997fd94fc4fb89a21448c876fe5
52c4f5e Merge remote-tracking branch 'upstream/main' into gh-149306-wave-erro… htjworld May 3, 2026 https://github.com/python/cpython/pull/149307/commits/52c4f5e94c003662ca9a8e3756de9484def59c97
2d4c5e4 Address review: revert _read_fmt_chunk unpack, rename rounded_framera… htjworld May 3, 2026 https://github.com/python/cpython/pull/149307/commits/2d4c5e43537292b5cb02ecb7e7f878a7e8deb868
Clear filters https://github.com/python/cpython/pull/149307/files
Please reload this pagehttps://github.com/python/cpython/pull/149307/files
Please reload this pagehttps://github.com/python/cpython/pull/149307/files
test_wave.py https://github.com/python/cpython/pull/149307/files#diff-a199f1748809afe147b8e298adaef9a1af3bcf7c519b64823b573a47c4e55bbe
wave.py https://github.com/python/cpython/pull/149307/files#diff-8e67a696f050c6abebc661b71a215e2c2bb8d0bb2f27ee2ba25adecc8b1b094c
2026-05-03-11-09-48.gh-issue-149306.jvi7uE.rst https://github.com/python/cpython/pull/149307/files#diff-9377db8057196c91bba41d4858241ab3da48c1180a0aa91a60b30da92d888f87
Lib/test/test_wave.pyhttps://github.com/python/cpython/pull/149307/files#diff-a199f1748809afe147b8e298adaef9a1af3bcf7c519b64823b573a47c4e55bbe
View file https://github.com/python/cpython/blob/2d4c5e43537292b5cb02ecb7e7f878a7e8deb868/Lib/test/test_wave.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149307/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149307/files#diff-a199f1748809afe147b8e298adaef9a1af3bcf7c519b64823b573a47c4e55bbe
https://github.com/python/cpython/pull/149307/files#diff-a199f1748809afe147b8e298adaef9a1af3bcf7c519b64823b573a47c4e55bbe
https://github.com/python/cpython/pull/149307/files#diff-a199f1748809afe147b8e298adaef9a1af3bcf7c519b64823b573a47c4e55bbe
https://github.com/python/cpython/pull/149307/files#diff-a199f1748809afe147b8e298adaef9a1af3bcf7c519b64823b573a47c4e55bbe
https://github.com/python/cpython/pull/149307/files#diff-a199f1748809afe147b8e298adaef9a1af3bcf7c519b64823b573a47c4e55bbe
https://github.com/python/cpython/pull/149307/files#diff-a199f1748809afe147b8e298adaef9a1af3bcf7c519b64823b573a47c4e55bbe
Lib/wave.pyhttps://github.com/python/cpython/pull/149307/files#diff-8e67a696f050c6abebc661b71a215e2c2bb8d0bb2f27ee2ba25adecc8b1b094c
View file https://github.com/python/cpython/blob/2d4c5e43537292b5cb02ecb7e7f878a7e8deb868/Lib/wave.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149307/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149307/files#diff-8e67a696f050c6abebc661b71a215e2c2bb8d0bb2f27ee2ba25adecc8b1b094c
https://github.com/python/cpython/pull/149307/files#diff-8e67a696f050c6abebc661b71a215e2c2bb8d0bb2f27ee2ba25adecc8b1b094c
https://github.com/python/cpython/pull/149307/files#diff-8e67a696f050c6abebc661b71a215e2c2bb8d0bb2f27ee2ba25adecc8b1b094c
https://github.com/python/cpython/pull/149307/files#diff-8e67a696f050c6abebc661b71a215e2c2bb8d0bb2f27ee2ba25adecc8b1b094c
https://github.com/python/cpython/pull/149307/files#diff-8e67a696f050c6abebc661b71a215e2c2bb8d0bb2f27ee2ba25adecc8b1b094c
https://github.com/python/cpython/pull/149307/files#diff-8e67a696f050c6abebc661b71a215e2c2bb8d0bb2f27ee2ba25adecc8b1b094c
Misc/NEWS.d/next/Library/2026-05-03-11-09-48.gh-issue-149306.jvi7uE.rsthttps://github.com/python/cpython/pull/149307/files#diff-9377db8057196c91bba41d4858241ab3da48c1180a0aa91a60b30da92d888f87
View file https://github.com/python/cpython/blob/2d4c5e43537292b5cb02ecb7e7f878a7e8deb868/Misc/NEWS.d/next/Library/2026-05-03-11-09-48.gh-issue-149306.jvi7uE.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149307/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/149307/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.