René's URL Explorer Experiment


Title: gh-149009: Validate `thread_count` in `profiling.sampling` binary reader by maurycy · Pull Request #149147 · python/cpython · GitHub

Open Graph Title: gh-149009: Validate `thread_count` in `profiling.sampling` binary reader by maurycy · Pull Request #149147 · python/cpython

X Title: gh-149009: Validate `thread_count` in `profiling.sampling` binary reader by maurycy · Pull Request #149147 · python/cpython

Description: The profiling.sampling binary reader reads thread_count stored in the file header but replay does not validate if there's more (thread_id, interp_id) pairs than declared. To make it clear: that's just a validation. Resolves gh-149009

Open Graph Description: The profiling.sampling binary reader reads thread_count stored in the file header but replay does not validate if there's more (thread_id, interp_id) pairs than declared. To make it clear: that...

X Description: The profiling.sampling binary reader reads thread_count stored in the file header but replay does not validate if there's more (thread_id, interp_id) pairs than declared. To make it clear: ...

Opengraph URL: https://github.com/python/cpython/pull/149147

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:72ec961b-4644-7ad9-7875-bcae78a26acd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB438:22DB35:49C2FEF:5DD4689:6B0241C5
html-safe-nonce4f83b498888ddbc2e872b744f0a5e8b9e166cd0f537bc29d7a60f2801a6c76e0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDM4OjIyREIzNTo0OUMyRkVGOjVERDQ2ODk6NkIwMjQxQzUiLCJ2aXNpdG9yX2lkIjoiNDY0NjE4MDUwMDMwNDcwODAzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7a83d0ef67d948197bbd16b2e7e57d6a2ad47127fb88403c9c94add6017c0676
hovercard-subject-tagpull_request:3601861660
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/149147/files
twitter:imagehttps://avatars.githubusercontent.com/u/5383?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5383?s=400&v=4
og:image:altThe profiling.sampling binary reader reads thread_count stored in the file header but replay does not validate if there's more (thread_id, interp_id) pairs than declared. To make it clear: that...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/149147/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149147%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F149147%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/149147/files
Reloadhttps://github.com/python/cpython/pull/149147/files
Reloadhttps://github.com/python/cpython/pull/149147/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
maurycy:remote-debugger-thread-count-maxhttps://github.com/maurycy/cpython/tree/remote-debugger-thread-count-max
Conversation 3 https://github.com/python/cpython/pull/149147
Commits 3 https://github.com/python/cpython/pull/149147/commits
Checks 58 https://github.com/python/cpython/pull/149147/checks
Files changed 3 https://github.com/python/cpython/pull/149147/files
gh-149009: Validate thread_count in profiling.sampling binary reader https://github.com/python/cpython/pull/149147/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/149147/files
d48dd67 that's it? maurycy Apr 29, 2026 https://github.com/python/cpython/pull/149147/commits/d48dd67d570c524a5448d5d8d786b8a80cb5a810
a0488e0 test maurycy Apr 29, 2026 https://github.com/python/cpython/pull/149147/commits/a0488e0ccf18f07afee683bc045279b60531c18f
12b05f3 blurb maurycy Apr 29, 2026 https://github.com/python/cpython/pull/149147/commits/12b05f33c47b77b3bb85c01ac0afb72651b82c30
Clear filters https://github.com/python/cpython/pull/149147/files
Please reload this pagehttps://github.com/python/cpython/pull/149147/files
Please reload this pagehttps://github.com/python/cpython/pull/149147/files
test_binary_format.py https://github.com/python/cpython/pull/149147/files#diff-bd4b914717c4ce7ddb2e29a91a71fdba550983ce9cea09b1ee06847b128d71b6
2026-04-29-13-08-46.gh-issue-149009.rek3Tw.rst https://github.com/python/cpython/pull/149147/files#diff-19c321de554edbc01a4a071bd9fe4f25348b8871be2ef0ce735837818a90d4ab
binary_io_reader.c https://github.com/python/cpython/pull/149147/files#diff-dfdcb94821b5902e4d751f5d78e385c19c1efa6ef2ed808e358741e41fda369b
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L568
Lib/test/test_profiling/test_sampling_profiler/test_binary_format.pyhttps://github.com/python/cpython/pull/149147/files#diff-bd4b914717c4ce7ddb2e29a91a71fdba550983ce9cea09b1ee06847b128d71b6
View file https://github.com/maurycy/cpython/blob/12b05f33c47b77b3bb85c01ac0afb72651b82c30/Lib/test/test_profiling/test_sampling_profiler/test_binary_format.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149147/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149147/files#diff-bd4b914717c4ce7ddb2e29a91a71fdba550983ce9cea09b1ee06847b128d71b6
https://github.com/python/cpython/pull/149147/files#diff-bd4b914717c4ce7ddb2e29a91a71fdba550983ce9cea09b1ee06847b128d71b6
https://github.com/python/cpython/pull/149147/files#diff-bd4b914717c4ce7ddb2e29a91a71fdba550983ce9cea09b1ee06847b128d71b6
https://github.com/python/cpython/pull/149147/files#diff-bd4b914717c4ce7ddb2e29a91a71fdba550983ce9cea09b1ee06847b128d71b6
Misc/NEWS.d/next/Library/2026-04-29-13-08-46.gh-issue-149009.rek3Tw.rsthttps://github.com/python/cpython/pull/149147/files#diff-19c321de554edbc01a4a071bd9fe4f25348b8871be2ef0ce735837818a90d4ab
View file https://github.com/maurycy/cpython/blob/12b05f33c47b77b3bb85c01ac0afb72651b82c30/Misc/NEWS.d/next/Library/2026-04-29-13-08-46.gh-issue-149009.rek3Tw.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149147/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L336
Modules/_remote_debugging/binary_io_reader.chttps://github.com/python/cpython/pull/149147/files#diff-dfdcb94821b5902e4d751f5d78e385c19c1efa6ef2ed808e358741e41fda369b
View file https://github.com/maurycy/cpython/blob/12b05f33c47b77b3bb85c01ac0afb72651b82c30/Modules/_remote_debugging/binary_io_reader.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/149147/{{ revealButtonHref }}
https://github.com/python/cpython/pull/149147/files#diff-dfdcb94821b5902e4d751f5d78e385c19c1efa6ef2ed808e358741e41fda369b
Please reload this pagehttps://github.com/python/cpython/pull/149147/files
https://github.com/python/cpython/pull/149147/files#diff-dfdcb94821b5902e4d751f5d78e385c19c1efa6ef2ed808e358741e41fda369b
Please reload this pagehttps://github.com/python/cpython/pull/149147/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.