René's URL Explorer Experiment


Title: gh-148947: dataclasses: fix error on empty __class__ cell by JelleZijlstra · Pull Request #148948 · python/cpython · GitHub

Open Graph Title: gh-148947: dataclasses: fix error on empty __class__ cell by JelleZijlstra · Pull Request #148948 · python/cpython

X Title: gh-148947: dataclasses: fix error on empty __class__ cell by JelleZijlstra · Pull Request #148948 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Also add a test demonstrating the need for the existing "is oldcls" check. Issue: dataclass(slots=True) fails if method has an empty __class__ cell #148947

X Description: Also add a test demonstrating the need for the existing "is oldcls" check. Issue: dataclass(slots=True) fails if method has an empty __class__ cell #148947

Opengraph URL: https://github.com/python/cpython/pull/148948

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7639591f-bd1b-03d2-fb61-7fb65044c9e4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD04:38EE04:17C0DBF:1F5CFDD:6B020846
html-safe-nonce5aba9c1653b86f1a5310ece0bc3a29928ed21b3d4847b12a61aee88af89ab796
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDA0OjM4RUUwNDoxN0MwREJGOjFGNUNGREQ6NkIwMjA4NDYiLCJ2aXNpdG9yX2lkIjoiMjU1MTg2NzA5NTczMDIyNzI3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf3b3ae6d12358d8cf154bfda6844b52bc269c8ad036bd392038b7c2086876178
hovercard-subject-tagpull_request:3577077117
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/148948/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ac0d804bf05fcf49b7294225c9e14d449ca209ea049b0e56cffebb3a00c405c5/python/cpython/pull/148948
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ac0d804bf05fcf49b7294225c9e14d449ca209ea049b0e56cffebb3a00c405c5/python/cpython/pull/148948
og:image:altAlso add a test demonstrating the need for the existing "is oldcls" check. Issue: dataclass(slots=True) fails if method has an empty __class__ cell #148947
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJelleZijlstra
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/148948#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148948
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148948
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/148948
Reloadhttps://github.com/python/cpython/pull/148948
Reloadhttps://github.com/python/cpython/pull/148948
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
JelleZijlstra:weirdclasshttps://github.com/JelleZijlstra/cpython/tree/weirdclass
Conversationhttps://github.com/python/cpython/pull/148948
Commits2 (2)https://github.com/python/cpython/pull/148948/commits
Checkshttps://github.com/python/cpython/pull/148948/checks
Files changedhttps://github.com/python/cpython/pull/148948/files
gh-148947: dataclasses: fix error on empty __class__ cell https://github.com/python/cpython/pull/148948#top
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
JelleZijlstra:weirdclasshttps://github.com/JelleZijlstra/cpython/tree/weirdclass
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 24, 2026https://github.com/python/cpython/pull/148948#issue-4320573459
Please reload this pagehttps://github.com/python/cpython/pull/148948
dataclass(slots=True) fails if method has an empty __class__ cell #148947https://github.com/python/cpython/issues/148947
Please reload this pagehttps://github.com/python/cpython/pull/148948
https://github.com/JelleZijlstra
pythongh-148947https://github.com/python/cpython/issues/148947
: dataclasses: fix crash on empty __class__ cellhttps://github.com/python/cpython/pull/148948/commits/9983346ba92d5aa2735a0dfa0d6ff5b76bf50f2d
9983346https://github.com/python/cpython/pull/148948/commits/9983346ba92d5aa2735a0dfa0d6ff5b76bf50f2d
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Apr 24, 2026https://github.com/python/cpython/pull/148948#event-24823505032
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
ericvsmithhttps://github.com/ericvsmith
code ownerhttps://github.com/python/cpython/blob/448d7b96c181d13ca7f8977780e85b53b2716294/.github/CODEOWNERS#L426
April 24, 2026 04:49https://github.com/python/cpython/pull/148948#event-24823505046
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 24, 2026https://github.com/python/cpython/pull/148948#event-24823505937
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 24, 2026 https://github.com/python/cpython/pull/148948#ref-issue-4320467826
dataclass(slots=True) fails if method has an empty __class__ cell #148947 https://github.com/python/cpython/issues/148947
https://github.com/johnslavik
johnslavikhttps://github.com/johnslavik
Apr 24, 2026https://github.com/python/cpython/pull/148948#event-24830788097
https://github.com/johnslavik
johnslavikhttps://github.com/johnslavik
Apr 24, 2026 https://github.com/python/cpython/pull/148948#pullrequestreview-4169307768
View reviewed changes https://github.com/python/cpython/pull/148948/files/9983346ba92d5aa2735a0dfa0d6ff5b76bf50f2d
johnslavikhttps://github.com/johnslavik
https://github.com/python/cpython/pull/148948#pullrequestreview-4169307768
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/148948
Lib/test/test_dataclasses/__init__.pyhttps://github.com/python/cpython/pull/148948/files/9983346ba92d5aa2735a0dfa0d6ff5b76bf50f2d#diff-212e368b34eb9b134f87e765787d6d26b747235a358e13da8922f83861c0d676
Please reload this pagehttps://github.com/python/cpython/pull/148948
https://github.com/johnslavik
johnslavikhttps://github.com/johnslavik
Apr 24, 2026https://github.com/python/cpython/pull/148948#event-24831022513
https://github.com/johnslavik
johnslavikhttps://github.com/johnslavik
Apr 24, 2026https://github.com/python/cpython/pull/148948#event-24837387360
https://github.com/JelleZijlstra
https://github.com/johnslavik
Update Lib/test/test_dataclasses/__init__.pyhttps://github.com/python/cpython/pull/148948/commits/f3792ab96f82594a5c885f69b06244c20eee2479
f3792abhttps://github.com/python/cpython/pull/148948/commits/f3792ab96f82594a5c885f69b06244c20eee2479
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
6d7bbeehttps://github.com/python/cpython/commit/6d7bbee1d5714a345dca5a7e4089de3c2fc0fb59
Apr 25, 2026https://github.com/python/cpython/pull/148948#event-24868084285
Please reload this pagehttps://github.com/python/cpython/pull/148948
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Apr 25, 2026https://github.com/python/cpython/pull/148948#issuecomment-4319956467
@JelleZijlstrahttps://github.com/JelleZijlstra
Please reload this pagehttps://github.com/python/cpython/pull/148948
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 25, 2026https://github.com/python/cpython/pull/148948#event-24868084780
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
April 25, 2026 15:31https://github.com/python/cpython/pull/148948#event-24868085065
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 25, 2026https://github.com/python/cpython/pull/148948#issuecomment-4319956689
GH-148995https://github.com/python/cpython/pull/148995
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/148948
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Apr 25, 2026https://github.com/python/cpython/pull/148948#event-24868086186
ljfphttps://github.com/ljfp
Apr 25, 2026 https://github.com/python/cpython/pull/148948#ref-commit-efe54da
https://github.com/JelleZijlstra
https://github.com/johnslavik
https://github.com/ljfp
pythongh-148947https://github.com/python/cpython/issues/148947
: dataclasses: fix error on empty __class__ cell (https://github.com/ljfp/cpython/commit/efe54da446f80b4102ce70a5a5b1a183f5a376a4
pyth…https://github.com/python/cpython/pull/148948
efe54dahttps://github.com/ljfp/cpython/commit/efe54da446f80b4102ce70a5a5b1a183f5a376a4
…on#148948https://github.com/python/cpython/pull/148948
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 25, 2026 https://github.com/python/cpython/pull/148948#ref-commit-15e2b64
https://github.com/miss-islington
https://github.com/JelleZijlstra
https://github.com/johnslavik
[3.14]https://github.com/python/cpython/commit/15e2b64cd8bfaf0d5127584a88bb6b929f8dcc19
gh-148947https://github.com/python/cpython/issues/148947
: dataclasses: fix error on empty __class__ cell (https://github.com/python/cpython/commit/15e2b64cd8bfaf0d5127584a88bb6b929f8dcc19
GH-…https://github.com/python/cpython/pull/148948
15e2b64https://github.com/python/cpython/commit/15e2b64cd8bfaf0d5127584a88bb6b929f8dcc19
…148948https://github.com/python/cpython/pull/148948
#148995https://github.com/python/cpython/pull/148995
gh-148947https://github.com/python/cpython/issues/148947
GH-148948https://github.com/python/cpython/pull/148948
6d7bbeehttps://github.com/python/cpython/commit/6d7bbee1d5714a345dca5a7e4089de3c2fc0fb59
gpsheadhttps://github.com/gpshead
Apr 25, 2026 https://github.com/python/cpython/pull/148948#ref-commit-3abfebc
https://github.com/gpshead
https://github.com/JelleZijlstra
https://github.com/johnslavik
https://github.com/claude
[3.13]https://github.com/gpshead/cpython/commit/3abfebc9a0d7745140caeaac05d291c3c75aa08d
pythongh-148947https://github.com/python/cpython/issues/148947
: dataclasses: fix error on empty __class__ cell (https://github.com/gpshead/cpython/commit/3abfebc9a0d7745140caeaac05d291c3c75aa08d
3abfebchttps://github.com/gpshead/cpython/commit/3abfebc9a0d7745140caeaac05d291c3c75aa08d
pythonGH-148948https://github.com/python/cpython/pull/148948
pythongh-148947https://github.com/python/cpython/issues/148947
pythonGH-148948https://github.com/python/cpython/pull/148948
6d7bbeehttps://github.com/gpshead/cpython/commit/6d7bbee1d5714a345dca5a7e4089de3c2fc0fb59
gpsheadhttps://github.com/gpshead
Apr 25, 2026 https://github.com/python/cpython/pull/148948#ref-commit-678cc46
https://github.com/gpshead
https://github.com/JelleZijlstra
https://github.com/johnslavik
https://github.com/claude
[3.13]https://github.com/gpshead/cpython/commit/678cc46cb7c82f5f9b641b9870286aed0a6f6730
pythongh-148947https://github.com/python/cpython/issues/148947
: dataclasses: fix error on empty __class__ cell (https://github.com/gpshead/cpython/commit/678cc46cb7c82f5f9b641b9870286aed0a6f6730
678cc46https://github.com/gpshead/cpython/commit/678cc46cb7c82f5f9b641b9870286aed0a6f6730
pythonGH-148948https://github.com/python/cpython/pull/148948
pythongh-148947https://github.com/python/cpython/issues/148947
pythonGH-148948https://github.com/python/cpython/pull/148948
6d7bbeehttps://github.com/gpshead/cpython/commit/6d7bbee1d5714a345dca5a7e4089de3c2fc0fb59
pythonGH-148947https://github.com/python/cpython/issues/148947
gpsheadhttps://github.com/gpshead
Apr 26, 2026 https://github.com/python/cpython/pull/148948#ref-commit-9651429
https://github.com/gpshead
https://github.com/Prometheus3375
https://github.com/JelleZijlstra
https://github.com/johnslavik
[3.13]https://github.com/python/cpython/commit/9651429aa7a882601d80d3069045707202115bcc
gh-105936https://github.com/python/cpython/issues/105936
: Properly update closure cells for __setattr__ and _…https://github.com/python/cpython/commit/9651429aa7a882601d80d3069045707202115bcc
9651429https://github.com/python/cpython/commit/9651429aa7a882601d80d3069045707202115bcc
GH-144021https://github.com/python/cpython/pull/144021
GH-148476https://github.com/python/cpython/pull/148476
gh-105936https://github.com/python/cpython/issues/105936
GH-144021https://github.com/python/cpython/pull/144021
8a398bfhttps://github.com/python/cpython/commit/8a398bfbbc6769f6cabb3177702e7a506e203d61
GH-124455https://github.com/python/cpython/pull/124455
gh-90562https://github.com/python/cpython/issues/90562
GH-124455https://github.com/python/cpython/pull/124455
GH-137047https://github.com/python/cpython/pull/137047
gh-135228https://github.com/python/cpython/issues/135228
gh-148947https://github.com/python/cpython/issues/148947
GH-148948https://github.com/python/cpython/pull/148948
6d7bbeehttps://github.com/python/cpython/commit/6d7bbee1d5714a345dca5a7e4089de3c2fc0fb59
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148948
https://github.com/johnslavik
johnslavik https://github.com/johnslavik
https://github.com/python/cpython/pull/148948/files/9983346ba92d5aa2735a0dfa0d6ff5b76bf50f2d
https://github.com/ericvsmith
ericvsmith https://github.com/ericvsmith
Please reload this pagehttps://github.com/python/cpython/pull/148948
Please reload this pagehttps://github.com/python/cpython/pull/148948
https://github.com/JelleZijlstra
https://github.com/johnslavik
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.