René's URL Explorer Experiment


Title: gh-148891: prevent crash in HAMT by KowalskiThomas · Pull Request #148928 · python/cpython · GitHub

Open Graph Title: gh-148891: prevent crash in HAMT by KowalskiThomas · Pull Request #148928 · python/cpython

X Title: gh-148891: prevent crash in HAMT by KowalskiThomas · Pull Request #148928 · python/cpython

Description: What is this PR? Fixes #148891. _PyHamt_Assoc allocates HAMT nodes, which can trigger GC. A weakref callback or finaliser fired during GC could re-enter contextvar_set, replacing ctx->ctx_vars via Py_SETREF and freeing the old HAMT while _PyHamt_Assoc was still traversing it, causing a use-after-free. The proposed fix is to hold a strong reference to ctx->ctx_vars during the _PyHamt_Assoc call, so that a re-entrant free cannot affect the HAMT being traversed. Issue: gh-148891

Open Graph Description: What is this PR? Fixes #148891. _PyHamt_Assoc allocates HAMT nodes, which can trigger GC. A weakref callback or finaliser fired during GC could re-enter contextvar_set, replacing ctx->ctx_vars v...

X Description: What is this PR? Fixes #148891. _PyHamt_Assoc allocates HAMT nodes, which can trigger GC. A weakref callback or finaliser fired during GC could re-enter contextvar_set, replacing ctx->ctx_va...

Opengraph URL: https://github.com/python/cpython/pull/148928

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f5b555bd-308b-417f-f81d-65a62db4d513
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB66:1087D4:36C3C02:4922F7D:6B0215FF
html-safe-nonced1a8332c0147ff8cacf9f27abea2c6f122d4987f74ac213aeba7ddf5c9905b95
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjY2OjEwODdENDozNkMzQzAyOjQ5MjJGN0Q6NkIwMjE1RkYiLCJ2aXNpdG9yX2lkIjoiODk3MjM5MjUyMzc0MTkyNjkxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4598ce8435496ccc9bb52286e72795fb332970ce72a601c6dda04fbdbe330cb7
hovercard-subject-tagpull_request:3575035038
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/148928/files
twitter:imagehttps://avatars.githubusercontent.com/u/14239160?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/14239160?s=400&v=4
og:image:altWhat is this PR? Fixes #148891. _PyHamt_Assoc allocates HAMT nodes, which can trigger GC. A weakref callback or finaliser fired during GC could re-enter contextvar_set, replacing ctx->ctx_vars v...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/148928/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148928%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148928%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/148928/files
Reloadhttps://github.com/python/cpython/pull/148928/files
Reloadhttps://github.com/python/cpython/pull/148928/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
cmaloneyhttps://github.com/cmaloney
python:mainhttps://github.com/python/cpython/tree/main
KowalskiThomas:kowalski/fix-prevent-crash-in-hamthttps://github.com/KowalskiThomas/cpython/tree/kowalski/fix-prevent-crash-in-hamt
Conversation 10 https://github.com/python/cpython/pull/148928
Commits 5 https://github.com/python/cpython/pull/148928/commits
Checks 62 https://github.com/python/cpython/pull/148928/checks
Files changed https://github.com/python/cpython/pull/148928/files
Please reload this pagehttps://github.com/python/cpython/pull/148928/files
gh-148891: prevent crash in HAMT https://github.com/python/cpython/pull/148928/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/148928/files
5493663 fix: prevent crash in hamt KowalskiThomas Apr 23, 2026 https://github.com/python/cpython/pull/148928/commits/5493663623c031460f10066d558e9afbcbf0b638
1971be8 misc: add news entry KowalskiThomas Apr 27, 2026 https://github.com/python/cpython/pull/148928/commits/1971be817bfae5ad72c1f263de0dbe573e381b2a
68e43d0 review: update release note KowalskiThomas Oct 21, 2026 https://github.com/python/cpython/pull/148928/commits/68e43d0a8a246c55d5b436727410acacc93b47fc
d6ac3bf chore: shorten comment KowalskiThomas Oct 21, 2026 https://github.com/python/cpython/pull/148928/commits/d6ac3bf64e2ac3873839e38408e1094091a10d28
20725f4 chore: shorten comment further KowalskiThomas Oct 21, 2026 https://github.com/python/cpython/pull/148928/commits/20725f4b32de7dcbcb2bb8bf4356afd714f6d7e1
Clear filters https://github.com/python/cpython/pull/148928/files
Please reload this pagehttps://github.com/python/cpython/pull/148928/files
Please reload this pagehttps://github.com/python/cpython/pull/148928/files
2026-04-23-08-36-47.gh-issue-148891.AMMHow.rst https://github.com/python/cpython/pull/148928/files#diff-75b5a19ab64e9a03734a28d6ce313cd0ff0c59bce386a655c02757497a67575f
context.c https://github.com/python/cpython/pull/148928/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
Misc/NEWS.d/next/Core_and_Builtins/2026-04-23-08-36-47.gh-issue-148891.AMMHow.rsthttps://github.com/python/cpython/pull/148928/files#diff-75b5a19ab64e9a03734a28d6ce313cd0ff0c59bce386a655c02757497a67575f
View file https://github.com/KowalskiThomas/cpython/blob/20725f4b32de7dcbcb2bb8bf4356afd714f6d7e1/Misc/NEWS.d/next/Core_and_Builtins/2026-04-23-08-36-47.gh-issue-148891.AMMHow.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148928/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L240
Python/context.chttps://github.com/python/cpython/pull/148928/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
View file https://github.com/KowalskiThomas/cpython/blob/20725f4b32de7dcbcb2bb8bf4356afd714f6d7e1/Python/context.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148928/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148928/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com/python/cpython/pull/148928/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
https://github.com/python/cpython/pull/148928/files#diff-90866884a04307bbbb14a8c99bcb5c4b96edde026113a014601b2ae38881f149
Please reload this pagehttps://github.com/python/cpython/pull/148928/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.