René's URL Explorer Experiment


Title: gh-148823: Avoid importing `_colorize` when creating an `ArgumentParser` by DavidCEllis · Pull Request #148827 · python/cpython · GitHub

Open Graph Title: gh-148823: Avoid importing `_colorize` when creating an `ArgumentParser` by DavidCEllis · Pull Request #148827 · python/cpython

X Title: gh-148823: Avoid importing `_colorize` when creating an `ArgumentParser` by DavidCEllis · Pull Request #148827 · python/cpython

Description: This is one approach to deferring the _colorize import further. This makes ._theme and ._decolor into properties so that _colorize is no longer imported when _set_color is called, but only when the theme is accessed. Currently to prevent the import from subsequently being triggered when a subparser is created, this adds a 'fake' _colorless_theme which just returns empty strings for all attributes which replaces the actual colourless theme from _colorize. Effectively this is what the colourless theme from _colorize does. I wanted to avoid duplicating all of the attribute names here or further complicating the logic, but there may be a better way to handle this. Testing this did require an addition to the ensure_lazy_imports test helper to allow running additional code before checking for lazy imports. I think this might also be useful elsewhere when testing imports aren't being triggered earlier than intended. Command: ./python -c 'import argparse; argparse.ArgumentParser()' Benchmark 1: main Time (mean ± σ): 28.7 ms ± 3.3 ms [User: 24.1 ms, System: 4.3 ms] Range (min … max): 22.2 ms … 46.4 ms 200 runs Benchmark 2: lazy colorize Time (mean ± σ): 21.6 ms ± 5.8 ms [User: 17.3 ms, System: 4.0 ms] Range (min … max): 12.1 ms … 36.0 ms 200 runs Summary lazy colorize ran 1.33 ± 0.39 times faster than main Note that this uses the new lazy imports, this would need significant tweaking if it were to be backported to 3.14. Issue: gh-148823

Open Graph Description: This is one approach to deferring the _colorize import further. This makes ._theme and ._decolor into properties so that _colorize is no longer imported when _set_color is called, but only when the...

X Description: This is one approach to deferring the _colorize import further. This makes ._theme and ._decolor into properties so that _colorize is no longer imported when _set_color is called, but only when the...

Opengraph URL: https://github.com/python/cpython/pull/148827

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:66693684-a0f1-364e-d09c-ad5698c58fd3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB95C:1AE20C:40F23CB:522C9BD:6B02143D
html-safe-nonce1ee666a34ac39af8d13c421f98624fe0d6879f7042a2f3062f0ba2d8eee4d1e6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTVDOjFBRTIwQzo0MEYyM0NCOjUyMkM5QkQ6NkIwMjE0M0QiLCJ2aXNpdG9yX2lkIjoiODcyNDE1Nzk1Njc5MjM5MDcxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7b84bbf5f4650630d7ccff2936716364e0a7115564f09184ac37a41a2df3f5d2
hovercard-subject-tagpull_request:3561981809
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/148827/files
twitter:imagehttps://avatars.githubusercontent.com/u/15880420?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15880420?s=400&v=4
og:image:altThis is one approach to deferring the _colorize import further. This makes ._theme and ._decolor into properties so that _colorize is no longer imported when _set_color is called, but only when the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/148827/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148827%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148827%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/148827/files
Reloadhttps://github.com/python/cpython/pull/148827/files
Reloadhttps://github.com/python/cpython/pull/148827/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
savannahostrowskihttps://github.com/savannahostrowski
python:mainhttps://github.com/python/cpython/tree/main
DavidCEllis:defer-colorize-argparsehttps://github.com/DavidCEllis/cpython/tree/defer-colorize-argparse
Conversation 18 https://github.com/python/cpython/pull/148827
Commits 12 https://github.com/python/cpython/pull/148827/commits
Checks 50 https://github.com/python/cpython/pull/148827/checks
Files changed 4 https://github.com/python/cpython/pull/148827/files
gh-148823: Avoid importing _colorize when creating an ArgumentParser https://github.com/python/cpython/pull/148827/files#top
Show all changes 12 commits https://github.com/python/cpython/pull/148827/files
a2c9395 Add test helper logic to allow for additional commands in lazy import… DavidCEllis Apr 13, 2026 https://github.com/python/cpython/pull/148827/commits/a2c939581de35e312aa1ed479be13abc64837eb4
629dd53 add tests for lazy imports DavidCEllis Apr 13, 2026 https://github.com/python/cpython/pull/148827/commits/629dd53c6b48925a4ce880eee50296fe1ab5a20b
4fa408e Lazily import _colorize DavidCEllis Apr 13, 2026 https://github.com/python/cpython/pull/148827/commits/4fa408edda57ffd5b801ddf507b6f8fecb5c812a
dd8dcf9 subparser has also been fixed DavidCEllis Apr 21, 2026 https://github.com/python/cpython/pull/148827/commits/dd8dcf9ace683cebe28e5d7b2d03d4fdf37d6a86
36743f6 Add a test for parse_args (based on the readme example) DavidCEllis May 6, 2026 https://github.com/python/cpython/pull/148827/commits/36743f6b9a925cd504e306edac9bfa6a2f45f630
594619c remove unnecessary f-string DavidCEllis May 6, 2026 https://github.com/python/cpython/pull/148827/commits/594619cfd67456821bbd7d0e1b3a622aad438a6c
45ca6b4 📜🤖 Added by blurb_it. blurb-it[bot] May 6, 2026 https://github.com/python/cpython/pull/148827/commits/45ca6b42d8d5149ea4a719c1efb0f1eb9c697811
43b1c51 Merge remote-tracking branch 'upstream/main' into defer-colorize-argp… DavidCEllis May 6, 2026 https://github.com/python/cpython/pull/148827/commits/43b1c51105944aea17623e47f45294ba6b571c0c
0740ca8 Don't use colour for validation checks to avoid the _colorize import DavidCEllis May 6, 2026 https://github.com/python/cpython/pull/148827/commits/0740ca84f341f79db649d6d9df07e1e682027d09
da033fe Add a test to make sure the fake 'colorless' theme stays in sync with DavidCEllis May 6, 2026 https://github.com/python/cpython/pull/148827/commits/da033fe370e764c420ee7c358b39215a963fbf26
c803a10 Include the comment from the suggestion DavidCEllis May 6, 2026 https://github.com/python/cpython/pull/148827/commits/c803a10b628c41bde301776c17884853a2c03bd5
1d13627 Merge branch 'main' into defer-colorize-argparse savannahostrowski May 6, 2026 https://github.com/python/cpython/pull/148827/commits/1d136277a2d99a35c832f2c219e800d3e977fde8
Clear filters https://github.com/python/cpython/pull/148827/files
Please reload this pagehttps://github.com/python/cpython/pull/148827/files
Please reload this pagehttps://github.com/python/cpython/pull/148827/files
argparse.py https://github.com/python/cpython/pull/148827/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
import_helper.py https://github.com/python/cpython/pull/148827/files#diff-9164b29482098900098a8f331d75f919a81d6e8df1f3861eaacdb10967dd7257
test_argparse.py https://github.com/python/cpython/pull/148827/files#diff-c7651634d84a017884451f95f6535a1d2efbeacee1cca7cc1e27fdc748804aa1
2026-05-06-14-26-37.gh-issue-148823.ySmOE4.rst https://github.com/python/cpython/pull/148827/files#diff-99936b0c7d9a82adf72d7529c50902e50551a4c00e9933984e8e28a68d948e95
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L370
Lib/argparse.pyhttps://github.com/python/cpython/pull/148827/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
View file https://github.com/DavidCEllis/cpython/blob/1d136277a2d99a35c832f2c219e800d3e977fde8/Lib/argparse.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148827/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148827/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
https://github.com/python/cpython/pull/148827/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
https://github.com/python/cpython/pull/148827/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
https://github.com/python/cpython/pull/148827/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
https://github.com/python/cpython/pull/148827/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
https://github.com/python/cpython/pull/148827/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
https://github.com/python/cpython/pull/148827/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
https://github.com/python/cpython/pull/148827/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
https://github.com/python/cpython/pull/148827/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
https://github.com/python/cpython/pull/148827/files#diff-205ef24c9374465bf35c359abce9211d3aa113e986a1e3d41569eb29d07df479
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L261
Lib/test/support/import_helper.pyhttps://github.com/python/cpython/pull/148827/files#diff-9164b29482098900098a8f331d75f919a81d6e8df1f3861eaacdb10967dd7257
View file https://github.com/DavidCEllis/cpython/blob/1d136277a2d99a35c832f2c219e800d3e977fde8/Lib/test/support/import_helper.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148827/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148827/files#diff-9164b29482098900098a8f331d75f919a81d6e8df1f3861eaacdb10967dd7257
https://github.com/python/cpython/pull/148827/files#diff-9164b29482098900098a8f331d75f919a81d6e8df1f3861eaacdb10967dd7257
https://github.com/python/cpython/pull/148827/files#diff-9164b29482098900098a8f331d75f919a81d6e8df1f3861eaacdb10967dd7257
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L371
Lib/test/test_argparse.pyhttps://github.com/python/cpython/pull/148827/files#diff-c7651634d84a017884451f95f6535a1d2efbeacee1cca7cc1e27fdc748804aa1
View file https://github.com/DavidCEllis/cpython/blob/1d136277a2d99a35c832f2c219e800d3e977fde8/Lib/test/test_argparse.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148827/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148827/files#diff-c7651634d84a017884451f95f6535a1d2efbeacee1cca7cc1e27fdc748804aa1
JelleZijlstrahttps://github.com/JelleZijlstra
May 6, 2026https://github.com/python/cpython/pull/148827/files#r3195823213
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/148827/files
DavidCEllishttps://github.com/DavidCEllis
May 6, 2026https://github.com/python/cpython/pull/148827/files#r3196122006
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/148827/files
https://github.com/python/cpython/pull/148827/files#diff-c7651634d84a017884451f95f6535a1d2efbeacee1cca7cc1e27fdc748804aa1
https://github.com/python/cpython/pull/148827/files#diff-c7651634d84a017884451f95f6535a1d2efbeacee1cca7cc1e27fdc748804aa1
https://github.com/python/cpython/pull/148827/files#diff-c7651634d84a017884451f95f6535a1d2efbeacee1cca7cc1e27fdc748804aa1
Misc/NEWS.d/next/Library/2026-05-06-14-26-37.gh-issue-148823.ySmOE4.rsthttps://github.com/python/cpython/pull/148827/files#diff-99936b0c7d9a82adf72d7529c50902e50551a4c00e9933984e8e28a68d948e95
View file https://github.com/DavidCEllis/cpython/blob/1d136277a2d99a35c832f2c219e800d3e977fde8/Misc/NEWS.d/next/Library/2026-05-06-14-26-37.gh-issue-148823.ySmOE4.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148827/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/148827/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.