| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:39fe1f08-9957-e7b8-0fa0-51dcc31f8ef5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9A48:174933:714B:950A:6B021E5B |
| html-safe-nonce | f019ed577cc2a6f3812a49a25fb6863247bf1ea97bbac06cc31e91c5d5b08cfd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTQ4OjE3NDkzMzo3MTRCOjk1MEE6NkIwMjFFNUIiLCJ2aXNpdG9yX2lkIjoiNzE0Njk4MTQwODA0Nzc2NzEzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fa3bb8f8b0524fac0dd9121fa97b3c0f240098ed6ca67be127bd717c491bfe7f |
| hovercard-subject-tag | pull_request:3546798370 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/148700/files |
| twitter:image | https://avatars.githubusercontent.com/u/85053?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/85053?s=400&v=4 |
| og:image:alt | This an experimental rewrite of marshal based on conversation with @serhiy-storchaka in #148652 and #148653.
Includes a number of extra docs and data generators that are provided only for reference... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/148700/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148700%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148700%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/148700/files |
| Reload | https://github.com/python/cpython/pull/148700/files |
| Reload | https://github.com/python/cpython/pull/148700/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| mjbommar | https://github.com/mjbommar |
| python:main | https://github.com/python/cpython/tree/main |
| mjbommar:marshal-safe-cycle-design | https://github.com/mjbommar/cpython/tree/marshal-safe-cycle-design |
|
Conversation
8
| https://github.com/python/cpython/pull/148700 |
|
Commits
6
| https://github.com/python/cpython/pull/148700/commits |
|
Checks
50
| https://github.com/python/cpython/pull/148700/checks |
|
Files changed
| https://github.com/python/cpython/pull/148700/files |
| Please reload this page | https://github.com/python/cpython/pull/148700/files |
|
gh-148653: refactored marshal for cycle safety and performance
| https://github.com/python/cpython/pull/148700/files#top |
|
Show all changes
6 commits
| https://github.com/python/cpython/pull/148700/files |
|
7c214ea
gh-148653: Fix SIGSEGV in marshal.loads for self-referencing tuples
mjbommar Apr 16, 2026
| https://github.com/python/cpython/pull/148700/commits/7c214ea52efbcf12261128b458db8fe025cbc61b |
|
3835149
marshal: preserve safe recursive hashable refs
mjbommar Apr 17, 2026
| https://github.com/python/cpython/pull/148700/commits/38351499d915a61a71e9eeefe7b7af571c3a4e21 |
|
eb1c4b7
marshal: add benchmark summary note
mjbommar Apr 17, 2026
| https://github.com/python/cpython/pull/148700/commits/eb1c4b7ce46a2d49710e7ac687d5e59bb6b83207 |
|
4aaf064
marshal: recover loads regression with raw refs table + tagged state
mjbommar Apr 17, 2026
| https://github.com/python/cpython/pull/148700/commits/4aaf064344d59b668b1e22ee05acee86c4dae9c0 |
|
e931b7e
marshal: add final validation section + raw perf data folder
mjbommar Apr 17, 2026
| https://github.com/python/cpython/pull/148700/commits/e931b7ec45c21048389b4235d44a6220ceb9bdfc |
|
4c18f3a
marshal: add third-party + fuzz validation section to perf diary
mjbommar Apr 17, 2026
| https://github.com/python/cpython/pull/148700/commits/4c18f3a8a70184577c0b46d51532341b3615e541 |
|
Clear filters
| https://github.com/python/cpython/pull/148700/files |
| Please reload this page | https://github.com/python/cpython/pull/148700/files |
| Please reload this page | https://github.com/python/cpython/pull/148700/files |
|
pycore_dict.h
| https://github.com/python/cpython/pull/148700/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4 |
|
test_marshal.py
| https://github.com/python/cpython/pull/148700/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269 |
|
2026-04-16-12-51-32.gh-issue-148653.G0_AMQ.rst
| https://github.com/python/cpython/pull/148700/files#diff-eff75c2cba33fabc606eb71bc754a0ef7cadde54d53b89fbcaf7f386da4a91fc |
|
README.md
| https://github.com/python/cpython/pull/148700/files#diff-1f18845cf70052a17b488b6f2ad3e3ef68f1d08ea7137453d71ac62ad2ac8792 |
|
exp0-run1.json
| https://github.com/python/cpython/pull/148700/files#diff-0114048520b0ec928b4e6689ec9b7215a67556e170db1893be377ccb4238a083 |
|
exp0-run2.json
| https://github.com/python/cpython/pull/148700/files#diff-bf3013cfff2aab36ac18c1692ec924985788f3ade33e53fbbd53ff5c9a2052a9 |
|
exp0-run3.json
| https://github.com/python/cpython/pull/148700/files#diff-7201aa05d4b187592a47bb7262d5c5c9807c27f86308225711e3439248b3cbff |
|
exp1-run1.json
| https://github.com/python/cpython/pull/148700/files#diff-e4c3246887b1c9030e2290d89e3e34bcd484a55adfb2acf9b59bc9f99f3ea024 |
|
exp1-run2.json
| https://github.com/python/cpython/pull/148700/files#diff-6b6f8895dfa8696435377d3149acff630f13ec01ce70b5344d2b059832b5ef4f |
|
exp1-run3.json
| https://github.com/python/cpython/pull/148700/files#diff-1c8ff9ef99edd1cb33dd7c02c1cbfca662d20a25207323656bbed862224d4671 |
|
exp2-run1.json
| https://github.com/python/cpython/pull/148700/files#diff-1c238b9eacfb6fb84367c39d790827cb369086263a7165f32fa45cf196a147f6 |
|
exp2-run2.json
| https://github.com/python/cpython/pull/148700/files#diff-46721ab937e95c5ede279c7434ccbfbc2e17a04173c0950cab1c3eb2f95ea99b |
|
exp2-run3.json
| https://github.com/python/cpython/pull/148700/files#diff-fd3507f470e71dcdf4977447d62be0be614878376e797a9f363ffeea8703fdc0 |
|
exp3-run1.json
| https://github.com/python/cpython/pull/148700/files#diff-2efe1e670ba0acd2173f276b3310228a9d398d58dfbb674c7396629a07c52b33 |
|
exp3-run2.json
| https://github.com/python/cpython/pull/148700/files#diff-ed7a310abbe22eb028250f9fd96bb47b26b95ecbdf53cf3e5758fecfe8371829 |
|
exp3-run3.json
| https://github.com/python/cpython/pull/148700/files#diff-4fefa95fa9532e01e791bc0ae8dbfd7d8bfe9a61412082c7b2e4827c65845343 |
|
exp4-run1.json
| https://github.com/python/cpython/pull/148700/files#diff-cecbea10afff143ab2d408a860294a69bf9267a777ae778784334dba1be4c025 |
|
exp4-run2.json
| https://github.com/python/cpython/pull/148700/files#diff-f241ccb2aed0c020d01b4c202c2f0e396f21a874299218c28960b6e4260ee0ba |
|
exp4-run3.json
| https://github.com/python/cpython/pull/148700/files#diff-fa1352831973d0b8984412e9f3d73e3aa75acf64aba8478d6569071f1aa86274 |
|
exp5-run1.json
| https://github.com/python/cpython/pull/148700/files#diff-b4e5891f2bcdf80b049aacfdd97f16a92e142fcc049d8f8a07c075b58beb0edf |
|
exp5-run2.json
| https://github.com/python/cpython/pull/148700/files#diff-557c569d87565d6cb967a6447f030d6e7dd654636f970fbde9ab628f968e8ceb |
|
exp5-run3.json
| https://github.com/python/cpython/pull/148700/files#diff-4bf29c8a8646d907151593f9341615b7cbd7cb987da6845dbd0c30c86f273b2d |
|
exp6-run1.json
| https://github.com/python/cpython/pull/148700/files#diff-027aaad712095a352f68d3bbc332cbaddd61c635a53a13190c08b84dd9ac096d |
|
exp6-run2.json
| https://github.com/python/cpython/pull/148700/files#diff-e05d5734a0b9cd009583b3fc8891a93a2b2263f46a03d2e0ef475a1e1ca4f5fd |
|
exp6-run3.json
| https://github.com/python/cpython/pull/148700/files#diff-9c97266eb0a344ed058687ead31b5e24cc1475d3484ff8f5e7e0d77c27b4a0b9 |
|
exp7-run1.json
| https://github.com/python/cpython/pull/148700/files#diff-6c91a82d101256bea9bbbc10e7e35b6b77458fc1fcafb8be71326d6e9a48475e |
|
exp7-run2.json
| https://github.com/python/cpython/pull/148700/files#diff-394ce4aee64ea0e026245ce74bd21661e6124f99d497c742902c7003a44c2c76 |
|
exp7-run3.json
| https://github.com/python/cpython/pull/148700/files#diff-782e9364039d25340cd86a84db28475f352a79c9869aba95011b37256f49f7b5 |
|
exp8-run1.json
| https://github.com/python/cpython/pull/148700/files#diff-859dc97ec3f6c69cc185b975ef296249dde9c945eb73c5754e4691611ffa3081 |
|
exp8-run2.json
| https://github.com/python/cpython/pull/148700/files#diff-7b4fe8d1dc25a5b371261bd4d281c00868a4d469c6faad7b35e63cfcd37723ca |
|
exp8-run3.json
| https://github.com/python/cpython/pull/148700/files#diff-bb2e1a642e23e54a26799fd50f9ddc52685ea83acf09acd33cfb1e59f92ef7d4 |
|
exp9-run1.json
| https://github.com/python/cpython/pull/148700/files#diff-9bf8c70fe05554a1988aeb63063fb276598621b42a7e9daa02db92846e649b23 |
|
exp9-run2.json
| https://github.com/python/cpython/pull/148700/files#diff-f9b58785bca4e9afbce2ff40e8550823cfdadc1d5a20d11337ba44658b354c59 |
|
exp9-run3.json
| https://github.com/python/cpython/pull/148700/files#diff-37eb9044dfcd481ec1edce58ba322c04cf38026a30bf0ecebc5b8036094bb796 |
|
expC-run1.json
| https://github.com/python/cpython/pull/148700/files#diff-5387d0ae186cc5a3aca81106d8fd25e3f3d29f1f2313b794e993a9a69adde9ff |
|
expC-run2.json
| https://github.com/python/cpython/pull/148700/files#diff-6edd2264d1fd887287dbcfb9f5ddc0311b11b3a1d7195924b8c3fe1d93eb055f |
|
expC-run3.json
| https://github.com/python/cpython/pull/148700/files#diff-cbcdf5100906b4c480f30cde37f76e786609294536ce03677c3c267625767dc6 |
|
final-head-run1.json
| https://github.com/python/cpython/pull/148700/files#diff-a9904606ebf926cdc5fe985b16bfda9af47f61c05d6d00cb7dc1c22098830cc7 |
|
final-head-run2.json
| https://github.com/python/cpython/pull/148700/files#diff-3d6da93958ea3711f8d50b7b99e25cf222de01a64025477507b5774a98608000 |
|
final-head-run3.json
| https://github.com/python/cpython/pull/148700/files#diff-db227886cc15358f86a38709359b0fed7412948d2cc2f59ddf139a5f3af667f0 |
|
pyperf-slice-baseline.json
| https://github.com/python/cpython/pull/148700/files#diff-11565c46ebaf778e164a004186a674e9d4de830e1fe878e257348cae66975478 |
|
pyperf-slice-current.json
| https://github.com/python/cpython/pull/148700/files#diff-98cab819dd86e8b39e226164c21b7d25af6c587aeab67d9d9b869f19b4062208 |
|
marshal-perf-diary.md
| https://github.com/python/cpython/pull/148700/files#diff-b89fe8d9483fca8859fad1c0efe6d622339c2ab2d518c3cf23364e00044fe4c4 |
|
marshal-recursive-ref-design.md
| https://github.com/python/cpython/pull/148700/files#diff-da4782a4086bc4abbc803a3efceb5c96a673dfc5f25364ae23c30f08c77ec9df |
|
dictobject.c
| https://github.com/python/cpython/pull/148700/files#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae |
|
marshal.c
| https://github.com/python/cpython/pull/148700/files#diff-46d545a32ea7176926cf1a963f25cdac2cf1c8098b3e020ccc77b63b2149d760 |
| Include/internal/pycore_dict.h | https://github.com/python/cpython/pull/148700/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4 |
|
View file
| https://github.com/mjbommar/cpython/blob/4c18f3a8a70184577c0b46d51532341b3615e541/Include/internal/pycore_dict.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/148700/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/148700/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4 |
|
| https://github.com/python/cpython/pull/148700/files#diff-47692c69ef97b2d7cf05ad8e0fa2024b575af96abf9bbc5486f71156ab67ede4 |
| Lib/test/test_marshal.py | https://github.com/python/cpython/pull/148700/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269 |
|
View file
| https://github.com/mjbommar/cpython/blob/4c18f3a8a70184577c0b46d51532341b3615e541/Lib/test/test_marshal.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/148700/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/148700/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269 |
|
| https://github.com/python/cpython/pull/148700/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269 |
|
| https://github.com/python/cpython/pull/148700/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269 |
| Misc/NEWS.d/next/Library/2026-04-16-12-51-32.gh-issue-148653.G0_AMQ.rst | https://github.com/python/cpython/pull/148700/files#diff-eff75c2cba33fabc606eb71bc754a0ef7cadde54d53b89fbcaf7f386da4a91fc |
|
View file
| https://github.com/mjbommar/cpython/blob/4c18f3a8a70184577c0b46d51532341b3615e541/Misc/NEWS.d/next/Library/2026-04-16-12-51-32.gh-issue-148653.G0_AMQ.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/148700/{{ revealButtonHref }} |
| Please reload this page | https://github.com/python/cpython/pull/148700/files |
| Please reload this page | https://github.com/python/cpython/pull/148700/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |