René's URL Explorer Experiment


Title: gh-148653: Fix SIGSEGV in marshal.loads for self-referencing tuples by mjbommar · Pull Request #148652 · python/cpython · GitHub

Open Graph Title: gh-148653: Fix SIGSEGV in marshal.loads for self-referencing tuples by mjbommar · Pull Request #148652 · python/cpython

X Title: gh-148653: Fix SIGSEGV in marshal.loads for self-referencing tuples by mjbommar · Pull Request #148652 · python/cpython

Description: PR summary Fix a deterministic SIGSEGV in marshal.loads() caused by TYPE_TUPLE, TYPE_LIST, TYPE_DICT, and TYPE_SET registering containers in p->refs via R_REF() before their slots are populated. A crafted payload with a TYPE_REF back-reference to the partial container can reach a hashing site (PySet_Add calling tuplehash), which calls PyObject_Hash(NULL) on unfilled slots. The fix adopts the existing two-phase r_ref_reserve() / r_ref_insert() pattern already used by TYPE_FROZENSET, TYPE_CODE, and TYPE_SLICE. The Py_None placeholder in p->refs is detected by the existing TYPE_REF handler at line 1675, which raises ValueError("bad marshal data (invalid reference)") instead of crashing. 16-byte reproducer: import marshal marshal.loads(b'\xa8\x02\x00\x00\x00N<\x01\x00\x00\x00r\x00\x00\x00\x00') Includes regression tests for tuple, list, set, and dict self-reference payloads. Originally filed as GHSA-m7gv-g5p9-9qqq; PSRT assessed as outside the security threat model (marshal.loads is documented as not secure against malicious data). Converting to public issue + PR per their guidance. First time committer introduction I use Python extensively in data science and legal tech. I found this while building an automated vulnerability scanner seeded from prior CPython CVE fix diffs (CVE-2018-20406, CVE-2022-48560). Happy to iterate on the patch. AI Disclosure Claude Code (Anthropic) assisted with grepping the codebase, drafting the byte-stream reproducer, and constructing the regression tests. I reviewed and understand all code changes. The fix follows the existing r_ref_reserve/r_ref_insert two-phase pattern already used by TYPE_FROZENSET/TYPE_CODE/TYPE_SLICE in the same file. Issue: gh-148653

Open Graph Description: PR summary Fix a deterministic SIGSEGV in marshal.loads() caused by TYPE_TUPLE, TYPE_LIST, TYPE_DICT, and TYPE_SET registering containers in p->refs via R_REF() before their slots are populated....

X Description: PR summary Fix a deterministic SIGSEGV in marshal.loads() caused by TYPE_TUPLE, TYPE_LIST, TYPE_DICT, and TYPE_SET registering containers in p-&gt;refs via R_REF() before their slots are popula...

Opengraph URL: https://github.com/python/cpython/pull/148652

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:283520d4-9587-fee0-1fe6-5ddd59915887
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE90:8AE25:1A3BEE4:22B6A72:6B021BB6
html-safe-nonceba7912e98c4bd1718df4e3e509f225aaba4fb4b65c4e0f91dcc0cc57e3f69490
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTkwOjhBRTI1OjFBM0JFRTQ6MjJCNkE3Mjo2QjAyMUJCNiIsInZpc2l0b3JfaWQiOiIxNjcwNDg2ODMxNDQyMjM2NzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacee256bc482239d3ad567d1649f5ecde09feba6a87878917d77d3f873669c90bc
hovercard-subject-tagpull_request:3540384539
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/148652/files
twitter:imagehttps://avatars.githubusercontent.com/u/85053?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/85053?s=400&v=4
og:image:altPR summary Fix a deterministic SIGSEGV in marshal.loads() caused by TYPE_TUPLE, TYPE_LIST, TYPE_DICT, and TYPE_SET registering containers in p->refs via R_REF() before their slots are populated....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/148652/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148652%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F148652%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/148652/files
Reloadhttps://github.com/python/cpython/pull/148652/files
Reloadhttps://github.com/python/cpython/pull/148652/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
mjbommarhttps://github.com/mjbommar
python:mainhttps://github.com/python/cpython/tree/main
mjbommar:marshal-self-ref-fixhttps://github.com/mjbommar/cpython/tree/marshal-self-ref-fix
Conversation 11 https://github.com/python/cpython/pull/148652
Commits 2 https://github.com/python/cpython/pull/148652/commits
Checks 51 https://github.com/python/cpython/pull/148652/checks
Files changed https://github.com/python/cpython/pull/148652/files
Please reload this pagehttps://github.com/python/cpython/pull/148652/files
gh-148653: Fix SIGSEGV in marshal.loads for self-referencing tuples https://github.com/python/cpython/pull/148652/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/148652/files
7c214ea gh-148653: Fix SIGSEGV in marshal.loads for self-referencing tuples mjbommar Apr 16, 2026 https://github.com/python/cpython/pull/148652/commits/7c214ea52efbcf12261128b458db8fe025cbc61b
0fd588e Merge branch 'main' into marshal-self-ref-fix serhiy-storchaka May 11, 2026 https://github.com/python/cpython/pull/148652/commits/0fd588e6398434151f128dd33a3163082b6320ce
Clear filters https://github.com/python/cpython/pull/148652/files
Please reload this pagehttps://github.com/python/cpython/pull/148652/files
Please reload this pagehttps://github.com/python/cpython/pull/148652/files
test_marshal.py https://github.com/python/cpython/pull/148652/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
2026-04-16-12-51-32.gh-issue-148653.G0_AMQ.rst https://github.com/python/cpython/pull/148652/files#diff-eff75c2cba33fabc606eb71bc754a0ef7cadde54d53b89fbcaf7f386da4a91fc
marshal.c https://github.com/python/cpython/pull/148652/files#diff-46d545a32ea7176926cf1a963f25cdac2cf1c8098b3e020ccc77b63b2149d760
Lib/test/test_marshal.pyhttps://github.com/python/cpython/pull/148652/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
View file https://github.com/mjbommar/cpython/blob/0fd588e6398434151f128dd33a3163082b6320ce/Lib/test/test_marshal.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148652/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148652/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
Misc/NEWS.d/next/Library/2026-04-16-12-51-32.gh-issue-148653.G0_AMQ.rsthttps://github.com/python/cpython/pull/148652/files#diff-eff75c2cba33fabc606eb71bc754a0ef7cadde54d53b89fbcaf7f386da4a91fc
View file https://github.com/mjbommar/cpython/blob/0fd588e6398434151f128dd33a3163082b6320ce/Misc/NEWS.d/next/Library/2026-04-16-12-51-32.gh-issue-148653.G0_AMQ.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148652/{{ revealButtonHref }}
Python/marshal.chttps://github.com/python/cpython/pull/148652/files#diff-46d545a32ea7176926cf1a963f25cdac2cf1c8098b3e020ccc77b63b2149d760
View file https://github.com/mjbommar/cpython/blob/0fd588e6398434151f128dd33a3163082b6320ce/Python/marshal.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/148652/{{ revealButtonHref }}
https://github.com/python/cpython/pull/148652/files#diff-46d545a32ea7176926cf1a963f25cdac2cf1c8098b3e020ccc77b63b2149d760
https://github.com/python/cpython/pull/148652/files#diff-46d545a32ea7176926cf1a963f25cdac2cf1c8098b3e020ccc77b63b2149d760
https://github.com/python/cpython/pull/148652/files#diff-46d545a32ea7176926cf1a963f25cdac2cf1c8098b3e020ccc77b63b2149d760
Please reload this pagehttps://github.com/python/cpython/pull/148652/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.