| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a7ff9891-7c3e-4094-fb50-b5591ef3cd71 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DC92:16BCD3:5E777DD:8559E81:6A4FC5CC |
| html-safe-nonce | 62fa550d1b4ef7984f363116eac6ed5ce840b9a5f2486c58381b7ec3fca25e4b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzkyOjE2QkNEMzo1RTc3N0REOjg1NTlFODE6NkE0RkM1Q0MiLCJ2aXNpdG9yX2lkIjoiODc4NTM4MzM3MjcxNTE4MTUxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2dc57c7b73b08d077986fc5d4aa6436abe6e935489e597015768164ad902d3aa |
| hovercard-subject-tag | pull_request:299392631 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/14864/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7e669da129ba23226af0ae5e366fc4eacd196baf21f4d5007bb7bed1c9de7542/python/cpython/pull/14864 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7e669da129ba23226af0ae5e366fc4eacd196baf21f4d5007bb7bed1c9de7542/python/cpython/pull/14864 |
| og:image:alt | A pull request for this issue.
@ericvsmith recommended using __all__ = [name for name, obj in globals().items() if not name.startswith('_') and not isinstance(obj, types.ModuleType) and nam... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | flavianh |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60b2ae4c725f51e2dac275d0ac5e9233e5967a61cdfaebd732f63da67ff1b71c |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 06fb64e1cb36b9a7a2e3f0e6c14af40ef9f439d4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/14864#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14864 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14864 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/14864 |
| Reload | https://github.com/python/cpython/pull/14864 |
| Reload | https://github.com/python/cpython/pull/14864 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| terryjreedy | https://github.com/terryjreedy |
| python:master | https://github.com/python/cpython/tree/master |
| flavianh:bpo-29446-from-tkinter-import-all | https://github.com/flavianh/cpython/tree/bpo-29446-from-tkinter-import-all |
| Conversation | https://github.com/python/cpython/pull/14864 |
| Commits5 (5) | https://github.com/python/cpython/pull/14864/commits |
| Checks | https://github.com/python/cpython/pull/14864/checks |
| Files changed | https://github.com/python/cpython/pull/14864/files |
| bpo-29446: Improve tkinter 'import *' situation | https://github.com/python/cpython/pull/14864#top |
| terryjreedy | https://github.com/terryjreedy |
| python:master | https://github.com/python/cpython/tree/master |
| flavianh:bpo-29446-from-tkinter-import-all | https://github.com/flavianh/cpython/tree/bpo-29446-from-tkinter-import-all |
|
| https://github.com/flavianh |
| flavianh | https://github.com/flavianh |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#issue-470403010 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| this issue | https://bugs.python.org/issue29446 |
| @ericvsmith | https://github.com/ericvsmith |
| https://bugs.python.org/issue29446 | https://bugs.python.org/issue29446 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#event-2496290180 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#event-2496290222 |
| https://github.com/terryjreedy |
| terryjreedy | https://github.com/terryjreedy |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| July 19, 2019 16:42 | https://github.com/python/cpython/pull/14864#event-2496398078 |
| https://github.com/flavianh |
| flavianh | https://github.com/flavianh |
| force-pushed | https://github.com/python/cpython/compare/55f563e018ce4764b77b2ac30f631de3c1e3b99a..d3916ddf3913b294cbc7783d86208618e28aff37 |
| 55f563e | https://github.com/python/cpython/commit/55f563e018ce4764b77b2ac30f631de3c1e3b99a |
| d3916dd | https://github.com/python/cpython/commit/d3916ddf3913b294cbc7783d86208618e28aff37 |
|
Compare
| https://github.com/python/cpython/compare/55f563e018ce4764b77b2ac30f631de3c1e3b99a..d3916ddf3913b294cbc7783d86208618e28aff37 |
| July 19, 2019 17:34 | https://github.com/python/cpython/pull/14864#event-2496517675 |
| https://github.com/flavianh |
| flavianh | https://github.com/flavianh |
| terryjreedy | https://github.com/terryjreedy |
| code owner | https://github.com/python/cpython/blob/eed5e9a9562d4dcd137e9f0fc7157bc3373c98cc/.github/CODEOWNERS#L93 |
| July 19, 2019 17:34 | https://github.com/python/cpython/pull/14864#event-2496517679 |
| https://github.com/flavianh |
| flavianh | https://github.com/flavianh |
| force-pushed | https://github.com/python/cpython/compare/7cf43f06a276ab645a4805a52a60d1b8ea257edf..76c8d3585bf0789381158b6e60187d76ca7210df |
| 7cf43f0 | https://github.com/python/cpython/commit/7cf43f06a276ab645a4805a52a60d1b8ea257edf |
| 76c8d35 | https://github.com/python/cpython/commit/76c8d3585bf0789381158b6e60187d76ca7210df |
|
Compare
| https://github.com/python/cpython/compare/7cf43f06a276ab645a4805a52a60d1b8ea257edf..76c8d3585bf0789381158b6e60187d76ca7210df |
| July 19, 2019 17:41 | https://github.com/python/cpython/pull/14864#event-2496534338 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Jul 19, 2019
| https://github.com/python/cpython/pull/14864#pullrequestreview-264345017 |
|
View reviewed changes
| https://github.com/python/cpython/pull/14864/files |
| Lib/tkinter/__init__.py | https://github.com/python/cpython/pull/14864/files#diff-46c8ee2e6d4e02b7a2839d0cabde53331f5ad74fb09fdd6149b70e9d5cfb2cdd |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#discussion_r305458977 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| flavianh | https://github.com/flavianh |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#discussion_r305537372 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| already imported in tkinter.simpledialog | https://github.com/python/cpython/blob/7a131a8fcd0bd5db2956223dc6cf0cd94a07824f/Lib/tkinter/simpledialog.py#L278-L279 |
| used in dialog.py | https://github.com/python/cpython/blob/7a131a8fcd0bd5db2956223dc6cf0cd94a07824f/Lib/tkinter/dialog.py#L16 |
| if parent.winfo_viewable(): | https://github.com/python/cpython/blob/7a131a8fcd0bd5db2956223dc6cf0cd94a07824f/Lib/tkinter/simpledialog.py#L153 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Jul 20, 2019 | https://github.com/python/cpython/pull/14864#discussion_r305572087 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| flavianh | https://github.com/flavianh |
| Jul 20, 2019 | https://github.com/python/cpython/pull/14864#discussion_r305572874 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/__init__.py | https://github.com/python/cpython/pull/14864/files#diff-46c8ee2e6d4e02b7a2839d0cabde53331f5ad74fb09fdd6149b70e9d5cfb2cdd |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/__init__.py | https://github.com/python/cpython/pull/14864/files#diff-46c8ee2e6d4e02b7a2839d0cabde53331f5ad74fb09fdd6149b70e9d5cfb2cdd |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/__init__.py | https://github.com/python/cpython/pull/14864/files#diff-46c8ee2e6d4e02b7a2839d0cabde53331f5ad74fb09fdd6149b70e9d5cfb2cdd |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/constants.py | https://github.com/python/cpython/pull/14864/files#diff-400d4e11dae99ce882f04774dd30a2cd1f804f03542587d325a142d86727d994 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#discussion_r305463975 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| flavianh | https://github.com/flavianh |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#discussion_r305537766 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/dialog.py | https://github.com/python/cpython/pull/14864/files#diff-f9d96e3860fad0995dd4c4c77ad661f7076e4ad53491e2b8c2a38f20fee1b59c |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/filedialog.py | https://github.com/python/cpython/pull/14864/files#diff-420df68e5c58e9638c157d94f1eba6480f6769f6c29b178de90c08a465562e04 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#discussion_r305464858 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| flavianh | https://github.com/flavianh |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#discussion_r305537940 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/tix.py | https://github.com/python/cpython/pull/14864/files#diff-abd9b8a9ae7794d4084022ddd6b7b087d504ad44962353313ab05040043f59c5 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/terryjreedy |
| terryjreedy | https://github.com/terryjreedy |
|
Jul 19, 2019
| https://github.com/python/cpython/pull/14864#pullrequestreview-264441865 |
|
View reviewed changes
| https://github.com/python/cpython/pull/14864/files |
| terryjreedy | https://github.com/terryjreedy |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/python/cpython/pull/14864#pullrequestreview-264441865 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#event-2497066576 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#issuecomment-513386352 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#event-2497066595 |
| https://github.com/terryjreedy |
| terryjreedy | https://github.com/terryjreedy |
|
Jul 19, 2019
| https://github.com/python/cpython/pull/14864#pullrequestreview-264442529 |
|
View reviewed changes
| https://github.com/python/cpython/pull/14864/files |
| Misc/NEWS.d/next/Library/2019-07-19-16-06-48.bpo-29446.iXGuoi.rst | https://github.com/python/cpython/pull/14864/files#diff-8da758ff741dc37e4a70dbccfb8013b4662597dae23dfd4574ab163f8c9e6473 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/terryjreedy |
| terryjreedy | https://github.com/terryjreedy |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#issuecomment-513388125 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/flavianh |
| flavianh | https://github.com/flavianh |
| force-pushed | https://github.com/python/cpython/compare/94460f3c16433dae3be6828e7d232e7ed6f53deb..7037f85a39d62213cf9dfb8d070b821a1bfc9b92 |
| 94460f3 | https://github.com/python/cpython/commit/94460f3c16433dae3be6828e7d232e7ed6f53deb |
| 7037f85 | https://github.com/python/cpython/commit/7037f85a39d62213cf9dfb8d070b821a1bfc9b92 |
|
Compare
| https://github.com/python/cpython/compare/94460f3c16433dae3be6828e7d232e7ed6f53deb..7037f85a39d62213cf9dfb8d070b821a1bfc9b92 |
| July 19, 2019 22:41 | https://github.com/python/cpython/pull/14864#event-2497169488 |
| https://github.com/flavianh |
| flavianh | https://github.com/flavianh |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#issuecomment-513406125 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting change review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22 |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#event-2497190857 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Jul 19, 2019 | https://github.com/python/cpython/pull/14864#issuecomment-513406140 |
| @terryjreedy | https://github.com/terryjreedy |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Jul 20, 2019
| https://github.com/python/cpython/pull/14864#pullrequestreview-264487074 |
|
View reviewed changes
| https://github.com/python/cpython/pull/14864/files |
| Lib/tkinter/__init__.py | https://github.com/python/cpython/pull/14864/files#diff-46c8ee2e6d4e02b7a2839d0cabde53331f5ad74fb09fdd6149b70e9d5cfb2cdd |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/colorchooser.py | https://github.com/python/cpython/pull/14864/files#diff-854da32ee28871939cceeeb8a0f01f8f4e2507a7237e497a114a62345634a68c |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/commondialog.py | https://github.com/python/cpython/pull/14864/files#diff-de47286a179bfc51df1aa4fdd671d736c4cb630f2eb31673944812e050196de8 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/dnd.py | https://github.com/python/cpython/pull/14864/files#diff-6df3fcdf780543636b2dbd21513144cfbb9bae13ff8b88068c0e2baa92a71725 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/filedialog.py | https://github.com/python/cpython/pull/14864/files#diff-420df68e5c58e9638c157d94f1eba6480f6769f6c29b178de90c08a465562e04 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/scrolledtext.py | https://github.com/python/cpython/pull/14864/files#diff-4ffbdbacd6f92136c06170f8375ea91433bda0e223bb2dfb1c991a5620fbcfd0 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/simpledialog.py | https://github.com/python/cpython/pull/14864/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/test/test_tkinter/test_misc.py | https://github.com/python/cpython/pull/14864/files#diff-c31b742e12bc0b55e3709a64684dc73ecaf2825ea0bfa774461eb5058cef0658 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/test/test_tkinter/test_misc.py | https://github.com/python/cpython/pull/14864/files#diff-c31b742e12bc0b55e3709a64684dc73ecaf2825ea0bfa774461eb5058cef0658 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Misc/ACKS | https://github.com/python/cpython/pull/14864/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/flavianh |
| flavianh | https://github.com/flavianh |
| force-pushed | https://github.com/python/cpython/compare/0cdd92a5aca490d5337dec4355ba7f81a9cf0fb2..5180d873afaeebcd7ea5359706e10b66ea4463eb |
| 0cdd92a | https://github.com/python/cpython/commit/0cdd92a5aca490d5337dec4355ba7f81a9cf0fb2 |
| 5180d87 | https://github.com/python/cpython/commit/5180d873afaeebcd7ea5359706e10b66ea4463eb |
|
Compare
| https://github.com/python/cpython/compare/0cdd92a5aca490d5337dec4355ba7f81a9cf0fb2..5180d873afaeebcd7ea5359706e10b66ea4463eb |
| July 20, 2019 09:09 | https://github.com/python/cpython/pull/14864#event-2497463849 |
| https://github.com/flavianh |
| flavianh | https://github.com/flavianh |
|
Jul 20, 2019
| https://github.com/python/cpython/pull/14864#pullrequestreview-264490486 |
|
View reviewed changes
| https://github.com/python/cpython/pull/14864/files |
| Lib/tkinter/font.py | https://github.com/python/cpython/pull/14864/files#diff-f683769c3d0086ff5edc5d3153ee6dc17aa109fce0fa75873e0d6e9cc171b6e1 |
| flavianh | https://github.com/flavianh |
| Jul 20, 2019 | https://github.com/python/cpython/pull/14864#discussion_r305573820 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/flavianh |
| flavianh | https://github.com/flavianh |
| Jul 20, 2019 | https://github.com/python/cpython/pull/14864#issuecomment-513452398 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/flavianh |
| flavianh | https://github.com/flavianh |
| Jul 23, 2019 | https://github.com/python/cpython/pull/14864#issuecomment-514184497 |
| @terryjreedy | https://github.com/terryjreedy |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/terryjreedy |
| terryjreedy | https://github.com/terryjreedy |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Jul 23, 2019 | https://github.com/python/cpython/pull/14864#event-2504035431 |
| https://github.com/terryjreedy |
| terryjreedy | https://github.com/terryjreedy |
|
Jul 23, 2019
| https://github.com/python/cpython/pull/14864#pullrequestreview-265603501 |
|
View reviewed changes
| https://github.com/python/cpython/pull/14864/files |
| terryjreedy | https://github.com/terryjreedy |
| https://github.com/python/cpython/pull/14864#pullrequestreview-265603501 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/idlelib/editor.py | https://github.com/python/cpython/pull/14864/files#diff-0ebe4cdabcc123ccaae0e7cb5fcc54423a11b82957a8f972db70e98a1e847ae4 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/terryjreedy |
| terryjreedy | https://github.com/terryjreedy |
|
Jul 23, 2019
| https://github.com/python/cpython/pull/14864#pullrequestreview-265649429 |
|
View reviewed changes
| https://github.com/python/cpython/pull/14864/files |
| Lib/tkinter/filedialog.py | https://github.com/python/cpython/pull/14864/files#diff-420df68e5c58e9638c157d94f1eba6480f6769f6c29b178de90c08a465562e04 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| July 24, 2019 11:11 | https://github.com/python/cpython/pull/14864#commits-pushed-63f71ec |
| bpo-29446: Clearly define __all__ for tkinter | https://github.com/python/cpython/pull/14864/commits/63f71ec68c9c0b5bd40ab0f167b73571a0b22065 |
| 63f71ec | https://github.com/python/cpython/pull/14864/commits/63f71ec68c9c0b5bd40ab0f167b73571a0b22065 |
|
| https://github.com/apps/blurb-it |
| 📜🤖 Added by blurb_it. | https://github.com/python/cpython/pull/14864/commits/f4188aadd0bfb7e86fb6c6588a358b61ea5e4906 |
| f4188aa | https://github.com/python/cpython/pull/14864/commits/f4188aadd0bfb7e86fb6c6588a358b61ea5e4906 |
| Adding acknowledgment | https://github.com/python/cpython/pull/14864/commits/fc260c41ce7741df0181b0ca2b0d1427c22a0c9e |
| fc260c4 | https://github.com/python/cpython/pull/14864/commits/fc260c41ce7741df0181b0ca2b0d1427c22a0c9e |
| https://github.com/flavianh |
| flavianh | https://github.com/flavianh |
| force-pushed | https://github.com/python/cpython/compare/7ea2ce533de5be28391a9abbec650e62339f39f8..2345535b221300e7c61bf11085959e49995349ae |
| 7ea2ce5 | https://github.com/python/cpython/commit/7ea2ce533de5be28391a9abbec650e62339f39f8 |
| 2345535 | https://github.com/python/cpython/commit/2345535b221300e7c61bf11085959e49995349ae |
|
Compare
| https://github.com/python/cpython/compare/7ea2ce533de5be28391a9abbec650e62339f39f8..2345535b221300e7c61bf11085959e49995349ae |
| July 24, 2019 09:13 | https://github.com/python/cpython/pull/14864#event-2505640443 |
| Use explicit imports in filedialog.py | https://github.com/python/cpython/pull/14864/commits/e9cae4f3a3f4fd5b47b3e78dae1c2872589ef8f6 |
| e9cae4f | https://github.com/python/cpython/pull/14864/commits/e9cae4f3a3f4fd5b47b3e78dae1c2872589ef8f6 |
| https://github.com/flavianh |
| flavianh | https://github.com/flavianh |
| force-pushed | https://github.com/python/cpython/compare/2345535b221300e7c61bf11085959e49995349ae..e9cae4f3a3f4fd5b47b3e78dae1c2872589ef8f6 |
| 2345535 | https://github.com/python/cpython/commit/2345535b221300e7c61bf11085959e49995349ae |
| e9cae4f | https://github.com/python/cpython/commit/e9cae4f3a3f4fd5b47b3e78dae1c2872589ef8f6 |
|
Compare
| https://github.com/python/cpython/compare/2345535b221300e7c61bf11085959e49995349ae..e9cae4f3a3f4fd5b47b3e78dae1c2872589ef8f6 |
| July 24, 2019 09:36 | https://github.com/python/cpython/pull/14864#event-2505709415 |
| https://github.com/flavianh |
| flavianh | https://github.com/flavianh |
| Jul 24, 2019 | https://github.com/python/cpython/pull/14864#issuecomment-514558433 |
| @terryjreedy | https://github.com/terryjreedy |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/terryjreedy |
| terryjreedy | https://github.com/terryjreedy |
| Jul 25, 2019 | https://github.com/python/cpython/pull/14864#issuecomment-515196158 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Jul 25, 2019
| https://github.com/python/cpython/pull/14864#pullrequestreview-266862898 |
|
View reviewed changes
| https://github.com/python/cpython/pull/14864/files/e9cae4f3a3f4fd5b47b3e78dae1c2872589ef8f6 |
| Lib/tkinter/commondialog.py | https://github.com/python/cpython/pull/14864/files/e9cae4f3a3f4fd5b47b3e78dae1c2872589ef8f6#diff-de47286a179bfc51df1aa4fdd671d736c4cb630f2eb31673944812e050196de8 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/font.py | https://github.com/python/cpython/pull/14864/files/e9cae4f3a3f4fd5b47b3e78dae1c2872589ef8f6#diff-f683769c3d0086ff5edc5d3153ee6dc17aa109fce0fa75873e0d6e9cc171b6e1 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Jul 25, 2019 | https://github.com/python/cpython/pull/14864#discussion_r307484838 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| flavianh | https://github.com/flavianh |
| Jul 25, 2019 | https://github.com/python/cpython/pull/14864#discussion_r307493095 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Jul 25, 2019 | https://github.com/python/cpython/pull/14864#discussion_r307508131 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/messagebox.py | https://github.com/python/cpython/pull/14864/files/e9cae4f3a3f4fd5b47b3e78dae1c2872589ef8f6#diff-92d78f271b7e222ef0521caf15775e56d7513a909043b49ee74f535cb94702c3 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Jul 25, 2019 | https://github.com/python/cpython/pull/14864#discussion_r307485258 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Lib/tkinter/filedialog.py | https://github.com/python/cpython/pull/14864/files/e9cae4f3a3f4fd5b47b3e78dae1c2872589ef8f6#diff-420df68e5c58e9638c157d94f1eba6480f6769f6c29b178de90c08a465562e04 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Jul 25, 2019 | https://github.com/python/cpython/pull/14864#discussion_r307486553 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| flavianh | https://github.com/flavianh |
| Jul 25, 2019 | https://github.com/python/cpython/pull/14864#discussion_r307493568 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Add missing __all__ and reformat others | https://github.com/python/cpython/pull/14864/commits/6883c8ebf7dee0a8ec45d07f734bc54f6e375cda |
| 6883c8e | https://github.com/python/cpython/pull/14864/commits/6883c8ebf7dee0a8ec45d07f734bc54f6e375cda |
| https://github.com/flavianh |
| flavianh | https://github.com/flavianh |
| Jul 25, 2019 | https://github.com/python/cpython/pull/14864#issuecomment-515215058 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Jul 25, 2019
| https://github.com/python/cpython/pull/14864#pullrequestreview-266893466 |
|
View reviewed changes
| https://github.com/python/cpython/pull/14864/files/6883c8ebf7dee0a8ec45d07f734bc54f6e375cda |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting change review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22 |
| Jul 25, 2019 | https://github.com/python/cpython/pull/14864#event-2510869347 |
| https://github.com/flavianh |
| flavianh | https://github.com/flavianh |
| Jul 25, 2019 | https://github.com/python/cpython/pull/14864#issuecomment-515223376 |
| @terryjreedy | https://github.com/terryjreedy |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| https://github.com/terryjreedy |
| terryjreedy | https://github.com/terryjreedy |
| 76b6451 | https://github.com/python/cpython/commit/76b645124b3aaa34bc664eece43707c01ef1b382 |
| Jul 26, 2019 | https://github.com/python/cpython/pull/14864#event-2511231780 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Jul 26, 2019 | https://github.com/python/cpython/pull/14864#event-2511231833 |
| https://github.com/terryjreedy |
| terryjreedy | https://github.com/terryjreedy |
| Jul 26, 2019 | https://github.com/python/cpython/pull/14864#issuecomment-515274702 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
| lisroach | https://github.com/lisroach |
|
Sep 10, 2019
| https://github.com/python/cpython/pull/14864#ref-commit-dd555cd |
|
| https://github.com/lisroach |
| bpo-29446: tkinter 'import *' only imports what it should ( | https://github.com/lisroach/cpython/commit/dd555cd047ad922e8f5fe53627d2cde3acd6e63a |
| pythonGH-1… | https://github.com/python/cpython/pull/14864 |
| dd555cd | https://github.com/lisroach/cpython/commit/dd555cd047ad922e8f5fe53627d2cde3acd6e63a |
| …4864 | https://github.com/python/cpython/pull/14864 |
| DinoV | https://github.com/DinoV |
|
Jan 14, 2020
| https://github.com/python/cpython/pull/14864#ref-commit-574a4ab |
|
| https://github.com/DinoV |
| bpo-29446: tkinter 'import *' only imports what it should ( | https://github.com/DinoV/cpython/commit/574a4abbdfca575528c27ddbb1771269da022b7e |
| pythonGH-1… | https://github.com/python/cpython/pull/14864 |
| 574a4ab | https://github.com/DinoV/cpython/commit/574a4abbdfca575528c27ddbb1771269da022b7e |
| …4864 | https://github.com/python/cpython/pull/14864 |
| websurfer5 | https://github.com/websurfer5 |
|
Jul 20, 2020
| https://github.com/python/cpython/pull/14864#ref-commit-78dfff2 |
|
| https://github.com/websurfer5 |
| bpo-29446: tkinter 'import *' only imports what it should ( | https://github.com/websurfer5/cpython/commit/78dfff28f1d98b91cbfea928bc0feaf52ca9215a |
| pythonGH-1… | https://github.com/python/cpython/pull/14864 |
| 78dfff2 | https://github.com/websurfer5/cpython/commit/78dfff28f1d98b91cbfea928bc0feaf52ca9215a |
| …4864 | https://github.com/python/cpython/pull/14864 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Dec 29, 2020 | https://github.com/python/cpython/pull/14864#event-4155630652 |
|
Explicit imports in tkinter.simpledialog
#127930
| https://github.com/python/cpython/issues/127930 |
|
gh-127930: use explicit imports in tkinter.simpledialog
#127931
| https://github.com/python/cpython/pull/127931 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14864 |
|
| https://github.com/serhiy-storchaka |
|
serhiy-storchaka
| https://github.com/serhiy-storchaka |
|
| https://github.com/python/cpython/pull/14864/files/6883c8ebf7dee0a8ec45d07f734bc54f6e375cda |
|
| https://github.com/terryjreedy |
|
terryjreedy
| https://github.com/terryjreedy |
|
| https://github.com/python/cpython/pull/14864/files/7ea2ce533de5be28391a9abbec650e62339f39f8 |
| Please reload this page | https://github.com/python/cpython/pull/14864 |
|
| https://github.com/flavianh |
|
| https://github.com/bedevere-bot |
|
| https://github.com/terryjreedy |
|
| https://github.com/serhiy-storchaka |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |